From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B46E8C77B7C for ; Thu, 3 Jul 2025 09:34:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35CBF6B0131; Thu, 3 Jul 2025 05:34:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E6EE6B013D; Thu, 3 Jul 2025 05:34:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1606A6B013E; Thu, 3 Jul 2025 05:34:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 015796B0131 for ; Thu, 3 Jul 2025 05:34:16 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 582C9124764 for ; Thu, 3 Jul 2025 09:34:16 +0000 (UTC) X-FDA: 83622442512.25.E979030 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf11.hostedemail.com (Postfix) with ESMTP id 09CD240019 for ; Thu, 3 Jul 2025 09:34:13 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PxCvQMV8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rX0rMgui; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PxCvQMV8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rX0rMgui; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751535254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AEzOsqJCpTsA6+tGxdT7oSoEwUMy3kIEd2qkVoXTzqE=; b=jACjjA78AvZHlSasxtY5R43vtr8ly740YlA0IfX/8/8H8jNgPdlFW92ziYBQwrHSTxVT1w rZHC+4Yi0qIQFwiTaJQc9uSQDcM4SMJ8G3gIbu7dim1FOftm4PGavVj1deC38KX/fZRQaH 8X8MNkkXXjQiVEkdKVfJBOvle2I4HbU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PxCvQMV8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rX0rMgui; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PxCvQMV8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rX0rMgui; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751535254; a=rsa-sha256; cv=none; b=28Ckz8LQa4W6lu6HYPBN/vUoGHwVsSWOyen3cOmstURm+cAUcGiLo11qMZ9OR+l0BTHt8g N4bJgLwDDJQuQCAQo1pnB9Md0XAb5hpaFMptILjZrpqJqyWUb6Y+buC6PGdB7RJYrCZ2G8 Cx/amKDWuMZywVArnvmscItHhhCRXSs= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 53E471F457; Thu, 3 Jul 2025 09:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751535252; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AEzOsqJCpTsA6+tGxdT7oSoEwUMy3kIEd2qkVoXTzqE=; b=PxCvQMV8zndbQyE6ly524YmDf3Y8RUCs9p3YqF/9H+vWukJGv8+MZDRm+mwjgmXRB3ZofF EzdTEJLNO+zIoMTaghdJQH+WQj913S4rhFuBY1dqNVnedyXSgjDa/9Jbb62eK6LZmBzeYn 3YcjzwuGxlicevjqJhhsKkSjGP5vxR0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751535252; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AEzOsqJCpTsA6+tGxdT7oSoEwUMy3kIEd2qkVoXTzqE=; b=rX0rMguinqvqFDR6ZeF31Y+VH3j5DsAHDP4uVp4f24US7KyZ1egnEXh0BlFYfSL2Da7lJ5 ba/h2+EfXBoYEUAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751535252; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AEzOsqJCpTsA6+tGxdT7oSoEwUMy3kIEd2qkVoXTzqE=; b=PxCvQMV8zndbQyE6ly524YmDf3Y8RUCs9p3YqF/9H+vWukJGv8+MZDRm+mwjgmXRB3ZofF EzdTEJLNO+zIoMTaghdJQH+WQj913S4rhFuBY1dqNVnedyXSgjDa/9Jbb62eK6LZmBzeYn 3YcjzwuGxlicevjqJhhsKkSjGP5vxR0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751535252; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AEzOsqJCpTsA6+tGxdT7oSoEwUMy3kIEd2qkVoXTzqE=; b=rX0rMguinqvqFDR6ZeF31Y+VH3j5DsAHDP4uVp4f24US7KyZ1egnEXh0BlFYfSL2Da7lJ5 ba/h2+EfXBoYEUAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DD47213721; Thu, 3 Jul 2025 09:34:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ScaFL5NOZmgvAwAAD6G6ig (envelope-from ); Thu, 03 Jul 2025 09:34:11 +0000 Date: Thu, 3 Jul 2025 11:34:10 +0200 From: Oscar Salvador To: Mike Rapoport Cc: Andrew Morton , Alexandre Ghiti , David Hildenbrand , Pratyush Yadav , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/3] cma: split resrvation of fixed area into a helper function Message-ID: References: <20250702173605.2198924-1-rppt@kernel.org> <20250702173605.2198924-3-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250702173605.2198924-3-rppt@kernel.org> X-Rspamd-Action: no action X-Stat-Signature: ezut77pwh1tmjhqutjkzfhi3uxhsyufh X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 09CD240019 X-Rspam-User: X-HE-Tag: 1751535253-579202 X-HE-Meta: U2FsdGVkX194zIECrIvGn3i8KSn0Uc7k/96pOLtFFfwh6Yvn93s3NTiXEZ6dvq2A2vOvF3tfgKgYGI37aeZTg6u1q0imE4RIf6C5BBqjzoQeFob1mGa/r1QsABIbOptfEdM+t2HyxKi5qrue/w9d1LsWvMrE2RqtPJDCe4uMO0fVwkZv3QT2HzghczSi7eucxBTkd6X8QVr/1ffhgiI4WcHg51Yr/vn1pU3GxlNIeT8LKjZ0oo1haeJMS8Kduo09y5GcCsWkSCbtY4YiAxlFilyEoSz2EcqnKM6hhbLCbQlrVVS8ych6E7X9FViYNoYhtz1jOF7iG+NV3WSSY8KPT/ShSoHSavk7YcgvDdxMexasmIJQNEPrEKD2zvVNjz03Z1Hr7FX34SaKPCSN0js8bQDEF5m5piMNi8DPQd6OwmomXmjOH0zlTNPzgHMl8xYpp7T8nJJkxl2vMmz4IIV15eAk6lZTHcP3uS+VOTOp4g2uVyfcEct1AglV5NaqPOy1UQ9ktJc6LS6/hWARCAqjIgPuRQxeYNqgugCfeyI6Qb2HzSVBbRrGO3lVe5CnDCSYgAM81ouAv3iB8XtAmnceA2nirhDDJmMI4bEnTdRCpVco87wHEfxAAJ+R2RXD9HtlMouubi8QhDmRtbx9JJeZYAjQVU4W9hPOfw7izHhigKIHZKKKtLnEm1H6yGsmz7M7DYjZmXK09oWk8LK8duPi6+W5zIjg7P3+TM6FGD3nFFDjHcbynUVyE5s7LmTLa2/YzTamYCDRLlLeOv56Qsv3IykSkS9PnMshY5d+oxgnbX0hiO0oxFCc7XdUfqqht3UWAj5kt6menp1s0OBWACix6VKOlHyex8StuLpt5u1Q3N5SPCkyHiqHErIZ7puOLCdh1eypCF9MpdiXV9mqSR92KGxM94CSLK8BcqVHXtD9R9tMzvvUhPc2sXV9AnqMWcjQjzy+7HeLwk2dpEAUEm9 4OXCha/C uZB1nGUN2IU6dQwbLZGOmPk4quFCkSDxGJgwFCpt0+Mq3Pb3ZFGPop7/5m0njU+wilZoFSerkHjnr3vbUxXW62VH1DgwYiW0g9ZfFz8wyv3HmcVGCc7m33MLYw2J49AtsZHeBJGTjoTMuO3iZT+zS1sazduy0rXeWWCWk48SyV9WzfUT6Ot0IV3ee94S7A71kz5e9t1KzSRna/13Lco2EkssKCwYCTrbM4/KkI/b65k76LJu11PNzYnNZU60awFFDLW8xAxmM9hS51mJxmDdqAfTYml7iolE2nzrf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 02, 2025 at 08:36:04PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Move the check that verifies that reservation of fixed area does not > cross HIGHMEM boundary and the actual memblock_resrve() call into a > helper function. > > This makes code more readable and decouples logic related to > CONFIG_HIGHMEM from the core functionality of > __cma_declare_contiguous_nid(). > > Signed-off-by: Mike Rapoport (Microsoft) Looks good to me, nit below: Acked-by: Oscar Salvador > @@ -433,10 +448,10 @@ static int __init __cma_declare_contiguous_nid(phys_addr_t *basep, > > /* Reserve memory */ > if (fixed) { > - if (memblock_is_region_reserved(base, size) || > - memblock_reserve(base, size) < 0) { > - return -EBUSY; > - } > + int err = cma_fixed_reserve(base, size); There's no need for 'err', you can use the already declared 'ret'. -- Oscar Salvador SUSE Labs