From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37D36C83030 for ; Thu, 3 Jul 2025 09:17:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C62796B0153; Thu, 3 Jul 2025 05:17:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3A046B0155; Thu, 3 Jul 2025 05:17:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B77D86B0156; Thu, 3 Jul 2025 05:17:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A897E6B0153 for ; Thu, 3 Jul 2025 05:17:04 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7C9975AF12 for ; Thu, 3 Jul 2025 09:17:04 +0000 (UTC) X-FDA: 83622399168.16.0F3DBCE Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 374DD14000A for ; Thu, 3 Jul 2025 09:17:01 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=E3s24UWY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aTjCnBfy; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=E3s24UWY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aTjCnBfy; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751534222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l7y1s4fvtr8B8FLht4Zw6Q/Lw7MtiAfaDUQQM/yYXSw=; b=l/LOd7iYFPqku/9lwpJm1fdRElL+koPzz9NPmiT4wI9LPaqL/rLtXUvlv4gU5MdGktmb3L Lp5JO0X484ZEQ2dxMPmhl50ixloLskQmGnq2VSLE4WRQt6mFaFUN0ewx+feTxGvVc/xz55 qYpE5oKXnZvAcBnq2ogED8aefjsf1mI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=E3s24UWY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aTjCnBfy; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=E3s24UWY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aTjCnBfy; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751534222; a=rsa-sha256; cv=none; b=UYPMdGRz+AtCulnpZH0fxeZJJjVYWiOts0hPcZWYGtsAh9L+56eoXMcjE4HLsoCg7S9MRT jIXLzbuAchpAJN3d2Xmx2u6TT7sQ1XZsn6gR9YIzOjgzb+9Z1G7wzgjuPFp1r+T/gnid9+ deBeqTawJdUUvN588VckDziDbFXwvAA= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5299121167; Thu, 3 Jul 2025 09:17:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751534220; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l7y1s4fvtr8B8FLht4Zw6Q/Lw7MtiAfaDUQQM/yYXSw=; b=E3s24UWY3Bvz1AMHIzOjmyXA/CNUO3GBhGx31Ia0OR+Vjlej++hE7dH7qTEviY33IdAdKc IFIw1DEvjp7+0TEnBh6NbWTu6320qUXn8ixaD54I0zk45W34W48YbJbU/AjdzBm0l+ciGV I8jt4fGpHGUJmhgtbUtUQlmLS0mQY+8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751534220; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l7y1s4fvtr8B8FLht4Zw6Q/Lw7MtiAfaDUQQM/yYXSw=; b=aTjCnBfyh8tUDRy3nIwIsy1T7vYazk0iEDaHiYXq4ml4NBw+LbRO0iCktfcHcJ5VXIae/I 76SYbrewxK7ZdgBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751534220; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l7y1s4fvtr8B8FLht4Zw6Q/Lw7MtiAfaDUQQM/yYXSw=; b=E3s24UWY3Bvz1AMHIzOjmyXA/CNUO3GBhGx31Ia0OR+Vjlej++hE7dH7qTEviY33IdAdKc IFIw1DEvjp7+0TEnBh6NbWTu6320qUXn8ixaD54I0zk45W34W48YbJbU/AjdzBm0l+ciGV I8jt4fGpHGUJmhgtbUtUQlmLS0mQY+8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751534220; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l7y1s4fvtr8B8FLht4Zw6Q/Lw7MtiAfaDUQQM/yYXSw=; b=aTjCnBfyh8tUDRy3nIwIsy1T7vYazk0iEDaHiYXq4ml4NBw+LbRO0iCktfcHcJ5VXIae/I 76SYbrewxK7ZdgBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 19A5313721; Thu, 3 Jul 2025 09:16:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aE2OA4tKZmhPfAAAD6G6ig (envelope-from ); Thu, 03 Jul 2025 09:16:59 +0000 Date: Thu, 3 Jul 2025 11:16:57 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo , Lance Yang Subject: Re: [PATCH v2 4/4] mm: remove boolean output parameters from folio_pte_batch_ext() Message-ID: References: <20250702104926.212243-1-david@redhat.com> <20250702104926.212243-5-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250702104926.212243-5-david@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 374DD14000A X-Stat-Signature: d8bqtrunqpiq1cry6bex41a91kt6ykny X-HE-Tag: 1751534221-944965 X-HE-Meta: U2FsdGVkX1/d8rGCYU+NEviBrjhaTWJ2SJgJ6Yy8kFvGIp0NNKx5lPVb7esVjAMj3h+KUCvRdROlobjJo6Kq9zkO39fl5y6SFtthiRG+0bJVxgwDawoO9LvtSPHeFJJ2eA7d4J0DZ4zEI/YTpMf1pSKoq+lE/nN6Z2XLGnV6IeNa3uQTadH+r6+yQ+SJSqSXdEVJ/TFx2YnyrmYNKKFiz2HCHRoWnox5DKwBlFByKOMBTaDlmiTx/T2ln26L+fPBY39kJmMl79IRFt3ackPaO/7Gxt+QYLy1WF+6sYxr9Ulsko88nA2Qj7DXbEiGxDBNH7iPGBQjQuMccEN9XJh5jINo5sa2Y5TQsZY9W0o4+6JKQEGQ+H5OwyfbFIwK5UUH9zHy1axNfHgLnED8gf9/3aP18jNbz8q8yQjCEjLWx4yEVVhppwSMdG8PnS/YixPpX+eO54xCzNTR++EleIsIxeFKNABW08P7rC/mEc3P6x4WLzaxnkJLJD8RX5buvTwWT3dWMXi9l+cEEFIjFEJiptjxw1AAEE88f5H365Ncdd5aLGnKIJmAdxTAvSMXwAkG49fzXoT6RBd92Zh0MvGnNeO2ZcjBGXoYx6HGRd1FC/Zo+lktbGyc/Z2AQBljt3Z4x0A4aH1RWAoLzsYLNvjKkse05zYEASGLykbDTPDJQWrMKHG/zTdBMzd8pl5a66XCGZx5dePw/FDBc2XDEdRMB8gpgjX3ZqlGoOAYweYJFZ8InGPpW8d6RpqrEqU5oYNYdr/91itfvgo+RVcGuKIeYEiGJgp0tA/WB2ggAd2N3i1XFNIklY3RaKWMhY5siDDe8q9XCSNkRD+J2RSghIWkPU6kb/li3Z1RC6CP3YPT5oZkn6i0D1R9OdtrIzy53sbBUGaR8BD6hR8hLTcMZrimQfOr1H0muIyHH8TKOQ/BTU52847F2ifsq9bZ3fECJPOhUL0B8NPxF7BMRtuDgaA MqvXzmWT 9TZg0ecEQyanIxH8RUJpJ7AX9HpayRjjO+wLr7DthxXANeclL4eHFFN3SyrxtkQLNfQ/UhliPLMeSaT9J+61Nzw1leT+TPIDYOb41PIIjCkUb3/27lelpBigCaNnNc0rbifv9E+DbtkwEcik7ckg/YFxnmOjJ08vmAtU5GCPqZAJmBe1KYEukJM8pBSsgHEqLuFX77Yij0qam6kgYMjP1labyQEpx+F1aN9vRdqh6QEL3IzB5bUuBoaegeTBtIoudvrzKbfeT+IfcHhOemhCJ7wq694a+oJsEMoD7Plu+xiGRHBlplmFFVLtPv3p978vUDtK7+aP3tcRnPRTajU4nXMhxxh/TkuPO8w+mAcFIUB9BC74sN0cj4+vKdLd6Mr4kzdw7xqrPh78Tn5vF2NJPWWUzrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 02, 2025 at 12:49:26PM +0200, David Hildenbrand wrote: > Instead, let's just allow for specifying through flags whether we want > to have bits merged into the original PTE. > > For the madvise() case, simplify by having only a single parameter for > merging young+dirty. For madvise_cold_or_pageout_pte_range() merging the > dirty bit is not required, but also not harmful. This code is not that > performance critical after all to really force all micro-optimizations. > > As we now have two pte_t * parameters, use PageTable() to make sure we > are actually given a pointer at a copy of the PTE, not a pointer into > an actual page table. > > Signed-off-by: David Hildenbrand Although I think it'd be nice to have a comment pointing out why dirty-young bites go together: Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs