From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62189C83F03 for ; Wed, 2 Jul 2025 20:38:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01BBA6B00C2; Wed, 2 Jul 2025 16:38:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0EBD6B00C4; Wed, 2 Jul 2025 16:38:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFD7F6B00C5; Wed, 2 Jul 2025 16:38:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CDE5F6B00C2 for ; Wed, 2 Jul 2025 16:38:16 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 744B358F91 for ; Wed, 2 Jul 2025 20:38:16 +0000 (UTC) X-FDA: 83620486992.05.5187BFF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 5E38BA0003 for ; Wed, 2 Jul 2025 20:38:14 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OoHzHsiJ; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751488694; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Oly5ZQ2+eF4YcMPWn15EEV0ajlmQqBU4UwuVPpiZtmw=; b=QvrA7bXhD792fCE+t9daBGKALtt9Fu2141tptfNnf3xSCggoKv3/QenPTUQbgeelKAs7qw Ihoj1rFR0uPdM0JHbpU0txqmLZU/59/zLy5YJu6X04yNXvZEJoIjk7L2YNMyQkJCmKCI0X UtmIaafZ2p7D4AXKdoniPe8GtTGeNMw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OoHzHsiJ; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751488694; a=rsa-sha256; cv=none; b=sEoDks4mdpcCbFLy/YQcxeDZwj+TyXuqpH4B/5AAmqAysx+IJWFll+tJj3H5KCYuYleH6x +brPvoRYjhZyvonW2eGGyc9H/pLGRAl2aAFEFiLProDs/VzhhUNHTWHjrkaiL3nA63jVnO 05k4bwdZZZqsVdb64fiwa9dMm4hlXsg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751488692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Oly5ZQ2+eF4YcMPWn15EEV0ajlmQqBU4UwuVPpiZtmw=; b=OoHzHsiJCLM0k72xBIfwEes6mfULRlVpi9TJz/mtzxDdQyH7ipvW7jZ2d8f4C/QqV+EwpI 5WbS/FLYHA1hjMpw+/f3hRgjTJeYMGB6Qltil0hrsR5Ve/LKX9OZq0CL5qf+0SfQZQ6bvz XEz5JqeuGU8qNNfEQXVuABvYThm9qMU= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-270-ioErxg-FPX21sCgUdnFWNg-1; Wed, 02 Jul 2025 16:38:11 -0400 X-MC-Unique: ioErxg-FPX21sCgUdnFWNg-1 X-Mimecast-MFC-AGG-ID: ioErxg-FPX21sCgUdnFWNg_1751488690 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7d399070cecso1011721085a.3 for ; Wed, 02 Jul 2025 13:38:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751488690; x=1752093490; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Oly5ZQ2+eF4YcMPWn15EEV0ajlmQqBU4UwuVPpiZtmw=; b=rL1ulTbhVkyINU8PWgBS0tRLP5uZ64hcJZa+z4k3vrD4y4aKk433ZQcBTM1jjEfiWk QRwIAqXH/n7PkfAswYfRoJPi8FJghhJuqpoMySKCOaYio2KqKpZXHxFsWJGfnp3Akr2u iqsGbjzBvpULFynPFtIk/oNZ8saB2mAWV+AneLIt+7hHXP7R02sPGqXfuVe5MULcA+p3 8xllg1+qIsCLb2DeEkgu8u4yAHm4Fw6/vTl7X3Zf8EmM2lgYMKAZCer9YasrNLhiYi6C Ivyhnw6Xrk+ZKj7WzQ6YOx6q3wZ7aBS4cZuYdL84waTsl9m/45uRqiacDIc/NZjjAqp1 G4QA== X-Gm-Message-State: AOJu0YzzikWnePfhcp1LDYdSlVPgM6F52XMbxT4MyV7FsE8kypmO8Fpn uuAhK/ceTBn46xG4+Ss1xcwMbO3dp3qrV8bTalTqhmYJhtPDkJM5JalIdqrnxROIzBc0STHMvti mOisKgZq4bxPGTopQBn5vjG3pKCZjS+gdORYZ5xd/rjykZD1+7o5E X-Gm-Gg: ASbGncvzR3G3+hFT+/LXVpyWg2HgcrGUiHZchfzhOGmKY+QT5mWjZYbnrh4fdbRlX5P Bkh2pSG4h58niMwtlnCsg3MmLrrM4OCGJYz8MjtWMQ5zUBB2xqHJAyTmaujnJ6phWzL6KTl2Rxi YInAuybJERlzcKJgGKg/rx61NjpceXt5OePGSHbLCoGYQuPV6XZczCksrKLn4c+hQJwWTKOy7BF 8k7QAoZR9s95u0I77zReCsoWoQ991fLsmscvKiSlqAfM0oHgltTbAhJRnKtkpGdi/L1O4a8uo16 m/B+U0tUvpdd/Q== X-Received: by 2002:a05:620a:46a8:b0:7d2:284f:e471 with SMTP id af79cd13be357-7d5c478e4c5mr618535785a.33.1751488690345; Wed, 02 Jul 2025 13:38:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGg9rDsOnDdQfr8hbXVLmBbDwC94mU5hTrS99xRgYOcTc+6ei90hAfdRAMYJSP1J/RUmFYj1Q== X-Received: by 2002:a05:620a:46a8:b0:7d2:284f:e471 with SMTP id af79cd13be357-7d5c478e4c5mr618532385a.33.1751488689959; Wed, 02 Jul 2025 13:38:09 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d443139b31sm1003759285a.7.2025.07.02.13.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 13:38:09 -0700 (PDT) Date: Wed, 2 Jul 2025 16:38:06 -0400 From: Peter Xu To: Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Suren Baghdasaryan , Muchun Song , Lorenzo Stoakes , Hugh Dickins , Andrew Morton , James Houghton , "Liam R . Howlett" , Nikita Kalyazin , Michal Hocko , David Hildenbrand , Andrea Arcangeli , Oscar Salvador , Axel Rasmussen , Ujwal Kundur Subject: Re: [PATCH v2 4/4] mm: Apply vm_uffd_ops API to core mm Message-ID: References: <20250627154655.2085903-1-peterx@redhat.com> <20250627154655.2085903-5-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pnfUHuhZRqXB3HS_xq3n8yXfXNESHN6ZUPV5jX61eMQ_1751488690 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: wq1cw974jzz6d4bzijy7o6h47r5itywt X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5E38BA0003 X-Rspam-User: X-HE-Tag: 1751488694-347306 X-HE-Meta: U2FsdGVkX1+QrqotbH00mH/+Vxf6UOytJb8K6hBncvT1FRfUBihw3Ljr0W7cuzdTaCcw1oGe8D2u02uzh1f5yA9m3rlR7IIn/OsG1zQCt4xgk9IUyY0kHBVO616iI7irJCjY2e/PJxIFYYAxnS1/GobGxXFkM3qRDCLAblaRyOJ7N5Eg258EWeZVucx/Nm/Etn9PcK2wlYmiz5FsMkpFvk2d4T/8xGfBQ7AafpKu+mA51bGLTLuiQgkn6qrXW7kxAKLZEEg7snGuApDxPrfghTy3KOLmDdwqCgpIYa8t+yQeGutrpcz1UOKGxkuNRc2Q//jMK4Yd/s3ezpgxUHFDG8HXxqKBOjYImDCoq16spVj7IUkeGUiEIQhy15pDz0wMA+2cRSa65sDLPRHN0PPdsPcP3t9E5ka8whOn/XkGD+VWXq5jEdFBIS1NKI1h3s2sVY0mGvfG5GzRih5jT0tP12FpRO3XMFeBtm6xH1Oo0wtbh1ZXIbUX2cbFjchP3IF8SN+9tjv1isVP+ICtJEOOB/B6pIwvNMIUYNHV0z0hfblBtzSi8Gc8oEP1h/PG3pPovSGcmq20APOGUnQzlnO5JaeQzFg1JoC1pvwSd7mOER40Ecejw1bmqrWl3qZcHXnOpyc7OD19ij2j4w4fjYZapijABL9ZZVHb1CP7C6MBwamg06McOmxE/2dPN7aoSHsEy2jHJ8TkT++ownElMlJouBfKBBI/XN+UNvOhn4LXU1WlhTRosvUNQG+39aIQnPSvGWXyC50KJHgQMACpTGmdrGaCVW5WBRvWF0sqdO9Fx8m62S+KSjLMrSwk1Kn3mawQRu9UMvr51iXo7MVA2H5kmwyx8+0T6Sp02yqcDc35GxBMcMbneo1rfDJJSud31I4GJoEtzVsbmF35LU25QT+Hrn2eXwbpIlkNa6+p3XAGZ48un69BAVxY+wT45ZP4Qz1e3SWTfT7cx9F4mD1AR2/ ggxOj/cX 7WZ8O9Y50TiJJMxKCM7zRD0F6nMBfySPuXouJNGfAvxPk8yY9Xlmmh/G8ssLSXnz1BU4gzUl04kPLQtgof3CBHvo8EWCpg/DfwtQ1xjyNJGrCXL0LtsffXoM8d1FGRbPqSiOhRCKN/lKgD4A7gKP3GzZZmIJQirDWUbR6v7iqfuCns6JKCYaIHUQefsWoOP/JLZHjyy8NCXXqinZ9yPPzvPaHqL6tc4tGgpuVBLWxDg6b8+DB5eby+eyv1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jun 29, 2025 at 11:55:27AM +0300, Mike Rapoport wrote: > On Fri, Jun 27, 2025 at 11:46:55AM -0400, Peter Xu wrote: > > This patch completely moves the old userfaultfd core to use the new > > vm_uffd_ops API. After this change, existing file systems will start to > > use the new API for userfault operations. > > Maybe: > > Move userfaultfd core to use new vm_uffd_ops API. After this change file > systems that implement vm_operations_struct can start using new API for > userfaultfd operations. Sure. > > > When at it, moving vma_can_userfault() into mm/userfaultfd.c instead, > > because it's getting too big. It's only used in slow paths so it shouldn't > > be an issue. Move the pte marker check before wp_async, which might be > > more intuitive because wp_async depends on pte markers. That shouldn't > > cause any functional change though because only one check would take effect > > depending on whether pte marker was selected in config. > > > > This will also remove quite some hard-coded checks for either shmem or > > hugetlbfs. Now all the old checks should still work but with vm_uffd_ops. > > > > Note that anonymous memory will still need to be processed separately > > because it doesn't have vm_ops at all. > > > > Reviewed-by: James Houghton > > Signed-off-by: Peter Xu > > Acked-by: Mike Rapoport (Microsoft) I'll take this for now, thanks. We can finish the discussion in patch 1 to see whether we need to refine the API. -- Peter Xu