From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F33CCC83038 for ; Wed, 2 Jul 2025 17:53:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6938F6B00A3; Wed, 2 Jul 2025 13:53:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63CD16B00BA; Wed, 2 Jul 2025 13:53:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52BF06B00BB; Wed, 2 Jul 2025 13:53:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 42D246B00A3 for ; Wed, 2 Jul 2025 13:53:44 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D6DE11A0316 for ; Wed, 2 Jul 2025 17:53:43 +0000 (UTC) X-FDA: 83620072326.20.4F82A80 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 9FA0FC000F for ; Wed, 2 Jul 2025 17:53:41 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pmnMC2zj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=agyambVu; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pmnMC2zj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=agyambVu; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751478822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FiMDhOWgDK6aRf46H0zrt2j/bBbAo0BPLVU88GTsNyw=; b=UMhXFwwXo31xuO0vR2NAAhtlR8G/rzhc/TvmeHbO5UeZ16KbKKxdZeKlhwZKHMeBnX2607 0/n5agOWraGi/KL5OtQWSS7BxxayZ2dwOOsBkH8Xz7fRMLTY1N7pbyq09ij1XssSCLyzQ2 ZxyOj7NKhyrvvt/HPrpXp/UF72MZrvs= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pmnMC2zj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=agyambVu; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pmnMC2zj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=agyambVu; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751478822; a=rsa-sha256; cv=none; b=k0hBfl4eBqAL7Dkp3hh0+78C9av9R0+PqviVwY4LoZ3saTdcwI5C/BeUUtnhWbDp768p0f DeVSjUZ8JgOl6r/1v8kaUT2xxmX7E1uB25Qy1Aid9tJ0wWwQbwWBn59NVzoxAOojbddRMA srvMIXunyvMzPRAKyp6KyGtjsVct9hQ= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0400021163; Wed, 2 Jul 2025 17:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751478820; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FiMDhOWgDK6aRf46H0zrt2j/bBbAo0BPLVU88GTsNyw=; b=pmnMC2zj224RwnAUnlYQvqnfeIVeR8nocowKQ8dn6EATdfc4u8N8TISPzoiAPVcp190R9H 0FfXrZg9w67/rlQExlkcTgynGOgBaagOx8/iJ9W17ljhGGVFH5IRXA6HZhBL4IIq2j4Kuj iX7bzHwZ0wDJlJzvqlJOTPLS90WM8QE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751478820; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FiMDhOWgDK6aRf46H0zrt2j/bBbAo0BPLVU88GTsNyw=; b=agyambVuYYk7F7azrM2/DaReSK43Kp5URpcxsoyad0ADNIL6jenmjSpWtnktE12LCC+ftE wzpTASRxGrHEwrBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751478820; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FiMDhOWgDK6aRf46H0zrt2j/bBbAo0BPLVU88GTsNyw=; b=pmnMC2zj224RwnAUnlYQvqnfeIVeR8nocowKQ8dn6EATdfc4u8N8TISPzoiAPVcp190R9H 0FfXrZg9w67/rlQExlkcTgynGOgBaagOx8/iJ9W17ljhGGVFH5IRXA6HZhBL4IIq2j4Kuj iX7bzHwZ0wDJlJzvqlJOTPLS90WM8QE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751478820; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FiMDhOWgDK6aRf46H0zrt2j/bBbAo0BPLVU88GTsNyw=; b=agyambVuYYk7F7azrM2/DaReSK43Kp5URpcxsoyad0ADNIL6jenmjSpWtnktE12LCC+ftE wzpTASRxGrHEwrBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C5F2E13A24; Wed, 2 Jul 2025 17:53:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DpteLSJyZWj8BAAAD6G6ig (envelope-from ); Wed, 02 Jul 2025 17:53:38 +0000 Date: Wed, 2 Jul 2025 19:53:37 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo , Lance Yang Subject: Re: [PATCH v2 4/4] mm: remove boolean output parameters from folio_pte_batch_ext() Message-ID: References: <20250702104926.212243-1-david@redhat.com> <20250702104926.212243-5-david@redhat.com> <3f8d6f3f-f98b-4f90-95d5-f4a09d61c88a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f8d6f3f-f98b-4f90-95d5-f4a09d61c88a@redhat.com> X-Stat-Signature: aham7kqcr4idej67oke4eeym1ks1r8um X-Rspamd-Queue-Id: 9FA0FC000F X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751478821-305144 X-HE-Meta: U2FsdGVkX1+i5wubA5JFvY8zFmHwsgLiCje4QetW36ZnTeB2xQ4+N+Nm53Q6tMKn/PuYfYtLXQNrlQQSpO6TXw5q9Li0qwRZ5oNNAy0G7k+cu3SMABrLs0tTE3CgemxZ3HgO/dUEtCo2nzKsCDINw5kRbDiFz3YGqn6LIworRyLPfSz8iFJNg5hCC6ACXYj1dHE/Eb/jd/Pb3jfrdrnKSiwSsuLDzfOVUqknGFxPmnVqzVvJGXENLsn/2G5bBC6TpZTJy2uk2ZCoXzuFZMyBAssuOuTKwP8ujUTBc2YVWs857uDNgjpmAv4OQRL3vLfIehQE8YlCC/SBuRvajBrAkWgN1pyN5jZiJyPJRuwQj3DE+dzGoXKIhyIg6lENR+2eKcs46l3enWB+pnWPMKGu+zGCm0/XmmWjJuG8t53McWC/54+xdS65RPeX1sDd6RE6HVJKCIZcHJ0yRX4DVC2pC0trkyHCNd5FzptFNH9v1mSfxBcDIo65Jd3+YNxg5FJf/MlJJgP0xl5lCwQgjP/KLXgRlgG74bSuJ+vg3Eirt1UKPZ4SP6+zxIMFCqJSehR7MknZ//pKiIXHrB+Wceb6ML1e1zAs8t4A34SkxzfMqi2aRZr4eUS1Mmc3CK+1I/d2sUUowxBcbgB35lnj5pnIyuSuv29kkDQBBv8rnJLCVKmSPirAA8rRhRF9ejIDmz45/TNrnak++Gyc03insMJ1u/uQ6DCBGt8HvSYyRvz/SknbfZMj+HuSsr4/w6KLadHmsoqDowbwvOVRqqUvGsDIOcTjPz2ZJFJmAPuXOqoRSfa1C3WKMAUBGY9smpcgKRmzTygJfSqp+bSx6Yp5RyypEgbzAC0HUJvlFZNpOtMfyInQ2Ru5Wv0v74wv/6UMsGJwHwN86P2Zn7CQGQzxezoLdKNQ/hL6pVFrYGODihu63wFLiSS8srff0rWtgTqMTDbgZfueeZ8vJhyFBswRaW/ 2dXrUX4t Cdm/kUvDD0QqsNkMSaQgKajQ2GDia39WfZykPrbdB3XP3nSB29vAQFbuP0hrlRV62Vqk2vZFMn6VEXtzp6FlGw8jRDfdg8tbiEg+KnKJcEemTI1WJ+2R2JBh1yGVdwx5jIVlVxINbhRNjN2OkIR83/g5ARXOKeLIqyjHgzLGYN3xsBOISOA259BF2Yaf1Bgu1CfD7jVuPLmJ78v+EW9KH1671fRgE5vTLvRM0a0jPT5jIGNK3gYBkEi+BLqrKd7P7rAEA3JsZlkguvgVKV6Ndb9yFijI6HQdrGPqtdwX+EKXJighmE0hdfrkmwVE255/nhK2dtzVC627FOtw2TDRxU559ZF/vVhT5uCyh2s97JyP1thrJbcOCU/pZJDgbC5MhD8Q2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 02, 2025 at 04:40:30PM +0200, David Hildenbrand wrote: > But more importantly, usually young+dirty is a moving target as HW can > usually update it asynchronously. Ok, you mean they often get queried both at once? > So in the common case, you really have to rely on the young+dirty bits from > get_and_clear_full_ptes(), and not on the current snapshot while the page > remains mapped. > > The madvise() use case is rather special in that sense. I see. I mean, codewise this looks like an improvement, I was just puzzled by the fact that we're dealing with young+dirty together (while we didn't before), but given that get_and_clear_full_ptes() do that already, I guess it makes sense if that's the way we usually operate. I wasn't familiar with that, thinking about it makes sense, but I wonder whether we could place a comment either in the definition of FPB_MERGE_YOUNG_DIRTY, or in the handling of it in folio_pte_batch_flags(). I guess in the definition would make more sense. Whether you decide to move forward on the comment or not (could be squashed), I'm ok with this. -- Oscar Salvador SUSE Labs