From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2DC7C83013 for ; Wed, 2 Jul 2025 12:47:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFBB4900004; Wed, 2 Jul 2025 08:47:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD41E900002; Wed, 2 Jul 2025 08:47:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE941900004; Wed, 2 Jul 2025 08:47:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B0BDC900002 for ; Wed, 2 Jul 2025 08:47:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EBC451A01DA for ; Wed, 2 Jul 2025 12:47:08 +0000 (UTC) X-FDA: 83619299736.10.2C338B1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id B09254000E for ; Wed, 2 Jul 2025 12:47:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=c8j+VtJ9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ESnPDywp; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QX0CWQCj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ALNdxtcR; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751460427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k1wIY7FTlKQzM4gTXb/EEfgvLm5LmwpW3ETkIJgLZjQ=; b=zErU7iG8M7VF0rxsZheX7EfNLAo78JzwPR4KBQBqEFmaLArYidPDeCv8K3vpbqiv/aZ1vr 6d5TFDCv0eG5hUiaWTKFg4ZNEAkTCwmXq7wKGnbWQxbGMiUPNDX2h74mBhA1oHjv1qu/N4 67hQiDdM55CSxeqKtBBn1lWwh9ZbNU0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=c8j+VtJ9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ESnPDywp; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QX0CWQCj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ALNdxtcR; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751460427; a=rsa-sha256; cv=none; b=rXnaKsbz4U2kxiKuHa4ancQXgukEpjG1bQouBN5VTP4ZoFoIu8x+xx8/kil4cu5btMT/WW 1MjPc01ZKNgP16dfJvdm4eJowACFp0WhHNanw3E9/ePl3nkU6oM9jiWV711TL1V381TQAZ 0lere6vvWAvrKPDoLaeWYlpPzWIYDdU= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BA20E21171; Wed, 2 Jul 2025 12:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751460425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k1wIY7FTlKQzM4gTXb/EEfgvLm5LmwpW3ETkIJgLZjQ=; b=c8j+VtJ9YX236iDh5ujSFWehUKt/yDO2+nPYL7d+SfjtapNmhey0WhzSQk+HX7+4RIEe6Y WVVTtPvuo8F4Sxx7OXgT/Qers4GQW81Ju+9qYdbdDwPyv51gUBPo18kJ1rdYJVxiHUdBLZ 60HVoOy9BACxYQyseeQhwgylSbJu7HM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751460425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k1wIY7FTlKQzM4gTXb/EEfgvLm5LmwpW3ETkIJgLZjQ=; b=ESnPDywpn3TljQ5v0UNHyV5ab7aLXcfCktN7xZ/b1FjfjHxRrj94A51KQnhuPHR1yBZTko LZ28qujdQV6L8KDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751460423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k1wIY7FTlKQzM4gTXb/EEfgvLm5LmwpW3ETkIJgLZjQ=; b=QX0CWQCjM7tKWQTzKmW15h6JTE3U9IHQ55Tsa+1UdJRsyLHXV+hvjOyFwpT3U8/0vbOvyk rA+P0Wo5GJ6nGtQ81r1csD/pxqcC6GziFpx6FM9kRJtGn3vJiH02H4cHQUeJcSt1o/opuA qRIp2u0gBaTTc5rhJrKdoaL/KzephRo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751460423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k1wIY7FTlKQzM4gTXb/EEfgvLm5LmwpW3ETkIJgLZjQ=; b=ALNdxtcRXQpzvotQ/cV98jn5/j/K7zdIvU0Pe1xxilGoAUlGVPUdgYOe5CNqykhHnBfu8e 3Nqj1bL9wYIMT7AA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DA08C1369C; Wed, 2 Jul 2025 12:47:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MABhMkYqZWjKIQAAD6G6ig (envelope-from ); Wed, 02 Jul 2025 12:47:02 +0000 Date: Wed, 2 Jul 2025 14:46:57 +0200 From: Oscar Salvador To: Donet Tom Cc: David Hildenbrand , Andrew Morton , Zi Yan , Greg Kroah-Hartman , Ritesh Harjani , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Danilo Krummrich , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , KAMEZAWA Hiroyuki Subject: Re: [PATCH] drivers/base/node: Handle error properly in register_one_node() Message-ID: References: <20250702112856.295176-1-donettom@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250702112856.295176-1-donettom@linux.ibm.com> X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B09254000E X-Stat-Signature: m9irm7bmj4fgyabt3b8gabisx9f8dwhg X-HE-Tag: 1751460426-208494 X-HE-Meta: U2FsdGVkX18kTHOXFOiavYcgPZ1O5FT/2qq1dv5ocvEggOUa8w0pFBDb1UVyXYO8hhXN1I+KMEpsB41CoMmUUdihwl/zS2BKu8LX2c5fSawwURHEiwj8rvUj6FeSOHJcNrLPNkqSK0d11THxA9ATcU61JRGhAwNrQCuWawLHCAMZZpsiEACFlYNT36H3sa5fhMcGZzms7VySefaQBvbU+FaA7lXb9sXMB6f1fUSU2rKLyejvkikZIhEQCyB+z5MH7b+w8dZYJd6byhxQq+EdRoItRxJFB2NLmoAoy2afkqour5ahk8npPWqjtGFEaqaIZ4M6o/1A5uUR1yXm7yCazLrqdeM0iyLZtm9oULVnY25poywgyzab2URvNOh901HobPJ4GL6+iN7Pt8c8JiAydhpt6XMET6f6IoDEGRx1XpzdPH36YtpinvuiGFJneDbt+Cg80f1MBrIYgUmtfqNXbpE5N3j/fki6bLh6Eh0A8oErLZ6TFCJt2LKiQkjXlmnEaPCF7GgB5lsD3gqzJieGXWXz5t/ycAiWelHWEVgZ/ZYbXmC45pcLezOOArKkARCja2EzJ8WbXG3uFgmFLqZD4R0bT8KLpVfOIPcC4iy2+JBJlCgT+kpuL/ZioaWFl1WpRR684/Ytf0UIleel0VbaIZV90cngXU68qIakHRA/PO826J3sNeIsbqMDUPhLqTv8flSS9vUOvNjtOOtn2K95jDj/sePraQyE4/vdDMg3fGJBRbfDVbUG88eNefrbp4brLNgte1peTMuyNme/i2lgRzyvtWkF9xLLfCgVwU3dwPtJN6BzYcTEHna64cQO6H9ePthnIHQOei2YkYQ1YSbsdxoHuagVszn9+Sx5T/+4Lqtn9jDj0RIqRU5PV0iN+ey4fKPeGzh06aS4WurHwXBNxAtzQ0z3pFBACHq6VVtjQRhnz5FIL+KJ8rdXckDEnZ19JECHNehNDb1UnAVVarY wt9gT6S2 s3j6qYG2dgD0kHfL9nN4mqHYn4pvxXUhQlbVn1qtHVWvRH75lKYk3kFMi4xvUvXmIKRgHLX0ju8ejLLPePhxgSPqWrNtkGaTekwyJ7m4AcX3yXi8iELUM2g4e+04rlp3jP74XxTDprmIjhYGuz4ZQGSZOFcE4jqmAZfe9MLe2suw6zk88j5xlwYXANG7M2GLFrsyyuT/WZAz3aGxBpqHkbuBJHhwqk8NAYZnA2HIZ752GdqciyGMrc8NO/1OxMcq0Q6Zv1CJeCj/cACSyA/wBEQSt0d2/iwGj3wqM30dwEyQbBWVCYhOKWjqUanQaDlqEbvd/5IL0E4MASuX2mCyOg7GFoK0iOBvfRkfh7NBehVAI5pblCuW5JrKs7k3H1ZUFGkoWEytaQmgkQx1/F2R00PlU+29RzXBMUPLEKDIji89LyR9bF7SuczLcpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 02, 2025 at 06:28:56AM -0500, Donet Tom wrote: > If register_node() returns an error, it is not handled correctly. > The function will proceed further and try to register CPUs under the > node, which is not correct. > > So, in this patch, if register_node() returns an error, we return > immediately from the function. > > Signed-off-by: Donet Tom > --- > ... > diff --git a/drivers/base/node.c b/drivers/base/node.c > index bef84f01712f..aec991b4c0b2 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -885,6 +885,8 @@ int register_one_node(int nid) > node_devices[nid] = node; > > error = register_node(node_devices[nid], nid); > + if (error) > + return error; Ok, all current callers (based on mm-unstable) panic or BUG() if this fails, but powerpc, in init_phb_dynamic(), which keeps on going. Unless it panics somewhere down the road as well. So I think we need to: node_devices[nid] = NULL kfree(node) ? Also, once Hannes fix lands, we might need that as well. Anyway, I'd suggest you hold on until Hannes fix lands, so we can later rebase all your mem-hotplug on top of that [1]. [1] https://lore.kernel.org/linux-mm/86f89a65-f0f6-4462-9eea-ac691de2f3b6@suse.de/T/#mbf392eb390b8053f96be50da3b40dfd9b62dd389 -- Oscar Salvador SUSE Labs