From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F661C83013 for ; Wed, 2 Jul 2025 08:42:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E0B06B00B4; Wed, 2 Jul 2025 04:42:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 369B36B00B9; Wed, 2 Jul 2025 04:42:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 258406B00BA; Wed, 2 Jul 2025 04:42:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0B0D66B00B4 for ; Wed, 2 Jul 2025 04:42:22 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A0DD61407CA for ; Wed, 2 Jul 2025 08:42:21 +0000 (UTC) X-FDA: 83618682882.09.6150958 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 599EA4000F for ; Wed, 2 Jul 2025 08:42:19 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KPvIdnrf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="1tT4+xW/"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KPvIdnrf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="1tT4+xW/"; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751445739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jU2bqc1mBirNwkpAEUTKLOgtJSq8z+qHvFX/1pA5K3g=; b=C3CqxdoVMYBkhLZtE09WKgidWrB4LvBRcDwef2S7IuCaqNf/nqR9kXjihf9PxA4i4/yecV GOyRvSup7G2yxFWDnKrPeh1JtIyccfoYNcVd9A6eSMbzgDquTdzyzwOc9zIYoMhKqlMsF5 gWqZKFmDGx6awKG5p6xrdadnf8paIy4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KPvIdnrf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="1tT4+xW/"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KPvIdnrf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="1tT4+xW/"; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751445739; a=rsa-sha256; cv=none; b=GIq36mquYKZp84Dhld/FegbK8+OcDsTMDuOGSEv7RYg75ypnqtbQDnOw5WJQbKPheIuArF RbegBJXg40JAaUCyT2tWAA2ooKR/XCJLqfoyYW708XSiIVjpdPF4C8nHXiybuctEwerVIw YKZT6T0xFhny/MMAyVUbl6p8FNCou+E= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7DF342116E; Wed, 2 Jul 2025 08:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751445737; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jU2bqc1mBirNwkpAEUTKLOgtJSq8z+qHvFX/1pA5K3g=; b=KPvIdnrf2W5r/V8c0HlZjQsYbIa913azRk6tifhUjd1gfC/R6iakGDF7DNruBeci4IDTKT jX07h5GlvmqRiJpJ7n0+bjSNHKQ/tVDfHuQOl8IhM1QPfmwjJ6oRFvSapbJi4cXLitUzJ5 h1bXqsGoq1DzndVnxfqTrJJGopeMw9Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751445737; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jU2bqc1mBirNwkpAEUTKLOgtJSq8z+qHvFX/1pA5K3g=; b=1tT4+xW/ZzRfq9fMuYAiXP/y58cdzahxouxX1YBZav2YWJWxcqQXLMOx2yGca/05YoUpm0 r43CuAimn8u0kCAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751445737; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jU2bqc1mBirNwkpAEUTKLOgtJSq8z+qHvFX/1pA5K3g=; b=KPvIdnrf2W5r/V8c0HlZjQsYbIa913azRk6tifhUjd1gfC/R6iakGDF7DNruBeci4IDTKT jX07h5GlvmqRiJpJ7n0+bjSNHKQ/tVDfHuQOl8IhM1QPfmwjJ6oRFvSapbJi4cXLitUzJ5 h1bXqsGoq1DzndVnxfqTrJJGopeMw9Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751445737; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jU2bqc1mBirNwkpAEUTKLOgtJSq8z+qHvFX/1pA5K3g=; b=1tT4+xW/ZzRfq9fMuYAiXP/y58cdzahxouxX1YBZav2YWJWxcqQXLMOx2yGca/05YoUpm0 r43CuAimn8u0kCAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 514151369C; Wed, 2 Jul 2025 08:42:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id AR7VEOjwZGgsUgAAD6G6ig (envelope-from ); Wed, 02 Jul 2025 08:42:16 +0000 Date: Wed, 2 Jul 2025 10:42:14 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo Subject: Re: [PATCH v1 2/4] mm: smaller folio_pte_batch() improvements Message-ID: References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250627115510.3273675-3-david@redhat.com> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 599EA4000F X-Stat-Signature: 5iaxszdiqrutmeiww65hcq5gw59xih1y X-HE-Tag: 1751445739-110841 X-HE-Meta: U2FsdGVkX18NWWOaHg++7RnXT4uCfTi5NwKHS6U5NkyA2jN+n6WgL53KsRdrcJ1z+gAQ8m44ey3Us4zUQB3RVUdrNfB7d6oV0ZeuovnO8mAzx5sanYvu+HPd03UogRY+n5rqsgUylAzuHaRfgXYbEbqMXBG2/JxBX9tng1bLRcE76KrsB6LrsFOpprwugkuv/IV1Xp/AkfPPx1cM3O7VD66zUWLE0Q0+DSmV/YWK6jGSZt+t4AmzpFhW4GQjduh7FyhZ+E5e0h3PyyGnIT0P1iikc83ZkgFWJVzaHUuJ2GbmzBrsIQ4kkyADwFDRI0J18v0WO6hI58SDfDce4aVze1bed9piaBWo9bi4YxVa/FI4qaias+VxwUijp3WGEGbMb+6aAI8GIBq0Z8C2lMJUr2aITmZ5SV9YLxsUqmpdgyxlOhZeqGFBWb8mVpr18Ovk0AiTrC2xKyl0I5kFbu+G7qRL9vRq7Bd813kUSiYu7rUzMdfLVTgoCKcL1EMSTrFysh5/iy3Gk38VZ3UkcG3n7rcIKiPYXkhOZ/UraIcOHCWgVyO0wKOuh6eBrEqpg13F5/PAaTm7HHucs4jx9Q7nn6AwJmBkitHvsdMmRavtyuJA1IVn5SZkjD7vaZ4UujZAlgS8DbqsvEUuec9+nyDIrOYoIe346eIko7Y23vFu+gen+IDqS68ZTIgTaHDaRUj/Q0Iu+rJDmmLNh35K5tjrun2Sk/QQYVf35FWY/+T0MbFoSc6jNGQ58+xq1Nc/pkoze9ukCq51bJiHlajgOoe7ddZsSf1OGpGrSJv/wMfBnCCqSFkjpH9aocO048G7aUmLEIa7gjdAcLw+0d4V0VGxjyTQlHq2R1FiFqc7STzKiSsxFIIPwOePqQrt9keqdW+QzXQYhIrdbcGsApcc/gZqYQgsLfX/SniH/TioNhzUHW0vrQREWtXux2IE45tG24gDFxziboEynocAspmHb4F s2O1ZmOT xth9MwpqgHRwjS8brazEulIlvYt8Vbde+fF+gXXka0rmw692ILpTnPNGGWYsBQkkvmJlyNx9eu8ns+4odf7vEjQu6lyBuXOV/oA3BXLPhzGLiUJpo3IOvdbIp6WgVpZtX8Odx6kF0cY0LHOZKQ/oR9Bf2yeCxIckazkniX6XmEZWkorazQLsQnar6fs8J0TCge22RIxmF7QVI28Z2kWdY9fpvX/851WqbFxtKiy0EzyEAgRr9ehSz0L38QXMwWXzfpQ2FL2d/Azbax3TiQmgY8EkOTAQdwPLdFjumTak07ZUwFaT9pdsEmfS8BNz22//3496Q3CITfQEH7YtU4pF0lBMGWmmNxtgpfZ2qUFlZiQsc/QdL5fjyJ1+BCsnHlPd8MciZHZYWWeN3Ci1Kff8RscuyxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 27, 2025 at 01:55:08PM +0200, David Hildenbrand wrote: > Let's clean up a bit: > > (1) No need for start_ptep vs. ptep anymore, we can simply use ptep > > (2) Let's switch to "unsigned int" for everything > > (3) We can simplify the code by leaving the pte unchanged after the > pte_same() check. > > (4) Clarify that we should never exceed a single VMA; it indicates a > problem in the caller. > > No functional change intended. > > Signed-off-by: David Hildenbrand Hi David :-), I have to confess that I fell in the same trap as Lorenzo wrt. __pte_batch_clear_ignored changing the pte value. So I'm not sure if it would be nice to place a little comment in __pte_batch_clear_ignored claryfing that pte's value remains unchanged ? Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs