From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D91EC83013 for ; Wed, 2 Jul 2025 09:09:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3EC4D8E0007; Wed, 2 Jul 2025 05:09:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 39C8E8E0001; Wed, 2 Jul 2025 05:09:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B3408E0007; Wed, 2 Jul 2025 05:09:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1B8A28E0001 for ; Wed, 2 Jul 2025 05:09:34 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AFBF51D8A2F for ; Wed, 2 Jul 2025 09:09:33 +0000 (UTC) X-FDA: 83618751426.25.84CE99F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id 804E34000B for ; Wed, 2 Jul 2025 09:09:31 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XJcpNtP6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=gmgXlmut; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fBtVbuH3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=P4eGlMxu; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751447371; a=rsa-sha256; cv=none; b=YYAEoNN1YNH0io1pcRA0OzlTzzuzL9YvYYqyNMNawOg0M1kd935VxFxzHeyh5ZRQHzcFNQ fV4cfpx09OUOz2e97TEuiXrKeNXfsclVgteW6vljacDAtWklG16fHiPCulKxr1fFj0saEI bZ8bEZtdnLlbf14so63CDg5BaEdV10Q= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XJcpNtP6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=gmgXlmut; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fBtVbuH3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=P4eGlMxu; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751447371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TsYN+KydblcbGJyH+2QgDKawOYmLVVn1pDOpsr1JdQQ=; b=bLIj2jOepToK5d+PhIFlGaKqqD9xS+JS3egba4OfGRI3jz0XU4Am9KX5rpMdqFvDDVOMd3 qqxnSRTcWi/Tl3n2indd8FA96eYtB7FpZ/8ykDQ7L72SUvKU+e0PzYgJcU/Lw9fbjW3sjl AYSx/IwIaTG4mW/zcKDoGsV/eh8HDq8= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3102321189; Wed, 2 Jul 2025 09:09:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751447370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TsYN+KydblcbGJyH+2QgDKawOYmLVVn1pDOpsr1JdQQ=; b=XJcpNtP6GQIaPRR/mSY2ixOvedMTzz1z0UzXnDjNB5UrH6GnYni9QOq/x31hXxE/64FbVn sVxVf8G9sEw2pxutjFQruXHhK142SmgUrrxXBY0B2N97LxJEQmYcCOQvwSwcjc123ivoxQ EAOoVRtdIFLoHZ7hW/Hq8kxboKawxyg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751447370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TsYN+KydblcbGJyH+2QgDKawOYmLVVn1pDOpsr1JdQQ=; b=gmgXlmut1qzWz/5rsncqiYPId2MkHwK5t0pgUNucjMym0WgEvJZCa/R/RsIPDLgLBtf/H8 4sCtAY3618YSGZAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751447369; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TsYN+KydblcbGJyH+2QgDKawOYmLVVn1pDOpsr1JdQQ=; b=fBtVbuH3Cs4wUfyXjIfvYLHYTSvu+kioty+pDAS9dGG9z76crY44XVy0ERhNLJLtOpPOkh jX/PTkVeJdugLGPxkTdWu93676gJvGqP+xuMdX1OYRMD64028cZtKAjNnuZdA+JRTP/yjH F0ydEzbklaz8btvgN/Qp+k4NO4FC7Do= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751447369; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TsYN+KydblcbGJyH+2QgDKawOYmLVVn1pDOpsr1JdQQ=; b=P4eGlMxusc4c+4VQEr8zq8ftcIp2LlusisbfI89F4Z9UmQcT2EtB1mdzj6Yo6UvIehMM8/ ZX0JVP4/pKiQfQAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 056301369C; Wed, 2 Jul 2025 09:09:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2YQyOkf3ZGj0WQAAD6G6ig (envelope-from ); Wed, 02 Jul 2025 09:09:27 +0000 Date: Wed, 2 Jul 2025 11:09:22 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo Subject: Re: [PATCH v1 3/4] mm: split folio_pte_batch() into folio_pte_batch() and folio_pte_batch_ext() Message-ID: References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-4-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250627115510.3273675-4-david@redhat.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 804E34000B X-Stat-Signature: ar7t989xb1s8mr5bzqwehckj5dgjwcue X-Rspam-User: X-HE-Tag: 1751447371-695528 X-HE-Meta: U2FsdGVkX18qyfJhfaZTrE43sMNA4fW+HQCxf+3rxBIFUjNzfHMcpBkkfI6eBLkpL0BIzHoUCaJz3lINv5PuSHcb6EnFNAhNWCL+Xhb/oS+19oGtsbl5S2hR2ut/TdrNi4qNc4hVDCu+DmRTPT5WDjAOT49/7xHXPSEVxsIGHQAHGsXHXrNDgfx45AKUDxbeKuPbRCbdwwN3w4za3g3veXPBTuKfnLQk0K6MCcduJ4vEKWZqXHKdGTQhyKKgaWpGAWMbKNR4fNPsVwVulESzUxPHTnK0L2wB6zKPGgH+/+aBxZZdBIWak/4Sa+rJksh3xH+oubJA3z9zZEiPyd+7rQee/BJvMomq6RhAS0Ag7L1gtpLv7RGmhtNN4tFnAdeKQ1LdIznFe5o0DmyUiNQTr9YxgqTAFQWh73qTwIVYAbVZAsIxeGh4bt/8IV7ERQ/fk/Xq2Y3fahyUADkT8iNrAI37LmTRWhumv/7fnwwm/F8Sr2VxvNT2JzOqgnFZddn4WgPANEDjF+Xz3EBr9u4n+eMjOkYWOM++uwlkJGo7IhIxPa4bFgZO6Ck4+Y8QVsoa+W/vZpw+dKHe11wiFSy3a0xqfzIIt9fgqNo6CcFYWx0TB6Y7bV49MaxL+dosfqVEI7dcMLzGG6ZpwNt5/A1VtmUwWWjTSB0FrC4iVvFmQr9p+dKzJvhcEK8fUZLn7jN/lD+9QNtcPPUUPuYgf3UY8qU4q1fZnxQ4klIOvP2qxg08XB89HVfOAIz+oqtrYj1glzIE6wcoEdlHN0gI+lybZhxg0on6IJP4DEEVgpWymB76og1MLw7wZVsbJqkjgPVVzEP8G+/17h7B+z/+Yk8wLYfoEdJECSODOBArBhg6qPiIx+NOSadLguq8NKpLlLeQJ81/zSlrWgtmURr0qPPttfs63Zl5beghvaNMzeCXp3f8nJylzEmN2CgkSNR2bTuIRlKDCW4qWRzvNAUNt9n QQNmSPvh 6p8KnSgrvYDiMghrHiSDqvdrtSJKAnSGsSgywE+H1DUlO3UmvFASiUiQaemPJxFujHzx0FUX6PsibMNcwho9wyeFtX0Zk3Mn6bGXut3TXmGvysVcYJv9Dnpa/tAcVGz0efqzdEx0z/gNdMIp5z1Gj7lC7Qb0RuU37S1YZfUMyV76LeJ5cw5GwUxWY0OZ/in6LBA8utWXaTiENA5fMaR9u+E3Esy7SHqJUEqmAkTTJFpiNRiy/HFUITolQIk/BGa+45WGeZC81bNzXnvyVOU0OJiJhQsOPf200uwbP4k9RxjesOScFYLSIU/kzAS+1lwBbcuVeuJm1gONsPq5ORvt1k/DGVUgnkAwuEXh0YeegySTJzJs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 27, 2025 at 01:55:09PM +0200, David Hildenbrand wrote: > Many users (including upcoming ones) don't really need the flags etc, > and can live with a function call. > > So let's provide a basic, non-inlined folio_pte_batch(). > > In zap_present_ptes(), where we care about performance, the compiler > already seem to generate a call to a common inlined folio_pte_batch() > variant, shared with fork() code. So calling the new non-inlined variant > should not make a difference. > > While at it, drop the "addr" parameter that is unused. > > Signed-off-by: David Hildenbrand FWIW, folio_pte_batch_flags seems more appealling to me as well. Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs