From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 114DEC83F05 for ; Wed, 2 Jul 2025 09:07:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DCA16B00CE; Wed, 2 Jul 2025 05:07:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98D026B00CF; Wed, 2 Jul 2025 05:07:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87CA76B00D0; Wed, 2 Jul 2025 05:07:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 728576B00CE for ; Wed, 2 Jul 2025 05:07:55 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 177671407D7 for ; Wed, 2 Jul 2025 09:07:55 +0000 (UTC) X-FDA: 83618747310.25.9842570 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id CD1A1160004 for ; Wed, 2 Jul 2025 09:07:52 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YjlWNsOV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="CiXv54a/"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YjlWNsOV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="CiXv54a/"; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751447273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P2fD/2YL7KNYrFMoa0ML6XAgkOGWhDNJ70P1HU6KJaI=; b=AFce5LwPQzGWLSd1otTtmP+UrGDbQaEExGwfdSp1QHBSLWDondNLqAkVR95FTrkHc6Nnwf CTamZLJWesN4Nt4T2cHQCLlU4FWYiCMxowCD5m+Ql/bygkSaJDpl6rvkH6f58AWrOLsb7/ ferDv054qbuzfWzluoL4Nw7SVTspWD0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751447273; a=rsa-sha256; cv=none; b=ReJqnooCoRgGJF3mSR/PevpfFqiWOYC+JPsj36i0QCeO1A2rnxKTqum20rKDu9z1Io1+oI 8t2XGqpCwE8OzmH9VK6wGZuUPNOA6Nsy9wRFwhpR+fg/ZGvuyvmkCeTxz47OluSDkUDpki H5Iq/KUAEhSbAInzcKp52DnkeVmgNrQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YjlWNsOV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="CiXv54a/"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YjlWNsOV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="CiXv54a/"; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 20D7421185; Wed, 2 Jul 2025 09:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751447271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P2fD/2YL7KNYrFMoa0ML6XAgkOGWhDNJ70P1HU6KJaI=; b=YjlWNsOV1sSS3J9CyIw57rl8hd8PVXUWqJDsNq+NJ0d34QgIlsGz7coPGka03v/EWlUsyb y9rOyHeJsaiW3b117Bk6ngAZoX1zVoJdjbKVA70G0p3fbyeRsSn06plEscHosUBA6x9ECh QzjwDOZaOtRN+dfejDHBi0kaidBVNYM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751447271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P2fD/2YL7KNYrFMoa0ML6XAgkOGWhDNJ70P1HU6KJaI=; b=CiXv54a/Am3bR4gTcZgrBwFs2sk0eQWzOh1O+a0iG484R7wkuFq00aD9/dlYpUutwo3EG2 O6B79FWQXQaaaXDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751447271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P2fD/2YL7KNYrFMoa0ML6XAgkOGWhDNJ70P1HU6KJaI=; b=YjlWNsOV1sSS3J9CyIw57rl8hd8PVXUWqJDsNq+NJ0d34QgIlsGz7coPGka03v/EWlUsyb y9rOyHeJsaiW3b117Bk6ngAZoX1zVoJdjbKVA70G0p3fbyeRsSn06plEscHosUBA6x9ECh QzjwDOZaOtRN+dfejDHBi0kaidBVNYM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751447271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P2fD/2YL7KNYrFMoa0ML6XAgkOGWhDNJ70P1HU6KJaI=; b=CiXv54a/Am3bR4gTcZgrBwFs2sk0eQWzOh1O+a0iG484R7wkuFq00aD9/dlYpUutwo3EG2 O6B79FWQXQaaaXDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E121F1369C; Wed, 2 Jul 2025 09:07:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Qiw6NOX2ZGiMWQAAD6G6ig (envelope-from ); Wed, 02 Jul 2025 09:07:49 +0000 Date: Wed, 2 Jul 2025 11:07:40 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo Subject: Re: [PATCH v1 3/4] mm: split folio_pte_batch() into folio_pte_batch() and folio_pte_batch_ext() Message-ID: References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-4-david@redhat.com> <17777b93-41f0-4943-963f-0330489b01bc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17777b93-41f0-4943-963f-0330489b01bc@redhat.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CD1A1160004 X-Stat-Signature: 1izqi4czpe35qb5x7gtc394gqibdxkwj X-Rspam-User: X-HE-Tag: 1751447272-958471 X-HE-Meta: U2FsdGVkX19nIapHBsipBRdaXly7rzIUoJDIPbWfzh6BNEPm1i9mdrLC1pi0DoQDEUKJkQ4nBNSf6RTPFDlov9yv5YUp6HCWpeCVhzOGcJ0QHx1rpttMDbEw4tyNWspyePJwoQ1Tx7Ea1swIkGxg2fbXqviU6/LSzVujRY1dSoUW23+uIQ84rcUjDP+5gknYb/2UF1UfggIDt9mvml0JwiCYse3dMcRGbp8lkfh3k4rNQLFLUa4VD18SeiaYBO04AHsskBREsGMkRQvuTx7RZfm/OXXXwNPNHBICnuDUzbJHN207UNAWt8JEcCa5qTaOdEa+whgV4FtXHEieqZAgpq+Vh93G2Y/XhGkV/JpL+yxDKOJnb4fFAyjGPFHHA4pJprTllh8toEz+E9At0Uf6gwjIyWdNO+TnmIeoyNKSE7SKOM6zEE5ueHkza+b32KyYsKLGHk06GSwn8AwDoAYgVREIuW1ylbvN7kFzEpSOzVqeFkOJ+C15As3gRfKSGguvqzSv1E508D07iJfLgXYvTOSM9g7PcbT28XoGYFBOETz8RKDJKVgygdw5X7n1KQF+tIbEDTxmz4Yjv/Aw17Lt40KOMYeUrX50xEijEnrdlI5iKIj4zvGVY9qXLjthrV/GNRdLx6rA/I+c8l/J6vbaTmtix6smYOvA/mXmOwGDZySeyivHxI0PfNu5M+wOeY7k/D8BlVskKXWKMucu/BA8zf3kq24OkPbmXnAiLHfOvO/aFd55Xu072WrO6er5LYAxdvsP7KeKfDe3Lpvs3Ci3T/rnRoykH5Is+JQaax9zSB8DavyK+IUDG51kl5GfHyJMhFQUX4QbZ2e08OGrJD4FOzwktJvrdJLqdivNBkKXts36G3F8w9lok8ybCGFgyPt0sPxg7sJYM465DyBx/rZykcs92a3X8StRlATnn5aCW4RkwPBf/NSS1lUggeEP4XxK0paXc5fenMOoAoOVlN6 PjPUOjfw PZrt6y++pnwsJMerwQaoA8CAiUoFuhVE32/nO0cHODMGi2rv8c6dDh6hSJnK2gUnzpf4FYS41eTzVbXms5eX4r2OWpcuXdXxgBfPofGYp7x4EqOddG1uRWTQZ4aT21VxtGc5SiWHyZOW5RcRkOWfpOU1XOc1ROSJQXLYgt0yDsC2gXvuWOLN4TaqcWlZ5i/qTqHRnYxOMakXdelJrgh/CDgVTZhYclAkOANtEpkMkLkzALOnple7H6z7Jc/i0hJHJZUspCd7EzjYbKSvyET/x7smagNa6KME3Kh1vzWYOCQMCNkj6uq9ywfdvB1OSWT4vKhakgvdYbbbLtkQ04lRlNs5vD2qKELYLGWSpFpdtyJIBzdjsXz2X8uWR72+AIj3l/Xwr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 02, 2025 at 11:05:17AM +0200, David Hildenbrand wrote: > Not necessarily inlined into the body (there might still be a function call, > depending on what the compiler decides), but inlined into the object file > and optimized by propagating constants. I see. > > With this change, a single function, folio_pte_batch(), identical to folio_pte_batch_ext > > but without the runtime checks for those arguments will be created (folio_pte_batch()), > > and so the users of it won't have it inlined in their body ? > > Right. We have a single folio_pte_batch() that is optimized by propagating > all constants. Instead of having one per object file, we have a single > shared one. Alright, clear to me now, thanks for claryfing ;-)! -- Oscar Salvador SUSE Labs