From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED97C83013 for ; Wed, 2 Jul 2025 09:02:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 231F06B00D1; Wed, 2 Jul 2025 05:02:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BB9A6B00D2; Wed, 2 Jul 2025 05:02:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05C846B00D3; Wed, 2 Jul 2025 05:02:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E54676B00D1 for ; Wed, 2 Jul 2025 05:02:54 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5DC60BB70F for ; Wed, 2 Jul 2025 09:02:54 +0000 (UTC) X-FDA: 83618734668.22.D9134E9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf17.hostedemail.com (Postfix) with ESMTP id 446A04000C for ; Wed, 2 Jul 2025 09:02:52 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1Fdp7qRY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="ca0bA/va"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1Fdp7qRY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="ca0bA/va"; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751446972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pIb0lfPUXtpRwSrqU6GCKD30rV+XacuTCI2v/FcPKU8=; b=A1/r62XDpr2AK3q4nuKuorJWzEcOKrcZzqgK5XKDzPyWNdkGO6svNNKdk2A42X5WfU8KOv uGo4S8OmY34a6gEFWU8xApxONAJcflmv3o8bwRnpUO8TI1d7ahvgj5wUHgzuP+c7bC7hcZ rZMCTg1e65f0+hCw+b2S/AqwFC1HOO4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1Fdp7qRY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="ca0bA/va"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1Fdp7qRY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="ca0bA/va"; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751446972; a=rsa-sha256; cv=none; b=HyjhBykekdJaLvN+520MS2HHs2VMK1rEd4w8U5+Ejap0BpCFHWuqKg//2FNA8+AxFsBIQI KTCYz5mX76KSClGgDP4tPnTEER818+fU6w+uk06SkHOu/1sVQYWjiREKxFOQEw4au5qb53 bJ27c8Py5PToJiq0Cqy0fWTcB6gehio= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A84081F452; Wed, 2 Jul 2025 09:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751446970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pIb0lfPUXtpRwSrqU6GCKD30rV+XacuTCI2v/FcPKU8=; b=1Fdp7qRYA/Bw3VBBVzCklNjsI7Gvrpcf4nHOHlJnAxRGyOOZsIyiDTDCvQsRtDu0oMpWry E5Kmtl6czApZCSEA7mw9aP7yBLNl6l2VwiBxnFrOgmyufcpDQu/6IESOf3LzV6ZV5R6Nfa BdU0bJrUGp9WE5ITXwMLX3VSelanN6A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751446970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pIb0lfPUXtpRwSrqU6GCKD30rV+XacuTCI2v/FcPKU8=; b=ca0bA/vaFSl5VLPSWHyxSZJY+8zypA1AIXlb5d9nHR8ZG4Qxx7OG6mjW5XUVBR4U+UbLDO c4EeypilGnYLjxDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751446970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pIb0lfPUXtpRwSrqU6GCKD30rV+XacuTCI2v/FcPKU8=; b=1Fdp7qRYA/Bw3VBBVzCklNjsI7Gvrpcf4nHOHlJnAxRGyOOZsIyiDTDCvQsRtDu0oMpWry E5Kmtl6czApZCSEA7mw9aP7yBLNl6l2VwiBxnFrOgmyufcpDQu/6IESOf3LzV6ZV5R6Nfa BdU0bJrUGp9WE5ITXwMLX3VSelanN6A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751446970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pIb0lfPUXtpRwSrqU6GCKD30rV+XacuTCI2v/FcPKU8=; b=ca0bA/vaFSl5VLPSWHyxSZJY+8zypA1AIXlb5d9nHR8ZG4Qxx7OG6mjW5XUVBR4U+UbLDO c4EeypilGnYLjxDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 73D4F1369C; Wed, 2 Jul 2025 09:02:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id S0H4GLn1ZGgvWAAAD6G6ig (envelope-from ); Wed, 02 Jul 2025 09:02:49 +0000 Date: Wed, 2 Jul 2025 11:02:43 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo Subject: Re: [PATCH v1 3/4] mm: split folio_pte_batch() into folio_pte_batch() and folio_pte_batch_ext() Message-ID: References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-4-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250627115510.3273675-4-david@redhat.com> X-Stat-Signature: sjp1kb6q7gktphapnrj8b9sm4mqiz4rc X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 446A04000C X-Rspam-User: X-HE-Tag: 1751446972-90946 X-HE-Meta: U2FsdGVkX1+EJKhIz5bAyrk8fxxI5daiY/SI60dP2hrYwbgZzuifDCvQXlvl9OvppP7bmm39Nyjl9W19qOpLfYN195LDzZewZQJdegHBBOpjYo4m4YxvqZd2/ugttkBo9sXH07A2uO8WHFL4HSzGDRfWQ0DPMrCwmBR9hmPZ5thfUBgKitDNyzYnP0NG/y2Y4qFXHm7kDdqF37+F4EutrgFCSbSTUDCyQGw1IeIvxt4xxjpRoGmKha4mmnzEn1b8H75Sn7lKc8zzNKJwG9EWX6HS91YcgqECgFtmP6udHwwBt349aQzFenxB44XZzJ2gPKdTG9zHPaMhJ9TCNhgM4gsnOLPcBuBtu0pc+WoORifdB9AuWsOROZrB9y9ohZuIoyAK8MGl1vNgYgp6JRZcWoXgq86NL4PPdWpYf1i/w4WdgTwljl3476hRKe6gbFYKZs2YBCxWE4Zi7owyh0o9oj6Y2x1USttpCZWUyfRnhE42DdjVjhBfL7WWX4LwKhUfLWiKHRb3hnD380ZDq/gOqMShKHIEDjd5J7lrCNSkWyddP3pik41Sjp84Npwqtm+qZMRNsiizAvsw6C3pWZPpeDKdh6/wKK9P2ze5JkzkhxU2boLbCx+cbxFwZe2jRnc9DFt4xlf6uGyrrYnmthX64XAKF3rDKtqH/zaQELcd07vZveAssdLo6LNjEojO6IJlnGNbLLS5gkThkTmlYZnRQvUcwBz0WKvgKx/P1uuZoJcHSPwf+GcX+7qaRo6wTepE+b8VNXMV0eBKB/S+NRfBhMUOIzIxRk+fYUqiJSR5+PAhzcvwDLTkDgoan/Hb9w5oKYKCxRlKJbTekYtHWdE2TdbqA64EPoyxQtrwx/+QmsStA2V4K3tx+L63Ebjhk9TAxENhMZaSbcCzaD2JxH/C1PYfweq40J6cP0HD59J1WQqRNmtWZ6+Ok5zMTUS3QKN2iu2G0b8MczfM4ofNRkx sKYFNvGu 0jGQufYVTSXAQK/XMZU1jY+BjfGP+3PtxR00LizQL3/kghk85P2yTTXlyNudJgyueFd+QQ+uayzMzNBS/w4sBpbpG4MMVo/pkcaekl/YLnJ4BFltHIBnmbVm4yIY9L6ObLZzSarX/DOZcgefpua12rrfs+3/Vl7jYke5kF2IWab6lBXycnOfGJzrftNL212dWZts/to5LYpvJ4BUrlf28UEqvV78rZxjn51e67WQQsvbGgf2BGnB+5BFB6wvNTNs3Us9SotfTlSQkVPq8acSN18zUV6cfFsYJHnAz7TpwFLIFKrcyBErYVI2r5QNkj+u7lgNhka7UqGnLPRKADD/zL/BVtlMBiqN5PxSbUhohdBfftK5AK4iRl+WOWXuNQbgA7M5EAauRsdfFIIrrMlzHmpEzFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 27, 2025 at 01:55:09PM +0200, David Hildenbrand wrote: > Many users (including upcoming ones) don't really need the flags etc, > and can live with a function call. > > So let's provide a basic, non-inlined folio_pte_batch(). > > In zap_present_ptes(), where we care about performance, the compiler > already seem to generate a call to a common inlined folio_pte_batch() > variant, shared with fork() code. So calling the new non-inlined variant > should not make a difference. > > While at it, drop the "addr" parameter that is unused. > > Signed-off-by: David Hildenbrand So, let me see if I get this. Before this, every other user that doesn't use the extra flags (dirty, etc...) will end up with the code, optimized out, inlined within its body? With this change, a single function, folio_pte_batch(), identical to folio_pte_batch_ext but without the runtime checks for those arguments will be created (folio_pte_batch()), and so the users of it won't have it inlined in their body ? -- Oscar Salvador SUSE Labs