From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F79FC83038 for ; Tue, 1 Jul 2025 14:13:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B76F56B0096; Tue, 1 Jul 2025 10:13:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4ED26B009A; Tue, 1 Jul 2025 10:13:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3D5F6B009C; Tue, 1 Jul 2025 10:13:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 92D026B0096 for ; Tue, 1 Jul 2025 10:13:26 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 017761404EB for ; Tue, 1 Jul 2025 14:13:25 +0000 (UTC) X-FDA: 83615888412.05.DE1E3B0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf15.hostedemail.com (Postfix) with ESMTP id B7171A0003 for ; Tue, 1 Jul 2025 14:13:23 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="fj/kboH4"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=vDLANK9x; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="fj/kboH4"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=vDLANK9x; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751379204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=308uoqRlnx7X0lgfvdqcjwUYokULphn4Vw4LodQsR5o=; b=aZrxqlEP35xp4l/9cxKeqFdoioKHdSz5AIKjaE5BMc2ipQgZwtLdeZJ8ZzfOi+vVT6A8FS S9fgIavchP1UH9QCVv+fzU+y6ZfjAE0CoJ80kpKMB0W7FMaqQE3o6+16AxOzvi/s35n5hE YKD+fwDCCcsLTquSDIQTp6lENtCJ7tM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751379204; a=rsa-sha256; cv=none; b=r8LD52Pr3V2dX1qDKed06J8RIUapu6plpDfQ00uuZPW4wvvKL41duXSkBiP6r7ZjO9j4FZ Y/utk0TVKloVuhzYKwrFoKQqEvY9pA6RhcobYFcHlDO6gK2A/nQGCY0dRuT30Z8+X+6H5+ ZzXb0nPEVDv91fS2tqOpzOyzkhQrIQo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="fj/kboH4"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=vDLANK9x; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="fj/kboH4"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=vDLANK9x; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0E7FA21163; Tue, 1 Jul 2025 14:13:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751379202; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=308uoqRlnx7X0lgfvdqcjwUYokULphn4Vw4LodQsR5o=; b=fj/kboH4KQfcB+2NK7stZp2v9j81anBKDvI06A+jEjl8B2StlJ8ZHCzPUsKtDRpUVzDEwm pq0iehHJFvviE1JDIYt6u3ix4Y0rueVprK5SeVpne3jM3BYgbwlpMN9XRqMPwN27nfJSLd 9AaECB5nG7UfXMkbEnLCpPO9emscBL0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751379202; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=308uoqRlnx7X0lgfvdqcjwUYokULphn4Vw4LodQsR5o=; b=vDLANK9xvzv/ISlOpynUA53aZ5dvuOgXrUmkPcPgGr92mOdrZx4z2OfGK4Hm9RxUocM9h9 Il7ODqzzUoIMGIDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751379202; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=308uoqRlnx7X0lgfvdqcjwUYokULphn4Vw4LodQsR5o=; b=fj/kboH4KQfcB+2NK7stZp2v9j81anBKDvI06A+jEjl8B2StlJ8ZHCzPUsKtDRpUVzDEwm pq0iehHJFvviE1JDIYt6u3ix4Y0rueVprK5SeVpne3jM3BYgbwlpMN9XRqMPwN27nfJSLd 9AaECB5nG7UfXMkbEnLCpPO9emscBL0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751379202; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=308uoqRlnx7X0lgfvdqcjwUYokULphn4Vw4LodQsR5o=; b=vDLANK9xvzv/ISlOpynUA53aZ5dvuOgXrUmkPcPgGr92mOdrZx4z2OfGK4Hm9RxUocM9h9 Il7ODqzzUoIMGIDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 958981364B; Tue, 1 Jul 2025 14:13:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8mHnIQHtY2jpCwAAD6G6ig (envelope-from ); Tue, 01 Jul 2025 14:13:21 +0000 Date: Tue, 1 Jul 2025 16:13:11 +0200 From: Oscar Salvador To: Jinjiang Tu Cc: akpm@linux-foundation.org, linmiaohe@huawei.com, david@redhat.com, mhocko@kernel.org, linux-mm@kvack.org, wangkefeng.wang@huawei.com Subject: Re: [PATCH v2 1/2] mm/vmscan: fix hwpoisoned large folio handling in shrink_folio_list Message-ID: References: <20250627125747.3094074-1-tujinjiang@huawei.com> <20250627125747.3094074-2-tujinjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250627125747.3094074-2-tujinjiang@huawei.com> X-Rspamd-Action: no action X-Stat-Signature: sxhfu76h57ogha4e77jj3pgbzqfqryqr X-Rspamd-Queue-Id: B7171A0003 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1751379203-844721 X-HE-Meta: U2FsdGVkX1+6m0MrZFvvHHeTosKP7RDknfOjYW/Bsuc74IHVS4K3lt9NPGXyHwJi7u6FRQeM6RQWr23iqiIyiEiPSfDHFs1iwIUFtsubTtAzO9KFE+/FpKv9lPwis5aHG4YscbexILVpfLmHB4fRZYH7zS+lIvpK8W3ewnEMotVeSIhn2i2lzr3BJJAV2IhHlmomzDtBLKWF2LC/os60yS48dGWYOc1ylOTD8kn8Ay59ioNh91wvCJFPa4QiM2E4mqZi561b/Zvk1mZ89eJqsR2oJUSsXWMr2Zb9MYBkxeUwcXyF/qNp0/zzXbZuuIwbxmsBdo7PMkKIO8Rr0M6VhfzyLCSdkGuNd30GrQhbDUwoKGjpZfPRIOTithLzjD53J81U7+dTOxWfCH+Kpzm74X1+C6UdimICS3+Ju+omtvZucH0AmvQvnUL88eAb7PLFWIamSpLQydytZHmNLNatEI9IHCN+NvQpm5JXEvVrZnhAty3AqdGuca+gSz4iV3pQUQNcGeYME0rXzbaHME63IChU3VI5IeAPs/IFEdpiF3hOdfcnX0AmQtoc2G3G0aDGG+f6iho4CdusuWUQ10H9h/jme2CJnWoE02H5x4cdgPgoLUi9wdI+FxBrPpQJydR/RdEmJk6bZChQKQmpEC5r9TteRDd01uqE7eSKxjO7VxQCp/uaDzYv2vDtYWS9zmF2Qu0MgWTvdfj6sVd2dh6GhFgS1HoGLfq10WpElGTUT+DMlVBnHR5ZBoE3gYtDm++fCu6FVbrywPfnqDJ+siMZ//2EjvrDALFAssAyub1g09wceZ4RiDWOpTV2QcZ227+85g2ePz2EA06vrJNEY8+J1ofsqyk2Zw1D9gIfsq1xClqGrVglbWi3Bs4X8+6sEK+tSf7l4eZrHovD/hI8haJTXQ4V4wBEG5EXJcizhZBueYyaG+y8qr+jJPKAokiEpl7PMyR8OW3Es2tJRT3cTNx rdV8NICF 33yY7yNL8Mx4RKbuiZGQbReBqyKdSOPtSVV/b4X7dBaQCUOt+aNJe5kyxcSkq7ms03JZWiXf2p9R6HHULCVwifrpozAgw2/K7Kv9zojFopVJat0kro3Pf7K1+9NRExCyVPVVlR9RJHpXxqWJaPxNGHCVORakGDSuAvhGhcAM1rNilWIKlNjG2tHGuuleXUjfA2pcnbKGTFIYFNzY+Att5uRdWsjL1/C2Atg5swfHduZzrMwXNCqMmPbH1cVXE1XKJRkXBZbGVjyh1RwRGHfd70UYZqnqBqPLEKtsAn1Cq8mAzzE5yGdZenvMG1DgmN2Mh4QZ5EZZbOf3dtSmr7vwvdW4dfk+xF+OONFxQ9/5c93u6eeemjYN167HbGat2VIX/rCw3dFTRZRAkVKdo7UiUvfjssZarrFrx/vlCtWxHT8H6bJHMPK+EIJOHNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 27, 2025 at 08:57:46PM +0800, Jinjiang Tu wrote: > In shrink_folio_list(), the hwpoisoned folio may be large folio, which > can't be handled by unmap_poisoned_folio(). Uhm, why can't be handled? I think we should spell it out, and maybe even put a comment above unmap_poisoned_folio. > Since UCE is rare in real world, and race with reclaimation is more rare, > just skipping the hwpoisoned large folio is enough. memory_failure() will > handle it if the UCE is triggered again. > > Fixes: 1b0449544c64 ("mm/vmscan: don't try to reclaim hwpoison folio") > Reported-by: syzbot+3b220254df55d8ca8a61@syzkaller.appspotmail.com > Closes: https://lore.kernel.org/all/68412d57.050a0220.2461cf.000e.GAE@google.com/ > Signed-off-by: Jinjiang Tu With the above addressed: Acked-by: Oscar Salvador -- Oscar Salvador SUSE Labs