From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 188CFC83038 for ; Tue, 1 Jul 2025 14:02:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98D916B009A; Tue, 1 Jul 2025 10:02:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93D9C6B009F; Tue, 1 Jul 2025 10:02:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82C8C6B00A8; Tue, 1 Jul 2025 10:02:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6F26A6B009A for ; Tue, 1 Jul 2025 10:02:14 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 046201404E2 for ; Tue, 1 Jul 2025 14:02:13 +0000 (UTC) X-FDA: 83615860188.24.4A65ACA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf15.hostedemail.com (Postfix) with ESMTP id B9E31A0004 for ; Tue, 1 Jul 2025 14:02:11 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=t8fqm0v+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TD4tex0L; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UIHsdcBd; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NPkXE81P; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751378532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+mw1e7Rg2jy9fk1epcQyE23D22I29lxpvK2sxJYsy8g=; b=JEI24CG/S97Wx1FkCVxnx8Pp8EJShB+F4XdRjrLXwY7B0LIToQpcphhdT2qu82sH1Yprki 0eSbNAt7r2pNGFjHaGCFobpxUyZ5b8d7U8Re92AfZ8aSgnJZyEuRq/Ypj94tRjG6APgnIw A6PjyqJzxxkxajf4n6+jw/cjWv9HvJM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751378532; a=rsa-sha256; cv=none; b=tBoElTRA8UjFTIPTl1oeMIO/D+Em89toxwNBmX5OXAd3o65VSrMJfu6wcJZjjq/PB7Qpuo bzolK852wBXywA7eu3hvz/hh3EJJOCqJk5FAGtuAx2P+i6GicNIwmoWCWVSIsSjOtYohzf 8pXwKfxvMqOGiGmUAKk+4nwLjjV+Pno= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=t8fqm0v+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TD4tex0L; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UIHsdcBd; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NPkXE81P; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DE30A1F393; Tue, 1 Jul 2025 14:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751378530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+mw1e7Rg2jy9fk1epcQyE23D22I29lxpvK2sxJYsy8g=; b=t8fqm0v+cONoqSpGAXOooSomqyWmv+aTRNnBcBTNKRUYp12Z7+QxR5WW+N6+6AyOq8VYMX jLR36uz6VVETdm5pm+1gJY15dVwkAhG+LEugvKWRYOEzBOniqLH+E8eiOA6TAWCW/olpqC dDf54Rgg98/Bx75dBL2YFhHaOeg+1tY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751378530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+mw1e7Rg2jy9fk1epcQyE23D22I29lxpvK2sxJYsy8g=; b=TD4tex0LAQEA7ATDDVjzO33js6i/Uf7bBeIzTvsWT6hi6AulKgdFl5yNvI9coDaoM7gro+ rl2iS+Da7ajIVRAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751378529; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+mw1e7Rg2jy9fk1epcQyE23D22I29lxpvK2sxJYsy8g=; b=UIHsdcBdL14XNbunZFYPbfvX1HS9dZBWw2eLs+eY8489HWueoDV/yj+ZFNpGhl8lSBuF20 s6HoTungt+lGzUnztH3WRiXInjPeFrXE1DIZAFkbxtoDrfa0o0B6avoJHNFDNcROc9RDuZ jqwsGoUWjesd4xp3j98TRjWu9hXhXEI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751378529; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+mw1e7Rg2jy9fk1epcQyE23D22I29lxpvK2sxJYsy8g=; b=NPkXE81PyBahBB6+Bum0Ax9T0E+gKFEaTdT6B8SKs4vu6u7mrjlmGx9S/VMmPmaLMU85S+ hF3vOoY0x68Q4bCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A02601364B; Tue, 1 Jul 2025 14:02:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VFNeJGHqY2g6CAAAD6G6ig (envelope-from ); Tue, 01 Jul 2025 14:02:09 +0000 Date: Tue, 1 Jul 2025 16:02:08 +0200 From: Oscar Salvador To: Hannes Reinecke Cc: David Hildenbrand , linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm/memory_hotplug: activate node before adding new memory blocks Message-ID: References: <20250701114155.16452-1-hare@kernel.org> <20250701114155.16452-3-hare@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250701114155.16452-3-hare@kernel.org> X-Stat-Signature: xuun699rcwjiohngrqt7edwaqj784nq6 X-Rspamd-Queue-Id: B9E31A0004 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1751378531-954549 X-HE-Meta: U2FsdGVkX1884xdxn6aoWS4CpizLHga3aCRLL03vhxmAed9MV/wuouSlCulBxkkmkwxpLny9UEy621TRqgI8+8XiLdx3ngqPZ8juLAyUYw6NoRMgALAr4QSU3/MsAVAZlYF8f1cVSMNU+8wjBW6T06qmj0at160V7s2v87XxrQ+iqsdCETmftmcENoAUFetBr7Z9Qjev3nEyfW5TXiaIJY3gGt3uNDJqSQsuKrsCNVvj8AngOcHuQaIZniFi8Gn2ChuBZ6+gfO4BEY8YvCY7fQlz3vlDguXP+4I8J12PW+2a8N9sxLgixxVk8JgwYs9QNgaQgNH9YPX+W2739jbc5I3+QHfRenEs1C982ce/c5u+CZfYhoDiEDwLDidDtHQLz6NXFHf63XAaqeqfcOFDDbONfm9spxeabj4r0Rp+W1VRdaVmtGbO4WeeAcFmyMOPYhnVJ66NnBDd/C04ATCbqak2pAbr3/UeqnNmDIw0G/rB74jI1HB7xsJuZyNNNebokw3VsfGGjqeEBYA/x6ZydhR60G+Fw2aOGM1kCIlpIDAFqQ+y1YMkq/D5/qn4a3UH5sVhHfImBpUT/IiLZ+785Rm0qA1rLvrj6GO0dvqMz1lbNfRIhyZpgRjcuvm54Yfd+eYV/EYF+s3482QnzI9JOHJCp4bfnp/Vx/bij/16zgIu6LzErV+4vVMK5MVukeFRRgUKpjwFoJyt9bhbDjD5yfY/ActYl4ahew+qosNGqCXVHcqvM6MTYvRovj/XM45blmU882aI78l6zfwXOAX+vFzbppnuYnPycc9H2RujZAxa2iiPkxYdaySHPWVQcuvH9L0uU5yuOB1QFPj4kw3rVJYz5pts3rV7umNd11RUZj+dKPabtPN/Oor93fdMIuVQD1c4qR7qoucbOqLb2zjrClc5lSxF05bAwGhLnUFrvAo1T6wMrIvHGvqrwwNT6wm7lNm9O1Jbbsq17nIPLZH t5yjDL8+ wsE0uwiiHsudK0zRIoxZ6IPtoTm/uTOP1a9RG/iUkLqQDjw5MMGpzUWy4fSk/YySS4NR0+nvKJgZH3I6OJWWh7ADAviuBPx7vqHo7foI9MHzbkDKwgFZqAr9sVJRcG6w9rN1z2Kt3vDXl3tbhYb4U0FlijnAeX3LFy+JrTF/B688/damU5G/MKOt3yYlL58On47rT5l+66huDbRlhYFNdfQamXT0SPUJcqNRAhnlk+HReqtY1YnkVIomb8+gAi4SOSuPdDTZND+kGSvKyTmaEDVX8ImInMu+a4/YHKHUWAMn7OvVRinpYixiC6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 01, 2025 at 01:41:54PM +0200, Hannes Reinecke wrote: > @@ -1540,8 +1540,16 @@ int add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) > > ret = __try_online_node(nid, false); > if (ret < 0) > - goto error; > - new_node = ret; > + goto error_memblock_remove; > + if (ret) { > + node_set_online(nid); > + ret = __register_one_node(nid); > + if (WARN_ON(ret)) { > + node_set_offline(nid); > + goto error_memblock_remove; > + } > + new_node = true; > + } Do we have any constraints wrt. having the node onlined before calling in __register_one_node() ? This is a sensitive path (convulated :-) heh), but unless I'm missing anything, it should be ok to call node_set_online after, right? If so, the above could be simplified. -- Oscar Salvador SUSE Labs