From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A503EC8302B for ; Mon, 30 Jun 2025 15:23:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 340D56B00D2; Mon, 30 Jun 2025 11:23:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F03A6B00D3; Mon, 30 Jun 2025 11:23:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B9406B00D4; Mon, 30 Jun 2025 11:23:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 082026B00D2 for ; Mon, 30 Jun 2025 11:23:59 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D0520C05C8 for ; Mon, 30 Jun 2025 15:23:58 +0000 (UTC) X-FDA: 83612437356.05.B9EED2A Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf02.hostedemail.com (Postfix) with ESMTP id 8079D8000F for ; Mon, 30 Jun 2025 15:23:56 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Ab5IZRmw; spf=pass (imf02.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751297036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6FceECBbuO6Z4x2Rp39hcL1hfD2xOI56xCXiWcKK9WA=; b=Z3yLJSRDo/NDZSgdZu1WcpSX8XLVfMBIeAEQww97/buBoPQCaWLUa4abKw1P5aFVBecDMS RGjy4vJ+Dodr76ewgtyEFmJSuSzza61NVmP/3s3u+cBJhMQ4GGvK0NYSSRr5qYxrLkrP2b XS5SoHN1E/0M0YGoouC+KxDZWE0Iv2k= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Ab5IZRmw; spf=pass (imf02.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751297036; a=rsa-sha256; cv=none; b=adC0tEoBDtuiLyakmD9Kyo9ZAIT1xYXEN2yD2UfYSC9hm4T4Zz298mt1KI8AEKQ8MVD0PQ zE6kiKF0b7KLfA1Ktawdlc+wEEpZA+t2JrhuW0UtmVLI8a8kTk7jQ/SDL7xzeQPAA2M3XO 8dcZftFmbq9wj8b8b+ZZLtiARugQD2c= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55U8V2Ia000758; Mon, 30 Jun 2025 15:23:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=6FceECBbuO6Z4x2Rp39hcL1hfD2xOI 56xCXiWcKK9WA=; b=Ab5IZRmwLvmMk3AiZ89wAAQHApO3HRzY/FKi33YccoEVV8 62jDs8lp3GuMhnbp5PvwJeVzIOTdSyIpma+gS0Ugks/c8ATcOXl8/K0Lujz+g0Ad dM1SgFXrBuUMrFqGRGP0yd+oVE8+JDooGZJbbiLjhPut5GCRrRHFIebtiR9AW6Jx +jqh3I+r86Dc9UH2RwXLLF7G0y4EGIwXIEG+8EQguDuTyxyDmyjszA0gk24KkYF+ WMQi8/9cdZV76CjE0Ytj99DnJbIc8orRNj1BD/lhbit4VZ05IUXEHPr+1f9T4Iaf PZjXXX61nBxSuq0zpSNKKHaNRcKWSqGn9BNz7ZPg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j5tt2hv1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jun 2025 15:23:21 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 55UFKkJT001633; Mon, 30 Jun 2025 15:23:20 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j5tt2hut-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jun 2025 15:23:20 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55UF6Jrx006928; Mon, 30 Jun 2025 15:23:19 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 47jvxm687n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jun 2025 15:23:19 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55UFNFi141091496 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Jun 2025 15:23:15 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9E3012004E; Mon, 30 Jun 2025 15:23:15 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4EF2520043; Mon, 30 Jun 2025 15:23:14 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 30 Jun 2025 15:23:14 +0000 (GMT) Date: Mon, 30 Jun 2025 17:23:12 +0200 From: Alexander Gordeev To: Heiko Carstens Cc: Vasily Gorbik , Sabyrzhan Tasbolatov , ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, borntraeger@linux.ibm.com, svens@linux.ibm.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, akpm@linux-foundation.org, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, morbo@google.com, justinstitt@google.com, arnd@arndb.de, rppt@kernel.org, geert@linux-m68k.org, mcgrof@kernel.org, guoweikang.kernel@gmail.com, tiwei.btw@antgroup.com, kevin.brodsky@arm.com, benjamin.berg@intel.com, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-mm@kvack.org, llvm@lists.linux.dev Subject: Re: [PATCH v2 01/11] kasan: unify static kasan_flag_enabled across modes Message-ID: References: <20250626153147.145312-1-snovitoll@gmail.com> <20250626153147.145312-2-snovitoll@gmail.com> <20250630143934.15284Caf-hca@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250630143934.15284Caf-hca@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: z4_YQR3yiIx6CG78lyz9FOWfFKu_sVzX X-Authority-Analysis: v=2.4 cv=UtNjN/wB c=1 sm=1 tr=0 ts=6862abe9 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=DoNX2vE5F4BLjyZpJB8A:9 a=CjuIK1q_8ugA:10 X-Proofpoint-ORIG-GUID: tSMJYZyFhxN0ELYUCpeHLTTc07NMO3uI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjMwMDEyNiBTYWx0ZWRfX8gNfFxZTXHKZ dZ80+g69PboCFvZ7mBnOUfK0bCwcv0dSYRqbRWUQ19q/nN1wI6TuhuYqwHy593nbcEA7jlbJwZD 77dnrz9oUStk3kQiVeqmPXKGtKxsdBJ2rMDUHOTQC4GBaAbPZwrp6WqFZf9dFe5sx5xhOKbWCy/ NwZq+dxl31GEeh7qeRCnnHi4Qxd16CxChbxAbT7vyTZGkfYmt2gzAZsQ9WVivWWtyFljm9LUYUu /A210g10AJ2Cdlfpn7GA0E0mvRxrp+tSiKfaUfSUuPHgdjtBlrSqzSrHD/D2Xsqd7rUwWfMIZjW fInaitcISkEwByhpED+nxsY2XtLUIBynWgUbXHjHc6nBJWSN0rrJzyr4x5ElJH4AxMuQUcAIOs7 1rhZuhkKthJv/kG2udE/dGMrx+Msfn4q3zQeVCOUgtPKntnHQoMJd3LZcLGKdzNOHbuQfZDm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-30_04,2025-06-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 phishscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 adultscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 impostorscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506300126 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8079D8000F X-Stat-Signature: u17xnptzkwkdcuq95kshrtoez8dn1f51 X-Rspam-User: X-HE-Tag: 1751297036-886948 X-HE-Meta: U2FsdGVkX19z9FE75spt5m0ZwP0vTGeetjtCK/S7djVgj6zzhoUYJX9HJ0xfL+wEp1yhZitYoFKZPTeVDeczMnKXlfLSZokknTQo0MFzeCIcvknCGekHS6kXlA2O8fjLv/IzFHVg06Spl8GyBqUuAwRjys5CotPdGKE9ueRGyZK9By9WiG6aDs22ny/k7FEMsDTRZupP04ocZ0I0m8dc6Oo8GKvOP1jTCYuyefmxcnQSy/7KymMNG1vxieReD2F+URDE6bBcQWKHzKnH3KNKFxjDIyhbEpq2jLJFPgMdi8Mo6Dr5V8ppuFgSrw6hWmUCkIVQr/ANqIRRtmMuEw6TpG8L6yM8s2V+bZdIlqgqVwrirevv2OSr02c14bpGl53xb8gVvfaDShJjAdA3C7zrttXCmjgnKwD5nX+B4MnDihuavGO2Qa23usNXph9xnaCR08tEWxt37vr6CmZF80RN41m2b16aE4Pzhja7z8sXe2i0l+ZwXSLd03ngqUscCDaz+D4Xdvad+r6VrbfYU1XHjei8voAjQEPmvj8+Skblhn45gCrseP5V87WBUQvgk8ZGB3kgXa3e/WudbhMUQAwajWBDo69Ghb/EyOyFZaF2Cf8ovpsM1RzkAccXGU/omELymzZAjpcG6f84rNo1oBRy+RLStsWIktljPtStqc4m+qpXVgMQZi+qFrkLIwoOFYQcCk1xt7Q/80fB5CzfSCZxTpg9A6cR9mU7uwBz1dpsMKben/6MnwpMEjyBDZjeFAmWAqzJRJZItGWBRqYJUX0ybpJ8EI8VjCmw+AePFjW//CNieLE6TheJZ/2RlC0X7wXgQ9R/5xJPH/qNociL54/6TgMGZBI9Gz1yTENg+dINYR/AqmAUXrtPFWVlgRA+3b7ZCivtEL6CaNUip5fvMqCvZfR7QtgrRmCpfHYtyQtsJgB25qNuA88us/3iwgFiIvMmcc7XjSfUbdPya9dWZi7 /BtolS3B WhQaIu+uhDOvl2PXF6OKnngVwGzCiVrkkNfTw5sPACsv+cWOREGIR2der+QhDswh7ssHaWx76zeVAU7wDxdoCLMz/NkyApUPCiBYaOotAVpPXkBEasOKbi+I/E2lPpymRl1IbMg2BgxsHhz+dmhYbPAS8hXyR7kwmuu/4nPfXq8zF8MxPzrE+ignZXfpDS7reSP37x0pgzDtU38B/ZPXxY6jPXmHidaWOB8CbapPbKoOEU+Za7iEmmb+CM7WnUALJErAEFm0Br6rr5gxbcAHfE1asaAWucs5iKs5D/6izlA6+f4uapOsgbdCU15lhvGTtEr9J+o4VMuTWyd/uxQo5ApnfizmiuvLQObwf9bDKIs4ixl3+m7jONTd7Wij+LPZIBj6XvIU8PS4gbd8eTEcqKdCNAxXR5whk6OKki7XLqF4Mx43Bs4WP+9YayUBawAyennw8d3KPAOeTasOYQyqoUtNLTEQONyEbF1nA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 30, 2025 at 04:39:34PM +0200, Heiko Carstens wrote: > > > +/* > > > + * Initialize Generic KASAN and enable runtime checks. > > > + * This should be called from arch kasan_init() once shadow memory is ready. > > > + */ > > > +void __init kasan_init_generic(void) > > > +{ > > > + static_branch_enable(&kasan_flag_enabled); > > > > s390 crashes at this line, when the whole series is applied. > > > > FWIW, it looks like kasan is called while its state is not yet finalized. > > E.g. whether calling __asan_report_store4_noabort() before kasan_init_generic() > > is expected? > > It crashes because with this conversion a call to static_branch_enable() is > introduced. This one get's called way before jump_label_init() init has been > called. Therefore the STATIC_KEY_CHECK_USE() in static_key_enable_cpuslocked() > triggers. > > This again tries to emit a warning. Due to lack of console support that early > the kernel crashes. > > One possible solution would be to move the kasan init function to > arch/s390/kernel/setup.c, after jump_label_init() has been called. > If we want this, is a different question. > > It seems to work, so I see no reason for not doing that. IIRC, we wanted to have kasan coverage as early as possible. Delaying it past jump_label_init() leaves out pretty big chunk of code? > Vasily, since you did nearly all of the KASAN work for s390, do you have any > opinion about this?