From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02F5EC8302D for ; Mon, 30 Jun 2025 10:30:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95ECA6B00A7; Mon, 30 Jun 2025 06:30:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9366E6B00A9; Mon, 30 Jun 2025 06:30:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 873276B00AA; Mon, 30 Jun 2025 06:30:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 768026B00A7 for ; Mon, 30 Jun 2025 06:30:59 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4F05E1D7017 for ; Mon, 30 Jun 2025 10:30:59 +0000 (UTC) X-FDA: 83611699038.05.EEC3E12 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf08.hostedemail.com (Postfix) with ESMTP id 61CFC160004 for ; Mon, 30 Jun 2025 10:30:57 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kQlxEzMy; spf=pass (imf08.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751279457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8e/7v2ltNn1nX9ioUgVxorlkzFe2GpNMHMiKKK8K6ls=; b=L0N6JRKVloK85yafcbGx9T8bq0+mHLn7mV7BAZF6lZZGWVdVWT2dTDwKw8ZciGD8P2VE9C Ea/H+IBVrQSlTRyODdnYbte37FqB6UpL5ZS2sGlYCU9xffm5ithp811IqMdGkLdzpE60CG YNA2NEahDtWeY2y1MIbGUaSg4ihaqZc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kQlxEzMy; spf=pass (imf08.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751279457; a=rsa-sha256; cv=none; b=oulWOjEAvqkrSfvPlODshNHNZ9nOaHFDEPSiQWBCf+YpNLBDrfAfR7rTBJdsfReIbBdblD X2lEs14hl1mUgsvSC1U0soQtvVpT59WGU7L8apWzj9pO+IXsMjqKhdRZpmL0w9puncdEmM mC6Wbohh6x4hlEzQKZFG/ErGFeBUgGk= Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-553b544e7b4so1944627e87.3 for ; Mon, 30 Jun 2025 03:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751279455; x=1751884255; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=8e/7v2ltNn1nX9ioUgVxorlkzFe2GpNMHMiKKK8K6ls=; b=kQlxEzMyb6/L/Vuzdnm2IoRFi2L4qNfox7ADIN8WavQd+shiNkx7cKDYz/fCdKU9P7 MSXFDTwdehXnh6WB5tlfbPK4Ctc7GsRdu223oidA38AI6Je2gKBigZ30RVXdiewsSrfF 4I16JULgBEgREBOw10X+NxzuqIZe3oqtrAfoYxtO1svEV9HL6eLeo2Wv+YVx5m/Zo6OF vrcHBV2ZWaJswKbw3RDfA6eXT8sYL+K8l8Q7Uj0y2Q8VHFylx7k/24X5S4GmqYZJylNv r5IvjZ6H/2XPbog+wOiSRIzReTo3151ou85+Mj+2r54RtKnvxRnfBJSI7b9oYLdMDEhr CPjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751279455; x=1751884255; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8e/7v2ltNn1nX9ioUgVxorlkzFe2GpNMHMiKKK8K6ls=; b=Lbx/tQeIKxoClFx75juJyQfuB+EQW6bfqqW6+cgNBfht5R+3O6QDzI7HudwnbpdMYq 4LeJCWYM1bryTm3E1nV5YmohXRf6KHmb+mt/5rqeCjnSVd46n7rLPGup4Ui0FuL/UAmH wt3us7iIlrn1/P8SrwiQj35uLYrN9/Cd+hiJctK1P21fXC4kudvWVcq78B0aMsFsqZko UriGdGbwraoT8xH8wBjRwjBGsVK5+ltgy/DqCYDO1Zd84T0+0FYa7foGlcFVaHIWKajx klCnovyWm9Z6zaBrfVlcH7eqqd+xQl79uyRxwbcB4EMq02A4J0RMTsSHx7tySHDhubPt y9Nw== X-Gm-Message-State: AOJu0YxS9LYRQxY/yfgOyFePeF2G+l04yrtz6Mm0fG3sj8rWCZSqaMh3 lLGuvJngXdFz6nwy6A1DfUtU48Qj8bV34bOwd6uMZ70adP+GaDJm+Ggx X-Gm-Gg: ASbGncsJhhENpKQ50plF5C7bPBrDCFqFzNf+ti8TXam4mOCBtiBMBCKe2x0bzY2A4yl wLi1oHW43TuW8ScsWRX2aO7h1G1RcGiDAhEQfhWKCVdsiow2bQC0YZZOOQXTLOOkzn5pepaTRso XYSpALoNIrKWIIu//c17z14DdY5yNAqpRX673fwm+HhmN+Hx0QZBSrEhPM7IQ2HfhziZuKuW1Ua /gzSOmGC6D3Wt3/lgPaG7K51Af7TUtTyGuxxCHkVNQ6qw6tCZpFBNclQZMdmg8VHetbr4T9qnI0 k3N2M39kMAgV8PMYtDClLvALUw2rlD6kC8n+NeyQF4tfx64YMXQPuhYYbbIRKE62FVeGaapxjCG 03dTe1ErhPQM= X-Google-Smtp-Source: AGHT+IEF2nOl072KkJX5VOycpUDoH66uDeT/lt1cf4dthiOO6DxJCwj1jJ46PgB8pAi9UlOEqIa06g== X-Received: by 2002:a05:6512:318f:b0:553:510d:f46b with SMTP id 2adb3069b0e04-5550b8b0549mr4515221e87.32.1751279455093; Mon, 30 Jun 2025 03:30:55 -0700 (PDT) Received: from pc636 (host-95-203-1-180.mobileonline.telia.com. [95.203.1.180]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5550b24d130sm1397220e87.54.2025.06.30.03.30.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 03:30:54 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 30 Jun 2025 12:30:52 +0200 To: Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Danilo Krummrich , Alice Ryhl , rust-for-linux@vger.kernel.org Subject: Re: [PATCH v8 1/4] mm/vmalloc: allow to set node and align in vrealloc Message-ID: References: <20250628102315.2542656-1-vitaly.wool@konsulko.se> <20250628102537.2542789-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250628102537.2542789-1-vitaly.wool@konsulko.se> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 61CFC160004 X-Stat-Signature: nb5k3xumww4c34oq54po5t46kge9rzre X-Rspam-User: X-HE-Tag: 1751279457-32240 X-HE-Meta: U2FsdGVkX1/Kh/do/UtZd/iXyKmUe+CwIjtxcyplKC6cYYSu/Ys4a3DiGef6H9CRCf6wCDwAOvnkODJogpy9YQAnJQL++3aep/z/kDkWxQ2AdmcW6Wu3HHrZUYqZQIbYFWRdXMcV3ebsfffXhbpb7Q3ZbeRAlyPETfJHqH/qwUXhJBbyb53MEez/apGvH/FC6q5mjwQNXeWRIETunIjDvXRxBrmKooa5lC/EQ9OX6jtC6B0qTxgHeGavL9PlZBx9ZOQD7193P3mWtvQOfx46DUoGd7pAI9s1vnzWoNXDP2XgGoJNgTwy1MmjPGzNhvBrSfpTIrbZkhrzKV+CWYXmxVJT9WRXbVXp4veTT5WdHbFP1BnhspTb46XU4mVjVpL6AY/dOTQhyHixv+QzuvTGnOjiJeF2eii8s0+RB7SoH6Ju9giT7vuJScHY//Jo/m07/nqbfUZ9aHVBZw8mR4VW0g69KDeMAXkaMcsDAZm1wtTcuA8JmRwrErZ0AwbxAGCgNIfa7XR/ALoVIT4jSLCDoqGHLt9vere7DuuWxJvfs5RP59nl0+Nq1Ltsl2BKhYeqVsr8gO1h2ZpuGdOG9J8ez2KTsdDWQ2ONANpokkc8NSUVHSLGA7pG3luZh52Bfu+vqVgzb5ifb1/7IRV2UtXuFT+lqYf2Zky/E2hoBIw06PbiCdv7at6o+8Y5tqOSE7deXDxJZipcoWqDLOdpAY8sqJk1TiYCEl7Q0ql/wWoCu1chEtq64GU+UwFnH6ntwy6/C/ADUeHiFpHKEgidiulCZR5YvngqY2fw/ohL2Qtqej5NZagDXzMPdmuXHWn0Ml/eaNkPDX+EpCeOLHX4WG+/PzEhGFJU1eW1QhmW3fUyu2VqM7FFkhff4+h282L34kaNNVwT2ejwASnzGjJ0znT86EQsVTXIN69e6I1zywET8qsa6PLWEz2E3qNR4x1PE9JP6R21Ax6XO0ok6WvARZB BO1gXbMx nNg+20fumw1SVcva7ac2k3XLzJT5XDEncpuHRQZFBvvbpYM015+ui0GlrN42vD2Ahj8Bjd6+T6lnswm5rHhpGYflorkb5+X7M3PYzf96pMWlMnYAdEtVY45PnCcq9+azBG3nrRIHxtmuKALU8iQV9PGUQmMKZg5jQJRVmcx2UQB5OcvMOzGdfbOH8D21tj5M2phfjFgi4sJptINEnLZ9scDA3kibhU4/2aUXLt9OYz8QkBT+lL4Xep/v0peiXxBj6uvmTSHCyzN1fzkn0oSJlw47Ae1XgwqxyP7UCAfJ02MUKP6Owm3TsRL8oyBIGdjTjBWAMevuljyKyJen3nQEPhI6VIxmaFxvTeIjeggi71NBpfDG2HQKyKPLYMDHEdYvXTPQ2hKSIPM9HZ12dI6eHylv9BT9cF1RX4u6+BdoRlY635G7JLW2rhGCALHxwj2Kxp5XqA+emK7K1K/+DfquC5vUFVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 28, 2025 at 12:25:37PM +0200, Vitaly Wool wrote: > Reimplement vrealloc() to be able to set node and alignment should > a user need to do so. Rename the function to vrealloc_node_align() > to better match what it actually does now and introduce macros for > vrealloc() and friends for backward compatibility. > > With that change we also provide the ability for the Rust part of > the kernel to set node and aligmnent in its allocations. > > Signed-off-by: Vitaly Wool > --- > include/linux/vmalloc.h | 12 +++++++++--- > mm/vmalloc.c | 20 ++++++++++++++++---- > 2 files changed, 25 insertions(+), 7 deletions(-) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index fdc9aeb74a44..68791f7cb3ba 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -197,9 +197,15 @@ extern void *__vcalloc_noprof(size_t n, size_t size, gfp_t flags) __alloc_size(1 > extern void *vcalloc_noprof(size_t n, size_t size) __alloc_size(1, 2); > #define vcalloc(...) alloc_hooks(vcalloc_noprof(__VA_ARGS__)) > > -void * __must_check vrealloc_noprof(const void *p, size_t size, gfp_t flags) > - __realloc_size(2); > -#define vrealloc(...) alloc_hooks(vrealloc_noprof(__VA_ARGS__)) > +void *__must_check vrealloc_node_align_noprof(const void *p, size_t size, > + unsigned long align, gfp_t flags, int nid) __realloc_size(2); > +#define vrealloc_node_noprof(_p, _s, _f, _nid) \ > + vrealloc_node_align_noprof(_p, _s, 1, _f, _nid) > +#define vrealloc_noprof(_p, _s, _f) \ > + vrealloc_node_align_noprof(_p, _s, 1, _f, NUMA_NO_NODE) > +#define vrealloc_node_align(...) alloc_hooks(vrealloc_node_align_noprof(__VA_ARGS__)) > +#define vrealloc_node(...) alloc_hooks(vrealloc_node_noprof(__VA_ARGS__)) > +#define vrealloc(...) alloc_hooks(vrealloc_noprof(__VA_ARGS__)) > > extern void vfree(const void *addr); > extern void vfree_atomic(const void *addr); > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 6dbcdceecae1..d633ac0ff977 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4089,12 +4089,15 @@ void *vzalloc_node_noprof(unsigned long size, int node) > EXPORT_SYMBOL(vzalloc_node_noprof); > > /** > - * vrealloc - reallocate virtually contiguous memory; contents remain unchanged > + * vrealloc_node_align_noprof - reallocate virtually contiguous memory; contents > + * remain unchanged > * @p: object to reallocate memory for > * @size: the size to reallocate > + * @align: requested alignment > * @flags: the flags for the page level allocator > + * @nid: node id > * > - * If @p is %NULL, vrealloc() behaves exactly like vmalloc(). If @size is 0 and > + * If @p is %NULL, vrealloc_XXX() behaves exactly like vmalloc(). If @size is 0 and > * @p is not a %NULL pointer, the object pointed to is freed. > * > * If __GFP_ZERO logic is requested, callers must ensure that, starting with the > @@ -4111,7 +4114,8 @@ EXPORT_SYMBOL(vzalloc_node_noprof); > * Return: pointer to the allocated memory; %NULL if @size is zero or in case of > * failure > */ > -void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > +void *vrealloc_node_align_noprof(const void *p, size_t size, unsigned long align, > + gfp_t flags, int nid) > { > struct vm_struct *vm = NULL; > size_t alloced_size = 0; > @@ -4135,6 +4139,13 @@ void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > if (WARN(alloced_size < old_size, > "vrealloc() has mismatched area vs requested sizes (%p)\n", p)) > return NULL; > + if (WARN(nid != NUMA_NO_NODE && nid != page_to_nid(vmalloc_to_page(p)), > + "vrealloc() has mismatched nids\n")) > + return NULL; > + if (WARN((uintptr_t)p & (align - 1), > + "will not reallocate with a bigger alignment (0x%lx)\n", > + align)) > + return NULL; > IMO, IS_ALIGNED() should be used instead. We have already a macro for this purpose, i.e. the idea is just to check that "p" is aligned with "align" request. Can you replace the (uintptr_t) casting to (ulong) or (unsigned long) this is how we mostly cast in vmalloc code? WARN() probably is worth to replace. Use WARN_ON_ONCE() to prevent flooding. -- Uladzislau Rezki