From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76FF0C7EE39 for ; Sun, 29 Jun 2025 08:59:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 182096B0089; Sun, 29 Jun 2025 04:59:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1328E6B0093; Sun, 29 Jun 2025 04:59:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3C356B0095; Sun, 29 Jun 2025 04:59:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D9AC36B0089 for ; Sun, 29 Jun 2025 04:59:18 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7DFBF160718 for ; Sun, 29 Jun 2025 08:59:18 +0000 (UTC) X-FDA: 83607839196.30.66ABA4B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id BC32A1C0002 for ; Sun, 29 Jun 2025 08:59:16 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cfaUtDhy; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751187556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nSmWELiBr/bom45ioREs4JU1Lhf4cA/dgleUJioIVWk=; b=wb5jLkEcHb+wfr4KAwbag+Lo3xks/BfAdxlzmiyYzrVp1WbItJslrhtCE4KhDqixRBtE6X 4ZYS7/qegzHL+p31KKgKmLHaD2pM3DXH9jyLAiXC1FyjyilSel6obq+9b6s2j8JjbDNxnk Dq6VNRzhHi6PEIR87qyTWFHP39HXTDU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cfaUtDhy; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751187556; a=rsa-sha256; cv=none; b=F/Yxg2hlnC1K20U/Lb3WFArdAojr3EDvOzERFT5n03jk0XIj/dGJ249z7mhztVU6PydVVU yiKMqDobVIDLeY0X4vzfuLVUYJ3tsgAQIeezWk7Yfv34UtmHnU5rYNyoXNXoy+a4WX/dQQ 2BGXspoKTjJWOYaKjy0Il1GIkRq/Ox8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 30E7D5C5550; Sun, 29 Jun 2025 08:59:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADCDFC4CEEB; Sun, 29 Jun 2025 08:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751187553; bh=2eYiVKln48kRhT50NpUvXobTX6IcKbD3C0QWhmyAYwY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cfaUtDhyvfvnp50pRz46yIi3ba4BZSPc6hmAyDdXemF9gc0bPQtaX/v6kuA83H2E5 CUTuAyxx27Y81bqttTz8OV3v6wQj/1vD9r4l4O271BGY3Az/xVEJgiM9MqvnSbo+Jc GqC22HJbJRu3grjxznxafCImBVekBNJdadaInTSfoBNsImnXivPq0uTergxHwk4GA0 C7E72su7krOeO8VZNG4cgpe+ajCtXrllB3qV6d+PGmbkbQywWT2CJbcTjGTHput30M V0vudPZoV6rxMvUDaOmbBP0W6oAzbgT9iWBYzUt5ZZnGP44wBbiuHLT9Mr61rruE24 V/UxY30SfbQAw== Date: Sun, 29 Jun 2025 11:59:04 +0300 From: Mike Rapoport To: Lorenzo Stoakes Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo Subject: Re: [PATCH v1 1/4] mm: convert FPB_IGNORE_* into FPB_HONOR_* Message-ID: References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-2-david@redhat.com> <6e3df002-fd04-4acf-a670-d36d5478921a@lucifer.local> <9427d552-b94d-4b27-a4e3-ed958c153b48@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9427d552-b94d-4b27-a4e3-ed958c153b48@lucifer.local> X-Stat-Signature: ueam5s9x1je8ppt675tewzn3joiudneq X-Rspamd-Queue-Id: BC32A1C0002 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751187556-810078 X-HE-Meta: U2FsdGVkX18v4u+HhmKTf7h0RPCwx+m54RxmGguknFvEv77dOsKQDn2SF/mlux6gI9P523yQD4ptmGX5l4QO/zU1NNh9QoLqgq4StZ0OdR2Bodh2zSROsudttqyvf88Mc3hYr8Al/Uk9MMAv4iJUee0nD3JvKhc8njPAamdd3gl1pdYIMHW1DrExC7fCexMTBTHpK85dDPp2RphJ34w25I1/WS4xXV52HVshOnlWmaqRjMDZHD+8Kf4+0dbH1Njpotpy5I/5L2URKvIOwr6QLX55GfCLJscpvu74BLeOx/RS9fpeuGYYi10upPvajgP0QdhNTjSkqpJOB6Y00AVn/XRcRJjGbomVq+IEk1MUhdRlqt8j+RNs927WZq6zDcUy3o8D3tvGJM1UOn+ISuVEpzd/OPvdvbd7lU4i3uyaySmslJNoLodCnXS+tCBBRmCcq+p4gchtyBbifTTz5EpbSC8v8Z606iIHmZ1HfUc22mn4qgTvfzwOwppPO5I00/KyPVbMzIQFqYxLBTLtbp/s24klazaT4gTJ3g08uPYkdAzEZl4nDDUxAi2A6dk4Xrhe1fz2SoNWGtKoaEA9gDQ1sGMuzm94M4ZgHZKL89n3L1FqltY1EoJ7EBkhhCpWd78ktJRN6wlL7gMLs5CCmkosPTePtrdJGnKaoicSzm4efTraFJbMqUI3IVnuX9bg/EqFuwipXnM1TNih5Bm7W7BJWF0fqxdMeHJ6detfhqcDZBSFC4Qe5u70EJIkZFHLr0Oq8U3yd1VKH0AlQ3Nj58BjPY8SUchEpmskkPQd3gZkMEojBwGO06BdO/TClpc+ori4ju/CRIk/GH5PE1XlbOdh1vLamUb20FvIBtdiLC4irAuB4hrNmrtH1+pr/fNmUvmoimSpmyU4rvy7Zwoj0ViyNUEHCrk5KbuRRP1Q1J4arOD66+oQMBKEoQbOfGAE1/HXi/tRvvHKDY3me3NCnV1 puKM4XJi l19tn6d1U9MDrht7rBgcGtxsPNNY+DzAtxCYAL+iHYhRgyQGeJeR9Vy2PpgWmPjEZnM1YL/QLI43b9GkP4ZIUz4HHP86qdasM9RJNl8rS1ibdkcf9jhRQR3sqYx/bChVSW7ECbn5fIApn0XHEoLI0ism8ZB08HKehxEWsa81AuoGKdZ9T5ozEICVZcn9h+s5sJoLtVDZmztM9LosehL2kowhI1TtV+CgBfRzJ+HG8qF58Ma/MxC/wa4l9oTObT050C/aWJAx4IS6gKWMDP/lYNf3sV18q0WbKGv8FtvP5frUuuim2GwZwj7qqH/sP0Q9IkI+PmUwfIDCKR+4a4T27/48N4xrwmciPDddg/jo3ZZRigsdCLWubZ0QF30DiOrKRR/Ic X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 27, 2025 at 05:33:06PM +0100, Lorenzo Stoakes wrote: > On Fri, Jun 27, 2025 at 06:30:13PM +0200, David Hildenbrand wrote: > > On 27.06.25 18:28, Lorenzo Stoakes wrote: > > > On Fri, Jun 27, 2025 at 01:55:07PM +0200, David Hildenbrand wrote: > > > > Honoring these PTE bits is the exception, so let's invert the meaning. > > > > > > > > With this change, most callers don't have to pass any flags. > > > > > > > > No functional change intended. > > > > > > > > Signed-off-by: David Hildenbrand > > > > > > This is a nice change, it removes a lot of code I really didn't enjoy > > > looking at for introducing these flags all over the place. > > > > > > But a nit on the naming below, I'm not a fan of 'honor' here :) > > > > > > > --- > > > > mm/internal.h | 16 ++++++++-------- > > > > mm/madvise.c | 3 +-- > > > > mm/memory.c | 11 +++++------ > > > > mm/mempolicy.c | 4 +--- > > > > mm/mlock.c | 3 +-- > > > > mm/mremap.c | 3 +-- > > > > mm/rmap.c | 3 +-- > > > > 7 files changed, 18 insertions(+), 25 deletions(-) > > > > > > > > diff --git a/mm/internal.h b/mm/internal.h > > > > index e84217e27778d..9690c75063881 100644 > > > > --- a/mm/internal.h > > > > +++ b/mm/internal.h > > > > @@ -202,17 +202,17 @@ static inline void vma_close(struct vm_area_struct *vma) > > > > /* Flags for folio_pte_batch(). */ > > > > typedef int __bitwise fpb_t; > > > > > > > > -/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */ > > > > -#define FPB_IGNORE_DIRTY ((__force fpb_t)BIT(0)) > > > > +/* Compare PTEs honoring the dirty bit. */ > > > > +#define FPB_HONOR_DIRTY ((__force fpb_t)BIT(0)) > > > > > > Hm not to be petty but... :) > > > > > > I'm not sure I find 'honor' very clear here. Ignore is very clear, 'honor' (God > > > the British English in me wants to say honour here but stipp :P) doesn't > > > necessarily tell you what is going to happen. > > > > > > Perhaps PROPAGATE? or OBEY? > > > > RESPECT? :) DONT_IGNORE ;-) > 🎵 R-E-S-P-E-C-T find out what it means to me... ;) 🎵 > > This works too :>) -- Sincerely yours, Mike.