From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6B7FC83F18 for ; Thu, 10 Jul 2025 08:42:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EFA26B00A8; Thu, 10 Jul 2025 04:42:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A0556B00A9; Thu, 10 Jul 2025 04:42:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3903D6B00AA; Thu, 10 Jul 2025 04:42:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 26E996B00A8 for ; Thu, 10 Jul 2025 04:42:36 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C4CB5C04EB for ; Thu, 10 Jul 2025 08:42:35 +0000 (UTC) X-FDA: 83647713870.02.19617B4 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf06.hostedemail.com (Postfix) with ESMTP id 242B1180003 for ; Thu, 10 Jul 2025 08:42:33 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I8cR+ttK; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752136954; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qQ3OATblgHYemeFAwSAQ7ZV2cJzqyCE82EHlFQOPW+M=; b=tCA5g5qZgnefDD1bYXqqrrwVnRrngiQnNrvTLO9TKLqN4vPo5m2nZdP+RwM/5pm1KrBkJH ZJ7LMohxf+SEioMxnnAvUb0//oyF08zq3DNom8aEY/rYK2NCb2waitRXK0749GW1QN5F6h nq8om8N08lpo7FEt1hRYV9+JdjRUaBo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752136954; a=rsa-sha256; cv=none; b=wZh6kbJUnzPs81jHBB6TvyRsSyOGYMLZ9oOfC1aLtLOlEiEw/mbHJVWabeyRCNJI4DQQDu AEjgb7bcaJJCixN7KvJ+tL1OMMsk8vvKLLp1LnPVLClzG5Ed7VzCMRPauiRmMk2zFyAehx ZI7OpON2UOXN5sYgUeosb6U6b/rNSHY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I8cR+ttK; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 717CB61476; Thu, 10 Jul 2025 08:42:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59F4DC4AF09; Thu, 10 Jul 2025 08:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752136953; bh=N7lVbkdHA3+AaTIpvBFWHX0SAnOFAgo8RQjZ5xhsVRE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I8cR+ttKHF9yVAYCEUlvjW+JSd+2z+KUMiWHqhXL87CVS/PTXMKk4lH+VBdypmiux fvuZccdAMLh7zUdT+bYBXYEiES1dwoezghRhIGJ8KukUKzbYQksVbfIuUD7KpRnPfd UGm9Z6/B01CQN3mUC7ZIS5ZbLm4MVeZOB5IEDURyJ9vGewFhigSLpMb2LrZos723nY 33OO3+q3IUXDa6jcHrC27IZhyEOacXptEU5JAJhOMNn/82oH/cpuRiBnZHCuHfGrOv a1kKcLAqY4BnEyi4ZwutYKe98n8vrmUpFqgvnth/7aNZ9x2GSSjsaULPBDDBPuSAis YgErcO59ZTfEw== Date: Thu, 10 Jul 2025 09:42:27 +0100 From: Mark Brown To: Zi Yan Cc: wang lian , Liam.Howlett@oracle.com, akpm@linux-foundation.org, brauner@kernel.org, david@redhat.com, gkwang@linx-info.com, jannh@google.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, p1ucky0923@gmail.com, ryncsn@gmail.com, shuah@kernel.org, sj@kernel.org, vbabka@suse.cz, zijing.zhang@proton.me Subject: Re: [PATCH v3] selftests/mm: add process_madvise() tests Message-ID: References: <48D7AAD0-07C9-4E2D-9171-081A503B47AF@nvidia.com> <20250709123224.6593-1-lianux.mm@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HMq8UWvlx2E25A13" Content-Disposition: inline In-Reply-To: X-Cookie: Who is John Galt? X-Rspamd-Queue-Id: 242B1180003 X-Stat-Signature: uz77twobbrqqfj3f4jyh77fmoztsuowz X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1752136953-104671 X-HE-Meta: U2FsdGVkX18RWTWc3kV5EHVSlmcNKpFlKpAHJtxVrgUJTB62o9lM3tzftmvqeszaZ002/ZrE896DKyJlQZ4vGGF9GqUjcbx0YUWjRBWNXA4y/xlIDKxVpi15SAz32h7OER9AErqRRpZ1/1Fkye6zJl0t7VmiNyUtWVPjkDJ4lk6CQOQiK00QGtUb8FdQI5JP+PM6dnnSXYBop4UXROGvQfePwDFuk9EUj90hN/KUl+CNrWDYNNRFeIeWZ50/tpNaqJWghfjYSV3Q3Y/ZBJIDrySrjgJgdptdBE+Irc3D4zSNibV6+U50ctj8qvbQq5u4xLG3dcU0IdmXQq+ys3kSPvZAqOtYRBGvpMnZ1Ygh7bs2NcLM99K63+tbVMO8UT2iNHAnBci4PawJEeK9zkvUeDZu7mtkG7lrisodg4torNLgcuM1l9ygbQ+kBjyrmJ65KMPgQVYa3tLbLBbRku37aUMj9JP0Tn8D21Mi12A8/RNAdkZObHq/suwRLtS+uRgmAQ4bQeq37eaCUW+nUNVkZJfFCq+aC5kHIq2dxpiSCqHLe1AVe75EtAe3xNi84IWBGtgIBXVqT65pYOGH/bI/XqDo6P1WYmhF7uFxGYTyi70Ti9P3JXlcJBtzwr5tHJXmQxqkTq+UpcYJe2G8CuFzQAviWHZddn/s7FHJUD7L3eKBNSfayOJqWh828S8Ian+2OEgR+gqruO0q7aOXlSv9fZV3mCO23B3DIiI+uYn3lnROAzWjNGgtFNA2Ysqb/+oXDVKYaDPTtqrDwJzhfo7onqPhvdD+ou2uPHFXgO3EQ98kNK/9McJ5P+Cm+XK3MgXnV4o2q2gYQ4oSey9NTgAJIGSe54gdcveH+sF24IqPtYxLo7JTAPOJSfbGwRppVoOm5PuCL184ltuBvF6a1l3qvtjP8zYEEOAHXdoC9xo/tyGitKFp4jVLfIWhbxE7In3vwvcDoTMpMcDjbF27Lxq gH9y50sa KSLvNuOi2nDFKjNeChaH3ZEBbOcN/2Vxhb82WBo2lcsVmr3eVkniKmABVAoAzlCaIUAHzcKm4mObf41hF/nsyXAUanGBKGBV5fYMqhT7cvxlUdYuY452dxagqV5L2bH1pEz5l4Dr9SRJeCc5hIo72wS7qHtKOyXkAZnlXNEORBRFjPOKze9JWJHb+5El7VyjYIEvy1AHWDtlr+bSrmLv9Gd73LAHfsbBaByO0dlZi50wTp3U2k1VuszQPOzmUQiWoJYq9C7Z5Y/lNlA7DE+Ubp/jIW6kySq83S5nPcZdOaJdtaR+bQX5xyCZo+2e6+g9vlnD2O6NiUQsgzYZlLqlA8IYkIqclkJwjA7HYnpdpbRZxFORzslr+PzYo48lnLT5SO7261n0pvlZApiM6TPhkLl6ezI/9gHWRwFWUPwvaOcXpY5nUzLe6PWvqxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --HMq8UWvlx2E25A13 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 09, 2025 at 10:46:07AM -0400, Zi Yan wrote: > On 9 Jul 2025, at 8:32, wang lian wrote: > > Thanks for testing the patch and reporting this build failure. > > I don't have an arm64 environment readily available for testing, so I > > appreciate you catching this. I suspect this is caused by missing or > > older userspace headers in the cross-compilation toolchain. > Right. My /usr/include/sys does not have pidfd.h. IMHO selftests > should not rely on userspace headers, otherwise we cannot test > latest kernel changes. That's not realistic, we need to be able to use things like libc and for many areas you'd just end up copying or reimplmenenting the userspace libraries. There's some concerns for sure, for example we used to have hideous problems with the BPF tests needing extremely recent versions of LLVM which weren't available from distros, but just saying nothing from userspace is a big blocker to getting things done. With some things they're widely enough available that you can just assume they're there, with other things they're less standard so we need build time checks. OTOH in a case like this where we can just refer directly to a kernel header for some constants or structs then it does make sense to use the kernel headers, or in other cases where we're testing things that are intended to be controlled by libc it makes sense to use nolibc avoid conflicting with libc. --HMq8UWvlx2E25A13 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmhvfPMACgkQJNaLcl1U h9CImQf/Qotd6O/HXpyLcvS62Q/sJq8PY9vqEKgtMwJiL4Kh1ix8b1qyKqZyXQwp gLgU8WKUsgQccOUaRsyiUP3guh7d4WgmbOdNZDsvUOP0OkJ/GQmyL/X19mZptqKR hlvVhP8qRiI0BxVlpuEU6QxeSJZuilN2p9NoRwAGHNoOKb4E8lLZFlFS0w8KvO4Z NekttHHsY6wwSZlgiPzM2bRugoYQ7XamUQDm+mjH+3jY87FWFGeR7qA7Zbhuh2Ec HV3HMVJk5azHp5HeKUtMy9TyPxq/fnT6rtvC4Chz8nVNUD7hUWCHPZzEu0hZNiJF G0oep0VX3ZcNRFem90bLQ5OrkR8ZcA== =xV34 -----END PGP SIGNATURE----- --HMq8UWvlx2E25A13--