From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C18C83F09 for ; Tue, 8 Jul 2025 16:45:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70D9D6B008C; Tue, 8 Jul 2025 12:45:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BE5A6B0092; Tue, 8 Jul 2025 12:45:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D3F46B0095; Tue, 8 Jul 2025 12:45:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4E6F36B008C for ; Tue, 8 Jul 2025 12:45:58 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F3B631CF698 for ; Tue, 8 Jul 2025 16:45:57 +0000 (UTC) X-FDA: 83641674354.26.C10C8AF Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf01.hostedemail.com (Postfix) with ESMTP id 0262540013 for ; Tue, 8 Jul 2025 16:45:55 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Td1Be5LH; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751993156; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lX1gzCWtyg1PlSnHbltefFM/GnghA9lvZztlnvTvemM=; b=dqYs+lWMCnjxHjDPhIZUgZHbJpvxyE26MekME2HhacOMlAekFZz96l0BEctceEF3MQmIEw Usi6VLYZ9WTEMOP+O737pc9vwQs7p9lA6d6ertXTbaKm/U69nWVKYRzxvxJ+LBByEE+88/ czvgu1VT1p7nxeJae8Kwwa466RAyOmU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Td1Be5LH; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751993156; a=rsa-sha256; cv=none; b=AdcKKzkyGC9prNibb9I5jAy0fY0CefVrHmpB86CukDFHrMAEAQclO1ZO9mMchM0inofZHb FXmspPNsmjFdMvREtzTUmpnaZ60JK7ucmdyob/aE1BJTmyijGRwKQw6kZI9g4DdtlDhxCm sAwFHeuH+8XfqbII5stfvD+lrvjKlow= Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-553b584ac96so4464756e87.1 for ; Tue, 08 Jul 2025 09:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751993154; x=1752597954; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=lX1gzCWtyg1PlSnHbltefFM/GnghA9lvZztlnvTvemM=; b=Td1Be5LHC7FWfxwUVK8JRR2fBGWgfbKBw2DaEMmZ06VLVh0htQAT5GbNC0M+8JtK3I 722ya9JiWYuEZCDBtUUo2ohxPX+hVEhPoc9gykTQxck2r1vrL4Nd1DPREFc7Ms6ncItf OysYRX0NJdvqwBAJEA7TWnDTyS3Snpq1/Rzqswz/4zxgLmzM5ra1P2o+5bvx+QEqSF/G iKw2BlpjLGVq56J6h9S6PDWENBbYlPnhkQVeGENEuZ1stJWkmfzpUlk3lRGAQ8JS5ahY WHVzB4qrhIiwMbuywUl6k5oBFwk+Qe+MYa7qVV255E1PHvzoJL/Akp3zIFLq2KngOYKA 9Y2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751993154; x=1752597954; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lX1gzCWtyg1PlSnHbltefFM/GnghA9lvZztlnvTvemM=; b=lx6FZG3pDWSXG+FewF065ZMZAccZLAJuQZYuy8yGiOo4ZSQ/LVhzl8lsQMjlNBufuI l2eAc/u/sb2plrh+U8ReFS5XfBYYqv/0zJjyMhn9Jb02Npvz9tUVRQ0Z44ZioRHJaJve mYcJRZnkwfrohl6nNWmYwPNWD2gX4fhEUzXYKz6ZrjESTn0oUpqWKdXgtOFwZkWHWOn+ QykdR7aYLUNsQ3Yn/aox0x7ukBMQT2ec9raGAiQxotsXJsTQWP0w2vu1FX1cjVNc0a9Z LjURO2VP0u2r03oibJ+BGKAW1UbFvRl3r5x8FSkhZnMozivFApBIcgP6yTD1T+0qGRct OuJw== X-Forwarded-Encrypted: i=1; AJvYcCX4NXRKQNGBPzmOq0aflutmnbvSZ0hamWPwVirNKYrq32b2rSceBnLVbWR4OnxNVWh3YKzgZX9zTw==@kvack.org X-Gm-Message-State: AOJu0YxA0zc8VkTF+Lx3uHOkATF26TuLuaSktnIHwVdyTWVp2qd8gLIv Wsqfw8Z6R7viV/hOWm5COt/guTxWPFt0iOmzc0W8TNPvTh4KqolYwi7L X-Gm-Gg: ASbGncsosInWPiCWVY8JsV5b8JPyrjcqP4K5lwsIhcuNpkJyBGWrov/9GX4YDTRpZbQ 8VNU0HVn0qQaIJvgccE/WIUTxlrr/lpbb4uoszFjHcD81F6tvzKBePxrZV9m2CYW5wDmDwO6z3V 9Xsia7v5RAmSM6JtBX8TqKgK2Qkt7dAnADXxG0neFFxIwTJHNXzAbR7DeaNGiW6vOdy6g09T+gO gdu7MnoKBwCYP2ma38NFnVl5I3aqrjMDXgTTu0c/vC8JQSp8zqisG4z9KyjBTB5tn3Z3li2VjUj n8lc+pcVlXCeovTbYVxauYREcDs3kfURLr7t4fL1/VWlkvhK5CopMAF23UGflBnDZvMI3NVyZOs RAaan6Krj3V4= X-Google-Smtp-Source: AGHT+IGCjdMJ5CMc67BoyEjOlZ8XUsf8KIL2wMijv1phyIZo79nlY3bly62H5XIB9wPVnZfokgsx3A== X-Received: by 2002:a05:6512:3b91:b0:553:ccef:e2f4 with SMTP id 2adb3069b0e04-557f8353236mr1369280e87.35.1751993153671; Tue, 08 Jul 2025 09:45:53 -0700 (PDT) Received: from pc636 (host-95-203-1-180.mobileonline.telia.com. [95.203.1.180]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-556384c638csm1709225e87.235.2025.07.08.09.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 09:45:52 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 8 Jul 2025 18:45:50 +0200 To: Michal Hocko Cc: Uladzislau Rezki , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He Subject: Re: [RFC 2/7] mm/vmalloc: Support non-blocking GFP flags in alloc_vmap_area() Message-ID: References: <20250704152537.55724-1-urezki@gmail.com> <20250704152537.55724-3-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0262540013 X-Stat-Signature: 9ard3fefbcbkjtpq6zby57k3totp4azu X-Rspam-User: X-HE-Tag: 1751993155-345930 X-HE-Meta: U2FsdGVkX18iedkGJRElBKe4DEpbi4EKj1YNp5U4IN87F36hLh1+O6TOW6IukUdUoVi7gljr2SVPehx1SWfKnHKTiRR3DF/quIwxTQHBuX9XxSNTC2+kghp8tC8QXdGnUGrFJvBycIKw99snYTR4XB8lBkpWLBiWk45qfCTkVDRG3tD2dNFQ/v6TxD0faCfVE7NiVONG2BTBqYzaOVTyjsZiW9yRELeeEwSjJN8u6tYJwBXgH6a/mGhEM1T6zUnaY0Q2de04RIi25JuoZRt2R8N5MkKtMlDrPQLv/P1M/5eV38QmmU1TbLOrlTBnf8O59Z4U24QCcGMNHWNRHVDe1mifLo1ssrBlMszF5KN0Xa/K6qB5ssiq7J1a8NzXdmo81G4b87us3w/GHIJ8JkHLTKAxXCb/TA9trHhSUl7GmaekL6dzMQ/JW2H5ZXcfNqN4Ns12Kx37XKS/8bFbrOT24hJdIN4x8Z+3NvCS1m9r9SvGwlR8aBVG8HNfcKVjEeNZXo2co+QCrlVezZfFnb5fGLnlZU7gFtdJBXMuq19gb6DrMWZryOBFsDQeO4oIklIn+k8m/YH+ZvlOv9jTfST26O1/1HmcFAr9E22c1U8nccabtGoNHKDoRUoKkKlKwUT2RJX9wCUi8fVpS4XT+/RHG3nWy1OOjGD5onMVbNDZApnAba9J/kug4D0/l9B3XU3idDHBM1fpM4p9bM3zEEbJBXK/vFgCY1ZyXpLaAVyqosxiKSPNOz4YmF2yUG+N98H/7hKfUKsltwm5sOzr7I7jFUGMisAo9JOorLNPM+jnsv+obLUobAcCkfV+wVHaD7iOSF4KlADL9YZX3m8dL7adJUm1Z/LFtvbIQ+xhuWS/RrIMPRW4f7yBjIRtyK1rH6qdHNWg3F4GnC+RFYqrE8M2BTDf0vsMvB9eCQ7g5tkdAQPq8Q3WU3UfCt2MwoSKFtfoQ6kMiT18P9twWqykEVH z2JmgR9j LORUlozeArvpil0FI+ZmoMPcqDN/6ZyYs2Otdy4S9wOqgeNCErxLwE6yomRU9mIfQw8ZWzFMV/95ULovYWKfangPjyQDwQ7fZ1js1GAea/Pb3kHtRRW/2La5MjjU8hf0uAX2sKOHxlkSH39rbMmr2KgRkykEBtQ8Q2mZ+Eow6QCzerAV+qRMLHpPWyztXT+vM8u6AJeUxO6qUhtiY/ZQpm8OseJ1DNRLbqlI0F+HX+kagdCMhupORBgfJ2OlITeFu56PzE3ECxAKbxjsvHEogBCABKa5a0eP/REHjsTEPTx9eNuoPlNygWilvbeqXuFHj6UEJTtA5eIDRiIOXsMIDueofNgFpTUlGAx546X5K/gbwUtLrm0MYlieFcwn0IeqfRx3T9lHloNbyuHwYV+2qHvOnofrK3IBcyLskrUdP8mRGY9E+bDvQwQuC8c1MqLR5gG0BuPxHf9ywN1V4PNy370P94t6HPcAHcjs4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 08, 2025 at 05:17:33PM +0200, Michal Hocko wrote: > On Tue 08-07-25 14:34:28, Uladzislau Rezki wrote: > > On Mon, Jul 07, 2025 at 09:11:35AM +0200, Michal Hocko wrote: > > > On Fri 04-07-25 17:25:32, Uladzislau Rezki wrote: > > > [...] > > > > @@ -2030,7 +2033,8 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > > > > */ > > > > va = node_alloc(size, align, vstart, vend, &addr, &vn_id); > > > > if (!va) { > > > > - gfp_mask = gfp_mask & GFP_RECLAIM_MASK; > > > > + if (allow_block) > > > > + gfp_mask = gfp_mask & GFP_RECLAIM_MASK; > > > > > > I don't follow here and is this even correct? > > > > > Allow nested flags to follow a user request if there is a request > > to not block. For example if we apply GFP_RECLAIM_MASK to GFP_ATOMIC > > GFP_ATOMIC is converted to zero, thus to GFP_NOWAIT. > > I still do not follow. The aim of this code is to filter out all > non-reclaim related flags. Why that should work differently for > non-waiting allocations? > Btw. if you had GPP_ATOMIC the resulting mask will be still GFP_ATOMIC > as both __GFP_HIGH|__GFP_KSWAPD_RECLAIM are part of GFP_RECLAIM_MASK. > Right. I misread the GFP_RECLAIM_MASK, i thought that GFP_ATOMIC and GFP_NOWAIT are not part of it. They allow reclaim, but not direct, i.e. it is OK to wake-up a kswapd. So, they should not work differently. Thank you for the comment! -- Uladzislau Rezki