From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14177C8303C for ; Tue, 8 Jul 2025 12:29:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AADFE8D0002; Tue, 8 Jul 2025 08:29:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A85F68D0001; Tue, 8 Jul 2025 08:29:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99B998D0002; Tue, 8 Jul 2025 08:29:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 84B8E8D0001 for ; Tue, 8 Jul 2025 08:29:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1F333128DBB for ; Tue, 8 Jul 2025 12:29:16 +0000 (UTC) X-FDA: 83641027512.17.C408E7D Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf26.hostedemail.com (Postfix) with ESMTP id 24A6414000A for ; Tue, 8 Jul 2025 12:29:13 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f5qniAxS; spf=pass (imf26.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751977754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jKrYTylI11tpnP0mGBFQ9r8Vbpw/JVR1OwgCplmGikw=; b=7k/ZF8RxZ6uLsuYtSP7fmUS6RuN+kgLoiwgZq7r3OB4BKZYWhPVPQ+KpWvIixmquNtkvWR W3xWF1Iw14QCOytmz+u1a4ChhJQORc90yToiYj1e1IAOF6/oiNju8WfCfgdNXBzQhtOB2W BYYlEdN9xyEeAEN36YzllLqJ/0Gp4j8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f5qniAxS; spf=pass (imf26.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751977754; a=rsa-sha256; cv=none; b=rA7xK63TjQwlKVJoqSLZ6AEZ+PHuyHP+WrPTBh17fNe4N4RphcDHnimlcFc6vqxVQWI03q hhr99Hgfx12QeoI8d5d2rMGqNvYqpuSzX0Oe+wOWn/jUP4926v2Y1YY2saxmYSOabZVMgr CYSQyGGJhAK8cGZGchtZAm7OpNw7xIA= Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-55628eaec6cso3898480e87.0 for ; Tue, 08 Jul 2025 05:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751977752; x=1752582552; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=jKrYTylI11tpnP0mGBFQ9r8Vbpw/JVR1OwgCplmGikw=; b=f5qniAxS+oSxHtxKpmhx3J6p1o1cXAChblWF+M9vObrsVQ+AThRI0CbiTh/IILfiiz vb0xkzqOZa3lKjl6DpWv1Rk71a14SlrIXu/FiYFX/31t09/OhqIu3DWMpQSdnb8HB1rW 4FQZ1BWULu0oPWM/wlRqsN5WFTeQb7Zm+YZBeqYEAJKV+ofNgcUTb+KMzouBaOfOOPm7 85v1tak+ufymAK7sqrGchMi7FEi8FbxkkN5DoXuTfIorQo7k/Q7txvZ7wKB1an/koGtd UI4tmbzLEHOxMDlloOBnZf/V3qg7CmM8IV0jfoUtgRFDuj0WYaSm6No7d8LQQ2yHq3ij apVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751977752; x=1752582552; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jKrYTylI11tpnP0mGBFQ9r8Vbpw/JVR1OwgCplmGikw=; b=FGKu/KzpEtMUhYQNllUcYLCiXuhz7zCG3QJ+hCtao5eYg8iupiGuXF0M+/HZMdSFub iqji4nP2NisEPiNKyKJixZHwAHcO7+bHtVTB/Xynwyn3gUGyrMJsuV+vPqwnncqeTUQ0 VBPv6//UEH/AEz3QLcrKxb5VGGImiRIFtR4XWtaJPq6e0SL52Xk1Ak0iio/MPWwhk/8+ /5whK1EbwtBqU/HOr4X71yHdNeIDyI5GLFrZvXq39qf6jfR7McrLcQN7bRSm9Xz0BnO/ RaZkjP3ROEntPgrtLrzIq295ND3+5t3TLPjx2fnrn0voRXgqDktcQreJbrxj5B6Ax2uo kbCA== X-Forwarded-Encrypted: i=1; AJvYcCWKSgJHjT9YRCJYoNy3ls0IOuo1vMywt/pYPx0zuwvyGEacNH1UNF8PgGIAPhShv/cS+mGadMIJvA==@kvack.org X-Gm-Message-State: AOJu0YzoTT8nQAcawY+imDN03N/gE+nNnI2pfqRn0kmU95CGnvLw+m08 Ah08uk331D3yAPz6iSv48yrXfmTe9W9XopLBtsXyXK6T8Ahlmhti2vl6 X-Gm-Gg: ASbGncul3ORycRGxnQ9YApoUpWFqtcP2piyXcDjuvz++6fzC/OIvgj8b5ixTb7GDZjA ijtIx3kygtA8OD4vQCr/hg8IM9V/g/mEHwNB7+11ajcxoHwgxDf50Oz/gMZFY+Qtl9mUeUFvZ2s oiNIzSVBdO3y3CYQs5ip102GRgxo7cpO81mUsyYYPHkaVbKWWpw7KxSb0MMbQJqtk6R05BzfkG6 n1bmRfkA5KyXdi/LZa8MegheekKCwvETgVXeLeCs5uDr5m3UAv/5HdUX3eDMiV58ucBtpI0ZOsP biK2Pp6rWPi2h/Qr3btALRAqFU2sjfIf9WxLnO+s2dh32BE/vtcfQVCW+bKRVb9J+Zn1k8z5E9f SJgbtfNWpWPc= X-Google-Smtp-Source: AGHT+IEU5jsNR54q8+iXNXGyc5nxjnUooNxl/UsyiBDeeI9PBzPIVZY9DBdq1dx6K3vis5Z8an2Skw== X-Received: by 2002:a05:6512:1516:10b0:553:510d:f470 with SMTP id 2adb3069b0e04-557f83020cbmr886743e87.4.1751977752160; Tue, 08 Jul 2025 05:29:12 -0700 (PDT) Received: from pc636 (host-95-203-1-180.mobileonline.telia.com. [95.203.1.180]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55638494fe8sm1674536e87.112.2025.07.08.05.29.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 05:29:11 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 8 Jul 2025 14:29:09 +0200 To: Michal Hocko Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He Subject: Re: [RFC 3/7] mm/vmalloc: Avoid cond_resched() when blocking is not permitted Message-ID: References: <20250704152537.55724-1-urezki@gmail.com> <20250704152537.55724-4-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: fa8hwjamdi8oqnr73fbxw1mpuy34mee3 X-Rspamd-Queue-Id: 24A6414000A X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751977753-279854 X-HE-Meta: U2FsdGVkX19O0V8KQXV5HYcBz4G48LMqg4m1Su1MukQKLRQVP9d97ogR2hqsST/zgyNnKqPLDRVH83mowDaT0ekWIH7iaMiVVvVaNX9qklAGuXRO0x70QNv9Vre47ESmDcXA5Q3H3z0JmdqxmMg3DgLcaWjVpIs6UhOpmKmOLJyJh4qU+DjnM4vnlwAyGNjFlef0GTeeUQM+lb1RWYrDLLS0MJcdvAUxr0QRup6DtPvJ96zncsZPI1RlkVHhGv5wSIQ8WNmdLVJNq51DJwt9YJ0TxnHoZTzCnWlgYu+SPQ7CsmyGvaFI68luDilcX8BCkHPfVByObQAoECvO016q5N8kO+FavRfLZHKlu2BFoDO6yrtEAtMIzQLiEAAaspAicbfs2Vl3vd7C/M7LZ+DoGI5mUWHp4bhgpUuc8ExKhdinelqRZdcydkW1Z5APXAs1tE4iSHMzyCyH2uLrTjnMokaqeCxE03gQ0JEIWYDpwKZ3/6Kau/NcNxopzA+mJcdwwZXHFgMsAnUEvxhCJhWiNLh5R0A2mb+EXZuDU3DynFwH5hY0lxss27rO1hQbzPaQ5E1N0FvpGhdRiMhyNxzqxAJysY99e4O1T+9ESbyPHWw7Tv1pSyjf5DLnrlMmn8qawmRgonGI5Iu9WN1s5wAcdQe3rmVY98UlRmDaErLgBZWY2bqDxSPN2ckcRy7oivJN5bsk2Sz55+upto/4iLqEHGwvx/ZNWpqr5cg2iBCbONc/ByKG1vpkGUqpd5HK9/1QAFAwYHFbHeXvPcxpXtgKhDSGqZrKpFL7MwQic52d/KhTi6B5gstfv8tvNho4IYmmMYXlPoVSQkOcSgyrF5EHIEIY+u7nXkVM2WGowG0r5LYxgr8TcDF3uBr1C4HaKZqF9SR9h2KE8Gtq23HHzvtJarYsrmqQFzl5oHYDKJ2jUkaE+QwaOBomC/LHpwMzkYLfpbDvLyLEE0XHwWk7Qf3 Sg1NNF0r xdEaixNalq9AzM/Q080iN5XWNfIsjc8c7tBLrILWdj7J515R6QzOTT6T9DDhxkGg0zh11kcxn01lLM7TAbMdGXR42K2mfSYEcpY7zW5nV12c7HrCccm4ujZMgk4kEgNgad3t/idm4hlmKd904Lj0PV58ZfdAfMYEM/8VMqD5vPuYZRDU4SAOJ0DYepXMsqy5vFzJkXcIWq7FW5CvbPOS8mw91jbc/ajKYiQ0YfppgfDqjVO8fQgN0BaGOiHOwANrd3tzf3KQTUEOeJAOfrEVoHLZC6aQa2gv1CUeAwBWPlRKU2Ang3sUNnZCaWZPFGBT8xzsdQQCBENT40X8dOYJNMu++MMlSvVNvHUIxo4b46V0a+2YMr5befJb8Y0N4LSBkk4lVf6H8Yv8wPSoK/SUI6ALa1s1dCQGwKQzqjc5basbtYtR53sl8YhERDXUovBUqMcFzS5TScQRz2lExgm1bjddC195Skskp7Frj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 07, 2025 at 09:11:43AM +0200, Michal Hocko wrote: > On Fri 04-07-25 17:25:33, Uladzislau Rezki wrote: > > The vm_area_alloc_pages() function uses cond_resched() to yield the > > CPU during potentially long-running loops. However, yielding should > > only be done if the given GFP flags allow blocking. > > > > This patch avoids calling cond_resched() when the allocation context > > is non-blocking(GFP_ATOMIC, GFP_NOWAIT). > > Do we even need those cond_resched calls? Both of them are called > shortly after memory allocator which already yields CPU when allowed. > I think it can be just dropped. -- Uladzislau Rezki