From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D56C7C77B7C for ; Wed, 25 Jun 2025 20:17:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21E266B00AD; Wed, 25 Jun 2025 16:17:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F61A6B00BE; Wed, 25 Jun 2025 16:17:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10BF46B00C0; Wed, 25 Jun 2025 16:17:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F24E76B00AD for ; Wed, 25 Jun 2025 16:17:30 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 68946121B08 for ; Wed, 25 Jun 2025 20:17:30 +0000 (UTC) X-FDA: 83595033060.13.8894B4C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 38D0F160006 for ; Wed, 25 Jun 2025 20:17:28 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AhIDNQWF; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750882648; a=rsa-sha256; cv=none; b=0naQGWc9+ysihrp8Qf9+dVT628ngwv8AzyUg77nOEuAmT7mwKckr+ceB3gy9tr7ldl7+SS qd0RvQS7JxwIBXIAD6B7vGpGwE5ss1B3hGO9iPKOMOQ/AvGnCmUNJnaQF0tyzv7XbmKjJI +DV72ijVr2XAlupdjZ7vX6FWoJa5Z70= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AhIDNQWF; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750882648; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KlmQIXJkSLHoHX0VDek2rLWbw4e0y5vAiIw+rJY/aIU=; b=vmnY1cZ2Of5fUjQg/6bC/MCpqccY7VDZL0EwDayiLLf5t4KoyPlwqcIn5v7b1oRpmvi/0O tUb0keHAm5XHFocoNOAtJqsCkJsIRoE/3sH3BjGglB9yYaqiOVonUU7Ot15cdHat+cqAP1 ikuXU9Tap8bCklqmefdyIVG6dk2fyZk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750882647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KlmQIXJkSLHoHX0VDek2rLWbw4e0y5vAiIw+rJY/aIU=; b=AhIDNQWFd5HCx8qaNsIYVhNjl8KXaVEtN/WCFj4Smwzf+GxVVOlD+0am6i6267r3+7+sMT V1/pnHN7zmRsDU8lFij+21Wn/+7zjwsrbrQeDrLGHl3BFG/h8+tWL5aXLD5CyGMfcPv6Ox ptUJGqn/+CkT4HUpIb5T9817ed1+Mkc= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-kbkpTAq9Py-s5mj1uApw_A-1; Wed, 25 Jun 2025 16:17:26 -0400 X-MC-Unique: kbkpTAq9Py-s5mj1uApw_A-1 X-Mimecast-MFC-AGG-ID: kbkpTAq9Py-s5mj1uApw_A_1750882645 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c7c30d8986so65096885a.2 for ; Wed, 25 Jun 2025 13:17:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750882645; x=1751487445; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KlmQIXJkSLHoHX0VDek2rLWbw4e0y5vAiIw+rJY/aIU=; b=ZZ0vmeHpccNLt8ba7BDztxuPyy+AaNf9BNSorv093J6L3UZdK3CxYfzBecIj+pZ7OK uFq0K7poZnaZm1Q2/ShL1ufG3BRPYGlmyvWFChmy+k5wQazTTVzO2iYxfBVZRiYKBFN/ 7aQ3kymZNgs7KHE4psWuZixmofpo66jaBIhwi3UbdM7qGQ+mykcrOffVNQ3njQzz0Z1m RKpi+JYXwDybMYVTdFgGdiUQZR+altOsXI2eUeRtvGRTq4bhsvr9eCiB/S23RMHoMyQN QnW/6hB/OHIZdUSdbQtF/pLR2Ac1WUBTZ3KDXR/1B3YbI/oHsBpro0fbAymSNSc4xcCp 0Itg== X-Gm-Message-State: AOJu0Yy/cs9LkcOaGxBfoFfPbvXZDy/9ZW83Rf1sUUoaYVd/1/7V+rCa UmU0ZbPt+9zJ20Foy7kItGLk21R6Av/FgTSVCAH7DNRV3eGM7OYFG7P2Zs8IG0PoRdDvlL6bXvu ZKOXkbB0KuGn1FRSGWLUnH+gEpb7bqq0D5TvryauTdg4V7zBPAyMO X-Gm-Gg: ASbGncs7t/dgb9gaCwJRkCCECI1+IFwHHStbkWoAx+BCWSQYQaQ98sNqcnfO9OgLKjZ M3QFJX09ky7UrOeHUxhlf20Z+OTQtEUmvBHCH/ymMvOoWB/ddCQdeJNDccZ1smvjVjS5t53Sw7s ZGTvBgHij6CMP3bIG2KntF984iJayAWzI6J5e7ajka2873y/B+S69Lyq8RudNgk7+7uNexpNPSn 2aJT6u143I4s4O/tcqYACClUSha8w4nrBd1CAe4njfvjeFcQsiHwMEXDZtbhWmYrQv11mXDHyzZ KWVKdWf2c+aAgg== X-Received: by 2002:a05:620a:1903:b0:7d4:295c:884c with SMTP id af79cd13be357-7d4296ca085mr688766085a.7.1750882645394; Wed, 25 Jun 2025 13:17:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEp93M4ZUN89rndoxAUp30wqRTw8qx2vuSj51L3iHO6Dl7nqKChlv50/E34qKZIK2pVZnw5og== X-Received: by 2002:a05:620a:1903:b0:7d4:295c:884c with SMTP id af79cd13be357-7d4296ca085mr688762585a.7.1750882645053; Wed, 25 Jun 2025 13:17:25 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d3f99fbe3esm653012085a.89.2025.06.25.13.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 13:17:24 -0700 (PDT) Date: Wed, 25 Jun 2025 16:17:20 -0400 From: Peter Xu To: Nikita Kalyazin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Oscar Salvador , Michal Hocko , David Hildenbrand , Muchun Song , Andrea Arcangeli , Ujwal Kundur , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , "Liam R . Howlett" , James Houghton , Mike Rapoport , Lorenzo Stoakes , Axel Rasmussen Subject: Re: [PATCH 0/4] mm/userfaultfd: modulize memory types Message-ID: References: <20250620190342.1780170-1-peterx@redhat.com> <114133f5-0282-463d-9d65-3143aa658806@amazon.com> MIME-Version: 1.0 In-Reply-To: <114133f5-0282-463d-9d65-3143aa658806@amazon.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sSqFkpG035BCawBl4uaR5r7um1CKocvaDgDid_VfKWE_1750882645 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: aenhehttygoo4xbr4yibchn94qayrzfb X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 38D0F160006 X-Rspam-User: X-HE-Tag: 1750882648-242464 X-HE-Meta: U2FsdGVkX18C8nLLrj1QjQIMPuFjsFGLOyAiG/TD0UH/plehVzZnxWplD/JWhqrty6hskVb0te2egJKX6aDXC4DxE9C6dHBR5wZ3u3elafI1PkiXLg8pqsZ+L+q+uOWnJf892oWohcXGE1DlG88eJQTsHHPYxibrHMvLFFIxUmA+fq6Sx0UZxmUA3LgC1ww15zCfO28+Bd7HU27Qb2lRHjc4gWJ0LWG3YWhZLSrl4H2buk1qp/pPq3dPZNkX9o1PRxw3KpOUsI5H/cxcEdTuI0AO7g6d8JndDI1am3S6t5RtV3RNsoCknwUqnV0IZMgpioOAfn+rdio4bONmS4tioWNk37rGgpCLJphhWzhu+t2mh4fypnTveasN9mtabDAWU6oQxg9han8IkJ+wDZkxMNwVRa2QT77W3jOdAMKy4M0oKwGM3PZq1q7zZxKApmWRgMMwGORb0+pXGsKLkHFPciVJumZ5eniGAHpnPNrgtWUH1ZO9b5WhDVGyhQLsjnBmvW62M8V+qrfhxwta0glDJk0ydWedbVi4ivObkjPOyYXt0itZz4F4/8M9Xo9155fuc9RaWtSpA6GgroyEeJrwwUM5CfHv9HGYZ5FRIFS5CZ25bPr8PimxgHYxdRc+hY0M6MidRe0zhIIE6e4pO+OEL1bb+Ji4bDc5HbTHyUhPdpImLqoNrX06gE+jcNQD++j5sCK5zjLV1WV3AmIb8jCw79WbBKI4JEdHiTVgqRH+WYa70Z7MnrspwEAnznCBfuFtAgxvZfUVCbk3LK6IstB+1K4q/YbUN+5UnSpc8vor6s0G35DUomXY410v8yLJDbS7ITECCRfsfbcsorbymtU3xzLC8phG2Jp8bDn+VPMq5v1Qayzi1IV/CylOYsIpAUzeTVMdjbkO5rxGg5oX5muSsNvwNBQ4F3hRsb2mFFn/RVLDFRHfFNoMlnrNUwZ+U8YFljvGcQ7yK9kMatguG95 ic5JViuL 6yB5GVlEJlgjkAug8jtviwI8KdCtEHy1OgqupVkvXePSh5wAPf2cT5D1PPMrZ56l8V6qJGBp3yz/XB0Z7Pr5G9xAcUJA3flFJIEVtZkiMjnCkxCaJTTB+kT2QwLsbL1PJx9XGR9E3L8J5cHEcFT/ZVc1M1fn9c+AIWS92mpeZqTTPnbUwdaJTniuP1AM8qwaweW/YVuhU0BZjsfQbcAw9h0H9AKr+LTfaVx+S1JJOAizrk1UfyX1+DjjyKQONl0VT4UZY/+P/8zqai7kDIsz6v9LCi0rW+3//zVi6KFi1SjOiNM6LQJfjUc4JZHSujF7EbNkagNYraDmAfuKlG+z/tzcM3OZpoN5oJjkXGwT2CVl4wf5Fwb0S/glqR9wSojSgmx6z2Dmjl2XUixfbj0gdm5tKHb8qeUiRIhmnd/ikOypaxINdfr1Chs+dCK/AJD7wD9HUYa2GX5kRRBjvrdjW4IZEyh89ZRlXZHPK6hjskvH6hV+Bbi2MGuVFswMV/Z2ded+bJtjyc9KIk0Krhinelb0Qn4mO4OdQlPsqPQ0/x0PtMfI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 05:56:23PM +0100, Nikita Kalyazin wrote: > > > On 20/06/2025 20:03, Peter Xu wrote: > > [based on akpm/mm-new] > > > > This series is an alternative proposal of what Nikita proposed here on the > > initial three patches: > > > > https://lore.kernel.org/r/20250404154352.23078-1-kalyazin@amazon.com > > > > This is not yet relevant to any guest-memfd support, but paving way for it. > > Hi Peter, Hi, Nikita, > > Thanks for posting this. I confirmed that minor fault handling was working > for guest_memfd based on this series and looked simple (a draft based on > mmap support in guest_memfd v7 [1]): Thanks for the quick spin, glad to know it works. Some trivial things to mention below.. > > diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c > index 5abb6d52a375..6ddc73419724 100644 > --- a/virt/kvm/guest_memfd.c > +++ b/virt/kvm/guest_memfd.c > @@ -5,6 +5,9 @@ > #include > #include > #include > +#ifdef CONFIG_USERFAULTFD This ifdef not needed, userfaultfd_k.h has taken care of all cases. > +#include > +#endif > > #include "kvm_mm.h" > > @@ -396,6 +399,14 @@ static vm_fault_t kvm_gmem_fault(struct vm_fault *vmf) > kvm_gmem_mark_prepared(folio); > } > > +#ifdef CONFIG_USERFAULTFD Same here. userfaultfd_minor() is always defined. I'll wait for a few more days for reviewers, and likely send v2 before next week. Thanks, -- Peter Xu