From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76959C7EE2A for ; Wed, 25 Jun 2025 16:45:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12BC36B00CB; Wed, 25 Jun 2025 12:45:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DCA76B00CD; Wed, 25 Jun 2025 12:45:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F35A06B00CE; Wed, 25 Jun 2025 12:45:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E3C966B00CB for ; Wed, 25 Jun 2025 12:45:30 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B1D2310269F for ; Wed, 25 Jun 2025 16:45:30 +0000 (UTC) X-FDA: 83594498820.05.8208A97 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf03.hostedemail.com (Postfix) with ESMTP id B4CFF20004 for ; Wed, 25 Jun 2025 16:45:28 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QWuvdJCF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750869928; a=rsa-sha256; cv=none; b=SGFt6hYiyeU25xHiS13Gp2pA3qa5o8w5d3QIzObNqYMV0ce4aUoNLgTPz6x1ZR1AhWc7++ I3Dr01S7AEOSOhK0ayzSRdk/cIiB6thEYu+1qAK1n88SPil/774d0jbLzoIA2XhembjdA7 roTO0I7av9GPPnz9uQbJ2vy1U8pDWCc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QWuvdJCF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750869928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MRZr72IanLp2/fvK7GINdWTxeiG4EJ1++O5w+i7hkpI=; b=F1ApvsTyJQi1HQsGJf/djJqMbNkX/WRWFDSIEMsZfJd9KmBlxI1ThXPul06z2f/Z9MwLlf CaHqmvkELoFqieDthfMotuZUE7CZkGegbUSpSyU89HzsujCn4wxHV8JD/Isl5w+x3Z1iT2 guJeP+LLJvp4hOQsvPVP5sHc51LuONM= Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-553e5df44f8so52403e87.3 for ; Wed, 25 Jun 2025 09:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750869927; x=1751474727; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=MRZr72IanLp2/fvK7GINdWTxeiG4EJ1++O5w+i7hkpI=; b=QWuvdJCFlWuGt3kq8O9DvyJ7HBDa/UTGHyKp47HJ/hyVFL/o69b+Yf2r1UXxAIDOs2 tmUX8HNveNRFrbrv00YA8ydyrBbkha2HyIRqeEYyEE70NzRbvx8DfVZWLgyDb/78AMrU lf1ST60/zgVNS0fdozSkbH4LeDjiRJ04K2Gq1k0QjW/M5/wRF09Nj8WZ65F9w3u70qSl nPlWdhjN+v/vXFypz/0hlHUKNeMdxqjcKs0wg3U+35gQU8kIRF34x8DvvBEXS4BoIBpS 3KLnKaAp/ZAz6/iQGbqVxSdRifx47+gwsa9Ra6BL03qgrLCiF6B869nbLjqHYzKuOuvq JYDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750869927; x=1751474727; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MRZr72IanLp2/fvK7GINdWTxeiG4EJ1++O5w+i7hkpI=; b=aBR6jCoKv4hf0y0GU8bboma/8HFJHJX6U3Cof85wtRyvBr6dA+FnSoqEJYtPHUMmO3 CrSkc4nvTvEeVeSfxwgNsUVZC2Qli9Fc4QKoCV90Jl9ZoMjb8YeIj+ZAoEdiXUMOPlof 2R8gFOY2FEBhSN43SgMlcy/NSu4prRBBIDQpXm6zs9IwfrpI4PLUltHtBVsMKC6xUZJ+ GtCpRCKS0PubkWHhohlK+p7hieVv8zEn9X82ZzSpTnmloF36/JVD2zFjV9MzaZeeTOaR Okz/SfHDa5riJ8Zyx3mhoiNSijcvZs+qto7MAS3WVsJK10QvGM9MfUzDwaQzs8AGbEqT eyJA== X-Forwarded-Encrypted: i=1; AJvYcCVU2cbdBRmcMFe6RWm1ykfcWkEs+eXY6+5drfn36grzZte104bc1v8Y6bwlIOivnmantm+r9N8kuw==@kvack.org X-Gm-Message-State: AOJu0Yxr8hKYH/tpw4PPE/kZqx5bXI2NZbGi4Xo5kRWgfRdSuFVtjFEa 47CK0ykLGdx2vAYPZmAG/uHYSOE22qb/P6VEn9xNk/sd379Sbbqar1Cj X-Gm-Gg: ASbGncuRNWfkduII09oJt6T4QPmUGwlVB7q2Qckk6G9vzRG/zLO5V0eo55Xvv8xYPWL rraDSuMxsHHqpVsEwKtrzIaQ6+LfgVZNCgRBY1sVDK0GnIev0S8MkQZ6yzBfmBqzSydTAypPRmU hA7yCf01VFBddMfSfCQRP2Ui+ua2CYgtKRx8oBZ+GMWsqUObSvhgCYzQfqJ6ZocbwSb2WDKg9x7 Z7bf6AlbwJfudrnOAcxI7kvQj5GYgqsnTg0VanAkhZh/NpkuXuSNGI/IqmdeNMh4WShekOKJY1M tQbUAYjsOsZ49iJJZU/Cvcqt9+VMQ8jB7jAjjZUxn1mOtJisWvT+hMM0yFDbTWd9rMPoFjJSOpU WCusqX7Xuvi4= X-Google-Smtp-Source: AGHT+IERJA18iuqTJ67hC1NMSnjOwwmCBiC97X66Q79tKTCEdC0ZK7RYZyFhg8vu+PtcnRO0IUB1Dg== X-Received: by 2002:a05:6512:2315:b0:553:cf7d:72a0 with SMTP id 2adb3069b0e04-554fdcc4d03mr1141864e87.5.1750869926585; Wed, 25 Jun 2025 09:45:26 -0700 (PDT) Received: from pc636 (host-95-203-1-180.mobileonline.telia.com. [95.203.1.180]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553e41c3593sm2251685e87.152.2025.06.25.09.45.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 09:45:26 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 25 Jun 2025 18:45:23 +0200 To: Boqun Feng Cc: Uladzislau Rezki , Vitaly Wool , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Danilo Krummrich , Alice Ryhl , rust-for-linux@vger.kernel.org Subject: Re: [PATCH v3 2/2] rust: support align and NUMA id in allocations Message-ID: References: <20250625062917.3379804-1-vitaly.wool@konsulko.se> <20250625063026.3379921-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: kpy439gcjfcx3fq1ezjd5ck3a13gheuk X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B4CFF20004 X-HE-Tag: 1750869928-557285 X-HE-Meta: U2FsdGVkX1+x6BSv6W4bQbRKUGdguaDFMVLBVf/wlu/BYstR/hiX4Rd54jdXKituv6ZfBpo2MKDRLOEU4cJNID52fNJf5ZfNIukTV3rO99vwm8h2kceB1Ao/QzMpilvq7RiaA7Vu0vDagAzolRBXT5VS+zE3qhEsP1kRm9Yheq2yU8riO3Tr1K2gRQj4HKrcldhJpTocjg7KvAEgJIQIRXGAH9X8NXxxLugmML3Z2dbregaXsJmKbH++ZWb0y/6Us6IAvXo/ml1HRTA3LtgZeTHq1euBn3pwbUqdYGgXwtR0ZXNbU9PxIXHw+KeHEmwydhP3hV8KWQKezOZ0wGid9bgx7vtJV2KJnmvIi3+garPZso4fM74cV4V5FsQ0OJEOLuPA8p6RDzJa0F4jk56ho/r6Bg0J9/3z8utIjuHeiN+Ws2+bwY8xhhZduiFwesoaY7FdqFh+z9jBc0f7Rnrl+vqCBT1R75TXF8outz10yfeaJ7K9kWpCwtGhatWoAkQtvFVFkky3j6gD++BAeW362Zp8Fy8mCdRlwtAjU3j+rnfVmsEMGd8vmxpPc75nGSz9xPlSEp6CVwMjAWxugwuVGFETUlGnHPrmPcc1hf/vLOcw6c3Ed5Hk92MAfptIio4uol7h5MS6GvUVWTh5VHngKxWLLq3aPD/epYu5FY5hvSMi23LK3fUWnROLGUoEMw/aMup06YRdVuZwUCSyjk0B2/8zMJadzwV9In0u8+PnAttYcHvfysERQt0JurvRN8JLmPfT3L5sNHmJwYWlE25PGoJNTKnfjORAUvlozbsprdCt0DC3pI7Rog6Ig++aCkh1PKLHMVBqLNC4v9ZlM8RbaZudqHXoTt1O49LuooLDmLs2Nbq7Xn+Ccp01RwAikuvzPIqUkOnFxZL7i7H8cfQd0ivu54MI3GGbRHlM/ugl4/Ql5Ps1+wBGsmvQdXPFHf8CNdUtsFzpV+qshNdGvHO 7fJCwsrQ vehTmXsTu4fibo7uLx3Rem7Kam/Kze6AqLGXYugFyz3zT7uTo3Cw+KIUrs68mDSEwg2v1xtFMPIPwMnFllbezkgmWpEylMdIHREs/4pPLR+7bJyATDggqJ17qwhAufC71BuIcJZ2pwFzZgCElpM7VL0T3yohXJ7CQ5ooLDTkyHVcrZ0ryoUYwOzePPvn78eLwnHBRlfTOMr69li3oJBdoay5MNCIHJy0ZFEfoJzSNy6ihWpLTo8TaTaeBSpiZNY55jlnjt+R2WpLchm5zLveppTOTv9bKiR3N12D49dM54sVRwXHdQj8YAeNmn7H3HQZ99YzZP4buxIjH8mJnKKxrvmyC3TCqKFhA/1JviKePF+OmIZH+ZpTI+iL/4pyz1LnWZuBjsHMbRF6u1pZHr79wWlOaS5a2IKCOw/x4tu/KlYgpll4VMd2hAJm3+KB1lQ/+rUrXYzbrezB9a3OPghKlggMZ8sTbHaaGbYhDW7azd2n0nvb5sMLjx1OZEw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 09:12:21AM -0700, Boqun Feng wrote: > On Wed, Jun 25, 2025 at 06:07:06PM +0200, Uladzislau Rezki wrote: > > On Wed, Jun 25, 2025 at 06:12:52AM -0700, Boqun Feng wrote: > > > On Wed, Jun 25, 2025 at 08:30:26AM +0200, Vitaly Wool wrote: > > > [...] > > > > @@ -151,16 +159,11 @@ unsafe fn realloc( > > > > layout: Layout, > > > > old_layout: Layout, > > > > flags: Flags, > > > > + nid: Option, > > > > ) -> Result, AllocError> { > > > > - // TODO: Support alignments larger than PAGE_SIZE. > > > > > > Thanks a lot for doing this! While you're at it, maybe we can add a few > > > tests for various alignments of allocation? I'm thinking: > > > > > > #[repr(align(65536)] > > > pub struct Test64k { > > > a: i32 > > > } > > > > > > #[kunit_tests(rust_vbox)] > > > mod tests { > > > #[test] > > > fn large_allocation() -> Result { > > > // Better use `new_uninit()` to avoid allocation on the stack. > > > let x = VBox::::new_uninit(...)?; > > > > > > assert!(x.as_ptr().addr() & (kernel::sizes::SZ_64K - 1) == 0); > > > } > > > } > > > > > > Thoughts? > > > > > > Regards, > > > Boqun > > > > > > > - if layout.align() > bindings::PAGE_SIZE { > > > > - pr_warn!("Vmalloc does not support alignments larger than PAGE_SIZE yet.\n"); > > > > - return Err(AllocError); > > > > - } > > > > - > > > > // SAFETY: If not `None`, `ptr` is guaranteed to point to valid memory, which was previously > > > > // allocated with this `Allocator`. > > > > - unsafe { ReallocFunc::VREALLOC.call(ptr, layout, old_layout, flags) } > > > > + unsafe { ReallocFunc::VREALLOC.call(ptr, layout, old_layout, flags, nid) } > > > > } > > > > } > > > > > > > [...] > > > > > At least we are lacking of vrealloc() exercising in the vmalloc-test suite. > > I am not sure it makes a lot of sense to add a kunit test on top of rust-wrapper > > around vrealloc(). > > > > From my side, i will add the test case to the test_vmalloc.c test-suite. > > > > Thanks! But we will need these tests from Rust side anyway, to test > 1) whether the Rust wrapper does the right thing, and 2) whether any C > change cause the behavior changes on the API that Rust wrapper rely on. > Ah. Got it :) -- Uladzislau Rezki