From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FFF1C7115C for ; Wed, 25 Jun 2025 16:12:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DD028D0009; Wed, 25 Jun 2025 12:12:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B4E08D0001; Wed, 25 Jun 2025 12:12:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CB138D0009; Wed, 25 Jun 2025 12:12:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6F4438D0001 for ; Wed, 25 Jun 2025 12:12:27 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3CCAE10401D for ; Wed, 25 Jun 2025 16:12:27 +0000 (UTC) X-FDA: 83594415534.01.48887C8 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf23.hostedemail.com (Postfix) with ESMTP id F3DEE14001B for ; Wed, 25 Jun 2025 16:12:24 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DoYgwZ5a; spf=pass (imf23.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750867945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=93IIFMtpjHWXbtApOQk2PZA6oepCE6RBk5slFq5Hdik=; b=Hseyd0VUZfpGrcheOdncndQNi0dnK+Yv2Eqs/yIlGM8I+0GjRd0k5iCW+Zn/3IAmlHCAVS HK8caYpdXkIgRw1YknDCn4ElCAFCYswSY9cMdZiRHHilU8H4QHfjh68MLUpCYB5RDkcXgT 3RWsr3Q1hoVvYSr4NmPpht324p+yBSE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750867945; a=rsa-sha256; cv=none; b=GF58P/m8tbepEw3Wy92ZSrR6Hy6QJCMy8tsiEjrrWVeVtLvz49nbWipsi9D4mbdVHemwqV A/DvDMA1fsFCnvlo6Lw9h5EoI1zhZTr4+I0/wb1XHxH4pjGclDFvPatvB60V4oShVfWn48 2JQuaAssML/Wc+d6kc8qUasqenw7uYI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DoYgwZ5a; spf=pass (imf23.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-6fadb9a0325so881126d6.2 for ; Wed, 25 Jun 2025 09:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750867944; x=1751472744; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=93IIFMtpjHWXbtApOQk2PZA6oepCE6RBk5slFq5Hdik=; b=DoYgwZ5aQ331bZ281qdGA7cJ9UYmN5pfuMH7jSIP/hbQpcbRlEbNuem6rTJEF72AWz n6cyJ657RA3Ipa61Er54tvxO6/Ng3bxp863nCHcDuFv/T+1viLQDIvugC+GVxo+kfwvv YLmtDHkAff99oFFKFvM7up6ZCi3BL7GSiYiuKodr5Ml0siBL3mZuXJhaDIY9aJ0L1NRA PxN3TomNDiuSSFYSnkXAmp2ga7IGeu+DOYWTNAZ0e6QJRKm60sxoZwe8Ag5EDTWD9Ke8 Xua7SeSnY7s1un7fXhIrCMC2CpqltSV5kY++oNVnNkmlfs950foCILlariq6BIXfAjIY 9LaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750867944; x=1751472744; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=93IIFMtpjHWXbtApOQk2PZA6oepCE6RBk5slFq5Hdik=; b=XMCA3QaOVNJELKNGvAUYBSDfTwfstt48+060MLiqg0PEDwaoGmZWxP1UhzsBsZWtSh Ci/spluwvwC1MZ7KPXqu46wHiQ6yQDU6ME8F13Nr4KM6jVZYvOOhgky0n7x4JRYSYezC hyvvhpGjWEQTIVYtxzxAOcJ7L+ALIf84VMMGc15CVeFYx+TbQoOyk7KaFwKHQ0HD1adn 7EWnEnQHxcvcRCreU/vbTqUAwJqffkuIhJ2388F7iRszOjaMorFaX2vKmBIXhwsTJSnM qEC7xFSqqpZwuyVWFQF7GeI926qz6yQuP3/H+BhbMH2W6K5tXAqVh0BAf6V27en3+sWh VjOQ== X-Forwarded-Encrypted: i=1; AJvYcCVQnVV5mp02aYWU752XxeQQe4loRKiyLkj+wnC+AHdyhCvgtmYVW/0vcOTfvbhViETNQWdBgT+7oQ==@kvack.org X-Gm-Message-State: AOJu0YylSgrs7pC1zDw+iqPVxfBpSuryIXhvpnkJmgUx6gBzySQ4AWLk qPkbkHZOFHhPh8pZlMTPQEYaQ7RmfV0VOrM/XUn+kHyFYNs1bL1LlJiJ X-Gm-Gg: ASbGncu8+OFOBQBacEEfHWsKBE8LOt0Gf431aw9X0k0KCf8wSqH64SjvPqMrWayWdWY 7EDeKDbKcDuDfI+YMsAYL3xHwx+WX11lknTX8MiIMTxwhxKKgkj0BF2yGV76lD5jFHfDI8S80np O9w6P1q9dVUNi7B9QalytwWQN+0Mbh+ENTn/MdmQ2k28G/GffwsCtsFXmfe5oQdrTUE+cU0zOpu FeWVhQXB1n4nHXOh+Oq1p9Pbq6SHgdONNb4L7LR0SPhcAQkHCdD9jGtsjCIrBflbF7f9Zwobe5p +1H1NbAGtKyKYOLaVtOkvbB/qNSb38fUPColSdKRL0aX8ZmOxcMSe8exJ+p6nUthEg0/6JbjSVe mKdset7aa7zjT4WnS1rqgBy/22LPftYcLs3E+nToW8JnAyY7Oe6u6 X-Google-Smtp-Source: AGHT+IEJ8Gfjo3D5S6gXArHq4VFOC0cXx8BsqNEVWuvhpzm8Kfr/wZ7A/4o9xYdgwaC8RIm9zf0ryQ== X-Received: by 2002:ad4:5d41:0:b0:6fa:ccb6:603d with SMTP id 6a1803df08f44-6fd5ef75c17mr57858596d6.16.1750867943754; Wed, 25 Jun 2025 09:12:23 -0700 (PDT) Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd095956b0sm69563206d6.99.2025.06.25.09.12.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 09:12:23 -0700 (PDT) Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfauth.phl.internal (Postfix) with ESMTP id 883A0F40068; Wed, 25 Jun 2025 12:12:22 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Wed, 25 Jun 2025 12:12:22 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgddvfedvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeeuohhquhhnucfh vghnghcuoegsohhquhhnrdhfvghnghesghhmrghilhdrtghomheqnecuggftrfgrthhtvg hrnhephedugfduffffteeutddvheeuveelvdfhleelieevtdeguefhgeeuveeiudffiedv necuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepsghoqh hunhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqieelvdeghedtieegqddu jeejkeehheehvddqsghoqhhunhdrfhgvnhhgpeepghhmrghilhdrtghomhesfhhigihmvg drnhgrmhgvpdhnsggprhgtphhtthhopeelpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehurhgviihkihesghhmrghilhdrtghomhdprhgtphhtthhopehvihhtrghlhidrfi hoohhlsehkohhnshhulhhkohdrshgvpdhrtghpthhtoheplhhinhhugidqmhhmsehkvhgr tghkrdhorhhgpdhrtghpthhtoheprghkphhmsehlihhnuhigqdhfohhunhgurghtihhonh drohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgv lhdrohhrghdprhgtphhtthhopegurghkrheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoh eprghlihgtvghrhihhlhesghhoohhglhgvrdgtohhmpdhrtghpthhtoheprhhushhtqdhf ohhrqdhlihhnuhigsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepsghoqh hunhesfhhigihmvgdrnhgrmhgv X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Jun 2025 12:12:22 -0400 (EDT) Date: Wed, 25 Jun 2025 09:12:21 -0700 From: Boqun Feng To: Uladzislau Rezki Cc: Vitaly Wool , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Danilo Krummrich , Alice Ryhl , rust-for-linux@vger.kernel.org Subject: Re: [PATCH v3 2/2] rust: support align and NUMA id in allocations Message-ID: References: <20250625062917.3379804-1-vitaly.wool@konsulko.se> <20250625063026.3379921-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: F3DEE14001B X-Stat-Signature: 3afeo6jo1o5dz9369g6gqdrmmpzbcaj9 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750867944-820951 X-HE-Meta: U2FsdGVkX18z/jo7tPlnUsKVUv7rQd5Q455WnG3HI5V8At2XYzua7YSA1mZQGog8/HZp+5g32DXSEvFL5KugfrCNU06cmHxwUoJeDSkNQZiWNR/sAKTbSQhr8UyRIkjcJxUIcXLskH6vDR5FlqW6ICfVC/MiIK3ggHLpiHXsgcZJWRtE6ROlLdWaNtN/WwMwhrRZqcnCKAbwjrXguXlRw3jmhdE9pKxmubB+4n3MZdb0jaFbUx/fQ7n5TYsmCN97lJlBbOJtM4nZjF9g9ReAqyL/uNNDmY+WYV1V+e6OQ+fyMamDClahDV9ESKL/NI6r1DsHJqz59WIqtCB9Zyf00+jKsuJcJ/g772DPSxRFsraUGpmg4nQhnFpGgC5Ad44DFbqOzPUdRCSiiqkkm8MuJPjJWhFusoq+ntwqzW8nbwUbhow0DeTMhUSpvQd8GqLTIt21OcJ0GXsu16S5y7urlwZKL5/4PI6aNx16A0n4ByXFuGviqq8IGXFvBYf7VpnPOPh1a/UvyFvCLkHHZU8QihdpyvQd7ni/Jty30D1H5HkGkdKcPWsR5nOBdnB2emN5FAeB+/iRVzTn1MkLRNB9qB/wSvZJodAxmUUyO+DXJnkKVMtUL3NGS0LvlZbb6aAVX7NwLHZbjgqGFCxKH6wvpVNeiq8T00TrcB8MeMvT81y7AY64RZhxPm+TcC3z6zesPMaJ1j9iaa1JOuebrMUq+xVkVa/DJ4DHsXV9b559+8ZBfGh2rW/57BWJ7Dg9MkafHR5xUIrV/SVjmmXpxjgrq/V07t9mM4wyB2AtT/3R6bhh+CwURMZ5qvVy/cJ4wxujw+LejsigvIaVZYSsEiFh0qsYP5Jpc/qdH6kmp5VmhmeiQwNlPiblF1W6Wdk/+T2DjQJ7wiXECUbyUImuqwgs+S5BwV52ywrHYkVBRgZ0n90yyR/BQe/tKwT41/xT9/2j27PTrfhZW1LLN6+0oZY ERjD88tF 2wlLTRQJ9wJZU+dPDvavAO0fRlxPG6i2YVjW9hzjgYNrs/HxbywajF2BW78pMUxporfHoVxaD8JCSThISZ3OqPEunD5Ayofwf9l2TbmK2WD+B4gejq0H+tOV2aobTLZi4XzhckNlykecvis03nQ3XaAwq0VBhAeAWtjY3KRPzuRtoGUQsAiOsFH0DvQWPxRJlOwowFcn8YHT/xx9+Cc8QnpzcygTVq/xMpLwhrXymyQ1Q+BxN2gm76/ZMtHPKY1V6XV4aoh0lhA3NKwgK2WDZHubqyYQBO0Ws/NSTQLjtsY73WZ446+mZk0qcYuAfScFykmtUh6Srgnyo6nniadgdpQF0S4SOxsPFb+p4uXGeTXGQwAhJlJgKCFQiKmneo0dCehiEkr3kYYsOqQEmgv/YBCFcpoCaTNUkTocbig5/sk0/xV6J/EKEU37xamvy69I47Ry1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 06:07:06PM +0200, Uladzislau Rezki wrote: > On Wed, Jun 25, 2025 at 06:12:52AM -0700, Boqun Feng wrote: > > On Wed, Jun 25, 2025 at 08:30:26AM +0200, Vitaly Wool wrote: > > [...] > > > @@ -151,16 +159,11 @@ unsafe fn realloc( > > > layout: Layout, > > > old_layout: Layout, > > > flags: Flags, > > > + nid: Option, > > > ) -> Result, AllocError> { > > > - // TODO: Support alignments larger than PAGE_SIZE. > > > > Thanks a lot for doing this! While you're at it, maybe we can add a few > > tests for various alignments of allocation? I'm thinking: > > > > #[repr(align(65536)] > > pub struct Test64k { > > a: i32 > > } > > > > #[kunit_tests(rust_vbox)] > > mod tests { > > #[test] > > fn large_allocation() -> Result { > > // Better use `new_uninit()` to avoid allocation on the stack. > > let x = VBox::::new_uninit(...)?; > > > > assert!(x.as_ptr().addr() & (kernel::sizes::SZ_64K - 1) == 0); > > } > > } > > > > Thoughts? > > > > Regards, > > Boqun > > > > > - if layout.align() > bindings::PAGE_SIZE { > > > - pr_warn!("Vmalloc does not support alignments larger than PAGE_SIZE yet.\n"); > > > - return Err(AllocError); > > > - } > > > - > > > // SAFETY: If not `None`, `ptr` is guaranteed to point to valid memory, which was previously > > > // allocated with this `Allocator`. > > > - unsafe { ReallocFunc::VREALLOC.call(ptr, layout, old_layout, flags) } > > > + unsafe { ReallocFunc::VREALLOC.call(ptr, layout, old_layout, flags, nid) } > > > } > > > } > > > > > [...] > > > At least we are lacking of vrealloc() exercising in the vmalloc-test suite. > I am not sure it makes a lot of sense to add a kunit test on top of rust-wrapper > around vrealloc(). > > From my side, i will add the test case to the test_vmalloc.c test-suite. > Thanks! But we will need these tests from Rust side anyway, to test 1) whether the Rust wrapper does the right thing, and 2) whether any C change cause the behavior changes on the API that Rust wrapper rely on. Regards, Boqun > -- > Uladzislau Rezki