From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2200C7EE2A for ; Wed, 25 Jun 2025 16:07:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63C466B00C7; Wed, 25 Jun 2025 12:07:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EB906B00C8; Wed, 25 Jun 2025 12:07:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DAF56B00C9; Wed, 25 Jun 2025 12:07:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3BFA46B00C7 for ; Wed, 25 Jun 2025 12:07:15 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 01EDD80593 for ; Wed, 25 Jun 2025 16:07:14 +0000 (UTC) X-FDA: 83594402430.14.56A6CAA Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf02.hostedemail.com (Postfix) with ESMTP id E7F178000B for ; Wed, 25 Jun 2025 16:07:12 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PQXvnrr+; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750867633; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XnWE/FYRGsLECYLN3ie8Uc/sL/GBMoEIignppjfaTso=; b=Ml+JbPRTRQ3XSGj5yk2V2f2BKhivQss1LlxOhrk8rRmvqOAsplgRydze1dwKBzFxwsqToo /XEK0tyyILk+ooVRtqgpFDXQTeqsNq0Po58EIiheg//R4RzlT+P8KEr193Ox3GeFcN+IZM QsGDTeiDQ8gHPjYQ/B83xcuTm/JDllM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750867633; a=rsa-sha256; cv=none; b=tXmW3jgpkhCL6QxhGp9+pGTrfU6RNcS0Ni16DkovDRowV6+860GUXEWvd9ncBRtb6EzaZB mJ56FCYZpXcfynO85+y6qsivfZbumfDJonRrh6NuFun7g3gpU6vOqO+El75HEakq56XROY C6v20qv7wfA6Q6i1FykELoPaf8BVucE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PQXvnrr+; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-553ba7f11cbso18457e87.1 for ; Wed, 25 Jun 2025 09:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750867631; x=1751472431; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=XnWE/FYRGsLECYLN3ie8Uc/sL/GBMoEIignppjfaTso=; b=PQXvnrr+47rUc761WtI6CTk2jRdO7CsLw+t3s1UtzaMMmWutuNYX+1cIWAh/9oaQAm 3kWzq9wbl12y6jkJao9a+s8mzJvqty/0ORKlFtPSXcCRpFq5wBeyvrgDFsplWLg85Mpy WdfHLHQRHE68cWM4DdlxCOsB1Te2xA2/gJTnYvysbThKZOsbL8iWMlL1UAGlj5tgyDSe bDLBOgtzE5siX8QHGVGQU3flD7vWFEp3kikJNyFopDYEssQKuGjTLAiaIQqisOplZtxI AgjL5aGJGGTMJ+HKlFaTZP00JUcOiQIMfe4yPvusdaSo9CiDxx6tPdf1muMBntlWaQbA 8tbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750867631; x=1751472431; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XnWE/FYRGsLECYLN3ie8Uc/sL/GBMoEIignppjfaTso=; b=DY7sgaQ4yiTccfgTlWs6p+oY1twmuFlbd7K4sw1t7VZoKX038pEHtj+ZkedkbpxEUj OUTr+o4wSVoURcQmLv6GLckJcFD1jWWkmIoQ9N1HYC3j6i4zqPFJTfwbJ/MOh4IBL7Dr Z3Jo5MUISOEiEIVKpTTK7+vk8htvITc/McLKtCooMGLu/nRafNQE87JinFvh8e3VVFPr GogMam1dlimIPu2U0v3nHAdWFH4MYIcysjT/GUTb8lgoHFch4Jnpxry6pTYbSkfLSmfl Od/BxdRqnChG8padPFCkQ4XP2SrOcweKz0T77ZUBamNxCQAi5j+CtGFxltlxXTplIYKO pDxQ== X-Forwarded-Encrypted: i=1; AJvYcCXZ380P+zCxwa79WAKLhY4lT2wkN7Wj3S90OcPjss0voxFD5zXaFEwwzD9Ed2xK6xsL0XNONxdUVw==@kvack.org X-Gm-Message-State: AOJu0YzYFcBJkV1V2s8rs4Iz7L2iioU6PB1NsNKBn48qOpHIJZ+W1W2X zUtu0BIk9witlkCOdcVFoFV8kEdBt6gwS7sjkGZp8h/z+5XKSzLtuB6w X-Gm-Gg: ASbGncv8dGrPMkgnIvTuV0GH6GiocbiS5oED7B5xVBK2/8JitUKlc4z4FKmB5t41iYQ 6DqI4gQBfLKnLCCidpoeiqeiRpNcFPGoioUl92NmHoy5dUmvLoYsIFmg4NW8pBGAtgSttLjltAP bVJbn3b57y7HFtQrmg62X9kmX/bwQ5h/lObjYEPHsEBUzn9wHuiYn/j/5vPkVI7kuD+U1i5catx MI7rOxL6+W7MdcqLlxxTa/dK8a97cmASmMRdIW5AbzwJhv30gC1Q+vxclTK40A5JMvCHZiZIsJt GkcdGJWSii9qt0bXxMAZ3aETGkzk68k4NXtebP3qwlEHphDL+AmTptiVH0tUnG/eOT6OpbOD4Vu vpeUvNnZvklE= X-Google-Smtp-Source: AGHT+IEYvc5wWLFX8kKqfnv/F8nbC1J+8svLCQtKEajYUFBBNISOkFSCXAGsLG39dPthenMDHeCXMg== X-Received: by 2002:a05:6512:24c2:20b0:553:ad48:3f2b with SMTP id 2adb3069b0e04-554fdcd719fmr842724e87.2.1750867630481; Wed, 25 Jun 2025 09:07:10 -0700 (PDT) Received: from pc636 (host-95-203-1-180.mobileonline.telia.com. [95.203.1.180]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553ea450edfsm1867766e87.102.2025.06.25.09.07.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 09:07:09 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 25 Jun 2025 18:07:06 +0200 To: Boqun Feng Cc: Vitaly Wool , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Danilo Krummrich , Alice Ryhl , rust-for-linux@vger.kernel.org Subject: Re: [PATCH v3 2/2] rust: support align and NUMA id in allocations Message-ID: References: <20250625062917.3379804-1-vitaly.wool@konsulko.se> <20250625063026.3379921-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E7F178000B X-Stat-Signature: tra7hta8u9byrsptig6brq9gtmnw7iq9 X-Rspam-User: X-HE-Tag: 1750867632-242018 X-HE-Meta: U2FsdGVkX1/Gm/AWeLUTA22vpYJGhL6I25+t2Gxl46BKqs4Pyh5SjyQC4iigSSjp3IrFB8jkculVwVDJduGoN6hClLzkucsmLX3YDHtMZSpW3WBeSidJyccswHr4EuFVAf27HWN6qqukIZwkjjCPbtc7dsRRg8lSnl/XQ46kBrQX/zw/tG+nXLQI1A249pQGWSqe23aiA49cQXSpEkgYM3XrrXUVYMsmDdHH3ON57Z/N/bI5OR17gu5Lv7Mv1iNuhI+Ssu2Vwcwn13SGnoGIHNRz03FtVc/yU/WQ748qx3LU58lOl/5mNlltY10qzeS8ESbL32wNONS9+kbitYegbWeicemZ8HdZmiGSDzWilWZgtZCMTdXWDmK31GB4IgMNzuzefkXu9WeOBe7I9lSWgIq5CPsKFb40tZ4hP4BhYNStfUmDvxixTeWdJnBKm2FmuM+/maaVq7wmtVtJgbuvhVjBR53fu0lN/jzyht8tyV72NgZET+nWUiEQQw2F11ywCw4e6b7u1ppqaGlQ4K2EGVj7OZ/byj+q2PgoZS92w842z17dqDK9YYMTECK77InKOh82U4MLiUvEQcdURY4wlloGaDLJGdlBxDxmRoQm1+C5RCbEqphfC3KrYh67yJvQ4m5hziu99KSFfryF0p6EvItoJQZC+3idztECXGKikM0qhCXcds2qcC2tjMfGq7VTXmh2sJWzJKktAkrFenLB5YhLG8VKTB/AgO0KAdRYYjqtv3AE90iXTzbY4KgrrqbMB/uXRLp1TvsG5JYced27+PjBdi5OJ947nLThWlG5yOGXF7s2cXmhpWYWKEdWDPJTpXiUH4EXULO2T6UABYtQBTKpRnLZsbfPVufaec/KHNxqg+/pUbnRuJzKPLuhoW6iP27zIdYuqkEaUCEOuDOSaMU99d9RszEFvxW3lo55r0hU1I4g36BZY78aOdFY4C+IqTwcui5ewwqZI/xHMVG jwzOV+7u NeMwOAKAUiQ7hvCdV9LvdWiX7kO6jrYSJbFxR6xlXOBYKdQaIwt1nTgwvYH8Q3DwrzpvI9C2//3iJrc0262pq54cjQGEM6OuErAnIEHVECTmazCdklAWw3uBgek5VZmA2I2v0I48VVQxIxL3Tlp8K7rt0+iO8Tn+nLCHid+U97QwjDMoMfMWowA1CCXmpFbP0hx7dx3+L96BXF+U+lFs5jwBarC5kLgMN6zkS7vO/AneBsyg6xs/hoiaDlEvxWohr2NZOIAzrhr3E8QL1JuS78Wwk0U84mTpXDkymPmUNzOddgSkZom7ZlovEDOib3uZa9/WQAIkNeGjhE/OvAZMbUdnWIJq/Ux+36+iEOk7+YjAQ+sRIsdR6uqVRvPeQ729q9FxXpxfC/dQkbTD8pQZ5zoTtsdsZduMoX/MZmCBwkCg0R9uBbivjZQGDjLMd/iu5OAp8HTukqJf8LxHfnQyMHQt7Fw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 06:12:52AM -0700, Boqun Feng wrote: > On Wed, Jun 25, 2025 at 08:30:26AM +0200, Vitaly Wool wrote: > [...] > > @@ -151,16 +159,11 @@ unsafe fn realloc( > > layout: Layout, > > old_layout: Layout, > > flags: Flags, > > + nid: Option, > > ) -> Result, AllocError> { > > - // TODO: Support alignments larger than PAGE_SIZE. > > Thanks a lot for doing this! While you're at it, maybe we can add a few > tests for various alignments of allocation? I'm thinking: > > #[repr(align(65536)] > pub struct Test64k { > a: i32 > } > > #[kunit_tests(rust_vbox)] > mod tests { > #[test] > fn large_allocation() -> Result { > // Better use `new_uninit()` to avoid allocation on the stack. > let x = VBox::::new_uninit(...)?; > > assert!(x.as_ptr().addr() & (kernel::sizes::SZ_64K - 1) == 0); > } > } > > Thoughts? > > Regards, > Boqun > > > - if layout.align() > bindings::PAGE_SIZE { > > - pr_warn!("Vmalloc does not support alignments larger than PAGE_SIZE yet.\n"); > > - return Err(AllocError); > > - } > > - > > // SAFETY: If not `None`, `ptr` is guaranteed to point to valid memory, which was previously > > // allocated with this `Allocator`. > > - unsafe { ReallocFunc::VREALLOC.call(ptr, layout, old_layout, flags) } > > + unsafe { ReallocFunc::VREALLOC.call(ptr, layout, old_layout, flags, nid) } > > } > > } > > > [...] > At least we are lacking of vrealloc() exercising in the vmalloc-test suite. I am not sure it makes a lot of sense to add a kunit test on top of rust-wrapper around vrealloc(). >From my side, i will add the test case to the test_vmalloc.c test-suite. -- Uladzislau Rezki