From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42EFCC7115C for ; Wed, 25 Jun 2025 08:15:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEF076B0088; Wed, 25 Jun 2025 04:15:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA0936B0092; Wed, 25 Jun 2025 04:15:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C40A86B0096; Wed, 25 Jun 2025 04:15:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AACB86B0088 for ; Wed, 25 Jun 2025 04:15:29 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 54B021619D1 for ; Wed, 25 Jun 2025 08:15:29 +0000 (UTC) X-FDA: 83593213578.16.B2017A1 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf14.hostedemail.com (Postfix) with ESMTP id EB632100004 for ; Wed, 25 Jun 2025 08:15:26 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ugXBAMjf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OR3gvBYA; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ugXBAMjf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OR3gvBYA; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750839327; a=rsa-sha256; cv=none; b=fkqkRARjkhnhDUVCm1qm3Kbx277du6nVxsJ9k3zUqp69I0PJ47Pcu0YntNi9FDapW4jp/G M/Ou2dXPVh3BVqfo1F7bUydtK9ovge9I9E7bLVn1q01upru+I4VC0UCVSadcVs7bowPA5S 2DNUKaxXfBfoYx6FxwGVSzH5Ic5UZgM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ugXBAMjf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OR3gvBYA; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ugXBAMjf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OR3gvBYA; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750839327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6BqRuDfyym3GMLPKIzCqnQ5WuIIDbXNkO7EJ8+AjpXY=; b=wXqWS/tnaJj1DJp13OCvTtsZGto/WjSxZAK2Jv2OD6L97jICUC4kRWj6dtltkCU3O/UPrY 06HIpByoIjFExVZEG5/hTwpPZN2WdGW6OvZ3wTc0YEmKaQ5MHVluyDN2+7/4+7W4i+epow JAM19P0uv1gBGeScHJxaertUTkvgl1s= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2B4CD1F441; Wed, 25 Jun 2025 08:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750839325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6BqRuDfyym3GMLPKIzCqnQ5WuIIDbXNkO7EJ8+AjpXY=; b=ugXBAMjf1CuR3YYZVcVdgSE+DpTi3ti3pqBby1QyvaTXUU6iozh/xxrTBb3XI7NTH4ZSLB hypsOfNQXPAY6zIFKsSKbggW+4ASPy+2+Mvpc1yz0rcmZBlfktxkuRB8iUnDdIolQRJBR/ lFSAot5RjOw4+1RDSPCbOKindeoQzPw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750839325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6BqRuDfyym3GMLPKIzCqnQ5WuIIDbXNkO7EJ8+AjpXY=; b=OR3gvBYAwe31U8phnHX5Z9yJtmLm4I5pEFZTjXPl9dhBMToX2wWxVDYYGGji59QL8pDU/u mbggJRf4r9X2Y5DA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750839325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6BqRuDfyym3GMLPKIzCqnQ5WuIIDbXNkO7EJ8+AjpXY=; b=ugXBAMjf1CuR3YYZVcVdgSE+DpTi3ti3pqBby1QyvaTXUU6iozh/xxrTBb3XI7NTH4ZSLB hypsOfNQXPAY6zIFKsSKbggW+4ASPy+2+Mvpc1yz0rcmZBlfktxkuRB8iUnDdIolQRJBR/ lFSAot5RjOw4+1RDSPCbOKindeoQzPw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750839325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6BqRuDfyym3GMLPKIzCqnQ5WuIIDbXNkO7EJ8+AjpXY=; b=OR3gvBYAwe31U8phnHX5Z9yJtmLm4I5pEFZTjXPl9dhBMToX2wWxVDYYGGji59QL8pDU/u mbggJRf4r9X2Y5DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AD9EC13301; Wed, 25 Jun 2025 08:15:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id u4CpJxuwW2iOGQAAD6G6ig (envelope-from ); Wed, 25 Jun 2025 08:15:23 +0000 Date: Wed, 25 Jun 2025 10:15:22 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato Subject: Re: [PATCH RFC 06/14] mm/huge_memory: support huge zero folio in vmf_insert_folio_pmd() Message-ID: References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-7-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250617154345.2494405-7-david@redhat.com> X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: hj43c7xqwsyxq8fwetkbee94ggts6ger X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EB632100004 X-HE-Tag: 1750839326-129209 X-HE-Meta: U2FsdGVkX18nlOrCqxbybb5tduhR/WoRjRWj05rRRchyFKrzuybA98EpOc2GsW28JJfq/doJLHH9PAbkN0Ph2mZWdLNYW/0SCJ5sFD4fbDkdAToxgV7YhphmzTVfsTueE1naPGO5ZD9mdDhUfGYWpt1nlEOy8zV/heDxX4ofbGiMWOA3OEXlDYuK6YX2z6cECXe2ZnhB+nKsA+ZZXKzvS+brarRzZ2if0m0diSZ4/z9JicQGAkycEc40H4KY82SSMbhVvwPVKsBNRb57UKth3CU9oL/u0MECIyB1IdewPvfcFDGDEpNJ5+j1soljgTgiJAuQMUwMKt6SqcUVIjODQBvX5YxJSKQFekCBUc69/Sc1QyHj9F09gumTbIta+v0CCAOZwENwTjdL4jSAynaNr41vToQUMWhYIpstijpP4fLTMSnEvsOc80RL+TSBzDC5/VqWS9QZGDYLM1IwA5xHUJQl4+7kuVjmy5FTujY10emtEgAGLA1AvGBjIL8mzAc1DCvSEg3ZzbW0Xt0F+g/ZXSSefU5fFCA6E0/Wc5WNiibq1C8VOQJ2vSteg8YlozS0TRs1JvqOD6w4SPZIZHG7hstD98hcAbB6c3IWc2OftvptPBTze16cfDdxPR3Uq77L6oYUCXCC1iMW3LTbOYmQAi6v9yAPJNAxQQcULTwny+6tbBjdSBotRMZVUdUuKOGRGHV6hTO7oHPxIVMxw+s3XxCNq9a/AAKfWyUvOEDFsSyr3uvVaYai5sbMmAKFatp9z09rEMMvF+HuBC1mR1v17rr340RSF3qQkEMHz8nyXGKviDt2OvF7i6UpNpez9RhFKAkCnCejg4zFCogh77Kbl/3zK2OOZVi8hlG3SrJRXH77wPIvkeFzm2XJ/+iiaUswaLxHBj5kCH8cDs+tKQuA7qRYxLmmk+6SLhwBIFKaWyZ8j8LeR7T+xJexY/6YUhb3qasqeoLCKNXi2yJXFNY 3zQ5ZLsZ eWPYtR4o49iirfrnsMbKImtsuzIVQS93sadcty9MYZolVv1a/JjRZtsaE+eG/ZzzvXTrY1pOfm/OmU5NwN9SCpFVAxHFN6K+rDn58GQ3ESoIs9UaVu4ZJyEaXNr4KIELwklhxRa7qH/9484K5fQIiUs7k32mLTYz/QDr7MBoIL8/oOz4Q/NCuosEIA7NEkRb7DL/FsUKCZgruaTgNn2kmrstd+rknmOneQbAoL+56UEfrWHCZRh5F0rbwZRSKswfEcu6wkFbzVQBMtm+a6qCFHAg9i8WJdzoyVOfaadAP+y/EusveeWQJYVLMijKfz3XbwV5iSzJIje9lLFQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 05:43:37PM +0200, David Hildenbrand wrote: > Just like we do for vmf_insert_page_mkwrite() -> ... -> > insert_page_into_pte_locked(), support the huge zero folio. > > Signed-off-by: David Hildenbrand insert_page_into_pte_locked() creates a special pte in case it finds the zero folio while insert_pmd() doesn't. I know that we didn't want to create special mappings for normal refcount folios but this seems inconsistent? I'm pretty sure there's a reason but could you elaborate on that? > --- > mm/huge_memory.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 1ea23900b5adb..92400f3baa9ff 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1418,9 +1418,11 @@ static vm_fault_t insert_pmd(struct vm_area_struct *vma, unsigned long addr, > if (fop.is_folio) { > entry = folio_mk_pmd(fop.folio, vma->vm_page_prot); > > - folio_get(fop.folio); > - folio_add_file_rmap_pmd(fop.folio, &fop.folio->page, vma); > - add_mm_counter(mm, mm_counter_file(fop.folio), HPAGE_PMD_NR); > + if (!is_huge_zero_folio(fop.folio)) { > + folio_get(fop.folio); > + folio_add_file_rmap_pmd(fop.folio, &fop.folio->page, vma); > + add_mm_counter(mm, mm_counter_file(fop.folio), HPAGE_PMD_NR); > + } > } else { > entry = pmd_mkhuge(pfn_pmd(fop.pfn, prot)); > entry = pmd_mkspecial(entry); > -- > 2.49.0 > > -- Oscar Salvador SUSE Labs