From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B478C77B7C for ; Wed, 25 Jun 2025 07:55:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A4FB8D0006; Wed, 25 Jun 2025 03:55:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 255408D0001; Wed, 25 Jun 2025 03:55:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1446C8D0006; Wed, 25 Jun 2025 03:55:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F335A8D0001 for ; Wed, 25 Jun 2025 03:55:35 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7E9B5BF74B for ; Wed, 25 Jun 2025 07:55:35 +0000 (UTC) X-FDA: 83593163430.09.248B5B8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id 5910D160007 for ; Wed, 25 Jun 2025 07:55:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=R5wIjtJC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=J2dZhp5t; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CDSxgEzK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="wBMuvC/o"; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750838133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XWM6hseW4eoKZZAbk3Im6Bzz3XY09qGq4SXJ9GVOPfk=; b=AoqnToQ5jj3psiDUfTRPHMlWFr5aU3/UQwO8zVpVHP1pzg3zTWnM5PPZepg0uke4lvoquO TL+Xpg9CbI+5nO0jpY/pO5S1jx577BYEgziM+ocR/poVJ0F5N8Kbe/oa9d9Kg4vCMxmavu 4p3ertjOusOcLuns/1EhdcxCpmogLY0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=R5wIjtJC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=J2dZhp5t; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CDSxgEzK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="wBMuvC/o"; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750838133; a=rsa-sha256; cv=none; b=DtfSCyYvFw5IeRdvzEo5l2wERO6GlmKTP0wPzsiVvOCt/kGtmnzwjbNIlPQiJPSHQrdQyf J6iwphHQzqkbWmoBpmLTLDXrkZ1d4Ioj9Xk67diXr0GTs9NDgTqm3HiRpZ00mSAKTpAJAk xIG5F66krEZUXPyttxwlqbD+XqDw2yQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ED1132118D; Wed, 25 Jun 2025 07:55:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750838132; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XWM6hseW4eoKZZAbk3Im6Bzz3XY09qGq4SXJ9GVOPfk=; b=R5wIjtJCZn1i/1vm/mBuJQHs+s0hkuaOVnLnLaT9RXCW6RE4+MDHcAWOxPiiPWLJgn7w7N uXgdi+nafBJjfEAzHvfm87SbLEan1PGtM7ph7Of001x4Fx9h9upaYaOxJLPKY09i+5dmv2 WSJ8LDp2b0XRSCoHXS+tKNxIAiUU8/w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750838132; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XWM6hseW4eoKZZAbk3Im6Bzz3XY09qGq4SXJ9GVOPfk=; b=J2dZhp5tZ/XnuGQtjxU5BNEasaCrXiNAYOJ/dtx2OHDHuuXqFTPOSfq94RGXAfMzhdgQKT FLUfS0dn03WpX/Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750838131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XWM6hseW4eoKZZAbk3Im6Bzz3XY09qGq4SXJ9GVOPfk=; b=CDSxgEzKPP2x/qWOIVC72xSenHdukkNiDUUHhWDhCmn9JX4R2Vi/y2uR7NNn5CONywZVGF e04B/LcpA4C9WBw8hZNYrH34sWXJmeWq9cCwGhVKYELFi2YJXPW9kCyHLJVa0kLXOLzIGS kDTkvybRoiXgp7ly1sgbUcSihJDaZsg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750838131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XWM6hseW4eoKZZAbk3Im6Bzz3XY09qGq4SXJ9GVOPfk=; b=wBMuvC/o1iuEL3o5PfUUQUDBp4AOyBXEu/z5ji4u8mx2yR4p4SAp+FYyc4PcKSjAlKRcAs R8oVO+hz5WcxosDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7B02313301; Wed, 25 Jun 2025 07:55:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yv9IG3KrW2hUEwAAD6G6ig (envelope-from ); Wed, 25 Jun 2025 07:55:30 +0000 Date: Wed, 25 Jun 2025 09:55:24 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato Subject: Re: [PATCH RFC 01/14] mm/memory: drop highest_memmap_pfn sanity check in vm_normal_page() Message-ID: References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250617154345.2494405-2-david@redhat.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 5910D160007 X-Stat-Signature: t67u8834efhqr4graxcnx6gnx9q4z1dx X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1750838133-239660 X-HE-Meta: U2FsdGVkX18PTQEby4IkPVHt8kSuY6gFKUQq/hDwoBMKXTXyhUs6NwrHnVFWKiCglhvMP3nsjEYFE9wOJklxEk3aZEow7/akIvesX5XTSGe40h/FlQ9DRIX3xERk/pbmgsLz88sbedheH0wNrY65/DBih6BQW+jahu61/iI34UMNcgPEZ+0Oo+No01FlmMaiSioQNE+Ik4YC6c2Hp+5oqPIo6T3rv6Kq1x0+Thq+6hBpe5D0pcQ37VaG3cOZUJuGdNYRmtvnqktle6UrytWjoTwKvalgYpeNVSnZ7hw/aR3DsO+hSEVwN/IoaqNBPAr8SgsHe5LtFjsHpXuESiFmrLo89KEw836KrX0IxhWxTuvu5eXpLkDHpc973O/Y/21caxQcJxItt8v50osgAjjqhvENSgXl94Pl0sIvmLYCqRvb20BeL3raVOpStijilm+fdwRRtaIpiXCGFII+Ax7wRbGGQRfSijeFLpR1jT4CJxs3dT3Yley4jeGlN9XBM6cOY+V9LfXlCgOacURbapgHp0me1dlpdOzw2fTdDRHheKDsKiFtzrirJE/wK96oODMD7iv9sqMWJM1XaVqFdwl00MTgiyChlDDUhcoxYWZCWJR5xz70dW266JtLfsdlQwJE3ZqC7CSZg4/zCXJSpucOukNQYXTF6uyCFGdit9/IcTSPVNlPMOZesnxj9KEpgvZOaSzn3BO3L4vdUICztf4Z2QdcvgxYDMPIXx/ofxt40hi67qCcmNsDnOmIzSyyR7Scwdcdq2NM+FBGywr/FscHM/ATW9Yg5LrlNEBwj3J1B38A8s9kRP+SDc1GNnhMAZKIg17HCoOWnRDGwQ7DJN+l/t7+2dVOOY4lCyo/Xmk6zaub4cgIF9S1opjyF1T49Vc3o4XcsF4UWfFV8aS8SGExrJ22XS2hIQtBy8ReBfLTIIW2u0ixgl2c3KSQEelZe0bi1R6CI29TRN+/m5ZaVqU GISL7cdk uCPyzeQTedyt/6ZBYGe8ILy5sV7Ipy27DP+EA1kmA4meUGoSKFKdTRjeUqBmdaTB5JqZ7ltFFauVBTa5AKojA8D/8V/ZIZEnffZLtm15orcAJDKvjsBoNdKXR7uTzpkDNa3RVQtzzdBRznK3yFDNlwa1n+mXhvN4NxfpMtIumcDQajzJJnXVefjHxyearnKjUu5d7UAmXA+o8APO7KXl8TH02XdFYg2tvov6NwPVytmXhhZW5C8uzz4zd7zeXYbjGY2peFiq4pu69zSfPCfdMcOgnMeCBa43vpPHNzeTWtnzzUHgWq13ughRcNV/I1/OpNR9XIHPEIITpBREwLTuRFAillA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 05:43:32PM +0200, David Hildenbrand wrote: > In 2009, we converted a VM_BUG_ON(!pfn_valid(pfn)) to the current > highest_memmap_pfn sanity check in commit 22b31eec63e5 ("badpage: > vm_normal_page use print_bad_pte"), because highest_memmap_pfn was > readily available. > > Nowadays, this is the last remaining highest_memmap_pfn user, and this > sanity check is not really triggering ... frequently. > > Let's convert it to VM_WARN_ON_ONCE(!pfn_valid(pfn)), so we can > simplify and get rid of highest_memmap_pfn. Checking for > pfn_to_online_page() might be even better, but it would not handle > ZONE_DEVICE properly. > > Do the same in vm_normal_page_pmd(), where we don't even report a > problem at all ... > > What might be better in the future is having a runtime option like > page-table-check to enable such checks dynamically on-demand. Something > for the future. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs