From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B622C77B7C for ; Wed, 25 Jun 2025 07:43:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2187A6B00C2; Wed, 25 Jun 2025 03:43:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EF966B00C3; Wed, 25 Jun 2025 03:43:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DEE06B00C4; Wed, 25 Jun 2025 03:43:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F152F6B00C2 for ; Wed, 25 Jun 2025 03:43:27 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9B65EC191E for ; Wed, 25 Jun 2025 07:43:27 +0000 (UTC) X-FDA: 83593132854.29.839DEE3 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 67FD4C000E for ; Wed, 25 Jun 2025 07:43:25 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=FfSWVFIx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="2Z/DsRZT"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=FfSWVFIx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="2Z/DsRZT"; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750837405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ebHyLuUK14qItIBQuWhot/BcmESBtVunMH4Kh6YCI1Y=; b=BFeqAo93SHU5FBNi5vrJd5grSg0Ku9YuRqrRbc6xhnZr3KQd2z3goWYS+L1M7A9n2gXg6e vhJJttuOuXWI2HYYDbfC0fkXrtXTqHHyHyCaE5rHrZ3tfmN8N8nmF3Xbjqy0ezIcN00fn+ rx5jeGhREMEiVA0pl7yFyUoGSvweOPo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750837405; a=rsa-sha256; cv=none; b=3/rpsNBSRUlvAlKyzSKftaGSfdDXiKJywadAGgSYIDrbMb7O3StBHTNJXt7pW8c6PvyAix JpvkUTGfsuz6EkIADCY67lBGLl8Yl2RARnC68lZpjSCae0duwVZL8En8ng/1XbuowLcDNa W3DSY0mRc9w4qrw7esjS2bTrWDXm+9o= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=FfSWVFIx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="2Z/DsRZT"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=FfSWVFIx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="2Z/DsRZT"; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C7ECE2118D; Wed, 25 Jun 2025 07:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750837403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ebHyLuUK14qItIBQuWhot/BcmESBtVunMH4Kh6YCI1Y=; b=FfSWVFIx62fpcU15mEohvf5Ig24z1aCRrNGa8X3vyNxmv5pCI09VY2AxtQEn7Zb2p72gM5 LwjLKmyYzhVQG1r5MYTbZVWp+v8xhOvrDHwBsvoqno6aG2aRp0Jw1GoKL8S2lkO2y8LZrw nYexw9AiOfaSBeORz4X9TP/gnHurlcc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750837403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ebHyLuUK14qItIBQuWhot/BcmESBtVunMH4Kh6YCI1Y=; b=2Z/DsRZTh84cpG9jVAxL0XIMiRRioil1FzUBfjpEoa0BvQ9GlwY+zFLUxJa+EF40zGKTlu YQFN24joKhyGQsAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750837403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ebHyLuUK14qItIBQuWhot/BcmESBtVunMH4Kh6YCI1Y=; b=FfSWVFIx62fpcU15mEohvf5Ig24z1aCRrNGa8X3vyNxmv5pCI09VY2AxtQEn7Zb2p72gM5 LwjLKmyYzhVQG1r5MYTbZVWp+v8xhOvrDHwBsvoqno6aG2aRp0Jw1GoKL8S2lkO2y8LZrw nYexw9AiOfaSBeORz4X9TP/gnHurlcc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750837403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ebHyLuUK14qItIBQuWhot/BcmESBtVunMH4Kh6YCI1Y=; b=2Z/DsRZTh84cpG9jVAxL0XIMiRRioil1FzUBfjpEoa0BvQ9GlwY+zFLUxJa+EF40zGKTlu YQFN24joKhyGQsAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5DB6C13301; Wed, 25 Jun 2025 07:43:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id sw0XFJuoW2h8DwAAD6G6ig (envelope-from ); Wed, 25 Jun 2025 07:43:23 +0000 Date: Wed, 25 Jun 2025 09:43:21 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Muchun Song , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] mm,hugetlb: Rename anon_rmap to new_anon_folio and make it boolean Message-ID: References: <20250620123014.29748-1-osalvador@suse.de> <20250620123014.29748-4-osalvador@suse.de> <7f8ac35d-89f0-41e7-acfb-bcf54991612e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f8ac35d-89f0-41e7-acfb-bcf54991612e@redhat.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 67FD4C000E X-Stat-Signature: ct153ckt3jmbp48pj497wb95iunyjcwr X-Rspam-User: X-HE-Tag: 1750837405-831682 X-HE-Meta: U2FsdGVkX1+/b+e01ul3GbG6yKZDssodl/KopidaaowWDtu++Ne2TbeDUoASvg/ZJVz0AvQdo7wtKgYFr65MIb0soZi/jIHvKLGJ2sOK3gXCkN08mo60L++duRRMlwAUQIKzQUE9tqaT2bBvp5hBp6pltrHTEepWLWi5ja/ZoH+clmXxC07fww0W/EdZvTSJEJv1ZcP3L3vSMbpKjoRphKk5+2gUEw95GX/kE5aFk7mraS7Vlie9gAj5Eambc93c4/U8ibqE4vDXI1/B7LVNqoTjKNYTu2Mql4gLPK6Ge3JmQhkzHtB5rpjiHIUllt99901BG49IkXneZgjHiKCz3vNgFf/7DBwhEjkORM5ich7lQ4fujI7KYt/86P0eqaIU0vOuUVi7ojYsJu1qVvhvKqxG+BfLuxahbPzxTIcVoUzdfwJ4eZaC4gXvKUtXsRrFQnh43XlOvO0UaNE3Xw9zpa0i8/8mTeidXnk0t0KpdgwUt/JUQni+JDYp12jN8ovr7FOXsc3yar/vfqcuvsYLh5ImBRs6QHMuylffYIBTPbxiaiMSFgn+sJObqKwUeG6g7eRHWcEzba7/i3//ihjEMnQUqFO5SeKYUtO/Dpaje6/gNq5ukpoBWeu7TE5YQN0c2l2jvpoPSiRNPbiR7aABYizbbFI6UXR4bMnKDxtry6mj+MJ5u9cr5qNvyFTzbqKMrtROzNbUKMjy3iuNf6wRrO/S4tmOaMAN0gQ1dhEOHEb4Fd4UGJn/BEqFruTMImqyVdd0o1w+OeY9qBw2cOYBoCG1FDQGJ9cERmKtliBlITSWXLLZHjmLEX/2CsV6VDaTZwnF287FbyANCt9DVKkWzvx4F5+hs/p8AjX3U6qA/yAXRxVUdXEdTVXnbSgcdSj/1rNoslYt1iACUUBghLV432LX3ovI9JfY6TNgpcOzNG9qvieNlkOLLavyy6WO2RmEPSyCXcE8SSQ2hKC91k5 /8+UEgFJ n05BAsGYjFbylZ5qcvBCv+3uLDmlu89D5hOqX0qRVsDnY4eeKw8CpXOIvbkUlVFUDKMjP9iRD9CU7h2vpJY4AZBkPhOwP5nnzUC6UfchFpD4duTBQlG1MGxpU94jbB2N56nF3kUUSus45PKuCCDb52W2fWH0AjbahnqwJ5q3kmVtzhkjZhICN5VawiHDYEOwUQhbPZWq9iTU7hl4vPSlmvMxgn25qWOn4lpW90VMkiB82L9mA8pWM0DYxcOyhS5cB4FFwrda/QDgnr0d0fvrzteyCsabWvSGOxwHiZhheR/U/9HBAGUq0ZJFMRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 04:13:17PM +0200, David Hildenbrand wrote: > > - if (new_folio && !new_pagecache_folio) > > + /* We only need to restore reservations for private mappings */ > > + if (new_folio && new_anon_folio) > > Could this be simplified to > > if (new_anon_folio) { Yes, definitely, will do in the next version. -- Oscar Salvador SUSE Labs