From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC760C7115C for ; Wed, 25 Jun 2025 09:20:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 826696B00A2; Wed, 25 Jun 2025 05:20:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D7336B00A3; Wed, 25 Jun 2025 05:20:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C5C06B00AB; Wed, 25 Jun 2025 05:20:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5681D6B00A2 for ; Wed, 25 Jun 2025 05:20:32 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0BD84106C8F for ; Wed, 25 Jun 2025 09:20:32 +0000 (UTC) X-FDA: 83593377504.12.D03AB1E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id DA348C0008 for ; Wed, 25 Jun 2025 09:20:29 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=miKXzUfe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Pp4+T8OW; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=miKXzUfe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Pp4+T8OW; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750843230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4q3oGP7adTB8xOiBgLxnYABFNkmwV9fipjngdpsbJoI=; b=0rpW0r3diFWn0nn9g6SjzgrIyqoncJeVnT2QnKJiQSfjSbK58PRCKTQUk55gNDk77fvaA7 47tVxB3605Y64uGwNQCasNSeJLWV1sepDsYZK8IFtaKcyKNNEk3U4oaWhJ0HOll3JqJd2R qdmWcLd4QPNYm+j6poVmtAWut9RRcDg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750843230; a=rsa-sha256; cv=none; b=PQl9RNL49ZN62wVl38YuwTBD4S+G274Q3AoNHSmZ3+DWHDkd4RXl6tmN4tYRqYIQK3oav9 5PfFqkGx0/WMkQj1DksXChtyfJ4Fvf1uKdgV+nMhpaJjehRrnr6kW9LT4FSMTq+5T1RshW AZblZZeqAKDcPOEObMH2JuOFew13YLk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=miKXzUfe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Pp4+T8OW; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=miKXzUfe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Pp4+T8OW; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7590B21175; Wed, 25 Jun 2025 09:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750843228; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4q3oGP7adTB8xOiBgLxnYABFNkmwV9fipjngdpsbJoI=; b=miKXzUfeGl2pjydsa10CWxnBe2+CHlKnhDyCPKT646v6UehiSg9+biAVtawaFBQJo8aQin cdgi38gDEtnz6+PbEP83t/UT9CgHsh9WL3l6nmLJiY4thRTvACpfvA99l3pGdRz6liynY9 qTjReKMPsEMjCSHjFPlG77NrYjPdvXQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750843228; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4q3oGP7adTB8xOiBgLxnYABFNkmwV9fipjngdpsbJoI=; b=Pp4+T8OWBB+ZZNZMVIItKcc5NnUoHOmitTzyHMdjD/Ru3J27KyA2yro2T4sTGDoOZWuswY vMG6X6WHMBNBodDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750843228; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4q3oGP7adTB8xOiBgLxnYABFNkmwV9fipjngdpsbJoI=; b=miKXzUfeGl2pjydsa10CWxnBe2+CHlKnhDyCPKT646v6UehiSg9+biAVtawaFBQJo8aQin cdgi38gDEtnz6+PbEP83t/UT9CgHsh9WL3l6nmLJiY4thRTvACpfvA99l3pGdRz6liynY9 qTjReKMPsEMjCSHjFPlG77NrYjPdvXQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750843228; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4q3oGP7adTB8xOiBgLxnYABFNkmwV9fipjngdpsbJoI=; b=Pp4+T8OWBB+ZZNZMVIItKcc5NnUoHOmitTzyHMdjD/Ru3J27KyA2yro2T4sTGDoOZWuswY vMG6X6WHMBNBodDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E8C3213485; Wed, 25 Jun 2025 09:20:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9mrjNVq/W2h9MAAAD6G6ig (envelope-from ); Wed, 25 Jun 2025 09:20:26 +0000 Date: Wed, 25 Jun 2025 11:20:21 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato Subject: Re: [PATCH RFC 10/14] mm/memory: factor out common code from vm_normal_page_*() Message-ID: References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-11-david@redhat.com> <1ea2de52-7684-4e27-a8e9-233390f63eeb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ea2de52-7684-4e27-a8e9-233390f63eeb@redhat.com> X-Rspamd-Queue-Id: DA348C0008 X-Stat-Signature: g3hm6wtz8xbrowojdmzhb4jaquscnqcj X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750843229-71942 X-HE-Meta: U2FsdGVkX1/nW2KKN7DzI9K9J4hvhH2M1h7KCJMhpGRNXk0vGXiGHTKgwnxo9nK6pBidSvdxDNNkowVUh14zN86It848xr8ngNudhIMdJin0YaaeQD+LDJRHf0BYAB/LK5SkBll3o3x2Kt9mLTeqdi+Mtj7ZCl3kJPEULvJ/kfF4awysPvyCuNDiQzUp+5J/REi0RMQ54gGEo4aJoNw/UkBoGfBvqLkamVEZgdDZem+F1aLnSaeZ+XJKFxO/tSZGVHEql5DZ5ljZD8tmAkd/Os/vtsSUbPpa8V+scl1+c6zE3BXd1ID81ovlY0MjX77NV0Hcbf8P7sQZ2Wj1xOJDhYog66b6CJ+olYdsbhsf08vQE7bvBuXNZUIQBi9a8yl4rxs5XGP/VpMwDvDW3OWW79xPlf2vE89FKyZutEGzZcxvLIwOlh7tOOYXZ/YcCWQitpbznw1MH72GypMXtTMv3wXkDNeCV3ZYvArbILCQFRXKQHytLo31Hwlz1bcaSpZwJc5eGtVuFFBRe4bjA6UVHa3R6kPrLaq60HI22Ysp15X+mzQztng8yEt6oNpYhHb4T/+K4tycrfTSmS/k+jwLJLQOvuIRadfrwBTsotSCMLbF3qBfr5MzW+6wPXjTR0RPjJTxudKJW+gcq41dhsqFzGB3K+SKb3Yz4gkUhHi1/3GiNOa+CNzSSpxCSw5ffnU1ghB/JwRne2gWn+CdEHcyU2uGxjAn0v58ymOmDpsPf5sWgYcB2j8pWvG7c6rAr8aSMTfjeWilCuDkreWAIInMut0OiIdbArCsj2glUiLQQFAzVJSG4SLqdsuRxkw1ppuSNMJNz/EyTK33HQ8VEBpq9xJRIU9S3DpubpKPUCOOqLifunqnfGdvGbwwvo6gwq21MVoi292/7Cg5Lq7iZVrF51QmtVNP66ALkCOtSEQQ2bYC5HWBixnGUyPaIoivIDDbd4Nz9MAg72I/UWGuJJl FMY5zlNb IFwmOrlKS1UWEzzD2nSnDaR9iLj1F8Wr7MnMXpGP6Z4fHmREqAeTTcvw3aMT2L0q9en77g5MHRNMex8mORA1JtB6w7n92EqeX6W32wt7GmgNjVNbm7D/fZkNUVZ8NDd5xlQyhHAgjQEdehFfcS7UoEV/wFH0ECor/0h6FngG6rIpzUyJC7TNfMw6v2Dr5XEkmgKtgGnWNtBeYY7lIMiBJ9A06zFCcClFJ1cRGnXn6hqiVdrxIXnjdnP1sgzPNnh6el+nn51atBRP4ppLLZ2xUYz+TH7JuvFfWYw6ybSNB3YHwmI7jcORHaG/k8YBD1gvKgQYXqYdHUkoo67WuM2Lp5zaLxg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 10:57:39AM +0200, David Hildenbrand wrote: > I don't think that comment is required anymore -- we do exactly what > vm_normal_page() does + documents, > > What the current users are is not particularly important anymore. > > Or why do you think it would still be important? Maybe the current users are not important, but at least a comment directing to vm_normal_page like "See comment in vm_normal_page". Here, and in vm_normal_page_pud(). Just someone has it clear why we're only checking for X and Y when we find a pte/pmd/pud special. But not really a strong opinion here, just I think that it might be helpful. -- Oscar Salvador SUSE Labs