From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B934C7115C for ; Wed, 25 Jun 2025 06:26:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EF986B00AC; Wed, 25 Jun 2025 02:26:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C7436B00B0; Wed, 25 Jun 2025 02:26:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 703F56B00B3; Wed, 25 Jun 2025 02:26:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 60EF46B00AC for ; Wed, 25 Jun 2025 02:26:21 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0848F1D967D for ; Wed, 25 Jun 2025 06:26:21 +0000 (UTC) X-FDA: 83592938562.28.A126876 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 0A34DC0011 for ; Wed, 25 Jun 2025 06:26:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=S7ZCT2KO ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750832778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3XnnY6mYnsr+cZrq2WIhH2EnyI4e0J3kr1/WKamV2Oc=; b=hvndcFqfzV6MdEgkTOX1+qE9z9y6Ktuc4Oqfuv6x/Suk8aRMs0jZnSnX/F6nejjc8o4UH4 oyn1kCD9BBfTZzrNYLtfWN7z6PJ+4HYtNX+TMgg+pFlm3fDPPvEIfmy0lIx+fLB018fTxs CvKoeLDv291e9LVm5oKUGsjbhdf0YGU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750832778; a=rsa-sha256; cv=none; b=Ui5rkBcw1ONZX+7M1RB39OW88y9qtGjf/mPHi61Byms/2VeFaOy0GZKJxv4iCD/QPLgzu3 WRogioKHlMKM56vlplkF5ix4YMd0gV13w6mai6jn3ccKZKBBandFCFm0pAgSSNjTc25M5b gbUzRyWvhS19KQNdztWYPU5ysh64vh8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=S7ZCT2KO; spf=none (imf22.hostedemail.com: domain of BATV+70981eda85ae58106cd1+7976+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+70981eda85ae58106cd1+7976+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3XnnY6mYnsr+cZrq2WIhH2EnyI4e0J3kr1/WKamV2Oc=; b=S7ZCT2KOF1JLrcr+/vCrqCURxA 23StPBuy1slIcKX1GxPymKkGYWQQieRiGTVpNnYv2b7lbSJcg0/8K+TOD1iZlJZboa3GqrFKzIXYL PTY6BJbsbdPDG1EVBiwEebUlzJgaOIo9uBZr3WrbUgPa1hsXsAl6+l5sy9RwN/YCwxGFxmNLqNryi M7EZlS0z+vmELvnXbD+CV1jAohc9FrreexgIIhsuRHfiPHSBc2M/q7ZKYCAAFnRlMpSJ7K41HiJus pYesNOLCI2AL5K3w6Gmgq8csF4gZJlSRYbaSqQqQyQcbK0yNmiG6UHXaYpNEtr3XO2VBYgTIIJWMF /Cds1dXA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUJaI-00000007ea5-1tFo; Wed, 25 Jun 2025 06:26:14 +0000 Date: Tue, 24 Jun 2025 23:26:14 -0700 From: Christoph Hellwig To: Joanne Koong Cc: Matthew Wilcox , Jeff Layton , Christoph Hellwig , "Darrick J. Wong" , miklos@szeredi.hu, brauner@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, bernd.schubert@fastmail.fm, kernel-team@meta.com, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v1 5/8] iomap: add iomap_writeback_dirty_folio() Message-ID: References: <20250606233803.1421259-1-joannelkoong@gmail.com> <20250606233803.1421259-6-joannelkoong@gmail.com> <20250609171444.GL6156@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 0A34DC0011 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: brqeth438gyr69dfu1uhis3czjty61pb X-HE-Tag: 1750832777-439263 X-HE-Meta: U2FsdGVkX1/LgQytDAeWEYBJ5wowG1Robm7QS6IwYOEsSZuzIyuTTEbvOWxlH8I7MWd5TOnfkmMfFqrFB5RmmJSabNQJnCsjF+xGj66Q5EX/eJFgXZVHZ5K7Utf59qrSKhAIoTJq1oTIAUFG6cVsMt7Atdap5Nurm3Cki25Dqr+nUZJ0/L8wIKQ633RyU4dLDPsibKrEqoKe6KFfMY3HhhQRjXGXCD77b2TGcF5NdboIQPTUCH0MmoJUxXC4lMkebvdQdX9xEmSbhMz2kC2cLFMg3ZejK2+tiwKvQYVouZRksKlp4syG0DztvRc29vlVdsjOyCdOA2+y6GornbQtPTu2RhiwR+dYHZuZ5TZ298wZCj2v1u0g1Ukmak0Jhlk79eTjjoLyI88CR7r6GcPXi5ztn3jheeVm7dM4UC2guu5/pSkWtfJY95kYszn22kR6DOeYlGfE9Yk+/qlPemGKTB34MOsVLg9UqvDexjadrHz8V6TrLeuaYBVuaPdXwtXkK+TnrKafGNnd43NUprEIbC/MeItemCcrjSlTZDC2jWt1+fWwg3zzA4qqM1braGCk2P2ySb8qO1z/lpIsvUn1VgHCkTzfqL3RDEKzNOGgKZ1LPxox3CAHdnEIgqynwTQaju5/Q3gH+1Ike3PxpUVAoIpQPRp/kG5mkn/n1GI/AwGFIVLHmXK7SGAyhSB4VoORNl0fbkxgWTUof7umkjIiDSpzZ1HQ6VPfliJ9bc+1pmu712U52CNYBf7RRkxUtcVgdt7TTu14g168e+0la+PhkKS3E3AGnGWzlmMGBt4cVuJQWcNp/FMnoteNeb6SDEYhPAWOv6ejvcWXxjmFNvvgZ4kMCLVvpP7Gm545DZbQrYKhXXvasmLDapb3kjhOwuLvIePedzMCPeDw9Z6KzYHBSo2ESwGsuzj3sZuVvfY4Q75nGMxVY5RFME+S5p7fu97AYO4CAZn8Pj24M568OzJ JzVTFG0T eDnaMQlUhXYSYhlSzYA2GyizJ1lstGbZXPRp00dFY4R7D+4dolNZx//g2U+bfpRSr00rBeZeh60/nXVRPAC7r+2M0chIKt3JPv2vtJaa8uonS/sReqOfi4F+O6hmUuPa534MpQp1nNwn+vmqJGRx9HlUD1HJtDFaCol3G1CDwBKWavdfxVkBm8+Mck2448zCIYoEWRYWsaUJ3+FiVuWyisIf2jKCbC2fkrrCizKlaSyxlW40/BjLtElrhLL1cvMzmhzwwLzp1XyXqC0g+kAdZbP0QAUs0thEEue8rhlI9APcAwACTakZWNmx4fOFp/ylspmXWVJIugGS4hK+2dmbs7LvNhctMXp+UbNuQBBy8MZgqJlXA8ytOCHO7QpqUty2K55pBafawdUup9deIp08l1IqDSdkh1Ef2yjfLE0dT1AZH4jiaDIgB7991qP52KcTaG5cm39kiLpJmfDdPzEgEUIZmveo4Ms6tnF21fcJhs7ZIYaPEYKkfj4wJQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 24, 2025 at 10:26:01PM -0700, Joanne Koong wrote: > > The question is whether this is acceptable for all the filesystem > > which implement ->launder_folio today. Because we could just move the > > folio_test_dirty() to after the folio_lock() and remove all the testing > > of folio dirtiness from individual filesystems. > > Or could the filesystems that implement ->launder_folio (from what I > see, there's only 4: fuse, nfs, btrfs, and orangefs) just move that > logic into their .release_folio implementation? I don't see why not. > In folio_unmap_invalidate(), we call: Without even looking into the details from the iomap POV that basically doesn't matter. You'd still need the write back a single locked folio interface, which adds API surface, and because it only writes a single folio at a time is rather inefficient. Not a deal breaker because the current version look ok, but it would still be preferable to not have an extra magic interface for it.