From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D04AC7115C for ; Wed, 25 Jun 2025 08:38:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C94876B00A8; Wed, 25 Jun 2025 04:38:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C42DC6B00A9; Wed, 25 Jun 2025 04:38:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE3EE6B00AB; Wed, 25 Jun 2025 04:38:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 97E096B00A8 for ; Wed, 25 Jun 2025 04:38:05 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 406F4C03D2 for ; Wed, 25 Jun 2025 08:38:05 +0000 (UTC) X-FDA: 83593270530.15.2EDD0A2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id 18DC6C0004 for ; Wed, 25 Jun 2025 08:38:02 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OLYJZMAt; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OMwI9gql; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OLYJZMAt; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OMwI9gql; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750840683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HcMPAZexUY6msdIP55rf1vEz6oztuzPcCv+1Pw4Atj4=; b=g5/T/5/nj4D3oioPODxlNfw9JCQjMb1R+M5mgxz+nfM/4YKUCX+KyfMOJT8gJ6sVPcYSdz AMQGxDEh2LJ8V7gO7Yf68QYKEZLXASmrh4Nfdzeu5FynV1dRUPkWdZ48JES2K0w6VW4ioX wRWygQxSUoAzFvLoSCyg5HMU9KY1Vc4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OLYJZMAt; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OMwI9gql; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OLYJZMAt; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OMwI9gql; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750840683; a=rsa-sha256; cv=none; b=Qr28Riecd3Zw35Iwe1Wog0fXUpm6BMWqRrWSYGGQQEHUgJg9Z4+yA05uyJFFJ9E9edaj8s RrSURsCzXwhQHNPjbFAKuQdShbWIfzykbtX7pWvX4QZt+t74bNH/RK/E8i8hfWDhovyd6q e9m51xfn2vjU/OknKzuzxjblfisa5uk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9131C21225; Wed, 25 Jun 2025 08:38:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750840681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HcMPAZexUY6msdIP55rf1vEz6oztuzPcCv+1Pw4Atj4=; b=OLYJZMAtygudvD/CIE0cZOWTk4461lHZrUEj0dGC2I73EjfPfHwnJVJ977L8C3VOZ4I/E5 SSP3u3KALqeCXon9fk3gOxk1u0ZyINCSk0tYrnSP8uEU94+610t/koqQMPhkliDTI3qiqZ VTUjhBWy9ry6fWFKTwEVLSbCYC5m63Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750840681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HcMPAZexUY6msdIP55rf1vEz6oztuzPcCv+1Pw4Atj4=; b=OMwI9gqlawaozmCo7wuNr/HhbhsxL2uRuAVg5AQOYBnUHVku7VmAoHYifwH+OThLFI+5I/ S0kxmlSauUjnzpBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750840681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HcMPAZexUY6msdIP55rf1vEz6oztuzPcCv+1Pw4Atj4=; b=OLYJZMAtygudvD/CIE0cZOWTk4461lHZrUEj0dGC2I73EjfPfHwnJVJ977L8C3VOZ4I/E5 SSP3u3KALqeCXon9fk3gOxk1u0ZyINCSk0tYrnSP8uEU94+610t/koqQMPhkliDTI3qiqZ VTUjhBWy9ry6fWFKTwEVLSbCYC5m63Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750840681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HcMPAZexUY6msdIP55rf1vEz6oztuzPcCv+1Pw4Atj4=; b=OMwI9gqlawaozmCo7wuNr/HhbhsxL2uRuAVg5AQOYBnUHVku7VmAoHYifwH+OThLFI+5I/ S0kxmlSauUjnzpBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0A4D913485; Wed, 25 Jun 2025 08:37:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YZNuO2e1W2iWIQAAD6G6ig (envelope-from ); Wed, 25 Jun 2025 08:37:59 +0000 Date: Wed, 25 Jun 2025 10:37:58 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato Subject: Re: [PATCH RFC 09/14] mm/memory: introduce is_huge_zero_pfn() and use it in vm_normal_page_pmd() Message-ID: References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-10-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250617154345.2494405-10-david@redhat.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 18DC6C0004 X-Stat-Signature: zr7enh8bronnym7kc8dxhggu91wdnwx1 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1750840682-579076 X-HE-Meta: U2FsdGVkX1/cZcVVKbXB0GodwUEWP1tBnrpgYTmtN2PXnEV5ZaeglsyUfVwDLMVLUGhEOp6IILvhUKrb9v36aXJFdd45esKkgt5p90Q7u7se9JuiGM+EXRw7queYTUb06pkkGujff2t/+bVJdAca7GDna4AXGqovkYDLsepQArECJVnAu5s0z15syC7ocGbU8v2rX1HhyB00YGsEBxKRF5M1kroOH6idWKDXBV/2h1rIamuNQAtxmEglY0tpBRVz52/mO7k1IR7+yscQR509gTVad+AoCKJzp/taObKXLkfMs8n6fhpO3Hts9Dt7e3Hhd6fL7pwzIhPribr6fL3oUPM0nR9nHUF27ia9ccs7ob+QAtHEdumTtQth/0g76+ep3SDTwhhD4Jq34/Scfjr9tNsv8N8pfyiU8kNsf3HDQCcGPBEPGGFFICs3KU/KhxCEiCdlScLG+zzPumROIGrzFXg9/Hky4k9ormui1k66evahSEuZhIK80WbzSEcA5ua3sdqaA6LqlIFWUB5Vnwvg3+c/fSBCyLEF7gtofO5M9EbOUIavhHa5fc8CkhorVY43mnUnQDydKzx0Wl0K1hyckpSAChhy9bHfxLT5FBfWCETVNROPPnDgbRklABsYqzMS6ItgUDI5dsiuj4T5ihLTJiGc/jRohOn2KyAjXrOTTvIOP4sD0vruZif3LsvGVcbGLtG4aUXGj+sUMaRpoqvwGutCtHcdlysrPP1btt2+iStbKzImda/brePL0sg2KemRnwFHfsm1Xpnd2pAC40s/rg8YRUZJH4nKmJfMsXNB2fdWbhznbojw70xEwQ3b32DXCgprrqYHLWVNoKYUw6lpAgZkFl8OlqFz5tuisa+vEUcvwK1F4xICimVPgMXNTweNo7vURmccD5w+bAMHoFo4F/thiI1WPFpAzXnn48CssKH+MsA8P0Sw9+nXU/MazVF3jeyWOfBQ8k6KaiiYWV3 ADbAKecT jKyP3DRm5XeeLyzZE7sk09INrjf9MJ5iPyAcKWLGhntti5Qapa73EJbhtoB7C+tYth2P9gYACSbdanrhpFr6X4VvJoZSctBhehDGlmoX2mZvZ9172GRdE3BbUqQLvWpTj4oB8p+cXsw7DqemWyPnklrjHxvS+UTD8A0NKW0Ht3FfF+LT9X3w37Ng1xHovfN5KrewoN2zkPri02QdzCrhHlBIR6LRKMKkgYXOOj4HCRqIg1AoDrH0Guf3SCkwI4Dy6K0k3Mu2IO+IbaMTZr2FZ+ZFiaaY58rKMAJIjgA8w0wK6usFaeu2xXmXTaqoFNk8LZUB9+gUq7eq4BEtPkzclntXfkQ+64l0N5STPEdOAUqOaELc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 05:43:40PM +0200, David Hildenbrand wrote: > Let's avoid working with the PMD when not required. If > vm_normal_page_pmd() would be called on something that is not a present > pmd, it would already be a bug (pfn possibly garbage). > > While at it, let's support passing in any pfn covered by the huge zero > folio by masking off PFN bits -- which should be rather cheap. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs