From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA137C7EE30 for ; Tue, 24 Jun 2025 12:52:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64F176B00B9; Tue, 24 Jun 2025 08:52:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 626B98D0006; Tue, 24 Jun 2025 08:52:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 563868D0001; Tue, 24 Jun 2025 08:52:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 44AD76B00B9 for ; Tue, 24 Jun 2025 08:52:02 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1D580103FEB for ; Tue, 24 Jun 2025 12:52:02 +0000 (UTC) X-FDA: 83590281684.15.512E238 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 53DD7C000E for ; Tue, 24 Jun 2025 12:52:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=O0ORMoVA ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750769520; a=rsa-sha256; cv=none; b=ZQcgxrNn7VgOTV1ArzIzbhOe+HBXfYdMg+Hb4gmuNMfaLcNDSyvhrI4IJ/CtKqiO18sCX1 fTzIJhSommJWOxN4iCCuGHqhuiWKD+KY4KSiv6aMyOzBYOVBwm63ozvbn8bMOdKnZE5Dq3 253PyHq9WTbh8JRM13D7r7EQPy0rPuk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=O0ORMoVA; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750769520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YOojs8ETOh0nTkI9FVoRaG17pTblKI2h/qJphUDsFTg=; b=tOXanv4BlbTfP7rqoCPtGZRRxpGg0cEmJ/K8591mmbj73UU0vr1wmx59LaBAyZXwXeQ2EY uNSlu1EUbzEMyOizMlIesDZQRFx8ASIYGj7YLELzioJvVX1vJg+FkSbomATVoa9kM9Hir2 3ABbT4VLDcegkadKd/Dr7IHXR33bLwQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=YOojs8ETOh0nTkI9FVoRaG17pTblKI2h/qJphUDsFTg=; b=O0ORMoVA2HBFIa95a4tYoOnfak MlNH1yfUbdVu/C/pxQlWEsaEhdAx3u7SfeayvsOe9NUYSILkqFBRqkm4yIBf1E8pvaYTgHU8nzzvY y9JJ10OQ6HASMGlWlOnmVsnklPeMvsR+pzbKqhpAlJa+iKEYdPU8j+FtVvU+WBWkAqRtHAbbtF8t5 eudvW7VJjfuSDpm7I/N24ZvaqCI5U+9SFvyDByBHQRUA97w0vqSV8Uv9Q4aWCqg4RF3hVL5G4FTxB yxwniFZbWrdvugPLzzqFJ9gn1vfOSJd+Vr5DzpRRDd0fnpYhXAZqoPh4iXN99K8hUZRhmK4+AG+Vl uuV/Unfw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uU37w-00000006bv4-0Kku; Tue, 24 Jun 2025 12:51:52 +0000 Date: Tue, 24 Jun 2025 13:51:51 +0100 From: Matthew Wilcox To: =?utf-8?B?6ZmI5rab5rab?= Taotao Chen Cc: "tytso@mit.edu" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "brauner@kernel.org" , "jani.nikula@linux.intel.com" , "rodrigo.vivi@intel.com" , "tursulin@ursulin.net" , "airlied@gmail.com" , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-block@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "chentao325@qq.com" Subject: Re: [PATCH v2 3/5] fs: change write_begin/write_end interface to take struct kiocb * Message-ID: References: <20250624121149.2927-1-chentaotao@didiglobal.com> <20250624121149.2927-4-chentaotao@didiglobal.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250624121149.2927-4-chentaotao@didiglobal.com> X-Stat-Signature: fp64xemwyo9yk8mf3hfmq3ozxbgmmbu1 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 53DD7C000E X-Rspam-User: X-HE-Tag: 1750769520-477359 X-HE-Meta: U2FsdGVkX19qkGBB9MmVhmADxIGqXaSuOvTrDzXhIloBpthOa4F/tS6dn6KIRb85LjCUABuP0iv7kuEMOw9+QdCP6VYe9zqOJpgli5y+YZiAB9lCiqeNN1aV531dEjn6wE68CHX/ZItMATELM6H650cMdxdIw6L5KF7eTuWM4CJ3roMiszbMbSAJTFF2fdnyLGfBue7pMnMn7z2hN3e/H8Ijfew2AAJ+DDsHtyq6msKPrSuLJWueThRgiiI0ipeozx1UEGj6Wz5/XoFw5PPghVUj9y7Un1TN5Bh8xmrsTGu0YXl49bgATPSdJpCzdlcphAFDFUS3V0lrFbpVDKieORbaiFFX/BEbTmvKYlFeGq+I97tNGqAu33GM55WyEVRIbdpgBSatBbciD5au5SAWv1opGHOuaW1UWnIAz2l+LkGqqoNwS9v6WJA7fSaKCfQJ5PTvfg/dRyJpHyg5LS0ImETd30zizJZxmGrNIYjY4uEqu/IoeNc0La7JRp137TqbGV7jWaFBjuCiIUuwsVWVxxmxhDVTVTjSrQ6Ym6o9KeCaaSoOV2hjsHdXmor0oLniMrVYmgg6TVpja2VRQsman2qvHKKDeFys9mowWF60vPLVcABKBVGxg6t0irc55lUc1/GB0jg/a3/3PinWo4l2ermsT897HKeVUxpz6PkyOUXosYLqfPDiaUlBG9KVurzW/R07FLmEiwSGfHuLXH7Ow7r2h3RFm1dixBtC1CTPLvCEqLP75D5kiiLCUXb4TVtwDpP5ZP9MwU728QDBLc5eXsVDFfzIA0eOneFjvw9aupgEDHeFJdhOvpmxnp2pdbZvwkKIpLCrvmDUp4iVi22c+SY99PKzvGdlfjl7qkEesH8VXslXoqzAp+Br+CsczEjh+z0cGIM0TeFaM96cDrYNYZkt/LuNSeshN4C0jQKkNI1Rod6AHr/y2TqEjro5BtiHVGOjKXVt6N6gTQ57Khi HL4U/QQ7 4PVJpt5rh+p5A15IEsqg0zXpqsVPuo3xJbbH2z89RLs3rxIPBDb0BrzMtsstvyHTg0JXQ85BA5Q6UEAkgdEfUM6fgzFasXBpXNYbyhEKRbKB9DZHFRnPwOiBbmGJE7bCgMMnjATxiWw31wwt4uY3JTBYsBe7eMeNzJpncfEG7pj5YSQ4cINsHk4rAFrZgCq4O8CPejpzceJLMAmIO0mHX/2Z7mkkah3AlPhUY5qV+X8NLHW1/AFraYyMJ6lIrwAwZpfBM4B8SqayQ6lqcwOH4f5MLP3ZJgGefprGI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 24, 2025 at 12:12:08PM +0000, 陈涛涛 Taotao Chen wrote: > -static int blkdev_write_end(struct file *file, struct address_space *mapping, > +static int blkdev_write_end(struct kiocb *iocb, struct address_space *mapping, > loff_t pos, unsigned len, unsigned copied, struct folio *folio, > void *fsdata) > { > int ret; > - ret = block_write_end(file, mapping, pos, len, copied, folio, fsdata); > + ret = block_write_end(iocb->ki_filp, mapping, pos, len, copied, folio, fsdata); ... huh. I thought block_write_end() had to have the same prototype as ->write_end because it was used by some filesystems as the ->write_end. I see that's not true (any more?). Maybe I was confused with generic_write_end(). Anyway, block_write_end() doesn't use it's file argument, and never will, so we can just remove it. > +++ b/include/linux/fs.h > @@ -446,10 +446,10 @@ struct address_space_operations { > > void (*readahead)(struct readahead_control *); > > - int (*write_begin)(struct file *, struct address_space *mapping, > + int (*write_begin)(struct kiocb *, struct address_space *mapping, > loff_t pos, unsigned len, > struct folio **foliop, void **fsdata); > - int (*write_end)(struct file *, struct address_space *mapping, > + int (*write_end)(struct kiocb *, struct address_space *mapping, > loff_t pos, unsigned len, unsigned copied, > struct folio *folio, void *fsdata); Should we make this a 'const struct kiocb *'? I don't see a need for filesystems to be allowed to modify the kiocb in future, but perhaps other people have different opinions.