From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30997C77B7F for ; Tue, 24 Jun 2025 12:02:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88A4A6B00B4; Tue, 24 Jun 2025 08:02:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83AC36B00BC; Tue, 24 Jun 2025 08:02:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 702596B00BD; Tue, 24 Jun 2025 08:02:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5CF6B6B00B4 for ; Tue, 24 Jun 2025 08:02:40 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EE81A14069E for ; Tue, 24 Jun 2025 12:02:39 +0000 (UTC) X-FDA: 83590157238.16.76453D0 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf03.hostedemail.com (Postfix) with ESMTP id 25CAD2000C for ; Tue, 24 Jun 2025 12:02:36 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="YPV/Hrs9"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750766557; a=rsa-sha256; cv=none; b=SVtu6MFTgtKSRNxhI9k5QMH1zGN1KjNaLh82raXWMLlEZPU9FVeGR919780PhpK7q9xOpb 1aZYTHf3jEOS+zVLvYupLFUm31ElW77mQzBm+mMFCgef2MnDXTe2PbA/bwZ25//HZm61Ix SwWANYYtTaWkdvttlW6PRfCIfkvGvE8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="YPV/Hrs9"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750766557; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SVb0KvDdPDxou4fHmBqqaIsVtBopt9+TQ0k6Zh3nVRE=; b=bbRVv2L5ReP+FwAsP/gPiyTBGcv711dGXwiNzxOBABugtaTuK1BxEQu3NVPdG31vC5UTCE /H2tMnC9uCDhVFn9WwXzHahdS8M2WmfPgeeInf2vnvucygxZEAyjZ07TSXkGkoUXy2OjXr CZG08SECZbE2QMFKFgD7dtNgYfWu2yY= Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-553b5165cf5so427878e87.0 for ; Tue, 24 Jun 2025 05:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750766555; x=1751371355; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=SVb0KvDdPDxou4fHmBqqaIsVtBopt9+TQ0k6Zh3nVRE=; b=YPV/Hrs9gG13zlnLzFatJ6VNcSAjZjUQxd8gqt7tx3jlaILqsCQ1JFDygX30+URFUo tNEjl0eNEVJW21gIWfUY1+HbP2RZBIarAW7qirMKErHKGrM4SYS2nldfyrv+U/K6oKQc J0PDefELF1c40dQrgsHRFCVUTbqi+okNK8/sUb7CcKbSYVk6ePXx4nVNEN2C3iyVKFM3 mIZszMLd/r6E8MgJlMYhhQbgcxjMPunVXDgu5xQh6ES5OSIM1eKg99i77zf2iJ2O9ttK LvosJaZvdZ1xlays0onzVeEGnNgTRgkAU/hGrT2u8VE5Zz4Trk+CmINZYrjUG0PVEWT0 uiKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750766555; x=1751371355; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SVb0KvDdPDxou4fHmBqqaIsVtBopt9+TQ0k6Zh3nVRE=; b=MJ4Dz3RrIdk/gIopJwG5090fGcGLq1VGatFXX8HZHd7HWF58kRGwGZ8zNMGBF5m/dl S8xN2cMpXUL4bjXlPW7s0A4Qf83w1AzRkixlQ23Ud3llwQbSLZKN3b6Rruj61J2ErhIt ukXu5ABGlzW1zZ0CE0PEVZsZeu861huWnK4V7SJ3yHjOVr+yPvKcIRJEKRLkip0iGZIq zziRJ7eLPer12Ck4F0+X2rYJ6sErcBjLWYMlZO5U/OyTZ2fa3mdogIxNHnf5mYUbYpJG JgNyQn+0DB53cnGqkzpssSwQmlPkNtOxGaPq8I/sDRvSuLTuhfjYrj91pOLkOSqWoPmH U7SQ== X-Gm-Message-State: AOJu0YxiBV2X8ph5ALwfvX/6yZft5sObJs5om0HRasozBLyS5sqAhm/h XHVXenKOdfZuKlI3vLFzxED4HqnjQymtwYmad0k6aj0AlE0zTlv8CZQI X-Gm-Gg: ASbGncsCCa0A+qKWdMtm/NS2HEfZXaOd/5ttTHHWqH55Vw5MoWJIw/xUAEOSzhkaXSb oOaRx6sHVKyHhnWOWioDdqcGNXrGFUYcyrhD/0uRZ1XiAkAPvZyLTLfGuricRSBNkoNfbIVlgiw fVH6+O3INxRNlfqjaanth5diUIsXRs4PlndyjY1vsUq57XyLXsFPa8AHrJ3okntJmmX34pgixIx uH+Bdhn7cmM2xgLHLbUYPmucEldk85OuQgvDeKd+Z9M/yAFx9mDTUHTxWEFFsF3NdABXXVbJWKM LbCcOZqfZY8xv1mHNHrsKY6d8r1KJVUMxu6V9ZlA2dNirC/5Y87LdusnaaU8DjruDkk/Pw4ZV/4 5M0c7aATGQnI= X-Google-Smtp-Source: AGHT+IFrLQz9ivI2vQ0wFljSIZucFOHmGpeRLQq9Egx2A6aWSvCsaFo5LFDJ2HVTYf3Q1opEGOYdUg== X-Received: by 2002:a05:6512:e9f:b0:553:2e90:98b4 with SMTP id 2adb3069b0e04-553e3baff85mr5409224e87.17.1750766554620; Tue, 24 Jun 2025 05:02:34 -0700 (PDT) Received: from pc636 (host-95-203-1-180.mobileonline.telia.com. [95.203.1.180]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553e41c2f69sm1801814e87.150.2025.06.24.05.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jun 2025 05:02:33 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 24 Jun 2025 14:02:30 +0200 To: Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Danilo Krummrich , Alice Ryhl , rust-for-linux@vger.kernel.org Subject: Re: [PATCH] mm/vmalloc: allow to set node and align in vrealloc Message-ID: References: <20250624095121.3243540-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250624095121.3243540-1-vitaly.wool@konsulko.se> X-Rspam-User: X-Rspamd-Queue-Id: 25CAD2000C X-Rspamd-Server: rspam10 X-Stat-Signature: ukht93nw4iaddk1b1oa9j7n5wurdxdpj X-HE-Tag: 1750766556-929777 X-HE-Meta: U2FsdGVkX18kF9o/w7UD9rslTDz/xNScDAprPJZrK7KGEqlSJDjXEYu5llRLakyznvdh0CsKY7etb8BLbrKEaoLPfTdB+MyLazy5+W0/vfMC4I/fwKG911TXQgER6Z5R72lXLv7UpKqIS/AgMCjp2lD+FoWp3v3hsSzw3Phe4MddGQATLLz6WgF9Lf74jWPhgkKcoboG1i4gKwpHiXhHl1JNJonlJ6Jpe0QKlfmQ/DGcOAo6z/nIv97arJR77YE83v6nxsYw2MzUIRmkRYXzHwfa9sBC3SsYhFChICeZDxNFb7gX5+FVpBx2Dp9tcXjgNma0SUnDzmqH1lAZlgIvQ0AYyxIAfrY2wgvIC2+okzQpRY9pEpXeq4vaVU8OEUkgjAbbIe4fboh0rhQ6namiZnF8e6EtDXlXtwNcWf+xi8qqwAsly2dBRJOtDDmKaXLtvUnqwdXJRPki/GdJU2LugwfxqbMM1OvWcw3iPzSWzRpzR4oh1Qo8Ccq+ntXrqQnyyGZNGLJ1xzvSw0vfaI9YaeQS+TQNNeUTayuqSIcosRibQSiBZEg0ms5m7j/uJXv26ywioUJV+ZNqjx5CLGMYvhOvecpMDr18i051mTTWju7fhRK7xmsMoeE23MG3AIusLF/8AWRRCGqeBvE8mBlC1NDMAUl2TePATdYIMjqet/09Aele39o7PeD3MtjcPDmANQ0ZjFoWC6Ykk5nt/Zr9s6sV4nEOAKN0Lta4RmquWRfmSY+hYj9roIK73Aar4xbPOvm1bqoTVw6ZFyFCopcSjW5H0NOWY+tFvi2zMRCqXcvCoi3U3AsEeacX4onu6K/5zlJne0eILvtdMGQcShADbkwNhGrbSMUQI4ch0nDysnu2AXnBgdSUlbRePMv4dAc6yqK7p83ViuPz8YDnHHmaLR2ur4k0eLokGZTiaZd0HSOCoWuFJFVGHBB8UnYrHAZUCzx/wai45ATrJ27MQFo b8gFmab1 MjQ6FMqghlwZxG5YrS8/iZv9YIIQJ5p3w/449YiobhmwldY+AsH7tFEJ2Neshcrg7613LCRFec90uBdbWGUn0L18R/sisA0ZJwFNGVjVEjVhRvyEmQ27ueu7PhvZMCltJZX3kWLL1BvmNJkl2EMRIXUZ5+iZnKdD+hLE147TOTv2pm8vRkDdjaGY3+wbMSJ8JWkAcGQCXtcf0zhlHaj3NE1sEZ2tuNFdD9S5Fb4YFSKeDAB9IL5d4I1iENfbdE42psh+brkZyD60MVrF33KL23zzzwoE70j4C6Uc0HFcFmdi6Q3Lmrk1vbrco0GWSkqGlBuKW+GY1sVb2abQHQb72cF91C2EHxqTXb38rsC2NSUZKG5tBWYfRmu15wdakIAWrUx1/X8gSnXy+09Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 24, 2025 at 11:51:21AM +0200, Vitaly Wool wrote: > Reimplement vrealloc() to be able to set node and alignment should > a user need to do so. Rename the function to vrealloc_node() to > better match what it actually does now and introduce a macro for > vrealloc() for backward compatibility. > > With that change we also provide the ability for the Rust part of > the kernel to set node and aligmnent in its allocations. > > Signed-off-by: Vitaly Wool > --- > include/linux/vmalloc.h | 8 +++++--- > mm/vmalloc.c | 16 +++++++++++++--- > 2 files changed, 18 insertions(+), 6 deletions(-) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index fdc9aeb74a44..7d5251287687 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -197,9 +197,11 @@ extern void *__vcalloc_noprof(size_t n, size_t size, gfp_t flags) __alloc_size(1 > extern void *vcalloc_noprof(size_t n, size_t size) __alloc_size(1, 2); > #define vcalloc(...) alloc_hooks(vcalloc_noprof(__VA_ARGS__)) > > -void * __must_check vrealloc_noprof(const void *p, size_t size, gfp_t flags) > - __realloc_size(2); > -#define vrealloc(...) alloc_hooks(vrealloc_noprof(__VA_ARGS__)) > +void *__must_check vrealloc_node_noprof(const void *p, size_t size, > + unsigned long align, gfp_t flags, int nid) __realloc_size(2); > +#define vrealloc_noprof(p, s, f) vrealloc_node_noprof(p, s, 1, f, NUMA_NO_NODE) > +#define vrealloc_node(...) alloc_hooks(vrealloc_node_noprof(__VA_ARGS__)) > +#define vrealloc(...) alloc_hooks(vrealloc_noprof(__VA_ARGS__)) > > extern void vfree(const void *addr); > extern void vfree_atomic(const void *addr); > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index ab986dd09b6a..117894301db1 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4081,10 +4081,12 @@ void *vzalloc_node_noprof(unsigned long size, int node) > EXPORT_SYMBOL(vzalloc_node_noprof); > > /** > - * vrealloc - reallocate virtually contiguous memory; contents remain unchanged > + * vrealloc_node - reallocate virtually contiguous memory; contents remain unchanged > * @p: object to reallocate memory for > * @size: the size to reallocate > + * @align: requested alignment > * @flags: the flags for the page level allocator > + * @nid: node id > * > * If @p is %NULL, vrealloc() behaves exactly like vmalloc(). If @size is 0 and > * @p is not a %NULL pointer, the object pointed to is freed. > @@ -4103,7 +4105,7 @@ EXPORT_SYMBOL(vzalloc_node_noprof); > * Return: pointer to the allocated memory; %NULL if @size is zero or in case of > * failure > */ > -void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > +void *vrealloc_node_noprof(const void *p, size_t size, unsigned long align, gfp_t flags, int nid) > { > struct vm_struct *vm = NULL; > size_t alloced_size = 0; > @@ -4127,6 +4129,13 @@ void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > if (WARN(alloced_size < old_size, > "vrealloc() has mismatched area vs requested sizes (%p)\n", p)) > return NULL; > + if (WARN(nid != NUMA_NO_NODE && nid != page_to_nid(vmalloc_to_page(p)), > + "vrealloc() has mismatched nids\n")) > + return NULL; > + if (WARN((uintptr_t)p & (align - 1), > + "will not reallocate with a bigger alignment (0x%lx)\n", > + align)) > + return NULL; > } > > /* > @@ -4158,7 +4167,8 @@ void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > } > > /* TODO: Grow the vm_area, i.e. allocate and map additional pages. */ > - n = __vmalloc_noprof(size, flags); > + n = __vmalloc_node_noprof(size, align, flags, nid, __builtin_return_address(0)); > + > if (!n) > return NULL; > > -- > 2.39.2 > Do we have users which require alignment and nid? I see that it is part of kvrealloc() API only. -- Uladzislau Rezki