From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C27C7EE31 for ; Tue, 24 Jun 2025 11:42:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88B046B00A0; Tue, 24 Jun 2025 07:42:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83B276B00A1; Tue, 24 Jun 2025 07:42:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72A8F6B00B4; Tue, 24 Jun 2025 07:42:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5E04C6B00A0 for ; Tue, 24 Jun 2025 07:42:20 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D16C212117A for ; Tue, 24 Jun 2025 11:42:19 +0000 (UTC) X-FDA: 83590105998.13.D1728C0 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf27.hostedemail.com (Postfix) with ESMTP id C44BF4000F for ; Tue, 24 Jun 2025 11:42:17 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vkbxa5Md; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750765337; a=rsa-sha256; cv=none; b=tV24uNuYYHSZ/py6o43PeBfwvXhEzN7JM6AEPBKYj/06dAHtZ0N4lQlF603HhKclaUYdLW 5Ms2Izc79fw1o1Hgk65CW3wCYIkR9/Z1fp/sV0sinkPENn9KqDs5yQk19TNxVEy6dTh07I /t1Wuyhd5l//r/n8QmmbPFefYjuBkh8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vkbxa5Md; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750765337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5s25fyGVsgH7CUUdiHpgC4SpMceOJi2ulartzmm/61o=; b=wSEl6KjAR3gr2eDeaILUudj9zX+V110m7SRWHJyJX9YNvB1LQONXlzHCs7Up50qo5dK3Kd 9S+hPhQV6HRWg/eJieivIcNAKD9wKdboGgNYaVjGg3MuLwIBRRhV2WZONsi4zFrDQl/9NE JgwMaVZnm2gMwiVEoF1NkNn1PZMErf4= Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-553c31542b1so4324143e87.2 for ; Tue, 24 Jun 2025 04:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750765336; x=1751370136; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=5s25fyGVsgH7CUUdiHpgC4SpMceOJi2ulartzmm/61o=; b=Vkbxa5MdA+WovmC93t0rLNVwoCTaBTyrIumpL36gdC+2MpYKbM0wpTOIjlPFSoYbAv sHihiLKwI5xNiPn+FmEL6+WQCdV5GsX+zAi23kjFtZl9H6Ld6I6ge3zEqyYoKkDv8uzi eCIYnGTegHJKnndmP3uBeR7JlcwyQ9yePrey920p8VJb+9L8Sof5dzqq4tbq9u4DzlGD bRax9hCGagZ4ZLAxgDN4Vo0juQNE+j/EnL2bzAR8c/1xlU32fgtxPLurYEMny3BEuk2G t+gPezVQbeUe5smsU9vlYK2mF8wm2jYWCr5JE42T3DA7H7gH+AB6Uy3lgiSpikUGnNdt VlVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750765336; x=1751370136; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5s25fyGVsgH7CUUdiHpgC4SpMceOJi2ulartzmm/61o=; b=kVZLI+KXiTBWV/ucacsdWOlYLwL4Z2tbcCDajdOWBdzuniQSeTgxeEidvcFOQrYdPS 0bD91YeodvlDHh6SfqxmXHwldghaZB0lSGXyxSIolMy/dwvisCJiAWzoyuXJZsxm91Hi zSymIfVkyfzLfZO/xF7yzr/cSJ40BtioUXEgy6OlMq+/Chu5bwLEDhfbIqP6zsS4jeD4 0vyW4VAgC0PtfZlc7aql76hKTTXDhG5fyoEfSyAFYfrp1YEEgGIywOTfgf/K83xeykkX 4KW6umhtLMZ+bxuf1XwKk4QYrOkKaum7bmlL9lVEvG3DYFYAOD6rQOgkTXw9glMLsIwU bJbA== X-Forwarded-Encrypted: i=1; AJvYcCVX5MRodcpWCiqSdkzE31//X/h6nxQQqWcbtKPQ86QISmQq3+N4uX/BzV9s6azlJVfg2buAIviIzw==@kvack.org X-Gm-Message-State: AOJu0YzPl4WOe+8EDOtzkBvrij5nZZ1AFdsFYdHtKZDswl6Xbh5cnlmA 4/3RH10Q6GvEbx5cXj5LoBWA3JhDKptxcUl7xbujZvi5eXKEbu2PpNMq X-Gm-Gg: ASbGncuVlNRAcU3V/2WZ/wpGuVPytTsuLm1FpJyhB0FZ+rEf7fjDAWG5tj/ZErd1E7p /ZB78NoahIdUVLN1K7bB32XSl9fn9nIk9t5nc3LGzmnhsGisQsQBX4cRlDMkAbseeGgc80cRgKe 41rcN08B3Fbbj1+rIFHt7G2Q3QtJtPsg6Lu26Zc6tp8gHgvRV4zNtc5egLeIGFclrs8oEcnp0ra bD2W+yrz5EvgQXwYaHnqqdjr1XDoCFk6F3/aeR3AVbJvNTPGOVEmfUmInHbdaxbuczasWNYkd+T ex0hY4hpVfmiYjmO2eewk9dFLxN2FYSKDb2dfZHhy02LER64Z26ul6+LvmZR6o015ec2MM8uNpL 5gGy8gEIhrxE= X-Google-Smtp-Source: AGHT+IGmukpKZCpvBS9DnXJ5zF/aXj7ll7dmnJzveDXO4jN9B/KEDcKBMAx2bSwr80gt54+0Qzco9w== X-Received: by 2002:a05:6512:3ca5:b0:54b:1055:f4c3 with SMTP id 2adb3069b0e04-553e3ba8018mr5596807e87.11.1750765335508; Tue, 24 Jun 2025 04:42:15 -0700 (PDT) Received: from pc636 (host-95-203-1-180.mobileonline.telia.com. [95.203.1.180]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553ea450edfsm1430158e87.102.2025.06.24.04.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jun 2025 04:42:14 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 24 Jun 2025 13:42:12 +0200 To: David Wang <00107082@163.com> Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Harry Yoo , Suren Baghdasaryan Subject: Re: [PATCH 1/2] lib/test_vmalloc.c: Use late_initcall() if built-in for init ordering Message-ID: References: <20250623184035.581229-1-urezki@gmail.com> <5686796f.8f47.197a1310b6d.Coremail.00107082@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5686796f.8f47.197a1310b6d.Coremail.00107082@163.com> X-Rspam-User: X-Stat-Signature: k7bunpe8dt8znpqkee87ni8ike9zcr54 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C44BF4000F X-HE-Tag: 1750765337-929959 X-HE-Meta: U2FsdGVkX1+OoTp9rIZ4J++MiqDET/lKv0REy7RJmtJ/E+mrpDdwZOHN8eqcTPTBFLQpYMadKu0/lfRafjrgSk8YBEuoRhBFMz7pvo1MhZB+UYszYCzl7WzvkTH9xlJxF4YkLDu9ZXc9RuSph78SqehRDZLpFXBwYXnkjARBZjjoVm1edg8H+PhIvFc9j0q6ID++emsmEV/Ag28X0LncYCGhPWF46QAWDyiltaP3FjNFyZiJ0DcmaSB32VAe81xhgj4nyiU2xWwHyyA3srIwrvZmfLEDS/fIAtvK5vXjEwILGVDB93kKTjGSKpRSR7zX7OTASL74qZFXDelMFgPyK3oVdbVVQ+2OlGpnrGGz2SgVK9ohFrQgZe6Fm3pRdLRB2v3f1EbHs60MVBplZlL2qN5029/xEOU75yJ9ubkqeNnuZtvf852Y6+ilQeTnTz3axSE+AGpuJJviN81CDGatH2fTHd4xdKQ8b6KEbdg5rSvq024Jwo/Z13v1sR1ALPEQhe1HKBidVk/N/T+3J8QIHg9b7+ksZV/mXCYGWxTWH9akvnUszuGU6cWmKpaMbIQSkWovevdQaASi8buBJKlOjVt2WHfgJKATqbEfYWoLkJq5w+cm4ELKVW26kxFjIGGtxn1Rgsa28EGvpETeFBQtX//1aJXloSOeElxzd24oVcSLyt5BDe0XUhTVpY1xeAqTtzgoW4PLARKd2hbJkWM7x+/7KYTcPy2Zob+KQ/rQPpdS0KxSJgqtI65eqv1+tNSxxc6zCysVS5/2+7U6GDzLcKufUu83JdbobF8Q4lWHkJVsSMhkMCHaZKOjOzzlkfeZ3wDwhEjRBwqnKDHKTmvGbvceQ9nx8Dm4a+/w9B32M7KcI37Lv3jy48LlSiTymWK5wrXtEAKMz7yYX7ZdRvmA9NTk1HLkj4I6XilI/bnRk91ywr9U6OvzRM0S/cV5vQPK/ZcV7fpT8HvjpS/zcr3 t4or/M2B 8HTi4awQ06k+df0abPfOaSFEiLQXewPIjkM3cbXWa8utqa26H+mHbV5rGF08Pb4QCfk2clQV9pxqqHaBOpEEBAFn+nkhyu8KYbj5AOEiZa63Lwzdo73y695DP3XCG6cQUPIW/J0wqdF/pAK4aPVw45sYAz/UQtS7KudkZXwwamWu+RTJfGMhOC0JBNW2ggmaOsI3Bh6F7Z6q40xj+aHvWRqg2zfmhKWI9EXMPI2BtEKhIIK18CPetTE+QVUp9TeIjx93eukKUd++A9T0PJ521aQj5F4KCY4Tr4YfXGytskiK3kzY96t/MZUUAR/5ec94j3BxEaTR+Jh8Ttsop2w/dIgu8PP3kGa67x75RoYfrBnMxQkP7xPHONyzC2txJ+Q2ZJhVSWM3/LX97xar/tbungcJ6W57HcgIZ8nwZUu+KrrzPYeMtMmKtYsoFkFZqVz37seWi67DpQKSA/FQXP8reUX34lGzcQnYi+Y9MkthwFdoy7UMzRd/LIoY9ZAhD/68MsnX3ZJ7MQN2En9qEydlCvIQA0mGCGHdwIKF/S+AYODc4HpYnQW24HLiR0/S59fU7ODulEA0SeiV4dG5vYnpmr2Id6uKV1mtXGnVs3ixGN6BYYQKzyo5DBdK8cESnEe/c67Px09wkvbF5VvnxgLU9M83EHD0baE26dpOHxH6fPxznsCSkIyBGW/QW8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 24, 2025 at 05:07:15PM +0800, David Wang wrote: > > At 2025-06-24 02:40:34, "Uladzislau Rezki (Sony)" wrote: > >When the vmalloc test code is compiled as a built-in, use late_initcall() > >instead of module_init() to defer a vmalloc test execution until most > >subsystems are up and running. > > > >It avoids interfering with components that may not yet be initialized > >at module_init() time. For example, there was a recent report of memory > >profiling infrastructure not being ready early enough leading to kernel > >crash. > > > >By using late_initcall() in the built-in case, we ensure the tests are > >run at a safer point during a boot sequence. > > > >Cc: Harry Yoo > >Cc: Suren Baghdasaryan > >Cc: David Wang <00107082@163.com> > >Signed-off-by: Uladzislau Rezki (Sony) > >--- > > lib/test_vmalloc.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > >diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c > >index 1b0b59549aaf1..7264781750c96 100644 > >--- a/lib/test_vmalloc.c > >+++ b/lib/test_vmalloc.c > >@@ -598,7 +598,11 @@ static int __init vmalloc_test_init(void) > > return IS_BUILTIN(CONFIG_TEST_VMALLOC) ? 0:-EAGAIN; > > } > > > >+#ifdef MODULE > > module_init(vmalloc_test_init) > >+#else > >+late_initcall(vmalloc_test_init); > > >+#endif > > > When MODULE defined,  late_initcall is defined as module_init in ./include/linux/module.h > I think the MODULE check here is redundant, (it is clearer though) > That was an idea to use MODULE, because late_initcall is designed not for module.s It would require the comment then. -- Uladzislau Rezki