From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 497B4C77B7F for ; Tue, 24 Jun 2025 10:49:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D09726B00A4; Tue, 24 Jun 2025 06:49:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C931B6B00A6; Tue, 24 Jun 2025 06:49:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5AEC6B00A7; Tue, 24 Jun 2025 06:49:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9BF4A6B00A4 for ; Tue, 24 Jun 2025 06:49:16 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5B210B9B79 for ; Tue, 24 Jun 2025 10:49:16 +0000 (UTC) X-FDA: 83589972312.11.7DFE38E Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf14.hostedemail.com (Postfix) with ESMTP id 47B86100006 for ; Tue, 24 Jun 2025 10:49:14 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Urc1qwEx; spf=pass (imf14.hostedemail.com: domain of pmladek@suse.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750762154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sFshqkaQrvO1s4Gkyifgl/GnVtFojbtYgAGH6b+8BAM=; b=AfnyjsCszgzaGa+TlQDidqEd+HfvdPQ9d7j1ZHjfZiQUEdQrqQppLWjUVrts+Fh+q9648q kEq2h8ZUhJt4vVMZtAGPhy+EpT49UvpPAGzL1zRdRsIrwvlDUl5GHo+EiSikeC4FWGqsCn 1uOn1Vbr+/cDG+vKsgauSnPx7pGGzGY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Urc1qwEx; spf=pass (imf14.hostedemail.com: domain of pmladek@suse.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750762154; a=rsa-sha256; cv=none; b=P+XxoDOs0oXflovjMxt9f1AhIdNVJ/LR1jLZgBIIm2L7IoRPgMNljcAPINedEyT2n4GAFF OAwveKMROfQohkX/KIfTaVIb6Zs4osJURD62bkvLUaCfRLuaZfXZrAHVWEUmi+k5/evXvr gkimT8DQtiqq6/UnbcT718YStxMUhVM= Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3a525eee2e3so220902f8f.2 for ; Tue, 24 Jun 2025 03:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1750762152; x=1751366952; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sFshqkaQrvO1s4Gkyifgl/GnVtFojbtYgAGH6b+8BAM=; b=Urc1qwExgmTRizd9ZmoLlZ3w3q5PcTuBzUtHscqYNLVpWml4uDbnWyU51AhEfF4jsy SrZmAk2aYUObrYFdBWFWhzwZqUxXE26+V+jjWELQDwxppOV0Dd1bnIYtl9uzF2dyKJEA 3ZTXlwoiE4rtXPS7J3ilHuD3xEy1s50fP/AkxJfJFtFtoXMJdOofBNBZUElLNy+Fpcep rNF0eObVmpk7HW2mwWJug4fd0iW8ArLikx18GDZMMeUDxIG9md5587CO8oycLNg5C+7j Enzf+utDsNAFoQQGwo6sXaoBsv07aXQSq71lP81w72xEd4qDcYAEBjxWz2/BuwP01zec C+Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750762152; x=1751366952; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sFshqkaQrvO1s4Gkyifgl/GnVtFojbtYgAGH6b+8BAM=; b=HEfyk0ces1saUJ3Ln0UD2MmgsgDNPunKioTdCRkQMRkb9hkiUho2HLArDRQGb/FJ5o jn2c5dHUocFetJ0L8OgkITIgFadUDCi8P68XED2m3p+PZMrUsrlQvj1VNwI3K5bUersR UvWoJpPoVDMjJseEKuvn6PiLPOalSyCBpjE6vqbS6pXErUNTnhRJDvpSjOAD9t1u1+Ul F6sel6JsGImL1eKPqN64eGTyJbrS9bAXCQkOvmcPVWIAEa88e6jaeMJEotbHtoXl2GXk TahJQnKjWo0vqlbSft61VqmXu42+Nx9qspk6/V0Y+Fc9yJ6A20B+Vbf0Z/GT/DSIRsHg CB3g== X-Gm-Message-State: AOJu0YywunFoT9I5unIwnlEkYdFvcMHHu8jMsvC9gekn9eUjiMvifBoh XznTzyjIajbXCf0OOCSeSs94VLngDPVgGx2qxv8O56A87jmnuyLQHmKNdMADsPqy+ak= X-Gm-Gg: ASbGncsMHB3hIY1dUsNCejYXmws0Ve14KKlF1N51sPW1R/4xg2zcJCoEAaGvy+8mOYV zYHrJNh1rM0YchynxqT3ZtWDUWNDMpr9a410l4JOh8n54/03DrgPekVLACBqDLruYAMgWYgahKQ NcNF1a+Ym/JaRW26FrFaFH/c3yUTyZBC+YdoHdjuCK7roopm8SlHR5rYO5Lvm/e5y6Xm13hprv2 wk07LPIY2yUw45R9/JHFglvdbCisOw4CQHUdLZ8n5L8/Xw+kqxuCidxZWfm47xA0Wf8zSWmg7KS oovgNPGBfcWaPCfUgnBQ+Rh2fjpA7L0nM81VwrzHiNsg9nYlIhol31YL7ITloECE X-Google-Smtp-Source: AGHT+IH/6/c8OvTyyQ7J3ydHQbrXdLtsONkE3vxKT5eL5llu+wMckRhJB/e15VUI27/0UmRMDV76jg== X-Received: by 2002:a05:6000:2b05:b0:3a5:34d9:63aa with SMTP id ffacd0b85a97d-3a6d12fa6f9mr8870617f8f.59.1750762152394; Tue, 24 Jun 2025 03:49:12 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d864a9d2sm103805525ad.149.2025.06.24.03.49.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jun 2025 03:49:11 -0700 (PDT) Date: Tue, 24 Jun 2025 12:48:58 +0200 From: Petr Mladek To: Anshuman Khandual Cc: linux-mm@kvack.org, Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Jonathan Corbet , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t Message-ID: References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> <68cdf649-a273-4d83-b862-6b675a793f18@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68cdf649-a273-4d83-b862-6b675a793f18@arm.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 47B86100006 X-Stat-Signature: q61t6ej1u5dg3ph478ehen9ama6w3qec X-HE-Tag: 1750762154-286938 X-HE-Meta: U2FsdGVkX197LxLrUsHH5EELEElf9nO3rYcfriinsgIMvu9OkyGMCc4T9BlkApqr+a7qGbBM/C9S8HBYC4nfcn3CzBy2WZI+9U4Btuol98JzVAD/l79UitX8KNLDgMl9hfI8Vvwdkfrnl7pxDGn198c/TbiyZqrahAMTqBoZtLSpA8Af/q56wbnYAxYCAVM/2TGDXRTuiTJ/ltdCsOMEH5CX0spJhTRg/IkNIQSwEZdGuL1Vi6PsCSQ8QXr3UMkcKIT8SLHLwb5qBlyiddZLpw+KYUYG6Xv8bc9d/kD5bBpmBKPCgaEursnA2tD+WAagnvhFJXDcf3gCPOhcw7uD7orp61QLhB/7Pwn8b3XbKiyKoYKnPp4iUYzWgtfcCqhEG37Fyrvn/ivsAdmW5q/qo/ogpfBuL799Nva77xbVgpU3/XsduzpIgO3Z/tU5G3Km5AbowzUoBdzhmxLHbcXbnsM4hbVAYoYOJkmkzje4pZI+uPqmPMBiBmZJCy3bryYbEc9Yvmwhh2o0u3PzwoxqiM++wjBnPaYSO25wS65icjIfU6HECC1QJuyJhKI++I+dAIHZnIJv2hEX2d7AKTQ1prZPizyQ+/SlZCS9Q6aHPgzxYGjTfaMQ/eF4xZdoj1BWBumRzXn8Ib8cVrythnrdtXUPoKS8b2sWg60xjICcgWl2L9pLpVKdmO5zUGrZckb+4ZOdX1f/R0+ShblY/mDNV9BB/INWUynoQzfZ+TDi1UICV/3R9dHXRBnOAlVGkNbS2TNqdgsiUdxdoKVTkTVpZYtxw/pX53t6wXf9eF7IUnGsuRb6rydwZGRN3/zqjXyELf6hmGLtpY6XOnaqcZUbEEkfkCjlfjHaj+LQfE4DrRBmzEVEuD0E+8Pi28g/mqstsPdnV6xtmDF9E1nBziqA5N2k9zbQEMEPOBB3+dPV0NvZucLwNZexVtLs/rbNge9IMQLC8kNsSmPV8eU5pCb vc+avMXj ZWrNtY0YEgflsR7rOdVvHZlFX0Cb8ZsNMbMhZc2mhpee+E5VlX2dm1wyg/BS/B1ZMRgV2cAoq/DzAFP8vTAkklDbO3n47o5ejvK0xDyXDXwg9geF0PthMUxYOofSYwmI8Hgysv46Y2gy+YiXdAUqJEh8F2WQbDM9XZZ+iWh40OXWsS88dT88qI757k6hRP1tWkwXcOBJKowtk3VleCBmLJTA9leuWn6c+4Mew078EGyJVCkUYPTAB38Eft79oWt8qCx3CsFBJ6+53llV9ag8RgLguIcZxeMsMm5RZ637gYRXuvK6L3y6duB4CVW3Xc1TWRaFR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 2025-06-20 13:32:31, Anshuman Khandual wrote: > On 19/06/25 7:31 PM, Petr Mladek wrote: > > On Wed 2025-06-18 09:42:34, Anshuman Khandual wrote: > >> Add a new format for printing page table entries. > > > > How many users do you explect, please? > > > > This patch adds only one caller. It does not justify the added complexity. > > Understood. > > The idea is to convert all page table entry prints through out the tree > both in generic and platform code. Added just a single generic example > here for this being a RFC proposal. Will go through similar instances > and be back with more comprehensive change set. You do not need to cover all cases at this stage. For me it is enough to know that the printf format will have several (like >= 5) users. > >> @@ -2542,6 +2545,23 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr, [...] > Agreed. Andy also might have suggested about special_hex_number() helper > on the other thread. Will try and use the helper instead. > > > > >> + spec.base = 16; > >> + spec.flags = SPECIAL | SMALL | ZEROPAD; > >> + if (sizeof(pte_t) == sizeof(u64)) { > >> + u64 val = pte_val(*pte); > >> + > >> + return number(buf, end, val, spec); > >> + } > >> + WARN_ONCE(1, "Non standard pte_t\n"); > > > > This is nasty. It should be a compile-time check. And the code should > > Something like BUILD_BUG_ON() against pte_t as either u64 or u32 aka all > the sizes the print format is going to support and it should pass on all > platforms ? Yes, I had BUILD_BUG_ON() in mind. It would be nice if you check at least the most known architectures. You could do it just by looking into the code. We could rely on the bots, monitoring mailing list and linux-next, for the less known architectures. The more you check in advance the less surprises would come from the bots. Best Regards, Petr