From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0A2BC77B7C for ; Tue, 24 Jun 2025 09:37:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99CC76B00A0; Tue, 24 Jun 2025 05:37:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94D696B00A1; Tue, 24 Jun 2025 05:37:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 863076B00AE; Tue, 24 Jun 2025 05:37:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 717F36B00A0 for ; Tue, 24 Jun 2025 05:37:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 11F6B12054D for ; Tue, 24 Jun 2025 09:37:14 +0000 (UTC) X-FDA: 83589790788.22.2D6014E Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf06.hostedemail.com (Postfix) with ESMTP id 9D653180004 for ; Tue, 24 Jun 2025 09:37:10 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="i/08+2bR"; spf=pass (imf06.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750757830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x3OfAz3+/wP0QnmRgAYo+n4xSL92uk1klBXDJyX8CaM=; b=AeF9qaktWHd5SsQB3lsz/nbRi87wZ2vjC42s7RDm1wUCO/VBweJAbOz/kRFDykX1eOnaCa iS7OcUIt9bp/r4d6jnSs20/eHNept8Fr1DHP48uTaiL1V15IqcqDz5qyiiZVFK+NS1NHGb lGnuvXA276EdiHpO5fX2zj88dB62BwM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750757830; a=rsa-sha256; cv=none; b=KT33z9hPpa29pl2oIGOJ6/WHLs3KjXS7OFxqMuV1Lx6szO7nb6LxnUIJtqXLyGjbdHCmEd fyvvs+9aQO4MK8C+jPDNi8gH+xPrpRTssQpbpIpgFYMJkz6GAYOX//k/QP3lNOUm0XnLna E/9zSunrYFo9hG0AD/3gjom2dgHWKUQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="i/08+2bR"; spf=pass (imf06.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55O6V6Eq031510; Tue, 24 Jun 2025 09:37:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=x3OfAz3+/wP0QnmRgAYo+n4xSL92uk 1klBXDJyX8CaM=; b=i/08+2bRWjF5jjWj19TuEaXbUXg2TgrjjUwp2cDXoRMqtL +SvUAtPjPxFdLARGFMIDH4QfxvAMvnR+h6KePzM3Px/pS8cFloPCyaHNGzN/6mc3 hxVvtKEi+Fs3DjjANamMr4sUBd6S1sKZZuxI9xSXzD2DEw2Bh2Pyl0WmrBlYdWms GJIroKa5rWz1wZ41CEI9s8e1uZ30L3DEYJckDZY681wepJmofOhsQLVju5b76Pqn wxiznvivYPLIo0daha+3cTsLE9+rzLpD9b6vzsetqefBD67U1O1y6ia/x1c+wH2F 2E9UZOofjsAEm8XhgSEwSEC5JeRinQlRdt+uvkJQ== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47dj5tqs1t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Jun 2025 09:37:06 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55O6WoO9002499; Tue, 24 Jun 2025 09:37:05 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 47e8jm36fr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Jun 2025 09:37:05 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55O9b3ug37224872 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jun 2025 09:37:03 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4A1822004B; Tue, 24 Jun 2025 09:37:03 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DDDBB20043; Tue, 24 Jun 2025 09:37:02 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.111.32.36]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 24 Jun 2025 09:37:02 +0000 (GMT) Date: Tue, 24 Jun 2025 11:37:01 +0200 From: Alexander Gordeev To: David Hildenbrand Cc: Dev Jain , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: move mask update out of the atomic context Message-ID: References: <20250623080440.3005693-1-agordeev@linux.ibm.com> <4214d6d6-f8d5-43b3-a413-f576fdaf215d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4214d6d6-f8d5-43b3-a413-f576fdaf215d@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: PJjezoW-OjHIXDCabrdGssqB8lpxBmor X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI0MDA3OSBTYWx0ZWRfXwpWOgiVsp5J/ zwkxus17L1WfD5Wfk9r1y1DU6djl3jrs7Y9TY68iA35MaSv4xFbpQ3FVa1mn3WblCpE+7kCgJZe WpBnC5d98e03DZq3hmJUv2TtY6S/TRVgdhF5dEbWMGQNM6dnmt2cUru8TF2geuReCEk6DDJ1PM5 8QrpE1n7yzGchcTfrKWFRHII7XXzNgJngOCFWQpN+oVqlvQnNDu0msEv8efwGqB56MUUy1JAz+B e7iFIR1Vwwk3PKuYTSe9m5+mn4UJUOCgC27InyBQJpLOyPELlLdhmtegZ1kf0WtddqefB3urVI5 H+/5cg1+OnAOrXEgxAqJc1nZRuKAXEQD6wdfsd6uP2nvneN3An5v7UVMPfUQ9iMNrRPnzwBsPSd 2niLc4Vhb2/iOsERCQ93FdOf9UPquoCAgOgADIbS7zhBGx/+mqoPdsc/WqPtRufpoWaFyP+7 X-Authority-Analysis: v=2.4 cv=MshS63ae c=1 sm=1 tr=0 ts=685a71c2 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=nENOSrSBMpMrXF5MCvkA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-GUID: PJjezoW-OjHIXDCabrdGssqB8lpxBmor X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-24_03,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=550 impostorscore=0 clxscore=1015 phishscore=0 malwarescore=0 suspectscore=0 adultscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506240079 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9D653180004 X-Stat-Signature: 5the9ywetwpitsh1y93eygo77yo8a3x6 X-Rspam-User: X-HE-Tag: 1750757830-348561 X-HE-Meta: U2FsdGVkX1/zrg8ylrxHdPE9tZTHxMnUlLphNAPx9AnUMfF28kEHPF4fJPYTdwasUCp2ZHsetFX3yCE4z7M3kCrYiA7TvJQGsb/9owayYoBcl7nBBi/Mp21sQpzJkhM08EIk0pXR6HurV0U+llFvNXkAtRjWVC1U/ryCNRruWsJIqO8aUSMx4SGa11v3z2pD/wH2Okt3teTnMmAd/yeJQ8LeaCsi92dqsd/tsbS7DSWf8wTfqMDiT6D/gCCySGYi8qk8YyuhWVA016oFXGqoTOihSn5aZRHQi8Gds6L0IxVJbcWFdvlv/pKdLO3QLEY1riilAbwIUi/OFaO4VWr6FffL5dD04HON7bacUpllTCYkKgSn09oN6ZOLJD4IgrWOVwdJODfAy7M+5oViF5kZr+serSQbNjmaZFQbh1OXkmgaLZ7iagQsmz/TjgaHrou+N+BCSZ27016kd9hAL4V8IaPXBTFBYNUe/O0Jjz/k/0hGLvfcILDQ6CsYp2yt1i+go0XHRydrYmzL2gV7T6/Qv2ZEnYgW4Q56ap1hOt3xOHw/yZcH9BemVvXzPqmajpswuFIOGMECDdiWp2+rmMDla63ovWguiV56rfNz0JbvrCLLDZS2KcggGjfsLrMMgJg1PlDZPvOp98fNKbzdg3tuu3pPoFk+S6wZghzwfukxMMoa3+Gy1S/JQELaDCNF69bAVowLCaJAO1LfH0TrOyKHyNGb3a2lWuwkTvcVRIiu92x5izklu9X6W62TMBCa7UzZeQnzP756lsbD/ljCEFUTga8BPBtDWEQRh/KGya81KUp8Hyzd5CFz1u1uXRq+IpyFiK5TW0Sn8C83qWehtGVKmDBn+ODGxc9cz9XuD7bSdnRCKzo9DWVwNQ8B109qRx2z/qM7G3G3YI1UVWSZ63pW68TsKtwjc4yOEEpYOpcGOb51g4KOCR4W3ubWLi3d/2KHwOgE57bTflmzN/5JIHz BCDjx8oO jmli1bHvTMiwQp1i1Vxa1zil/redbCsS2EWwTb7cV2zBh28+KGq1d+N5Qt4637qcQ85WjXi3+X7HX2UJ9NUyCcLCYlYJTv4n09L2OYdUKCNqqWkFKTv7rt+hG6G+LwI79c0Zw17rncHHhna7pZHmMM0VhI06GM+Ycy8BiYyaBj3+zZHf5hOk2X/8DgqBOaaHR2UFLaZ0QA2GTmnlDjswZO/NaZjJCw/EheCsg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 09:45:34PM +0200, David Hildenbrand wrote: ... > Let's ask the real questions: who checks PGTBL_PTE_MODIFIED? > > I see > > if (mask & ARCH_PAGE_TABLE_SYNC_MASK) > arch_sync_kernel_mappings(start, start + size); > > And then > > arch/arm/include/asm/page.h:#define ARCH_PAGE_TABLE_SYNC_MASK PGTBL_PMD_MODIFIED > arch/x86/include/asm/pgtable-2level_types.h:#define ARCH_PAGE_TABLE_SYNC_MASK PGTBL_PMD_MODIFIED > arch/x86/include/asm/pgtable-3level_types.h:#define ARCH_PAGE_TABLE_SYNC_MASK PGTBL_PMD_MODIFIED > > > Which makes me wonder why we need PGTBL_PTE_MODIFIED at all? Is there some other check I am missing? > > (same question regarding everything excepy PGTBL_PMD_MODIFIED, because that actually seems to be used) AFAICT it was thought as architecture-specific: /* * Architectures can set this mask to a combination of PGTBL_P?D_MODIFIED values * and let generic vmalloc and ioremap code know when arch_sync_kernel_mappings() * needs to be called. */ #ifndef ARCH_PAGE_TABLE_SYNC_MASK #define ARCH_PAGE_TABLE_SYNC_MASK 0 #endif Not sure if that needs to be addressed at all. > -- > Cheers, > > David / dhildenb Thanks!