From: Baoquan He <bhe@redhat.com>
To: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Harry Yoo <harry.yoo@oracle.com>,
Suren Baghdasaryan <surenb@google.com>,
David Wang <00107082@163.com>
Subject: Re: [PATCH 2/2] lib/test_vmalloc.c: Restrict default test mask to avoid test warnings
Date: Tue, 24 Jun 2025 17:34:12 +0800 [thread overview]
Message-ID: <aFpxFF9a40lFx+v+@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20250623184035.581229-2-urezki@gmail.com>
On 06/23/25 at 08:40pm, Uladzislau Rezki (Sony) wrote:
> When the vmalloc test is built into the kernel, it runs automatically
> during the boot. The current-default "run_test_mask" includes all test
> cases, including those which are designed to fail and which trigger
> kernel warnings.
>
> These kernel splats can be misinterpreted as actual kernel bugs, leading
> to false alarms and unnecessary reports.
>
> To address this, limit the default test mask to only the first few tests
> which are expected to pass cleanly. These tests are safe and should not
> generate any warnings unless there is a real bug.
>
> Users who wish to explicitly run specific test cases have to pass the
> run_test_mask as a boot parameter or at module load time.
>
> Cc: Harry Yoo <harry.yoo@oracle.com>
> Cc: Suren Baghdasaryan <surenb@google.com>
> Cc: David Wang <00107082@163.com>
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> ---
> lib/test_vmalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Baoquan He <bhe@redhat.com>
>
> diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c
> index 7264781750c96..c1966cf72ab89 100644
> --- a/lib/test_vmalloc.c
> +++ b/lib/test_vmalloc.c
> @@ -41,7 +41,7 @@ __param(int, nr_pages, 0,
> __param(bool, use_huge, false,
> "Use vmalloc_huge in fix_size_alloc_test");
>
> -__param(int, run_test_mask, INT_MAX,
> +__param(int, run_test_mask, 7,
> "Set tests specified in the mask.\n\n"
> "\t\tid: 1, name: fix_size_alloc_test\n"
> "\t\tid: 2, name: full_fit_alloc_test\n"
> --
> 2.39.5
>
next prev parent reply other threads:[~2025-06-24 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 18:40 [PATCH 1/2] lib/test_vmalloc.c: Use late_initcall() if built-in for init ordering Uladzislau Rezki (Sony)
2025-06-23 18:40 ` [PATCH 2/2] lib/test_vmalloc.c: Restrict default test mask to avoid test warnings Uladzislau Rezki (Sony)
2025-06-24 9:34 ` Baoquan He [this message]
2025-06-24 8:30 ` [PATCH 1/2] lib/test_vmalloc.c: Use late_initcall() if built-in for init ordering Baoquan He
2025-06-24 9:07 ` David Wang
2025-06-24 11:42 ` [PATCH " Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFpxFF9a40lFx+v+@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=00107082@163.com \
--cc=akpm@linux-foundation.org \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=surenb@google.com \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox