From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE0C2C7115B for ; Mon, 23 Jun 2025 19:38:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 526EE6B00C9; Mon, 23 Jun 2025 15:38:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D8216B00CA; Mon, 23 Jun 2025 15:38:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 378226B00CB; Mon, 23 Jun 2025 15:38:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 261A26B00C9 for ; Mon, 23 Jun 2025 15:38:42 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C67B81A0C59 for ; Mon, 23 Jun 2025 19:38:41 +0000 (UTC) X-FDA: 83587677642.21.1D27593 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf21.hostedemail.com (Postfix) with ESMTP id 1A92E1C0004 for ; Mon, 23 Jun 2025 19:38:39 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=HZ14eQx2; spf=pass (imf21.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.172 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750707520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OsDFFNadcPKAi2oIob212fTkg2LjML9Ql3EAFUmRUHU=; b=oXXcwHK2vjmdLFCnfwZnTZ5qxG3H730nNcP1LQRQSJZ+8U+GSthp+7wQb5vCrEVzefCZXl ChCmQ4cZtDSpbE32WPDUrgXyYFdnmfJ5GdYrktqtE66I36wkqYgiI45ofJNOemO4GB186j WPKv5sI+rOHmHXk9uoC7FGcfEJC8ry4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=HZ14eQx2; spf=pass (imf21.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.172 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750707520; a=rsa-sha256; cv=none; b=f59/IIpHC7cqSC90e/8mh6oyQbYfybp6tjRTNzxwIePh4JTrzs0U0YbVVvd+GV4x/GmWZF oRcxhzV5lgbVOoMq+Sdbs9knW8R87/oLnXPuS54TKEeaOH65PGTg4YQt2kS4HAZTXHLISF WgZrEN4G9NHAM5zIAVNVXSG/nbfwmxk= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4a43d2d5569so60904611cf.0 for ; Mon, 23 Jun 2025 12:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1750707519; x=1751312319; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OsDFFNadcPKAi2oIob212fTkg2LjML9Ql3EAFUmRUHU=; b=HZ14eQx2QYAltxKhGvJtNFKHQ9A07jA4I8a0JQJajD85qdou2QQrd38aCuuMPJnvyg yf8ISUQ4xEdZkk3rTSwbj/qJCwj0hbqG+XbGxXcoEQmhky8J3sgsceQqgX4Xw1E7ZYeK HKmAmf5db3utxbZVLdNvfG/nfzF0RFaMisnRNT9IEHZNlpoi60Wjb08HDe18ocRIF6nu 3TM6q91PKqIh1gDvlgAilSMQocN8gP71A59zZ7i7tFWcvZYpFRvpVDUmIUoX+xwuoyoa XwxvPdVydkiA9NFHr/+QpA2k4bW7ZsNveDwFusLJbhd9qvnsownqvIJOX4ve/8SjBUtz a+mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750707519; x=1751312319; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OsDFFNadcPKAi2oIob212fTkg2LjML9Ql3EAFUmRUHU=; b=L19Mb704GSeKcnq1szcNHwvKcoYPkd5+hWdVdCMX1+lnuv//rizQmNrueDL2FLCoof 5DG+UdaWujDPBUjpt6MQsMKjE8xUvNoNRnYMbKKjcN/CBVdRGOlVva2AepliXXfTU32h ZeBYQqWFsAicHexkfzVxja7zf6nixKwDBzRFrXICqelHAVzLCJXnOU9+Lhqh6vZUtPHS b/J/ZKGeENKDna+8pYTPPfRokPSpomtkes0ZgoDIrgdb9vCaHHigIfg6m9B9LO/sqhzF HzSweerU5Yv2DAs1UvcYVB/8x4DXuJfptXevGBWYNh2ycvhNzhp53t6kwV/zPdkInxpp bEaw== X-Forwarded-Encrypted: i=1; AJvYcCVf/vGAGZxsw3cxe3m06ACg00Pu7hKuwj3EjXD5MvYSdj0LrIGkc6X0droNVljIF7cTi88ofuE7wA==@kvack.org X-Gm-Message-State: AOJu0YwFGuf1ahzCfhuUvKrZ/WIlE9trK2IgrJ/n0y8Eg9VupWjEB1Pf 6wIc7/xUIBFfQ+p8TfqQ/J8+8K5OCtSWTz+4/TC8wj5wD0GUUAQrZMaFClyn6zJhyBQ= X-Gm-Gg: ASbGncvQd6Sa7JlrOWq5kMJ7yqXxWeZcE0k/7vdYReC8A+CFYXmtQSkWiwF70Z/rQe8 D8+rh+L6QK6glQ7Xntm9lJLYAsu5N7s1QXlDzb2rZY1nUXDcdbB4PxqyzbRx/51dcIwkTdFK1xR yfE4MexjLnXBc859iQ4cjNuiaj98Znbm2wpI7qp3LTtvtYaYu/VOwDyXKEz/DNJFEJYUEIo/9TP wCXQYKjUZFOdRGwWpGWmmIn4k1GXZYmsgeIZMN0ya1U+5Vwdhe7UD5ypZV6MDZQksofE4YYza/n 6XG89xP7s5IcJuKnRVW1onCL8YB+eZJCg169EBu7b3KJyxacLC4NEzLRnA== X-Google-Smtp-Source: AGHT+IGEe4owoKuwDVOewVa/4Edect3j8Yf80FLCWoMblOwP+OBaPb93AZugTiBwPwwRicj7AyEi8w== X-Received: by 2002:a05:622a:13cf:b0:4a5:8387:8b9f with SMTP id d75a77b69052e-4a77a24bc82mr181710941cf.15.1750707519236; Mon, 23 Jun 2025 12:38:39 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F ([2620:10d:c091:400::5:e19e]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a779e956bcsm41726641cf.74.2025.06.23.12.38.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jun 2025 12:38:38 -0700 (PDT) Date: Mon, 23 Jun 2025 14:38:36 -0500 From: Gregory Price To: David Hildenbrand Cc: Bijan Tabatabai , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sj@kernel.org, akpm@linux-foundation.org, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, ying.huang@linux.alibaba.com, apopple@nvidia.com, bijantabatab@micron.com, venkataravis@micron.com, emirakhur@micron.com, ajayjoshi@micron.com, vtavarespetr@micron.com Subject: Re: [RFC PATCH v2 1/2] mm/mempolicy: Expose get_il_weight() to MM Message-ID: References: <20250620180458.5041-1-bijan311@gmail.com> <20250620180458.5041-2-bijan311@gmail.com> <0067568e-a604-46d3-96fd-41b62968a90e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0067568e-a604-46d3-96fd-41b62968a90e@redhat.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1A92E1C0004 X-Stat-Signature: jf1qfpfh96hgj73rnhew5zeh3wjq4wb4 X-Rspam-User: X-HE-Tag: 1750707519-953999 X-HE-Meta: U2FsdGVkX1/Iryl9FczHAkPIAPzzAyy074pX7VXhrA/M0MAVqcOaX6WeI9WW4Z2d5Oy8AKc428QYRIgNna1F9FJkTWPQ7K97Igi/XXcxAB3R5DJ+sJ/DN99ohUyrAn+cn83JLoJcDLk96aY/a2r5e5KZ6genTA1Y0MXEfXsH6hbo97RqucZ4s7pbMKiGqM/jiguBOTT+ElDLtNiSj9o79Kui1MgrlOyhtlU6LKSzsHRDoZHUkOxJ5Fbyf8ntuOc+o5ZcqcNPFetyk4CAO8f4aQUcw+Uj0NzbmAVGbbuQfJXz69nOlTIWbKaKO7pyoeoLbbTOTfc7eEozdwHClXSQ1vOgNWRVH339O60jxlvp6mHbdvrfxL/9dNT47qJcCrgVXux8Uj6n35izRQermAHhkvSua7XpckniLoFrlopgoOFXUjZHFkEyiR7ih+EKMkg4ivTW2GINqsbk/08m2KpsNtm6mrZzf0sRZyz9QvFs06W9StReH/PKB9cUuToCgtwwAnfAza/UKjD6HU1pHksTxet4AVqPZutyWIDG3zBJScO19ZRuwdyYqeuAhzR4C4WF0h4RknTMYC3H44uyPBJ248BqpiF6LppPGkJR/BP/dPuaP/pe44D+b/SodtdHLInwn8kN+2TVsdvnpnLdGzOBmdlPzQLQiJSQm9jPTz7wFindNsqj0cUJrHqQ5ib0a/LxpXZXUaD2Kx8ExRphBGCrAM74e51RzZ+CMK154KAEUCJLhfVCuxsJXG/Av/D+GXh7l1Nv7rMgWfL37cxZgakJIuiuaa5U7CBvBvK15NE1Y4cpq4qV+XsEoVMdO8l/m5rjow9hratPyGg/4S+PsQqcSMlkx60aXAmH/kbIybHv5l3H72lhtk5/atv4mH75rRa02hkKGnfhlI/KDVnn/7jeck94Jmk5XMCu9tB9yNcrh8Nrz5e+9xjTWvIfYRfxIPoNMZ6KLCUgUCdapOy2Vcn 8X7oH7d8 ZxpIv21msXxc+6gUJjPhd/O45nndDi0nWgCXRQEB1qgIXLpDzmRtThvZrdW8I+k1j32ai3nQXGwrC9bABHslTV1vk0QfXbj8Bhi/1pHUfpJmWY5cKq7M6lgJTmx8nhIz8BFO4wmyMSuYX+PAg0wNiMSOrmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 09:14:34PM +0200, David Hildenbrand wrote: > > +u8 get_il_weight(int node) > > The function name is shockingly confusing when used outside this file. Do we > have some namespace to at least highlight what this is about? > > node_interleave_weight() might be a lot clearer? > this is fair and my fault as I didn't consider whether it'd ever be used outside mempolicy. So i agree it should be renamed or wrapped. ~Gregory