From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18AA5C7115B for ; Mon, 23 Jun 2025 18:12:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7A358D0008; Mon, 23 Jun 2025 14:12:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A29FC8D0005; Mon, 23 Jun 2025 14:12:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F1D28D0008; Mon, 23 Jun 2025 14:12:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7DEA28D0005 for ; Mon, 23 Jun 2025 14:12:45 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EDC60C0B8C for ; Mon, 23 Jun 2025 18:12:44 +0000 (UTC) X-FDA: 83587461048.18.3F48569 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id A66754000A for ; Mon, 23 Jun 2025 18:12:42 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dZSoH3tS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750702362; a=rsa-sha256; cv=none; b=2CzAGvJnjPTa/Inlr5WTPUvDwfzvlCgVjNPuEb6oX7s4Ai8rtywBuCmkRCMDtZoXh0dm6y 03PJ1jY/ik1VCOfuIctJ9qhfWu6RUu43SmWX5Itpk+b9HKRx8jX2M71vGdlR5hNY2pa3M3 STe6zzp56PvcFwwuL18zcf41v9DxZ04= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dZSoH3tS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750702362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Iav4YsZh0lX7sUJ5ofhiLBwN9GmAGN5M/lgmtGwU0kw=; b=g2AoUn1nLDm36o9a/K7l2uyC4X5YMDZeN7OdmTz1MD4D0gjmFPm9Uk2CE/eInMIoFN3jdu FtIwo3mItoi0nAjUuoKn4A/if8pVawANlRIhzmEkZUKkRu6WYdt5/ADHrSSI6VnuELpwmI vfdx8qDYILxHJgeQRamM52KNc3mAdbk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750702362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Iav4YsZh0lX7sUJ5ofhiLBwN9GmAGN5M/lgmtGwU0kw=; b=dZSoH3tSAeDi/JQbDk/XgmxhdFTu/cG1CsqdzCvybEtyXp8VoaBeE+rkWBNKP7qBGDQjv7 WmvbQie7ERyOcokAgt4xBB6AyOR/9NCh56FxwbKawqr8SjSxdBip81ORIaYkjzXOEZ84ug ZMe6jVycmQKQOomdNUiSA7rCCnKTWuY= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-5kFU1vR-Owy9x4Y9d3Ss2A-1; Mon, 23 Jun 2025 14:12:40 -0400 X-MC-Unique: 5kFU1vR-Owy9x4Y9d3Ss2A-1 X-Mimecast-MFC-AGG-ID: 5kFU1vR-Owy9x4Y9d3Ss2A_1750702359 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c790dc38b4so728565885a.0 for ; Mon, 23 Jun 2025 11:12:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750702359; x=1751307159; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Iav4YsZh0lX7sUJ5ofhiLBwN9GmAGN5M/lgmtGwU0kw=; b=G+LYelKgbuLAnlJMEs9y7laypORTPnDszWYXSk0SQ7uuBKk42NUYpnEzXIutzgjQrN IOc59E1u8xXBAjYinbDmSw8nT/7L+B9kMXJJsL8dCvOoeaaCwRtLf+73c2s65r0AXeZG Gm9PjchUQlny2PnxJywvmURhJOiO83HXhcGVhuu4s32Mp/UwwEpycPeNr3PDlPLkKZYv /shYmqQS7leKlO7hlbZFWxO39f9VtuOA7MfCAePL1gsv7zKf7ftYIQgvCnF55gm/z1u1 dmWzPlsmWmZgBj8aHxHEjXJ2qD/gznOvmWLVpC+1Cmic19yoRsPxG0gsAjzfCiWsjL+P lReg== X-Gm-Message-State: AOJu0YzQtu3NHR2kcZavnXWU/VMaCIiihXDxOtike/aLcxZuTvFNB8S3 8m8N52EtDykWiE4UxZOafLH/tEl7wte/1KEbk6evqpfAj5U89V2kmt5QZHkMVZAS7OH/7X//7gt lbPfXpdKlJPmloSbI2sDBV8MXQo3fBNoIuomA+RH/kf+gBBbez8G2 X-Gm-Gg: ASbGncsrEHyQcYP3+TY02kAXnlTOE/+uLQZ1gzI/D+3w+cvNVG+GQcFPd0AwI/Z/dQr f6I8H3AqWUdLUYH/vQ47Fz+INUfo1o2ZFyzjtdtjHVvrRmghjFC58oFouHPnEGEOrz0173ZeEAX kbopAP0douuaQDGXo0ibBqrel6fLfhkNVXYvk0IStcVTysa3IIkRaUEae/HJ0pVOnike26o09ut kNmUdI4t7lWUksABU/r+KLiCb/IADeE7F/672w3UtUg+6+RpRr4IOAi6261+IhetAeWT+Zm9Ios OgZW35b30v0D6A== X-Received: by 2002:a05:620a:838a:b0:7d3:910e:4a76 with SMTP id af79cd13be357-7d41ec19ed4mr68831485a.7.1750702359238; Mon, 23 Jun 2025 11:12:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgT47ZCKXFLELEORYNnyqp2jHGSbfohR2YiK4ItxepExn16fOZExu87ZTR5++yYdLc7Raq8w== X-Received: by 2002:a05:620a:838a:b0:7d3:910e:4a76 with SMTP id af79cd13be357-7d41ec19ed4mr68825685a.7.1750702358681; Mon, 23 Jun 2025 11:12:38 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d3f99efa3esm415953685a.75.2025.06.23.11.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jun 2025 11:12:38 -0700 (PDT) Date: Mon, 23 Jun 2025 14:12:34 -0400 From: Peter Xu To: kernel test robot Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Nikita Kalyazin , Hugh Dickins , Oscar Salvador , Michal Hocko , David Hildenbrand , Muchun Song , Andrea Arcangeli , Ujwal Kundur , Suren Baghdasaryan , Andrew Morton , Vlastimil Babka , "Liam R . Howlett" , James Houghton , Mike Rapoport , Lorenzo Stoakes , Axel Rasmussen Subject: Re: [PATCH 4/4] mm: Apply vm_uffd_ops API to core mm Message-ID: References: <20250620190342.1780170-5-peterx@redhat.com> <202506230216.JVgQj2Si-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202506230216.JVgQj2Si-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rbV9ns6s0CaJnOysAQevoTF6N2dPqfmChFIe2W82MDY_1750702359 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A66754000A X-Stat-Signature: ne1p8qyzg5yj9315ez8tfm1y5hto86i9 X-Rspam-User: X-HE-Tag: 1750702362-862268 X-HE-Meta: U2FsdGVkX19Cj2yZ4jA2TYLjFy9/jo3YyDpOrrBWKCioa4vYMGUYIdVU4E41GeD47aN4mGYePA5Yj6/lfo2sDcQuJ3NYdalxV/xqrmqO16j4R30O29+A2/gYQ+teu3vE4Ni5T8tBr7IcQPuQrIesD/ihjlou7iwqdY8xZTbu8JMZP58pQeH5yEXweVpvgEuJUj1OsRUk+P6itYEBhUj0ul0X9a+K+k6rM+z87NFIVWD4NOlfjoHyr+h9Bw8snftIA80LpD/WkOJR1jAuZlh0dguUyTVhNOb0OMQawp2t++M7L7WwTNY1dStHnadxO3q3E5hGZNunVLhkXF+vI9hZzCiz112mnNaP/ARt0HyTSBzriumH1ikHbDBN99C/0EyBms+nYLwPB5rCQjROc50s6VyhoXnqamVJHnGT15PYb91SxRA2YfYyXCNQUTsHriwyDO6EDf6fmWQAgzhwuNWXcf2xjcq5lbA0f19+HWTyDWBZLLEWP8eo7RuqFcxfWh4jzANVwtmQT3OTXjIwzCEEtvtBP1D2SxZAd3pAWdAJaFDVHk3/YPqNJBqEpuVMQt8vLfS6Bap8lMLQIElOhERfrxb0Hu3dtiVSGcPXQShFwCPSygD3B028iAnEvMOvcm/e5jcfyA84huTeRoml863IdlWmxu5o9TZWWHKVvNxfvwrMrcSeR0E9V5MNTYUYwegVQSnXgdoy2JtCk/hhMl3OfjTBGAyPh9c+9r6Uapiebna9m7IAnZj4k0qzvDDzuNIpsghfFRLuzeATGS8XYNtUQm0ciRVDYZOCy1TllKPIxVKq1sci5EQVmREuRb0ZSyl1H6l2F6LykVvc81wlBSAw1IbB6SKX9/QkjYbInHxwaHjxorEOHp4WuoovITsfwPsziA5UFgRCVrlE6S/HiP0C18AKLYaP01zlPw0kQU8DgJClaKIJZI1wzdxWLjlXzqNxYPfw3pUjA9on83ZLwhb 6+MVXhVh +uifrd/ptM5GhaX82AO6uyfJmU1rEiVmC8xbLfbathZ+QjAsXjSbtLH+t9fA29pETGanhphrSVD0Mn3TwJqad77EZt8BFGbqAO28Nge/a62Vw/Fwoa2MrumiVBGlGzm8bdXjBbWP9RibPHrqaD+R//Fl3KQH8R3bdN5D9XuTA3Mbg7jbmXNiH69Vc1dwPgYbmqVB9fpk01+72NBP6UXqlfkl0tWHtaNuewivKUE1ApVfuGcHqrDFqGLIDtdjd/oC4YszA+C/GheNq03oHusx0CUIb1Als/G1oVoL+SaVV52wIBoXXaopo4HuRpKmCpeUH3da/inFkPnWsXNci3MybiG+T/C13tsfmbxVk9aJqSyQ+8hkruqoYp8mU+7RxrOHeSAg0wI8S5OszLVVA/xGJX2z1lbtOIt2H93jkzCMqND85bT0IJZZN3FMm+S79QCtipQvhO4+FA4vJ63RmDCgVT3KUZzkjLfDT3dE4qxFSjxBBHTZmvJLdmTYb80hhRm7O+AaCeVh0HtQDipgzdmc/zB9efyzFScYNzEy+LwpuHfG7h5uPZzWkJgNBdwgJ/bh145kGfnRFyrE2m2cskcQYqvx5xOtd1dD4j/7TeHHPg8YES7eh+RXQHiS3VmY+/+OwctW93Xzkfh4WPcHjmalAu63WLG1I6IQnB3n73obYl0W7bSOGaN9+emxXfyQm5jWNSZYdUUK4dZWP4+lV6lU+aEIBv499zd6SI0t/eC6Ng3J1kFa1ZWPa64BP24U5VqvWgcdC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 03:09:13AM +0800, kernel test robot wrote: > Hi Peter, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on next-20250620] > [cannot apply to akpm-mm/mm-everything linus/master v6.16-rc2 v6.16-rc1 v6.15 v6.16-rc2] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/mm-Introduce-vm_uffd_ops-API/20250621-030557 > base: next-20250620 > patch link: https://lore.kernel.org/r/20250620190342.1780170-5-peterx%40redhat.com > patch subject: [PATCH 4/4] mm: Apply vm_uffd_ops API to core mm > config: i386-randconfig-061-20250622 (https://download.01.org/0day-ci/archive/20250623/202506230216.JVgQj2Si-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250623/202506230216.JVgQj2Si-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202506230216.JVgQj2Si-lkp@intel.com/ > > sparse warnings: (new ones prefixed by >>) > mm/shmem.c: note: in included file (through include/linux/shmem_fs.h): > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > -- > mm/hugetlb.c:669:12: sparse: sparse: context imbalance in 'allocate_file_region_entries' - wrong count at exit > mm/hugetlb.c:740:13: sparse: sparse: context imbalance in 'region_add' - wrong count at exit > mm/hugetlb.c:807:13: sparse: sparse: context imbalance in 'region_chg' - wrong count at exit > mm/hugetlb.c:5798:20: sparse: sparse: context imbalance in 'move_huge_pte' - different lock contexts for basic block > mm/hugetlb.c: note: in included file: > include/linux/mm.h:1391:22: sparse: sparse: context imbalance in 'hugetlb_wp' - unexpected unlock > mm/hugetlb.c: note: in included file (through include/linux/hugetlb.h, include/linux/migrate.h): > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > -- > mm/userfaultfd.c:270:9: sparse: sparse: context imbalance in 'mfill_atomic_install_pte' - different lock contexts for basic block > mm/userfaultfd.c:412:9: sparse: sparse: context imbalance in 'mfill_atomic_pte_zeropage' - different lock contexts for basic block > mm/userfaultfd.c:498:9: sparse: sparse: context imbalance in 'mfill_atomic_pte_poison' - different lock contexts for basic block > mm/userfaultfd.c: note: in included file: > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > >> include/linux/userfaultfd_k.h:90:17: sparse: sparse: cast from restricted uffd_flags_t > mm/userfaultfd.c: note: in included file (through include/linux/rbtree.h, include/linux/mm_types.h, include/linux/mmzone.h, ...): > include/linux/rcupdate.h:871:25: sparse: sparse: context imbalance in 'move_pages_pte' - unexpected unlock > > vim +90 include/linux/userfaultfd_k.h > > 87 > 88 static inline enum mfill_atomic_mode uffd_flags_get_mode(uffd_flags_t flags) > 89 { > > 90 return (enum mfill_atomic_mode)(flags & MFILL_ATOMIC_MODE_MASK); > 91 } > 92 Sigh.. I thought the cast would helped to tell sparse on this. Looks like I need __force.. I'll squash below change when repost: diff --git a/include/linux/userfaultfd_k.h b/include/linux/userfaultfd_k.h index 6064f9542d5b..6c5ca68204dd 100644 --- a/include/linux/userfaultfd_k.h +++ b/include/linux/userfaultfd_k.h @@ -87,7 +87,7 @@ extern vm_fault_t handle_userfault(struct vm_fault *vmf, unsigned long reason); static inline enum mfill_atomic_mode uffd_flags_get_mode(uffd_flags_t flags) { - return (enum mfill_atomic_mode)(flags & MFILL_ATOMIC_MODE_MASK); + return (__force enum mfill_atomic_mode)(flags & MFILL_ATOMIC_MODE_MASK); } static inline bool uffd_flags_mode_is(uffd_flags_t flags, enum mfill_atomic_mode expected) -- Peter Xu