From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72793C7115B for ; Mon, 23 Jun 2025 13:04:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEB386B00A6; Mon, 23 Jun 2025 09:04:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9BC56B00AB; Mon, 23 Jun 2025 09:04:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8AA66B00AC; Mon, 23 Jun 2025 09:04:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C4EC46B00A6 for ; Mon, 23 Jun 2025 09:04:09 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7ED6B1A0353 for ; Mon, 23 Jun 2025 13:04:09 +0000 (UTC) X-FDA: 83586683418.26.A20B438 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf30.hostedemail.com (Postfix) with ESMTP id 2EE3F8001F for ; Mon, 23 Jun 2025 13:04:07 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Xzi3226k; spf=pass (imf30.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750683847; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m9hELVzQV/CVu64h3X5ywumxR1ai3ku6k0P1BVVTc5U=; b=FMIjqfcQ1JxYNNvkf8kcj24wWLLw61wM+EJIKsJnOJ1885H0uABuvYLkdXzxrm66XScee6 YCuyk1V84GGSBIisqbNOxb8NAJOKTHhje66TmWabAfPsroedd9ztWM8QrXApXgSraLFz+u Tb9Wq/8NqiMpxt/d9Kv38dQ1K/9ZDwc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Xzi3226k; spf=pass (imf30.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750683847; a=rsa-sha256; cv=none; b=XA6sLNl9HC9nO8FKOXQtLc+SqPRDy+U2Ja2u7uEPRNLSgUlW7KJ+rSj169SNqvgj3p8oVs IgIm4wULmp6gtjWYPxsgWgKC6DP/M7GApPXfYlWTg763K3B01YyVoyLvntvs438AU1RW7p QHrYqYnN8BGZuGv2vBl2sgq3Qv5rhD4= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55N9voZh005257; Mon, 23 Jun 2025 13:04:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=m9hELVzQV/CVu64h3X5ywumxR1ai3k u6k0P1BVVTc5U=; b=Xzi3226khVmgxROOyNhHsaS/r+YCftnnz1r6uXRSLIV9TO 4Q+kwPHj+KOE3FdCYdJOfKuQUGnE6GHYUi34ec1ZkfYwfKbLBoKKA4uvHN5PKIXc f1DIii0OeDtZJAOGPX5XBiRIYib2M2KnSdPK6MXDGiI5KW4RWhuBpqdUCNamKDLk HTCztzohRPUAym2OA2VNvt1ef99Xesj0KO4vPID0RiHQMdMTtysUmNm/XB4Q3jPc VmSZLbhqHbxqVYoU+FsJBpziZw4HLmcQ8PYe/ZeYDGQ4z8504EbIEDmXtcYj4Gta UnNG4QlAyB9gsW4H3k7MRct6g0d4/ICbFhItR6yg== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47dk63hyn4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Jun 2025 13:04:03 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55NCJ9vU003980; Mon, 23 Jun 2025 13:04:03 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 47e99kefpr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Jun 2025 13:04:02 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55ND41Kw48497118 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Jun 2025 13:04:01 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 26B7320040; Mon, 23 Jun 2025 13:04:01 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EF8852004B; Mon, 23 Jun 2025 13:04:00 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 23 Jun 2025 13:04:00 +0000 (GMT) Date: Mon, 23 Jun 2025 15:03:59 +0200 From: Alexander Gordeev To: Ryan Roberts Cc: Dan Carpenter , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmalloc: leave lazy MMU mode on PTE mapping error Message-ID: References: <20250623075721.2817094-1-agordeev@linux.ibm.com> <107bfdb7-c8f5-45fa-872e-3e6928dc8025@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <107bfdb7-c8f5-45fa-872e-3e6928dc8025@arm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjIzMDA3NyBTYWx0ZWRfX70/Oa6vFHASv v/6hhtT+mIc57m8r+bFaS/YNqR+d4fx8hrbX7skWqGFDsokHeabeqBgWYZ7DngB1xPPmNSlWdD4 /TFYKw3nn/PDpxaQ0ETg5b2+Dwb/qIklh3VH/mcwPVWEGANk1DvvWu6arVvnPaWZuMNqosqqlbF XdA8NG3Vpzk3cSvGg3dCb+4X5ULGffpQEDnqYMRrRbrGQ1P1/2xm3Qe3YXXc3Pw5EowiG/npnZH cozLZMugKBOEQU2WhsTBelhwmriwqBnKbcT4baHoxiX8vxP8wDs2nF1lDnUH+u+DxrbRPplhQZS MjkcrGIqEOxMzBA3BErlrCchx7AiehZ9/eFdll4iPl/c/YTERbR7EwHGjiILPxQJEpgsseOSnRj g43cGr6ucKWlZ6QVJdX+rCgy5XTNVTGMkq93I/cttZfcDPL+BUw/LhfmdtYZav/B3pIAAOoF X-Proofpoint-ORIG-GUID: otpcNOh7C6nwTbelLw_ZvPmJMfw4xxjg X-Proofpoint-GUID: otpcNOh7C6nwTbelLw_ZvPmJMfw4xxjg X-Authority-Analysis: v=2.4 cv=BfvY0qt2 c=1 sm=1 tr=0 ts=685950c3 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=KKAkSRfTAAAA:8 a=VnNF1IyMAAAA:8 a=7CQSdrXTAAAA:8 a=5IMxBn348DrhKD73ucoA:9 a=CjuIK1q_8ugA:10 a=cvBusfyB2V15izCimMoJ:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-23_03,2025-06-23_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 suspectscore=0 adultscore=0 spamscore=0 impostorscore=0 mlxlogscore=914 malwarescore=0 phishscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506230077 X-Rspamd-Queue-Id: 2EE3F8001F X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: o9nztbeirsj71aca38y8zfzhsprzpo31 X-HE-Tag: 1750683847-956255 X-HE-Meta: U2FsdGVkX18alLjuTzHUriSg/YyQUf5Qxb6KrJ1d93PAHokDaypmzviZUpdRB1KXilwp2x1fdTZFMw/HB8XKACjnzjm75tl5HhxE15D37i0wEQNK8XqR+wW3anTcDE93cGn4VTu+F8vbXeqc+7jbuxr9AHGqkTRaGqw+2pLnprYf6QAeAKB+JJ4K/3wWR8Jaw71UyClauNnagfq/MStvBODVRJ0+TgkymhbUdKOMBJDraJRROJKTdT4R7VmI/3tRSL/01ojFPSZxPOpv1+Cyx+op4LhXkuSwUWDlyXChzxgS0RBrOkre8Obb3gZHXYjbk/O00hEpBg2s9xKQhqPlItyqh5r6GUJh3qRdwMtP+Zm3dgNwQcKo1jeKY2PcQ5Yh3qLa1ZbctOf5xnSiHrnFUsYT3m1EnhYLp3gTBHJyqFmMooZ/R0Pt5KvarNBcHhLMbXB54Dmq21on7Ft3QnQBzY2eCiTEZ149gDglUdiqBjJ8rlDENYoWVqQnyOLjNDuR2mKFDROUgHGc4L3ijg9DtiiFcy7+GCSt2SZLHJ/QGmeD6kIP4QFVLq8t9B90lQNznKztjxoEO0D/qiYFtvcschEI0jfTznfr0yDFoUbxXBMjEd6BsCCXcldmKXidJcRGWecYYC2L2Y+eHybBXc3izzFXbabyrjvwYu7cR2JD72bsbgA0E9PfTCeDPg5WaSTzV+jJzQt80TgN3YnuLZgKBod1FxsDG4eqNlVLbOsD9P2Q0hx2behPvjAFdHORsnFtjsTe2k35REe7zdsqiB0Da8TMCDi7uf4QD/sa0t2dGML4zI1yvRIGyU36ExiO3qbQVmsAAmpWy1RmI/MDE/N6BBPltVIZkpOI1TFwKPKAZA8GZC7cVw1gE2z6ym4iRvq+BtjdOvt8TBpyHiAqdpIqLlSsWlbWt5eh8y+6sn0uAPRq0XgekevIvQijiOE/LTcTuqv40OBj6EDo7esEggD voDfZ484 1pcBqoY7PIsQh01gBYmI8Nq772r379ZinPPOwUIbxRLz+aMltH/itY0H9r89Ka4Zske7hZVtzDSi5XSZ0fCWVPeNuASVv+GlpUf6kF/irGCT7m5sum54wc0TpcR2e6xW41Dbve44c+QDUGCYBiucClhAEDGYa43sBIpVirChPGR/EbHUo4e4/LOQoEfm4RurZWGYt+dp7+4Ln3QwXtYBKNsx+LHtzRthxN4OQw4i1QlosYb+uDH0FZ5n5hpJv3rIPhOAH/KCPR9DWTZatgsqQzKCpm1N0UB8PptvmJeJBwRMIJJQPWhoZHY/HqbrJbSZsxdl5mU7eEbyiPA6fz7HQQz3hBCM9ZQ67blLsf9PY7KxBJKFDLAOgaYl/4i+Ww6ULgYdqcKx7+g3q7Rc8DC6LoTfu4Dzr629gg42CsOiP+gn3kqFktiImu8Dv7WXd1fgyNuCFBh1GJ+nR1SMqd2VL/iNaq5YGnGvf95UOJF1RS5wXnwIEXU2ceDs6wQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 01:37:11PM +0100, Ryan Roberts wrote: > On 23/06/2025 08:57, Alexander Gordeev wrote: > > Function vmap_pages_pte_range() enters the lazy MMU mode, > > but fails to leave it in case an error is encountered. > > > > Reported-by: kernel test robot > > Reported-by: Dan Carpenter > > Closes: https://lore.kernel.org/r/202506132017.T1l1l6ME-lkp@intel.com/ > > Fixes: 44562c71e2cf ("mm/vmalloc: Enter lazy mmu mode while manipulating vmalloc ptes") > > Signed-off-by: Alexander Gordeev > > Ouch, sorry about that! The patch looks good to me so: > > Reviewed-by: Ryan Roberts > > I wonder an aditional Fixes: should be added for Commit 2ba3e6947aed > ("mm/vmalloc: track which page-table levels were modified") though? That's the > one that added the "*mask |= PGTBL_PTE_MODIFIED;" which would have also been > skipped if an error occured before this patch. Good catch! I think it certainly needs to be reported with Fixes and I even doubt whether your commit should be mentioned at all? > Thanks, > Ryan Thanks!