From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98EA4C77B7F for ; Mon, 23 Jun 2025 09:37:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D0176B0089; Mon, 23 Jun 2025 05:37:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A7716B00BA; Mon, 23 Jun 2025 05:37:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BD486B00B2; Mon, 23 Jun 2025 05:37:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1C32C6B00BA for ; Mon, 23 Jun 2025 05:37:27 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A0355EDBEA for ; Mon, 23 Jun 2025 09:37:26 +0000 (UTC) X-FDA: 83586162492.22.71D11FC Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf25.hostedemail.com (Postfix) with ESMTP id 5BBD3A0007 for ; Mon, 23 Jun 2025 09:37:24 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="dm7qr4/u"; spf=pass (imf25.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750671444; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l1TtOuRllpOCNnGMcD45DT7zyGjF1iie8WDbcU0BFxU=; b=YGcxrYSqdsy32DUdvTV0vIlxq8cCbpzaSdbBdzzUQ/Is1AsKTRz6ohRxAvTgmfZjkoF2dP 9JY+uA+WsGZEVfcrq31XTIsbMs3wy0CfaxsfKp8tAgzAwnGw5WsbwFuxwBVVVeXIAuoIBv MLWVT/QJVRA3XnGDsqwTEX5UK+jMBC4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750671444; a=rsa-sha256; cv=none; b=Dd57FMpxvLxdS314XUHHBj/83c+KZFHpUTQeZSYxbAyYn6rvshvzWT9n6DnNSALNQ9ft1q Roh8yJSLvj4VFzTW+ued77MubJcg7jAMB5rJvbVR313xY1A8fBteLzYKNXfvOI1Oq6AqQB G5Lahd/KreR+Cm74PEpj9d9RTD4JoY4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="dm7qr4/u"; spf=pass (imf25.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55MMjbjX012278; Mon, 23 Jun 2025 09:37:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=l1TtOuRllpOCNnGMcD45DT7zyGjF1i ie8WDbcU0BFxU=; b=dm7qr4/uPkHO4DV6fiky9VzQsNVA71uh2lP4D0rVvrdhM8 Oka3X6B4ZKqEWbYVjuh/Gr7uRJk4QTxYTDUkytZnu95OLIwlqADCZ2wTBcw49cMO 75v6I3f0nxJSpHyqZaOdA7HIDIvG11XQL9RU64KNch7Gg8OVDkTDVo1rILPKCyPT SIc66xz2esrh5ktMrVxz9B2SOF88jWvHw2YCnqOF5V16q1fZmb8H9I24euqOJz1W bacPcMpGMWM858PEI6HqgBRjS9F6nNYxcp8xKYy1+sB+aOUStlMbfWiv5uKB5Oqo VqTAE6nCHrNF7pnKAefvhwGHAqAFv+yVzCzenYLQ== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47dmfe0nhm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Jun 2025 09:37:20 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55N9R5JW004643; Mon, 23 Jun 2025 09:37:19 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 47e99kdaup-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Jun 2025 09:37:19 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55N9bHq633620450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Jun 2025 09:37:17 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B565D20043; Mon, 23 Jun 2025 09:37:17 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8D3DE20040; Mon, 23 Jun 2025 09:37:17 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 23 Jun 2025 09:37:17 +0000 (GMT) Date: Mon, 23 Jun 2025 11:37:16 +0200 From: Alexander Gordeev To: Dev Jain Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: move mask update out of the atomic context Message-ID: References: <20250623080440.3005693-1-agordeev@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 2G9D2zeuV1BGw5-UikZsaNQVpHz3CkAR X-Proofpoint-GUID: 2G9D2zeuV1BGw5-UikZsaNQVpHz3CkAR X-Authority-Analysis: v=2.4 cv=BpqdwZX5 c=1 sm=1 tr=0 ts=68592050 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=VnNF1IyMAAAA:8 a=QBSra2SYcZg9TIse_A4A:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjIzMDA1NCBTYWx0ZWRfX+L4UXNbSV4+T tBTReFTYYwutmoz0knu/XNIKLBq69M7aXgDRLv1bitj4RYXanO99MFD2NenfqtGWe2cMhsNIa8i 0x8po7TjkMyQrVlIBLxIb5atSCZ4MrVR+q1NYBu7hi2gcEoplXyk0sENGggFplod6zQQu86Yxlx B6u+ySvJYAve5iZpVPVeEK7t5XJbr4QmAKsvz3bAmaXOScf8ix99qDSSWh/Tydams6aMyz6hxJ7 YOkWV9TWLJ0zpnQPCbI5ZM+ipDbDhkmZR6WDfA82ioSP77PNaY4of34ugAhONY1ctPFfjrPxUoa ZCVjdg5PHUKA/TwJDi5jepKjYgKzULAAXl/gJIyX7ydqS9W0wEP+/VDHEUgR2TFG4wLL/8omCe0 ee96nHe8I/Gu8jTeWoSTaZxOksFdGXiNNsjRRpGQ8oH861hSYwDsFIFSWql6bNtnARI3mRrB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-23_03,2025-06-23_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1011 spamscore=0 mlxlogscore=861 priorityscore=1501 phishscore=0 malwarescore=0 adultscore=0 bulkscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506230054 X-Rspamd-Server: rspam03 X-Stat-Signature: z1hi5f1csemie3diuhruzkq9tahfh5cw X-Rspam-User: X-Rspamd-Queue-Id: 5BBD3A0007 X-HE-Tag: 1750671444-333247 X-HE-Meta: U2FsdGVkX191R9QF/ZL8DVA94NpbCkeoR0MtUb5/Jla7qULc4iq8MTpv7FhGMlRkXwXx8r9zkQT8ABqDudjf3IB5rNEtjp3n3Wx0uCkDZ2WfOobHBWr92dU+RSyYFHpUH6IKTQ33lF1DtqVz+gVxpbLHBhdXfLGD21DlxAJhA+0u/T7qNKWXdC1W3mna+2HkfkXpd+g2l0l508Q0m3HfIB+aXoSKpehNhSXz8/r4d24fB9lPzASxLUnMx3kXYfFYAqO3onnPfnxsEgmX0HLewttwqJqfZomuSqJ0z3AimXNM5EmRsdELkolWP0l/jbAQILG+yCP/C39Ge61jT5K5hU/ufRWSK5cH9ls76s/zSieyrYM1U1Gl0klYr3/cIv6NAIFSxtbFvWt8mHdcGDFqXRhUglQDcFZ/wI/qxga+5eCfHVcIdsJFpfuNFKS4PopKz7hzwtRbXsfpDKDWMYo1NXRd5FBAZrwBuHiHePb8/It81/V4yzjsA7wUsTrpDMlao/vnqsy9/me01mRbm/UQ7eaguotEill4g6Xj9te5VwsWECIOwDc9ACD1B9yMjewV+MmcNOdIzvk07OkQaDPY0zQMz6Ji3Oa+IV0TnLUk30WuYmIFa6ZP9QcOTwZHqSzNCMRKwkYKPuwnUpDmLa9tBEDiqH/F6d1ydaL4X6Lk/O2EYN355XdpUdBPls9ysbq5SWzVKjgrQVyzlnJkYNoSz4AZzcapjdF7NmBAuuQCvCpXM+nY0xAh3DTsyOUGsI4GEhevXs3FSSxBI+AVefgm2R/xvD9OU9zRQCjqbgNT3HpLgHtiZHAFxc8mOXzUqXF2r2bQ4RDP5MZrU/GeTorvmyX+pV/pysd4gOCtytBFSKylugc+kGanudwhcB8P9VJm9HMO5N+2zSqvlmNLpXPu1t9QeikmviucehX7L2eMxK81D1cOfal+zaX4KJv6hYANxMCQN/o2jhY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 02:26:29PM +0530, Dev Jain wrote: > > On 23/06/25 1:34 pm, Alexander Gordeev wrote: > > There is not need to modify page table synchronization mask > > while apply_to_pte_range() holds user page tables spinlock. > > I don't get you, what is the problem with the current code? > Are you just concerned about the duration of holding the > lock? Yes. > > Signed-off-by: Alexander Gordeev > > --- > > mm/memory.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index 8eba595056fe..6849ab4e44bf 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -3035,12 +3035,13 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd, > > } > > } while (pte++, addr += PAGE_SIZE, addr != end); > > } > > - *mask |= PGTBL_PTE_MODIFIED; > > arch_leave_lazy_mmu_mode(); > > if (mm != &init_mm) > > pte_unmap_unlock(mapped_pte, ptl); > > + *mask |= PGTBL_PTE_MODIFIED; > > + > > return err; > > }