From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07303C7115B for ; Mon, 23 Jun 2025 11:37:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65B946B00BD; Mon, 23 Jun 2025 07:37:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60C236B00BE; Mon, 23 Jun 2025 07:37:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FB026B00BF; Mon, 23 Jun 2025 07:37:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3A2176B00BD for ; Mon, 23 Jun 2025 07:37:51 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D9F9980129 for ; Mon, 23 Jun 2025 11:37:50 +0000 (UTC) X-FDA: 83586465900.07.B618F36 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf08.hostedemail.com (Postfix) with ESMTP id 0C032160009 for ; Mon, 23 Jun 2025 11:36:08 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HUe3zK06; spf=pass (imf08.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750678569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DlJHuROHmBDzciOtFdTsSex+vDj1whTc4hjnLYC1zuQ=; b=divOtatT5tWYn/JA6HBgsPJ+NIgzvtLvykG42fjPTtbAfs7R+zaA5Df/UYS3aGULlAbxUM GCoq2kJseqsuteBAXhrYdX3wwqKD4PDYGqgPMgf4WHXS2VqrhgFyCtivrbhp16cf42yr+R jaXDOy+BBTAgkPhaKxqVZ8sGcNV05kc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HUe3zK06; spf=pass (imf08.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750678569; a=rsa-sha256; cv=none; b=gUGFwmuU+Ow9m9r6jCuPX9bcnWF+Eld+RHvyLXVYTqM33r7OAnEE4dBRyDVKAkHLn+HobP 5//A/xI9vURBnNDG9Qm0SZkkxIJVVrN2k5x0ISPHOPY75wunfQ566iHaqcwn8yKwBQx94E dMX0lxXCRwRdS/N5k7oDjSHy1K0mqqk= Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-55220699ba8so4505603e87.2 for ; Mon, 23 Jun 2025 04:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750678567; x=1751283367; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=DlJHuROHmBDzciOtFdTsSex+vDj1whTc4hjnLYC1zuQ=; b=HUe3zK06eDvERKgCzI6Q8zQrwq3wVCzBAqE77QQAQxm2p+GSRJGe8YGn0Deyazfr/V Uz3jG3mHIs73L9+wFZoC/jFGHCSK0CtBDf6zMO7XQtj3lgaLPIhutt55N0Gy1zGsk3Qx S5TGnYbmWmtxYl2AUShHAgexWeDJw8fuEFKDyM0vphtjDQyYcH/d6BzkIQGdwMYcU3Oh jMHRnKJjF5lMFssHBkWlr+jd7HIcw0adr3dq6MG+JQiF4ZKBrTMqJvn3w3RM2/jb6GTx KsucnCjeJbEKeFOSGA9KNLF1O4/8xixe/XcL9Iv2kSHePCDx9d0slVVA7QidYc5bM6QK Rm0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750678567; x=1751283367; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DlJHuROHmBDzciOtFdTsSex+vDj1whTc4hjnLYC1zuQ=; b=twouI85LvYfESLfu11phdCTev7+hYhGk8CbWefmZtjBHlEXIHMmQ/KWEkUNtacllC6 wc1+cqIgIpM5ZYKLPsDvtMdQTqwMFl+WYFQisGnSNDk/fxCnK1S8YYUp+ZP6wBElcSIu qju8HHgErXNKa/THhHlXog20Cmhj8w5xjhHuoHdvx5jYVkDofTlDspKU7rAYQHmsOfn0 +GJEVAay/uxStqCyug8/btAT7eF8RmzFJ4Xg25S5bYUNw6BcE9tXc426dTXp5lXkQHro Ed1+N6EPB8sU5BrvKeha74qZSDeeKw8KddW4nREj1K6x2l478GEArzLOy51kURYnR+cJ Myyw== X-Forwarded-Encrypted: i=1; AJvYcCWGRR1joBReGDysd8dAmOwNyBBlRrsfRauVJA7bfohYQWjt5ra6z3745lzqWjrFLx94jCPDxAGL+A==@kvack.org X-Gm-Message-State: AOJu0YygJFGKboisUPZtMLDFGF0tCtzid4wM+e9omdYhR+fCggvYjJar T0ZQd1+H+prjouEk4Cfsz/P0PxeGaoLoQ0UnhGmRYRScCmAbQqNO+Mmt X-Gm-Gg: ASbGncvjtax2X8vj5Anrh3EJhU88ZgSNMjbfhPaV2sYhxKj4YwHFx5cUR2P7JprcEKE CKbS3GWrw8oWC01DJ+mv4BhBmEqlKcbCI+RxQskXTZX2AfOthmcStqkJ1AFuZhEmn0N/TEeUkEc gHNAnc6ndu7leBSPwseldipQWv6JZIbQlVgMYmV79h+lDe9iC8NW90//yoy8HU4zR+Dwh2cOAnU txHPYfCDth8GYOsXb8OGOLcfod6Vnf5gQQ/gKiKKxQAsUTZPDb7iYLT7Utxdmw7CVpXR5JKgB6C AuY8F3w2wVcKT7X7z9cx1Jhlgs8Qzokl045Pe7zW4dmSmB7RHpqehFpV+bcG+z5mr+DI2N2eazZ xtwskmRwRDAE= X-Google-Smtp-Source: AGHT+IGCoTf2/sK16URuJGlv/NEhBkck1QcOgj4h8WXpgeP6+mwYonBkdE86Wp1LGEoSP1Uo34TBug== X-Received: by 2002:a05:6512:3c88:b0:553:cc61:1724 with SMTP id 2adb3069b0e04-553e3bb51camr3527946e87.24.1750678566827; Mon, 23 Jun 2025 04:36:06 -0700 (PDT) Received: from pc636 (host-95-203-1-180.mobileonline.telia.com. [95.203.1.180]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553e41bbc84sm1371439e87.112.2025.06.23.04.36.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jun 2025 04:36:06 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 23 Jun 2025 13:36:03 +0200 To: David Wang <00107082@163.com> Cc: Suren Baghdasaryan , oliver.sang@intel.com, urezki@gmail.com, ahuang12@lenovo.com, akpm@linux-foundation.org, bhe@redhat.com, hch@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lkp@intel.com, mjguzik@gmail.com, oe-lkp@lists.linux.dev, harry.yoo@oracle.com, kent.overstreet@linux.dev Subject: Re: CONFIG_TEST_VMALLOC=y conflict/race with alloc_tag_init Message-ID: References: <202506181351.bba867dd-lkp@intel.com> <20250620100258.595495-1-00107082@163.com> <375419f4.2ba1.1979aad313a.Coremail.00107082@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <375419f4.2ba1.1979aad313a.Coremail.00107082@163.com> X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 0C032160009 X-Stat-Signature: 5cmi9qenasochpsg7axiq6mbcztagwrk X-HE-Tag: 1750678568-581309 X-HE-Meta: U2FsdGVkX1+AI92ChdwX+t8EmLN3xNEAs+2GfJz1Sms4OlwK8x69rxGv7Ryr8EE+yqhe6c88cdvGDQJp2rbRjTZ25mcxdGsTAmyY8f3kpEjQ/17nodpSVwWKj2/Uc6MK4ZubFEXOFbsVWUtkRMdBO3AUtRd0Efe2vCnmf+hetRjWp6+trWsIKKsbzqSwfAlOPipZRZdmF6z2YQBbuZvrW/YjUzsApIOcwOLhYWqQ1R/Ik9t73tbRzblLZM6n1vhqmeXwXnqPiDjOwmfIX6JYoNTjljkFvdDJjYZkEDf+h55G5LTa9kS6NZci0bCtJtWeo+NTPCjpeIUoikToBAWd5xOpgagyTQ57QQDsCHMi6317Pd/gmDdfCyLyw966K0TxfKSlp3x35uPg6exaFebTSrelKgaJgyqMpWm32vEDkaC+r2J+SJVYBOMI2UbCDyZwSitMJLSAt0DjxDVV2TNuzLhmabDVpcGg+Y1cx1Kg/oaJyInkg+IaZuW/kSrHmczNfFqNfRiPufwMkF+5ksagw+IGpVSM8UX+NXcQ8ahWAOot+5hBrkFvFAmW1Df2BI0CKSAqrx6sF5VX7+V26a577Hu/F+KhhSrA2RkYy1ldaRhhHkf8Le3l13Y7kXGHhUfk3lvSxY6VDTKGhZ6V5lk9wSmcwo8beZB3/aC2msucUeuFNb80HhuleVT12RxrgI+TFrPsiWpF7gEbRgDIr3K86j+A9/SkdmFuhySRp3K2hcHJ/0ieMcn9TK3Q0zgAiuxy94DBUWsvkYZE753WiC4zUvvkF2nGWJAK3dkaJLQ1MHmP8hGDcR6da+qX+Yb2UQD8MmdopVaSiOITzh4Q7YZTxIygE00XT80EIanfC1nJ+4e9kPufxRhG1Nlni02XTINJJeVNgRF+o8AvTH0z8U5ECHFH7X4QKJFJJDkg+xf1A7D6zUL9/6hH20iajyXW1zec1Gw39plkrcqqsEQceq3 1IJrrHdB FeTlHO1JVseb6fRXIXcayyCwUk84IYvN94RrLcRGg+ayeUlBDLMWjEdcb2do3TvpAgq0JwAzfu6IZYMFd68vddu2iUxtN96pXdmKoPetlSUlrXIPqegFadPjM1O438zujXDFnnBGtObYgnnsol3Kk8rIFEvce46f1A94Aq1iJRxGIUSDCJCIpTNvULX5E7oJhBYYXilNIbgPuhsxmx5IBOYWGiKAw+nDjkFloUCCVWA+4oTyAtNDiyST8daQsp6wt9jK8MaKyWeeH6CRImlusSwZ7zkmZd+Yicg7TcKT5ETHZfm1R6IgzMbFLGCPUIBrPiJnItHHIBWPgRg6eAnBGnPXO10UlPOKZ9sbCA2bCZP/yAaXSJ56NAZwApTi3XH9dhQuhLnGanMPYFXd6Gv/JTJQO/aynENo5JlJhRAwVsnXFE8vPnSsjAEhJJA37Ca7f80D8jutYWMXPnZmB+9FpIa4M9S46R7aensk2yW5H/ExvlIf62i6sXqG6BQVONjwPT64QdFPkEbrc5sN8ob01XPPL6LBoAEJ5+dHj1/AkR1jQKkuceRcHSo1wRKdBo2z1VK5ScTAgPa4UaawGbq6tkHomHFtwBDJsFF+ZUmhq18aw2fGShHlxWI4JhbkCKLTQqAr+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 10:45:31AM +0800, David Wang wrote: > > At 2025-06-23 06:50:44, "Suren Baghdasaryan" wrote: > >On Fri, Jun 20, 2025 at 3:03 AM David Wang <00107082@163.com> wrote: > >> > >> On Wed, Jun 18, 2025 at 02:25:37PM +0800, kernel test robot wrote: > >> > > >> > Hello, > >> > > >> > for this change, we reported > >> > "[linux-next:master] [lib/test_vmalloc.c] 7fc85b92db: Mem-Info" > >> > in > >> > https://lore.kernel.org/all/202505071555.e757f1e0-lkp@intel.com/ > >> > > >> > at that time, we made some tests with x86_64 config which runs well. > >> > > >> > now we noticed the commit is in mainline now. > >> > >> > the config still has expected diff with parent: > >> > > >> > --- /pkg/linux/x86_64-randconfig-161-20250614/gcc-12/7a73348e5d4715b5565a53f21c01ea7b54e46cbd/.config 2025-06-17 14:40:29.481052101 +0800 > >> > +++ /pkg/linux/x86_64-randconfig-161-20250614/gcc-12/2d76e79315e403aab595d4c8830b7a46c19f0f3b/.config 2025-06-17 14:41:18.448543738 +0800 > >> > @@ -7551,7 +7551,7 @@ CONFIG_TEST_IDA=m > >> > CONFIG_TEST_MISC_MINOR=m > >> > # CONFIG_TEST_LKM is not set > >> > CONFIG_TEST_BITOPS=m > >> > -CONFIG_TEST_VMALLOC=m > >> > +CONFIG_TEST_VMALLOC=y > >> > # CONFIG_TEST_BPF is not set > >> > CONFIG_FIND_BIT_BENCHMARK=m > >> > # CONFIG_TEST_FIRMWARE is not set > >> > > >> > > >> > then we noticed similar random issue with x86_64 randconfig this time. > >> > > >> > 7a73348e5d4715b5 2d76e79315e403aab595d4c8830 > >> > ---------------- --------------------------- > >> > fail:runs %reproduction fail:runs > >> > | | | > >> > :199 34% 67:200 dmesg.KASAN:null-ptr-deref_in_range[#-#] > >> > :199 34% 67:200 dmesg.Kernel_panic-not_syncing:Fatal_exception > >> > :199 34% 67:200 dmesg.Mem-Info > >> > :199 34% 67:200 dmesg.Oops:general_protection_fault,probably_for_non-canonical_address#:#[##]SMP_KASAN > >> > :199 34% 67:200 dmesg.RIP:down_read_trylock > >> > > >> > we don't have enough knowledge to understand the relationship between code > >> > change and the random issues. just report what we obsverved in our tests FYI. > >> > > >> > >> I think this is caused by a race between vmalloc_test_init and alloc_tag_init. > >> > >> vmalloc_test actually depends on alloc_tag via alloc_tag_top_users, because when > >> memory allocation fails show_mem() would invoke alloc_tag_top_users. > >> > >> With following configuration: > >> > >> CONFIG_TEST_VMALLOC=y > >> CONFIG_MEM_ALLOC_PROFILING=y > >> CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT=y > >> CONFIG_MEM_ALLOC_PROFILING_DEBUG=y > >> > >> If vmalloc_test_init starts before alloc_tag_init, show_mem() would cause > >> a NULL deference because alloc_tag_cttype was not init yet. > >> > >> I add some debug to confirm this theory > >> diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > >> index d48b80f3f007..9b8e7501010f 100644 > >> --- a/lib/alloc_tag.c > >> +++ b/lib/alloc_tag.c > >> @@ -133,6 +133,8 @@ size_t alloc_tag_top_users(struct codetag_bytes *tags, size_t count, bool can_sl > >> struct codetag *ct; > >> struct codetag_bytes n; > >> unsigned int i, nr = 0; > >> + pr_info("memory profiling alloc top %d: %llx\n", mem_profiling_support, (long long)alloc_tag_cttype); > >> + return 0; > >> > >> if (can_sleep) > >> codetag_lock_module_list(alloc_tag_cttype, true); > >> @@ -831,6 +833,7 @@ static int __init alloc_tag_init(void) > >> shutdown_mem_profiling(true); > >> return PTR_ERR(alloc_tag_cttype); > >> } > >> + pr_info("memory profiling ready %d: %llx\n", mem_profiling_support, (long long)alloc_tag_cttype); > >> > >> return 0; > >> } > >> > >> When bootup the kernel, the log shows: > >> > >> $ sudo dmesg -T | grep profiling > >> [Fri Jun 20 17:29:35 2025] memory profiling alloc top 1: 0 <--- alloc_tag_cttype == NULL > >> [Fri Jun 20 17:30:24 2025] memory profiling ready 1: ffff9b1641aa06c0 > >> > >> > >> vmalloc_test_init should happened after alloc_tag_init if CONFIG_TEST_VMALLOC=y, > >> or mem_show() should check whether alloc_tag is done initialized when calling > >> alloc_tag_top_users > > > >Thanks for reporting! > >So, IIUC https://lore.kernel.org/all/20250620195305.1115151-1-harry.yoo@oracle.com/ > >will address this issue as well. Is that correct? > > Yes, the panic can be fix by that patch. > > I still feel it better to delay vmalloc_test_init, make it happen after alloc_tag_init. > We can, but then we would not notice the bag that is in question :) At least we should, i think, to exclude the tests which trigger warnings when the test-suite is run with default configurations, i.e. run the tests which are not supposed to fail. -- Uladzislau Rezki