From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81388C71157 for ; Sat, 21 Jun 2025 19:15:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9515C6B008A; Sat, 21 Jun 2025 15:14:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 928F96B008C; Sat, 21 Jun 2025 15:14:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 865FE6B0092; Sat, 21 Jun 2025 15:14:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 746066B008A for ; Sat, 21 Jun 2025 15:14:59 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 022AD12165D for ; Sat, 21 Jun 2025 19:14:58 +0000 (UTC) X-FDA: 83580360318.16.6663BCE Received: from fgw21-7.mail.saunalahti.fi (fgw21-7.mail.saunalahti.fi [62.142.5.82]) by imf29.hostedemail.com (Postfix) with ESMTP id 432E4120002 for ; Sat, 21 Jun 2025 19:14:57 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (imf29.hostedemail.com: 62.142.5.82 is neither permitted nor denied by domain of andy.shevchenko@gmail.com) smtp.mailfrom=andy.shevchenko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750533297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2kVk+9NOf0wjGDwgUdg7XMyLpwPQP/6gFdwoEIbuEo8=; b=zgA+zZsCQpFbv0zje7H1cHur72Kp3gvQWBUG6YngCE7pqfLUjt3aP/zBIANRxR49wURZ9/ UVpg+88H9YS+wyRZg5vQoy0jyWNXzxryLpke0RHWpKR44Skn69dSbIU/WHUIIwPFL0/zF6 aPdxnnv7vyAqTIrWWsCQKCFaD3UgPD4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750533297; a=rsa-sha256; cv=none; b=l/Dwvp8S2XYcGI13W+bY10Dmr/MPDCca+pycGyfRjKGCEZIjx+m0jETf6Z9f5G+Lup5dzY YD9eIGVJxoMCBbzCsTsifR7OJDurLr1NJf0ZxO29zEHWgPysbQ0LTdYNGbEd+RMN7LbdEu PXcZ594+J6wScAQpP5m3uipKcIRW4XI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (imf29.hostedemail.com: 62.142.5.82 is neither permitted nor denied by domain of andy.shevchenko@gmail.com) smtp.mailfrom=andy.shevchenko@gmail.com Received: from localhost (88-113-26-232.elisa-laajakaista.fi [88.113.26.232]) by fgw21.mail.saunalahti.fi (Halon) with ESMTP id 017ea4bc-4ed4-11f0-9764-005056bdd08f; Sat, 21 Jun 2025 22:14:53 +0300 (EEST) From: Andy Shevchenko Date: Sat, 21 Jun 2025 22:14:51 +0300 To: Anshuman Khandual Cc: Andy Shevchenko , linux-mm@kvack.org, Rasmus Villemoes , Sergey Senozhatsky , Petr Mladek , Steven Rostedt , Jonathan Corbet , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t Message-ID: References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> <0d437b3e-37b5-4e98-90bc-afa6c8150e77@arm.com> <92a89dbb-7031-459a-ad5a-69b29b08cfc8@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <92a89dbb-7031-459a-ad5a-69b29b08cfc8@arm.com> X-Rspamd-Server: rspam02 X-Stat-Signature: 5od9z41kdhuyhdi7sxut6gubzey1tyyr X-Rspam-User: X-Rspamd-Queue-Id: 432E4120002 X-HE-Tag: 1750533297-74411 X-HE-Meta: U2FsdGVkX1+LzY+NqTY11nVjT+raey9M1wAIffGACF9/TRJi8JzSQSQg88AkGY1TGCvpr8MsejrDmqU5U3SRQtbekKoUFD3ATCNYgjUTiNpXvvYRu/85LWWdlQGXhLbduF5RRWRtpMuigoQwfjbmX3zU/AGKo2a34bXYRzLyOf1V4uOgQi30forK1WCCjmMmMaeE73tlXc3g5huQMjPdxQSKRn0g8edhZhjQuwAL+atkEB2KeYYaCUmOl5Hm/pvaox3h7uZ8An4X6/w+YMRCeFSbax2ihSThDpuOWC+BftDcpoU0xSPKOtndmicv3ipglvDUzA71ug9X9sT2CoQnbnYiZof5tKq5IXUG4GD3819eIke2CoOCpllhmZZ1++OBuT07mxUVwIP86UWBmik3kn/fNNbsMdHPrPdZvCybHCr9VA6tzjZ61S4yzswrlxSqCCZ5d2OM0So16rbCc/aQfpqRVpxc3aN5YS2/5kW8jdW87Ojl8El9rLQpZvv08OfoZe75F+LTGHd3tuy0svK40Qgry91BzK0ogPfAOpB+K1fIpM+5GcB2AmR/NxEV3hdWQpMIlenrcl+WjoKfK9a8BRXzVeVCcpG3j3gl7reafKdO0CNgmXA/vLGmFFJOTr4G9muCzXQU9qIQrpZfgRynICyFF88Z1HsF1IBXGxZB6mu0HJLGKdquSMS8L/YTg7IhoUjCO3TOc31fegrORtlh1jCO8d6qO85x0iMSpfPM1ofEXNG8vPZquSdVP/PWv8fA6Tp7roLfxijSlILI5k7myBEquIwS6uA4tuVxX6kJtXBd1lh2XBLwXyCQl81hBCxlYZthaQkauwy5bkNVkbw832cVNYBuI4SrtmFJmSEEE1YMaIp+RFIXBOazsondDX32e8BCZ7WwYbHv3tXennGs+tVG29Q+IPdsEYy5SuOTuki046mBzYllg+n4UVr9q9iHbW/yvWScFQIbEfOHmpb zhqCxGWb 1OVSF46wjCYF/ctEt7HYdXvzOiHYTt/ScN4nY5J7pJ9NISkHFA+T3pC8ryccfndCjX3y/wIokNrEeqmqL9jztLAg5inpwtMGk+P2zBhUfj6BYpAz6DxQqVyGvNxtPXA7IIk9MBNQhPpr6vqpEz+mihdGz6CHgYVnB01cH0JGwuxX3TWZtTL49pqec/2OQ3jMJ0xY61h6DSL6E0wnsTJpq+EMlpH02mQQxeiArUhBaqciq6Yhg8kvA6+bnGGvPHytPBEb/VrKNII/Hchx0hIeD++renJZ7N5PqniXb34R03qy+8O5sG1JTsSyyEZdcVgjQZo+k7RLG/TR2yJyYnuzeV0cgKg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Fri, Jun 20, 2025 at 12:23:47PM +0530, Anshuman Khandual kirjoitti: > On 19/06/25 5:30 PM, Andy Shevchenko wrote: > > On Thu, Jun 19, 2025 at 03:05:10PM +0530, Anshuman Khandual wrote: > >> On 18/06/25 11:16 PM, Andy Shevchenko wrote: > >>> On Wed, Jun 18, 2025 at 09:42:34AM +0530, Anshuman Khandual wrote: ... > >>>> + spec.field_width = 10; > >>>> + spec.precision = 8; > >>>> + spec.base = 16; > >>>> + spec.flags = SPECIAL | SMALL | ZEROPAD; > >>> > >>> Do not duplicate code we have already in the file. > >> I am sorry - did not get that. Is the above flag combination some > >> how wrong ? > > > > It's dup. Please, take your time to find the very similar piece of code in one > > of the helper functions we have. > > Are you referring to special_hex_number() ? Bingo! -- With Best Regards, Andy Shevchenko