From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C85CC71157 for ; Sat, 21 Jun 2025 14:33:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CEE76B007B; Sat, 21 Jun 2025 10:33:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 680126B0088; Sat, 21 Jun 2025 10:33:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 595B36B0089; Sat, 21 Jun 2025 10:33:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4534A6B007B for ; Sat, 21 Jun 2025 10:33:32 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 97C76101D25 for ; Sat, 21 Jun 2025 14:33:31 +0000 (UTC) X-FDA: 83579651022.21.CE3BBB3 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf11.hostedemail.com (Postfix) with ESMTP id A0F7340002 for ; Sat, 21 Jun 2025 14:33:29 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fDpWL1T4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of yury.norov@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=yury.norov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750516409; a=rsa-sha256; cv=none; b=2XEjl2FsBGB0U+x8gBrNPJ+OWVBVOTzr1T5+bAro5FVpBVIbwSQP3HNDlJAdRFsalfXCGe 6tCBd+M5E55URPzELBclVECqaIK/Rx3ZbsE+7q8G8IZfzjDeD6F+iAdbPFS1waSdUylZjy VoUyPmbcGSe237wq2Gx+PhUf/ZLhuvE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fDpWL1T4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of yury.norov@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=yury.norov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750516409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rpcV6fctoPHKkMmJOO7gDCJf9UFeAem7Es9ZNVW1blc=; b=c4C920ON4NlzTFO79GPhWvXtPbs4bTb7sjHCvqljf9jhWYOKZdKFN2ekrTPbJ044wwxeVx 5djWqCj6LgM/Kpb6PINq+wmQhtSU9l7XkdH+WRD9YBkSS0rcvtlCz7qz4GFpAXRLzR3oJO OuSOfGgkZ1K+AuHIvijCcVVW0CSqwHg= Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-b31bca0a32bso1979878a12.2 for ; Sat, 21 Jun 2025 07:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750516408; x=1751121208; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rpcV6fctoPHKkMmJOO7gDCJf9UFeAem7Es9ZNVW1blc=; b=fDpWL1T42t0bwd6ctLFQkAgWnKee6A/tNXeXgtZTWafp1+1vUT8dPKaCgHIsoXggZ/ J4BcXomGoE8B+eaMo6L1u+ik6C76uh45ArY6SW8AQAcL3HHDHegMdr9MxqsSPrmDv0N7 nS4Ly2SL/deN/XWGCWjVkgdjzAD9t/cVN786TQEmnPPx0gq+52mvDF8AKEsxohspGSpx 048gfVTk3dvLkPXVYJySNKpYRhfHtvFwq0jgQo6pezuYYxyfcNoym7EhO4JbroncsmKX R51uFSotSWUnb4FQazUuBXC5Dbswmf+OSriA0s6KIewv1rGGNNKIoWsAwZAMNgKOHPFm HJeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750516408; x=1751121208; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rpcV6fctoPHKkMmJOO7gDCJf9UFeAem7Es9ZNVW1blc=; b=DjFkgCSsPM//ZUAy39x5F5QahTWMTjmZvpyACXZGsKDlWfLAXdpRdYqyL20Gm9wvB9 JqXgNW9ymBJ4YPV+kWA1hgu4VV/mR0k05j2I6WbOzedSBmC7kTWdaZTvgaRYgvbN+bYz HkU3jcOxGdHYpf10PaFYbXG0nFGRtUGJLyQfw3chZiOZ18y1VLYoH1rWaALJ+goSHPxg Q90s1arrbqHF2ia92HrH1sEbDhr8gftWOtk1JmsXqyGThWP/D5A7vXAn1AsOTkew8Hui JqNRHqUV/RgmrI7BzsWjAftR/TXtzVNJc0HPvOp9RQuc9euNvucYYmDh8Y+OVNsbs2Vo onGw== X-Forwarded-Encrypted: i=1; AJvYcCUBhQ89WSkXroCGmkjgyNDad0G1/GXXOQbiQhAnOT+F+kWBMouciXwuWS+VfZkOUR1hSrIk7oqCLg==@kvack.org X-Gm-Message-State: AOJu0Yw498E9kY7+OnyQbjS5mnXj2TR/X36orspgMM/gAdzXX0sFFobd 1aVmvoGlsO23G5duazJJUVcAybKivWPE1JoQFPRpB49UWqoHetPuDxWb X-Gm-Gg: ASbGncveo1L4mtwTcALPLzmFuCUr3lf7WEkM8Eq6RYNUH7qrgmz9jBfddf7UIv5ygpA xgsR8kg3vKtir0TFfu5IjJqX/s1C+MNBvfuK5g45iNFOH8lJMCZEp8sIq7ybv2UmR0qBMdOnBaj 1JiEif4fznhwDk20g+gT3r9GqMewWVVq27PD//i5JTdzFNE86R8osTBbZEiLC59jJbzxENxhdq9 0OHgedobxeDqoqJ8XkNXNoF5TnjohJKowg3v7LIicIL8xMpVyafRi7kq5IHYnsAmbJPhdJnrNAA 4Q/h3N4WnknAVRwnEwtG55LI8mxOTIZoO20fWozH+B3yNOTbp6rvboTMYne3mBxLpMrNBGze X-Google-Smtp-Source: AGHT+IEa1dzclDb2tuusdyRFUEN+RVm3ocXALNNj4v2dS5L9ixXeDKVBkqE/mg1/e/SCGi0mCloBfg== X-Received: by 2002:a17:90b:3505:b0:312:959:dc49 with SMTP id 98e67ed59e1d1-3159d642a58mr10688811a91.13.1750516408260; Sat, 21 Jun 2025 07:33:28 -0700 (PDT) Received: from localhost ([216.228.127.128]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3159df93ad9sm3999598a91.21.2025.06.21.07.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Jun 2025 07:33:27 -0700 (PDT) Date: Sat, 21 Jun 2025 10:33:25 -0400 From: Yury Norov To: Yunhui Cui Cc: linux@rasmusvillemoes.dk, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, dennis@kernel.org, tj@kernel.org, cl@gentwo.org, linux-mm@kvack.org Subject: Re: [PATCH RFC 1/2] riscv: remove irqflags.h inclusion in asm/bitops.h Message-ID: References: <20250618034328.21904-1-cuiyunhui@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618034328.21904-1-cuiyunhui@bytedance.com> X-Rspam-User: X-Rspamd-Queue-Id: A0F7340002 X-Rspamd-Server: rspam10 X-Stat-Signature: m1dtgs1zddgsztb9h13iwxfufkfgwffa X-HE-Tag: 1750516409-809237 X-HE-Meta: U2FsdGVkX1/OQiYUFsw4ObSAO71DxiaPDMoOADQgAAV6NYoam60lnAhvOr4O2cyYTvX7jUwQsYyrE0FLtUwzCcQcKIAJSm7UCNd1+rklVfEm9eE23FqK+ZbvXUCpeFiTl6IX6JhYMdVxv+53TiKyowDyijkRNTXZ8u+IUtj816yFyJFYhJfJsLBJO6yCW/HyJxm00vjf3Re2XJx3m6UaiMnz9Bk/WdIXzupda2ON98mM4qWJB8TTo/8Ze3KFRAb77FbNwH+hl+fFqAT9OVc5oT3ZEzTldih5Z50T0iLSa+0OOm9DuuoD2TolLRIBpHKvjkx2ZuieAHAJES+W0bfvfFjQHsz7mlfnoebbPSnxzaRcECWmbb8GJcN+NTY/AvSuLGzXPj/d+0w8mob0q2gAsi6fdt8es68patS33s6l8I2Gxt+kgi6n/amTkJPBZqsAD0oS2ZmnE/LCU0GxPEYKZzFwfOgXLH0MGgZ7MNDD4j5g2DN5tvpyr5NYodzWCAj7ljpJ9Cas2BggaJrCUJwTsiMzRkB9ED0Gc0+4SeBZnN54HCIZ4iZ6rU7nydmI7YRedAqVtrGoBaPN8gepz445jG0FyiIv7KBZSso+2po1Xt2dNR+9TEOIAUn4VdwmwYM4rnep0A9/9/NmF8WqIalRiwwj0+5XyyZwVgP86EBZBCjKHcEMYopXhFaZ3vCL+N7bet7a1XSTtcRgIztDiTNPKvdivxU+rges7uic8CUo73eKOGFG2JsPAYU2hEmQ2Gbzpl5iltcODgO2ajx8UJiE0+RG4czJsOT9CK3oC6xEIBdxsOKRsgqYDnrqHiUS0tG6N2kQO11coVzlg6vXCof1f4KoE8mOqQU5FB6Ij7SPKuUG1vkIfL8U0sOWW1pVWKf3KsL+HK7CqeUrda0rA7YHUSOvBQPZOqoPXKuL0jAgGLbMyC/cOynYg/Iz9o0c2MPLFxad9S5sDDXmjKloJAd tLABaV+k p+88h+gtp8Gsgdvqf+n6zcHZaJno3XFtb9/K1eqBemhXPObQIcdIG+6GpjiDfMsb7C24LKHcRb4rz9WTM8fiPFzronSqZ8wqetilmqYRHL7uybX/5bI8K5KO9T797MMQICfpxTtmqzN6q8mRF9Klo8SfV3DZtTqeD17Cz+L6PlqiXSwmwxhm4wGqOVClFQD7Kz+wjCAZTqGCwY9Kof68/ZM5uxDA5PkucV2OUCMKZw73XWN/rJLfFeyknJ7CnNnCv/g1lAuxsMFe7nh8/rne5XjbKcilJAp/xx0nSxdEoPsnI85Gptc684UgSwq0z+3xV1GO62x/qxKBhWewP4m91mEkGVsn8OtnM7gk5Lv1m3VN2JBH8HAuPra+jZgKwpeBJCxCmFXbMrQMFyGcbOrzy/XfI9N+j5k6ZFFPA5yAvnDTMbhyHO68NRBkd+k44bka8r3GTvdSHa6rraVFKMXMdxpMZ4JAYYU3afUkPMPRRISjT9J+RQuBBrVR9UA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 11:43:27AM +0800, Yunhui Cui wrote: > The arch/riscv/include/asm/bitops.h does not functionally require > including /linux/irqflags.h. Additionally, adding > arch/riscv/include/asm/percpu.h causes a circular inclusion: > kernel/bounds.c > ->include/linux/log2.h > ->include/linux/bitops.h > ->arch/riscv/include/asm/bitops.h > ->include/linux/irqflags.h > ->include/linux/find.h > ->return val ? __ffs(val) : size; > ->arch/riscv/include/asm/bitops.h > > The compilation log is as follows: > CC kernel/bounds.s > In file included from ./include/linux/bitmap.h:11, > from ./include/linux/cpumask.h:12, > from ./arch/riscv/include/asm/processor.h:55, > from ./arch/riscv/include/asm/thread_info.h:42, > from ./include/linux/thread_info.h:60, > from ./include/asm-generic/preempt.h:5, > from ./arch/riscv/include/generated/asm/preempt.h:1, > from ./include/linux/preempt.h:79, > from ./arch/riscv/include/asm/percpu.h:8, > from ./include/linux/irqflags.h:19, > from ./arch/riscv/include/asm/bitops.h:14, > from ./include/linux/bitops.h:68, > from ./include/linux/log2.h:12, > from kernel/bounds.c:13: > ./include/linux/find.h: In function 'find_next_bit': > ./include/linux/find.h:66:30: error: implicit declaration of function '__ffs' [-Wimplicit-function-declaration] > 66 | return val ? __ffs(val) : size; > | ^~~~~ > > Signed-off-by: Yunhui Cui Is this patch a prerequisite for #2 or it fixes build on master for you? If fixes broken build, I'll take it and send an -rc pull request. Otherwise, please work with RISC-V maintainers to move them together. Thanks, Yury