From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E67C7115C for ; Fri, 20 Jun 2025 16:53:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DD506B008A; Fri, 20 Jun 2025 12:53:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58E146B008C; Fri, 20 Jun 2025 12:53:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A3636B0092; Fri, 20 Jun 2025 12:53:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2DA2D6B008A for ; Fri, 20 Jun 2025 12:53:41 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C4598140FC0 for ; Fri, 20 Jun 2025 16:53:40 +0000 (UTC) X-FDA: 83576375400.28.4B0F36E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id F04DB1C0006 for ; Fri, 20 Jun 2025 16:53:38 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OnrcTh1H; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750438419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Eo1XSA3SmcuMbRpTgyRtVlYknk3tdpLim2DRHohEz4=; b=YCAhtdS6Zcr5FN7OpPku8lfXiSgbmIYMMAMsqtx5QCN+2iWYCLh3UpGkqpnZ/AVtuUp97b hyrq1NsWWmmAPKazTXMY4q+NQio/PgOJYHSzXLMx2TYwIrbmWgRZsmF8oBsTrH7pIQ9n8p 3HiBzkvv/g32P6oQyMXfjOw7ohtclkk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OnrcTh1H; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750438419; a=rsa-sha256; cv=none; b=5TyQytLAS19e+j0Z/W7Q//Dh5EvdZdwfaagUPm/iS+JP4YS9IDDaI+yoh4Z/NP5zoN6RYr 8h4Lt9SuLDnJ1bJl4lJ/runk2R9uFmfz4BGonPZdmcR69Hfdbp1t4CJy/e2ycMWHQTnOW4 FeWcOXPrFdG5DKTeWr2Ofg8Vlos/I7w= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3Eo1XSA3SmcuMbRpTgyRtVlYknk3tdpLim2DRHohEz4=; b=OnrcTh1H3MnpfGDkkQoxf1opQy QjgELB6MqBVq+C0oj+tykw/OL5LNfDp2xeJgNZiFB3Q04xAMMvuDi/b9m407+tQhlW9AKFuDkx2OF 7TbU3ZgyGj61tx/nEwMkBmVgPk/nKhlhvxtD3OAriolG9rkNl+lYExgn0RZT2mG11GcDdfJkTWLdo AdoPf7MrTzij29LOh1WPBF0ktWSsRITeYO+y4Ts2Xn1vd0Il3V1zeVZIhD7mR7QEzsT3qeY4krrbp oSYtuUzMLUIz5EYnE+R7Nbv2Wvd7MmuaSrotBF/nUgWI1mF6mxvjB89f9oqy56FuyKDy/DUj5VVhX iLxQfJ4Q==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uSezL-0000000D7nF-2NDn; Fri, 20 Jun 2025 16:53:15 +0000 Date: Fri, 20 Jun 2025 17:53:15 +0100 From: Matthew Wilcox To: Shivank Garg , seanjc@google.com, david@redhat.com, vbabka@suse.cz, akpm@linux-foundation.org, shuah@kernel.org, pbonzini@redhat.com, brauner@kernel.org, viro@zeniv.linux.org.uk Cc: ackerleytng@google.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com, tabba@google.com, vannapurve@google.com, chao.gao@intel.com, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, yan.y.zhao@intel.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, aik@amd.com, jgg@nvidia.com, kalyazin@amazon.com, peterx@redhat.com, jack@suse.cz, rppt@kernel.org, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, rientjes@google.com, roypat@amazon.co.uk, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, kent.overstreet@linux.dev, ying.huang@linux.alibaba.com, apopple@nvidia.com, chao.p.peng@intel.com, amit@infradead.org, ddutile@redhat.com, dan.j.williams@intel.com, ashish.kalra@amd.com, gshan@redhat.com, jgowans@amazon.com, pankaj.gupta@amd.com, papaluri@amd.com, yuzhao@google.com, suzuki.poulose@arm.com, quic_eberman@quicinc.com, aneeshkumar.kizhakeveetil@arm.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev Subject: Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol() Message-ID: References: <20250618112935.7629-4-shivankg@amd.com> <20250620143502.3055777-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250620143502.3055777-2-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: F04DB1C0006 X-Stat-Signature: 9tbh8puhq487j6tfgabu9e8pcrk41ur5 X-HE-Tag: 1750438418-674239 X-HE-Meta: U2FsdGVkX1/u+6ZXTmR1FGXfvRX7WNUo4Xa3d9X7LrskgxRW2b/qjvp3sTl+rp9rfAoyzbG3OJ/7wNrVRRf9p369t2BKfsvK7+h1NVQrn4cw8c6/hboljcsyZKMtNdWekAZ0syFYx1GGNGABp+dGooOqm2+2JgJuadfXBpSY+JUFNsBj5/fvGHG6QP+J0/GcDbdTqVtTJN2T/SR00MJ1KE97frrqwe+Ft24L1A0Fa7haV4l/JJjQvdH6HqgFVna55gx7R99HG2rkejsvp5fqoyPnAfidQ9tx/CDUhICe/QruAfysEO9dmzE0CfhGnAe5qQSq4RFXcSsP2W/42ULw1IIizg4WbSfUI9ZbykCBuQN2C8V9bP1hw+Ln0FPbHBG84oMspGjtG5qmysAbrSETGPP75B8GO17SHTC8uq7zGY/evYzrTpmRaTmIEDtxG5hmVW4yw1TMKmOIQj63LV2LuJ/uCxM8nvnoYBb7CnSlTQs6rUIg7yEP+S0tUnwQ1eEiVeWqO3rp8Rs+Ec40mWDL9TmdLKBQANd6qjb2/zEaTQkgHNXFuNwsDcpE5ftkhkk7qDbV/+aKEhBN7AuyGTUf/zBXY0qZet+uRznNFHiXyLGDSEMiU1T+4L5o9y6WffRYV9fKXKJcIoHCDfTfun7TbzMrrwZ+Nn19ppYdqsM9G/csZGvd4buHF9Bzg2SLIs/bc80eCzuvpMiC6RTJT8m/SNrxoJRAQLZ4bZVR/p+76Znx6u0MVNKMrN3lcS3BkaJFh6h7KdnMeaIbjND+dQvEej02kuG/AAmBtd13tm3olLd++NP0B0eRy74nmcMbcxU6E6avwsv7ooE4hOTDQY/T2ZwaRgYaeK4thiBip3+cq1SG4wBcQ/U96sLnPKKUNJPoQ5QmrzO/mQUH31Q9WXvO21DUxvXqnDWo09lF3JOhInFFfpPnmMVeUgbYdkIm0TXhYoXSf4jGSIrNK3301H4 w+gWZDVt lea5dslYFn9CwSg/bIg8uG2jCwuwTIgkxIb2st10tqpelpDUAEImU1h+T8R6f8dCtf8c7WUDH3NOeSfIi4Q/cNskEsaPD/wwAxEivDCgXUhe+gRQdHv/j1cgVJVZl8HWjVtRptG9aZUq3kFcVGhvZLI5NZ2oeVTSWWuvBjBiphJtB4CFYDTLtyEPpUzIuQKuFHm2uS0v3H1Hed4NCjElXYNZ7DcgCJr4yVobfAvdphRqCQeaEvBdoChSpwJwF3I798hzkhW1yOt7Dn05ekaeJHs1g4iPcIKOYgbMt5y5+ekeyEGjPSr8VJ7cGTMGc3BtbKfQbM6l8R4LYWsylgdJElmoax0X52vzlbs3i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 20, 2025 at 03:34:47PM +0100, Matthew Wilcox (Oracle) wrote: > +struct folio *__filemap_get_folio_mpol(struct address_space *mapping, > + pgoff_t index, fgf_t fgp_flags, gfp_t gfp, > + struct mempolicy *policy) > { > struct folio *folio; > > @@ -1982,7 +1984,7 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > err = -ENOMEM; > if (order > min_order) > alloc_gfp |= __GFP_NORETRY | __GFP_NOWARN; > - folio = filemap_alloc_folio(alloc_gfp, order, NULL); > + folio = filemap_alloc_folio(alloc_gfp, order, policy); > if (!folio) > continue; This is missing the EXPORT_SYMBOL_GPL() change. Sorry about that. I'm sure you can fix it up ;-) I only tested "make O=.build-all/ -j16 mm/ fs/" (on an allmodconfig) which doesn't get as far as making sure that modules can still see all the symbols they need.