From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E1FC71155 for ; Fri, 20 Jun 2025 14:28:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20C646B0092; Fri, 20 Jun 2025 10:28:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E43D6B0093; Fri, 20 Jun 2025 10:28:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FA1D6B0095; Fri, 20 Jun 2025 10:28:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 000366B0092 for ; Fri, 20 Jun 2025 10:28:47 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ADD66120F7C for ; Fri, 20 Jun 2025 14:28:47 +0000 (UTC) X-FDA: 83576010294.14.56D7763 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id A4D4340006 for ; Fri, 20 Jun 2025 14:28:45 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DxvinQlC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XYg0ko8T; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DxvinQlC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XYg0ko8T; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750429726; a=rsa-sha256; cv=none; b=1TgqwdItliKE13lAHqTVvImEeHHVbfq7zXhIRakVPYnFe9lDEsEeDMnVcSeaio0z81eJ+9 kX023xv9piPW1RnyV9o8zd0y7zpqmlOHMuH4PM2iQ1pcVQ3VO0fMkRCFM7GdE9N1JWGGf3 29tIkWM9Svsqeistl6xdiJwyXPI2pZ8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DxvinQlC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XYg0ko8T; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DxvinQlC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XYg0ko8T; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750429726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zDCXy2xUuIpDrZt6lZelut4/OesMx2eGwdtjU0b+qKY=; b=mQgVTRpERht+4EKxLQu8TasTrB9yuKf1TwqRvK/obgeqzylE0F2ydsG3lyAZZdEZ+wMAUf kpBiVfAKSwS87jU0xl50VmUFh8qHl60OnB517/Mx0VvrN0hDIUuuy3zKTTxrzDnfwgqW+/ 6Fz36tMMXU0LYwFnF+QA797bE8IaLX0= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 20A74211AA; Fri, 20 Jun 2025 14:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750429724; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zDCXy2xUuIpDrZt6lZelut4/OesMx2eGwdtjU0b+qKY=; b=DxvinQlCQT7htDy2x3qJc0l8S9I2wtlZFnrvr2MmCgd+KCWdfllBkOoBzO53nGmxqAQGW+ n6IThfqJiNIVIq4K8/K/TU++WyqmptL5cVJjbzMf5RTxXRrtsFwHvGlIlLnj5girryMgWc zrAgVd3LusSS6dS31ymTmxMg+5IkYSI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750429724; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zDCXy2xUuIpDrZt6lZelut4/OesMx2eGwdtjU0b+qKY=; b=XYg0ko8TqcrK4PThoiWu27rjoKhW5F6wdUaFP7Xpo/XL8ibt9yp8Tr5B5wC4yCILbBDHwb 0rsEMIATsgX2hfCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750429724; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zDCXy2xUuIpDrZt6lZelut4/OesMx2eGwdtjU0b+qKY=; b=DxvinQlCQT7htDy2x3qJc0l8S9I2wtlZFnrvr2MmCgd+KCWdfllBkOoBzO53nGmxqAQGW+ n6IThfqJiNIVIq4K8/K/TU++WyqmptL5cVJjbzMf5RTxXRrtsFwHvGlIlLnj5girryMgWc zrAgVd3LusSS6dS31ymTmxMg+5IkYSI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750429724; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zDCXy2xUuIpDrZt6lZelut4/OesMx2eGwdtjU0b+qKY=; b=XYg0ko8TqcrK4PThoiWu27rjoKhW5F6wdUaFP7Xpo/XL8ibt9yp8Tr5B5wC4yCILbBDHwb 0rsEMIATsgX2hfCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A9F9D136BA; Fri, 20 Jun 2025 14:28:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id hPs4JhtwVWh2TQAAD6G6ig (envelope-from ); Fri, 20 Jun 2025 14:28:43 +0000 Date: Fri, 20 Jun 2025 16:28:42 +0200 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Muchun Song , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] mm,hugetlb: Rename anon_rmap to new_anon_folio and make it boolean Message-ID: References: <20250620123014.29748-1-osalvador@suse.de> <20250620123014.29748-4-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250620123014.29748-4-osalvador@suse.de> X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: 7cqap1xm1ow6me4k1jt5gda3w1mfut9m X-Rspamd-Queue-Id: A4D4340006 X-Rspamd-Server: rspam02 X-HE-Tag: 1750429725-190744 X-HE-Meta: U2FsdGVkX18pWjbHZz7FwsWlW2slNiZLjpQgZd39kX6TQ2RfuDOcGiGaggpSWedEuFhg3Dk6FgGeveOzrCCKgM8qiz2y5foICAu1F1PQxbct4tCP38u6dz273J0N5pb7lZtAO3s1y2HdRO9pkXC+1JVNPluXARMWxecRAiRN/ye4XEFjyOTrIypnYy2ENQ0JlwkQ90/AOyNi+oSuhzaPrdVQoAYXAB+VAdCzGKdjcFc97NFy/6dqxmInFyy3CIVY/ivtEG0l7eRBAYR/6DEjai9/SIa4a9g30HR44IFMdO/2Umw+jvgoKW9lv3hCqFdR2hVg3/477yXIpfspLEjP0e67WybD3Faf7y45kcyobKGdCnmeky1cQy22N5kJUblmCdOgbvM5QkPJyX3JGEu/QojMo7IjRhGFa0FsbqITuwuIwiv/ZYKmFwJX3x/tWJoQxt7dW+Cyao77/+2U5D9H7mRwGncoW+RC4cbn21APiHnqtQG8iM7rYFqauPvgxpV/626QFcehht8BiMTHwZszRXwYF3W6XoBEqF17tXrUxo0WN10FCC0Ci4pHL3Oyddqs/G4GhPSTegej+ZzmQZ9bVz+MyLgrRnQIxafL/VPGVTJhG4RKLC82Wr/5SVaB8zXcKIsoKK+1TWE7XF41ronCnjbHEhGQHiuw71fIoiqy4NWcmJ/n1lcK5TcDWVsXwofo2oudZ8Z9cqIbXYeRLyXEgjK1zv+yqersiP52tlNrxclU0c+ltfXXwD9lF3OaTVckNKZBx7CRJEoTkNexBKEkiFENLojcQQ0lKCvzhjKbJtaQC6L40BjimvkygA6BL+gk4rEmI7jPw569gYWmyEGov999SmiUpfg58Qaay1645HGM4gANH/lIayJzMiCe8P/iAljhT1KgXcflSwWDVaqp/ezm6MlnEtioX5TWVhk+YHuIO9fWMcO/Xu9d3hE4fZ2vS/YLZwpRwgPaoYe7rhA LQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 20, 2025 at 02:30:12PM +0200, Oscar Salvador wrote: > anon_rmap is used to determine whether the new allocated folio is anonymous. > Rename it to something more meaningul like new_anon_folio and make it boolean, > as we use it like that. > While we are at it, drop 'new_pagecache_folio' as 'new_anon_folio' is enough to > check whether we need to restore the consumed reservation. > > Signed-off-by: Oscar Salvador > --- > mm/hugetlb.c | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) [...] > @@ -6518,6 +6517,7 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping, > folio_zero_user(folio, vmf->real_address); > __folio_mark_uptodate(folio); > new_folio = true; > + new_anon_folio = !(vma->vm_flags & VM_MAYSHARE); > > if (vma->vm_flags & VM_MAYSHARE) { > int err = hugetlb_add_to_page_cache(folio, mapping, > @@ -6536,10 +6536,8 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping, > ret = VM_FAULT_SIGBUS; > goto out; > } > - new_pagecache_folio = true; > } else { > folio_lock(folio); > - anon_rmap = 1; Let's just on top: diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 57bb8b2dce21..f6ea1864ce5c 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -6517,7 +6517,6 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping, folio_zero_user(folio, vmf->real_address); __folio_mark_uptodate(folio); new_folio = true; - new_anon_folio = !(vma->vm_flags & VM_MAYSHARE); if (vma->vm_flags & VM_MAYSHARE) { int err = hugetlb_add_to_page_cache(folio, mapping, @@ -6537,6 +6536,7 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping, goto out; } } else { + new_anon_folio = true; folio_lock(folio); } } else { which is more explicit :-) -- Oscar Salvador SUSE Labs