From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A89CC7115C for ; Fri, 20 Jun 2025 14:12:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD7DA6B007B; Fri, 20 Jun 2025 10:12:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B88286B0089; Fri, 20 Jun 2025 10:12:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A77306B008A; Fri, 20 Jun 2025 10:12:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 971A86B007B for ; Fri, 20 Jun 2025 10:12:47 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1D590BD96E for ; Fri, 20 Jun 2025 14:12:47 +0000 (UTC) X-FDA: 83575969974.02.842BD7F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf29.hostedemail.com (Postfix) with ESMTP id D8528120009 for ; Fri, 20 Jun 2025 14:12:44 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NWRV6aCQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lu5I6+IK; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LITdzs1i; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=J8iZwDMK; spf=pass (imf29.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750428765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dtga4mO8TWdhcrNxuBweDXF4tRengQ+fG9VcYGmkW3c=; b=HbOjP4cPaC0PYGKSzWKiVRY9/ScfGvGKjZDt67vNwKpx4K48nXFkAZQiTuUQW12BygKZ9I nryUHxE1aiskRzFsTgjI7rlbhzxF5yET8r6AJBw+XQ4C3orwPvDIGS9o5poAr9w+kGQkVW 4AfjnOULzjyLtB28PYPXibZiMeR+BOM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NWRV6aCQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lu5I6+IK; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LITdzs1i; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=J8iZwDMK; spf=pass (imf29.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750428765; a=rsa-sha256; cv=none; b=FmbLjNNEhBDR1Q4nSbWhOJKRFT9mzoHyIxxDkue+1cLopdEck1K424bJTBrfR3iyQR8fG8 BRIL9fPeh6hsNjcf1foXLxRVYJtF3tgj88ST/2v6dNHDf/Z8FWclpKrLoNB7gaiid5Wkvs 7aMvqYawGVm1mMFppzyLbfaY1bcsRCI= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 360232125C; Fri, 20 Jun 2025 14:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750428763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dtga4mO8TWdhcrNxuBweDXF4tRengQ+fG9VcYGmkW3c=; b=NWRV6aCQSbsSKVN5q7Y9eC89NBbMnvIGOdeD9jTgcLGeihP0m1+9IfJ5+hR6kw8yI9AAuZ 4eHDmJ8sPs3OVvqXplQVXS5djquRGXDNfQ7iWg/O4rcNRWFUZ+xyscmkQ90uwDPiNAr1zJ 22YmVELpFy1fhQpf3UtBY+9IODRAoiM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750428763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dtga4mO8TWdhcrNxuBweDXF4tRengQ+fG9VcYGmkW3c=; b=lu5I6+IKrQqOm4192LOXk9YZWP6wH/RZ0bgYxq9QyDcXuhYKm7+eejNbV+Z9D4qldbzsNu os4HkuacHmeJ9nCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750428762; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dtga4mO8TWdhcrNxuBweDXF4tRengQ+fG9VcYGmkW3c=; b=LITdzs1igri+FwLqtM0ZNwDGXD4masM2omJHh/AYPLu9s73jc1wuAZXTdiEwma0v/YV3f0 UEXxFSYGjgJ6jG48+qTAN3LhSEcM2Go8CyS/rtXsOMcBx/uzgnW4/GlxLZ/4DEyUlxgz1F 2wgUcSTUnkFX8PS7NBCw7w5g76srinE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750428762; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dtga4mO8TWdhcrNxuBweDXF4tRengQ+fG9VcYGmkW3c=; b=J8iZwDMKHqlx6VCsDIpTprxToxyIOpCO/tg1AQptUJ6i2mcjOOKEs+yuAuZPY2k3qr0FyG YECuaevK1f5TyxBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AB5C513736; Fri, 20 Jun 2025 14:12:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DZ8fJ1hsVWhhSAAAD6G6ig (envelope-from ); Fri, 20 Jun 2025 14:12:40 +0000 Date: Fri, 20 Jun 2025 16:12:35 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato Subject: Re: [PATCH RFC 04/14] mm/huge_memory: move more common code into insert_pmd() Message-ID: References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-5-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250617154345.2494405-5-david@redhat.com> X-Rspam-User: X-Rspamd-Queue-Id: D8528120009 X-Rspamd-Server: rspam01 X-Stat-Signature: 5z9km4hy77fzh6cxr5tk9wjzdwqpxou4 X-HE-Tag: 1750428764-732428 X-HE-Meta: U2FsdGVkX18r6H2C24vUM12qlbEzymP0bnc31FJ6gi9NDVdJkf+KjVrJzPmXmmLwEx9oLlEi2rGHDRqlgt9gauRd/yhhd5TxveZTC/UBiCDNgOYpYpaITzzK1EwnwYvdNRsLvMfwUDxnLZkda5FmRuTRBRK265kSIjLHf1x+IwlCc0k/hXM1KptLpn1ls2alQgRX9/HF40liy9TmDDb97tz2l2RetCuEk7Szsj/TorsJmJtcfjuKooH2Ou61NMSI7qoWgaKkBRNJR7uw3Y920DkLLvb9PZfpBN9kU8LfU5TfrcBNEAzaWT8IRg4yVhEN6X7smJyP19Q/c+voePVH8B5B/+ZjHVxp9sL7GhMQ9U5YCuP/v0l9VQZ9jRN4fShyqTWIwsH5QYRNyB5dtXNJzY/vhHV4JMeVZTd3zWCb+A9oNsbHz2hZXiBMB/goC8wGNYAVkNQeIP6wfFSxJ7pg37Qinj+wO8u/OyTf5J75z+RbVsFCwGfYLNjK3W86FMAvAGj8yOz+mJNiBGe7s7aFiVsznOSrKhinvvaoUbeJfVT9ryF/SZYEXoy2n2nVc4VTyVZxdqSYlX7aKyGz1nSW7xDJcKnfpn81w6S6zsLHE5az2SxWPy2LcrUfVaVv+7s8eHEfHYeM1/mk2WYQ+Oy/ZP3C0Jy3WxXN8jZzckyUO/rjV3CRbw+MppWEBbaFOmdT5y3xOQQQ7R9cjTsjKoaaZM3z6AUVCbPTRMazxCrJc1qn8Yqgnzj0g3jHYDauCTQrVyN3Q0D+bjtrDpW1yzN7QnQ3i/n+0jzNfazAMo88/WY165LfIiax1pafctALOcEm8QTP+aGh3iwZSmnzogr2PMNimwig2J0a9BqZ6d9/G4z2Uq5/Z51imliYDX9nm4G8hM1vSQYQ+l77Dz6bJ32ATzPbQQKWlno/S2ybOojh9hfjLivFMIX+rIFitZRzxOH03exdfiepLXR0r3r0vdh MCGGTCdl vXyswD4ykDtcyl41J4GTRbs5UsYTmhtJq5OfjlCaa4FKD4jU0Z/OHA1OwiSs7JwCgiZOkhUlzI8JZBkFF0wwiUfBoIO+9DIrnA4uwlSJWPuncANLtrLUMHFHfoGgCtrDod6vTjGcvwapJykqfTUjlhKTS1Trvjk1OwSQPo+yuVaBzxIh7GFvYw3rks/9J7RGsGZ+X58zWun7lGJ7e3T8GOl9Mxtoenpaao9umQ36K/HgsYIyb+u6uZPqVxOvoACk0Avoa8p0DOXPUD+jAQvrjQIHLG0YKNgT+/RTovlgZy969N51qMr2HiTRy3A7T8vH66PdjkLv+ZApGuaY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 05:43:35PM +0200, David Hildenbrand wrote: > Let's clean it all further up. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador I was thinking maybe we want to pass 'struct vm_fault' directly to insert_pmd(), and retrieve the fields in there, but since you have to retrieve some in insert_pfn_pmd().. maybe not. -- Oscar Salvador SUSE Labs