From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DD79C71155 for ; Fri, 20 Jun 2025 07:53:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B33D6B007B; Fri, 20 Jun 2025 03:53:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 563A46B0089; Fri, 20 Jun 2025 03:53:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 479F66B008A; Fri, 20 Jun 2025 03:53:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3BB206B007B for ; Fri, 20 Jun 2025 03:53:33 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BB6D68011D for ; Fri, 20 Jun 2025 07:53:32 +0000 (UTC) X-FDA: 83575014264.18.387CEA1 Received: from lgeamrelo03.lge.com (lgeamrelo03.lge.com [156.147.51.102]) by imf22.hostedemail.com (Postfix) with ESMTP id 613A4C000E for ; Fri, 20 Jun 2025 07:53:30 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of youngjun.park@lge.com designates 156.147.51.102 as permitted sender) smtp.mailfrom=youngjun.park@lge.com; dmarc=pass (policy=none) header.from=lge.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750406010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PRl+x+cn5guXjzl5dWlxySfO3d4116NRfoQwQPu3mXs=; b=kQdE/VIdmTnTDZ3EJuHtEI9dOoDBlRRr1yRXYUBUAGaeAkR4JGMoYvDysOC6DajxIUxi9t VO0U2//gpFfAPqcbnIt5JFoAzUUcj/VqtOusQ+4Z3MpP2JCFKTsoOsPQQLst5IwsCsIS6B DOR2Wn6b5yyezqrlpuORlWjQK7tcChM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of youngjun.park@lge.com designates 156.147.51.102 as permitted sender) smtp.mailfrom=youngjun.park@lge.com; dmarc=pass (policy=none) header.from=lge.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750406011; a=rsa-sha256; cv=none; b=EsduyfcWmmM9QgTiUeTlPn8WsmpKZ2WlCYS2De2G7FaUqP7D+FdRF3hyfCUtz1IMEvWv1Z RYYDkfKeSoz9eAgdhnLmqG5FTfrzviwizPNjfcGUGe8eDokr+TA9ZeWSlRCiEUVaYJIi1K yJtbQpoaLbdC7PJVNjXebYgqS2sxaEE= Received: from unknown (HELO yjaykim-PowerEdge-T330) (10.177.112.156) by 156.147.51.102 with ESMTP; 20 Jun 2025 16:53:26 +0900 X-Original-SENDERIP: 10.177.112.156 X-Original-MAILFROM: youngjun.park@lge.com Date: Fri, 20 Jun 2025 16:53:26 +0900 From: YoungJun Park To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , Baolin Wang , Matthew Wilcox , Kemeng Shi , Chris Li , Nhat Pham , Baoquan He , Barry Song , linux-kernel@vger.kernel.org, gunho.lee@lge.com, taejoon.song@lge.com Subject: Re: [PATCH v2 3/4] mm/shmem, swap: improve mthp swapin process Message-ID: References: <20250619175538.15799-1-ryncsn@gmail.com> <20250619175538.15799-4-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250619175538.15799-4-ryncsn@gmail.com> X-Rspamd-Queue-Id: 613A4C000E X-Stat-Signature: 18p9ph9z93xzhfkfu7zusk3qha7dpt8e X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750406010-224845 X-HE-Meta: U2FsdGVkX1+tKPqnLztMPApjGj+FZB+T/dC0SyD6ItZCpBpJuHQSUfSRnxGsEPW7aEzOTeS9XC4evtpnXg0ky12HX/0twnzv7w28aql79RdQasUcOnPjcSG9My8bI8NxeAuMRXTIHgVsTZ9uFeDTVXvg8g3safoMlEzBT2FIqxny+9Z6rEe6STnDjPiZTbgTyTp94/MC7PMt+RyN861T1M5wrdwu/xCeOFzFcsfAlQo6xoognOV8p+gAtx2xhtg2Ug89tI44YTK5szv2hZ7xZGX3xfkD9bpuLlAwOQnWFKESjSOjlU+p1Db6V5zYPhBWn0FVGEmlGEcv4Riuo11Up4K2GEwwdOSheKy5QKGORD0/cmoG1i3nqm1gpveQVcfiKz42vhRlyu+FJTTOnAn2rhxKwhNYOdRTDsLJQpRgStQoUoskiyTxzsar8m33D5lw4TfNZ+Yah+EEH4k6Y3W+qpOAd3Tlnh7lLiH8wRvKmniSQfXOxeynN4Tl4Ez4pVUFqMQpELAxqVENII21UaKtki9MdmXQu6zUDVBJ1oQrjcMH1QYdrMHpKhypjM6zm8WQqoeEqGKNIdkQZxH7bTXHyINNDCrgkwemOWvE4RX/k24gxFAdukJAcj4FxZDEqloe5NMiAMO7xuJzPvIlPMqQOs+2ARTwBHrPUhlsMbdQ9fZ7na93ru2X0o91EXvxw9FQl8ydJ3wjS8TA15SWOdsm2sor/ywpCQS5FEN83rgWQB7zfYrBidTdinRanguptK/U94DZDORW4VjNLTFgh3QyJgI8TaPxiS8D+Chv9raUK/1+3Adl2h/DnBV4LCZEn4RAhAqS9pFv7AzIjgP9K6tj7E5RyBmsGEBVism8jKqc41ffF+24RRDpPA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 20, 2025 at 01:55:37AM +0800, Kairui Song wrote: > + if (skip_swapcache) { > + swapcache_clear(si, folio->swap, folio_nr_pages(folio)); > + folio->swap.val = 0; > } > + if (folio) > + folio_put(folio); > put_swap_device(si); I really appreciate the patch. great work! It's a rather trivial point, but I was wondering if the following change might make sense: ... if (skip_swapcache) swapcache_clear(si, folio->swap, folio_nr_pages(folio)); put_swap_device(si); if (folio) folio_put(folio); return error; ... My intention here is to minimize the reference to si, and from what I understand, this folio has already been allocated and would soon disappear. Is it possible to to reduce the clear operation? (folio->swap.val = 0) Just a small suggestion. Thank you again for your work! Regards, Youngjun Park