From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE20C7115B for ; Thu, 19 Jun 2025 13:26:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2760E6B007B; Thu, 19 Jun 2025 09:26:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 227186B0088; Thu, 19 Jun 2025 09:26:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13D0E6B0089; Thu, 19 Jun 2025 09:26:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F29FB6B007B for ; Thu, 19 Jun 2025 09:26:14 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A6E7F140147 for ; Thu, 19 Jun 2025 13:26:14 +0000 (UTC) X-FDA: 83572223868.17.A339600 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 5793314000E for ; Thu, 19 Jun 2025 13:26:12 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=H+XuEpV5; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750339573; a=rsa-sha256; cv=none; b=tQ38OyHGu/peW1cC7TmlMsvD+AYeo8xNdhHg0TiGOYQJ2rKoRk8QEw72Cvm/RS9zskUNX+ fvaT1/Pg634qaXLU6vlKnF451ooEMDSvbfOmjzldoHB3BxdCS7dYTNFbmBT3p92sFQle9Y AtPoP9Y00drQH8z0HJeh5adGi/fff0w= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=H+XuEpV5; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750339573; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mUtH47jkNHTUfdWVtm4j/G1WRt46Af+dgwGJAdSFHtQ=; b=CsIrIIxi9a8hAhwH2MO1pKB65vS3Y8SQ/oqW7aOJhn/G0S1cbiSVX0NyULPDncNOd4puMb ApJ8LXC3ZvY38rajjRWliMBdSJfS9fHmSKBH7lQTq9DgNEufogchrh5+a+H9Zwy62dx1dk anRLJ690wWHLEu2AFk0goptn7WsjnZ0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mUtH47jkNHTUfdWVtm4j/G1WRt46Af+dgwGJAdSFHtQ=; b=H+XuEpV5mXnE+WB6V7UySKtgBl jqlZGGTOTkFX1Hbpt4yp+nmMHmGCWmKd0DiFq93xPfzIs3qKQBKIbfnSZ1KEsxoQWFzCmqv3KObQe Rcoh9gz8uQYxkLVVe7rvm+q5C7K1eqkqeS9cOB2ePUwQJugdCPVGtRGRhILFu1twhnzr3lqfaccvY ElgkuMCMyfpfOyDqYaESt0G6UlcGlKQ3JYo3RjG9LUfXV0WPRGyQnMhUAeREXObQ7KenW44HnFqN/ jGL+tnqNBWTiGWQV6TWSKY1NwF8ThwNrQIoWW5SIQ4jQTlAiCrOnAtKg8lNvUuV0fonmpm1lKmvLL BkKgnqeQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uSFHM-00000008p7G-1NVS; Thu, 19 Jun 2025 13:26:08 +0000 Date: Thu, 19 Jun 2025 14:26:08 +0100 From: Matthew Wilcox To: Anshuman Khandual Cc: linux-mm@kvack.org, Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Petr Mladek , Steven Rostedt , Jonathan Corbet , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t Message-ID: References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618041235.1716143-2-anshuman.khandual@arm.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5793314000E X-Stat-Signature: yrzzdcmxb37a3wbyxwzhoekmxanrcu77 X-Rspam-User: X-HE-Tag: 1750339572-407161 X-HE-Meta: U2FsdGVkX1/FDQGocFFcHggkH8lpiTnWhK23Bj/eB0+Q7LTZcaHCLTzaefQL9Iv0R+LWLyyK7OxGPd9se2lH4KsZI0/VydJwOUPSI87OWH+LvQR88h9DEIqn14cjux4aUvc/B8babIrVXPmxfFl8tWJDTO4l4INkyI6emHYgr/h1yyK1MIryY72PfARihdrvqMAjpL/b+UBgKnl6lOXXLqE67lQn58a4SnU5NdgEPbAzZEuUJhoF2sTeCzi7cAtbh4kz6LUbyHle1+n/KkUExh6TyZvb+YIDYuDSfYxGhRG31UxasLn3i+R0W1iu9NiS6qnbc/lejCPFq6Z0/NLTgvMeOwKwlA4w1pZ3efEQqdOPoPnMqwFR+X/BVOqnN3oolOf2uI8Fi8+b/E6EC5MvIH2ht96EwXT3Uj6OrjZCifS8X8MCs/doXwOF641ml0/X6N0mXWkd/ctwpfrWF19oAGrwHE869i8GdY/r4G+Ru8W1vplryf+j2kp2kOVPkuB4Uw7VxGVwSw/XIVMN8x/7s0VeJYGM7061hxKdD6E1iMpiSd/ooKvM1r7VesWtJFHDxPXbn1J3UvC3Sjs6WFA7w5ms8Puo9qWZ+5MBVb7Az/FcJAQ6hZFHl1w3yC0aAtlH5ncetlSWGXitKiof8Unal1jssGw4YNHxVO6bj17fGeH5J2MKRdf7u+0YQYSzPstFAwEh7/R33VkFkppu9gZZtbo0ZKvkDpUUNKFXApl1g7EQurl2M1NE6/GD/I+peBq8WO56B4yr7D5uxAQ1bALNrkgSpM/eFEd3JWKMrwU8owUmoi9GJL7oJ2s8aX+p98kNRtksKcWM2uG1Nk1j65y5qvxgPTNAiDHOJTPHIJkBpDNiZW1zO2pes90tZtYRHI343coh58oGTMpylfV+lm33fEZirBaemTN3WNI9eZDQqXoxXwCvDr4nmPvT1/4FwrboGvv5q4uwtzNmlLOyJsg v7l+3oqv kNE57tRWfA1I/cNAb78b5GEfpdq1LqdqzN60XpdzOcUYoTumqdWCSwrbq/nM/x5lz9EqpYXh24XDKWYXU3Z4ndGQ6N1NZEdmfnZs78Qpc62cesG6FLmg0cFfMycXOVFRmKQlGlJV9AnnrgN+auKdJ5ISemVjhOoSbQ+vlN0BrTGR07LtcZR32j0YGDJ1JyuscRHcWpuW32KyZN1Zx17vRZ5qiuG0aGxKgTxIfE5GgT4xsR/RxEmT+32logjojMTtrwHNI9vCvB86KDHD8kz4eaPFosg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 09:42:34AM +0530, Anshuman Khandual wrote: > +++ b/mm/memory.c > @@ -522,9 +522,8 @@ static void print_bad_pte(struct vm_area_struct *vma, unsigned long addr, > mapping = vma->vm_file ? vma->vm_file->f_mapping : NULL; > index = linear_page_index(vma, addr); > > - pr_alert("BUG: Bad page map in process %s pte:%08llx pmd:%08llx\n", > - current->comm, > - (long long)pte_val(pte), (long long)pmd_val(*pmd)); > + pr_alert("BUG: Bad page map in process %s pte:%ppte pmd:%ppte\n", > + current->comm, &pte, pmd); Unfortunately, the one example you've converted shows why this is a bad idea. You're passing a pmd_t pointer to a function which is assuming a pte_t pointer. And a pmd_t and a pte_t are sometimes different sizes! (eg sometimes one is 64 bit and the other 32 bit). So no, NACK.