From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D152C7115B for ; Thu, 19 Jun 2025 12:07:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A8456B009E; Thu, 19 Jun 2025 08:07:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 080706B00A1; Thu, 19 Jun 2025 08:07:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB1386B00A2; Thu, 19 Jun 2025 08:06:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DA38A6B009E for ; Thu, 19 Jun 2025 08:06:59 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7085E1026E4 for ; Thu, 19 Jun 2025 12:06:59 +0000 (UTC) X-FDA: 83572024158.06.E0D9683 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 316B24000B for ; Thu, 19 Jun 2025 12:06:56 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zqPcFbLf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=jEwdsj8r; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zqPcFbLf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=jEwdsj8r; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750334817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KDAuEsNXKXygaILSEXeEMNcT2WMigGIcctwMV7a0cE8=; b=UECtqslOelEiwAdVzBaDD1LamYkB/SAiEh+RkR/MxRgqXW0xfodTAC1ejx8hOXABWfc5s2 q0KKkVrN+r98rKp5DJ7cDKWkIlXtoMUBlcuxhVJiNi6rnK6mSLAusS39kLrX622xf8V1m7 8fwvAgOhrb25a0eOyf9zpBPf0Pz1DRc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750334817; a=rsa-sha256; cv=none; b=qUc8aZ/JDEDHt29vpx1jajcCXmTnWzLhoBfZ6/L97L5JuKviqnKG3UQiy+BZFqs9lDbn+i u9k9H25BYeLWljx1jXtGcGqkc9hRklxzfffJVljhP/rFicAIlQIy2DVmuZv7rK1z2oNxPi n5mCGVuqg5E17gQ6djR2U05z3rLBM+I= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zqPcFbLf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=jEwdsj8r; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zqPcFbLf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=jEwdsj8r; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A9CA91F38D; Thu, 19 Jun 2025 12:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750334815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KDAuEsNXKXygaILSEXeEMNcT2WMigGIcctwMV7a0cE8=; b=zqPcFbLfpUQLjy+Nw4cOX/B2LiApdKR7t9DEm9m3vLLybWpiWlFBWTl6QNGFMMJe81DLE6 1uGk7SLFk0EUnA6QiPQBz3Kv/z1D/ZNALQXlfFywd0PzUqn46btyJOJmbpixQ6uQ0pR4Mz lMMpI0foMRv6N403hLovr2WkJq9iRKQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750334815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KDAuEsNXKXygaILSEXeEMNcT2WMigGIcctwMV7a0cE8=; b=jEwdsj8rqU+sAaEm1rAhYOm4nratZdmqMyGOXNSbv1Zh1lQm/lkFeChFWsq3xyo2+/dtFQ eI1mhCTdCBSEvaDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750334815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KDAuEsNXKXygaILSEXeEMNcT2WMigGIcctwMV7a0cE8=; b=zqPcFbLfpUQLjy+Nw4cOX/B2LiApdKR7t9DEm9m3vLLybWpiWlFBWTl6QNGFMMJe81DLE6 1uGk7SLFk0EUnA6QiPQBz3Kv/z1D/ZNALQXlfFywd0PzUqn46btyJOJmbpixQ6uQ0pR4Mz lMMpI0foMRv6N403hLovr2WkJq9iRKQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750334815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KDAuEsNXKXygaILSEXeEMNcT2WMigGIcctwMV7a0cE8=; b=jEwdsj8rqU+sAaEm1rAhYOm4nratZdmqMyGOXNSbv1Zh1lQm/lkFeChFWsq3xyo2+/dtFQ eI1mhCTdCBSEvaDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AB002136CC; Thu, 19 Jun 2025 12:06:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QUQhJlv9U2iXdgAAD6G6ig (envelope-from ); Thu, 19 Jun 2025 12:06:51 +0000 Date: Thu, 19 Jun 2025 14:06:49 +0200 From: Oscar Salvador To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Catalin Marinas , Will Deacon , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "David S . Miller" , Andreas Larsson , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , Peter Xu , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Hugh Dickins , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Harry Yoo , Dan Williams , Matthew Wilcox , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jason Gunthorpe , John Hubbard , Muchun Song , Jann Horn , Pedro Falcato , Johannes Weiner , Qi Zheng , Shakeel Butt , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, sparclinux@vger.kernel.org, linux-sgx@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm: update core kernel code to use vm_flags_t consistently Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 316B24000B X-Stat-Signature: myy4jw38fzcymj56wia77f9tw38z76to X-Rspam-User: X-HE-Tag: 1750334816-910620 X-HE-Meta: U2FsdGVkX18bMACAgA5GTaAoM+yIEgNUrNlPjTxzG/n051jZSyM/aX9BEX+XO3Wn39/RGbiedp+marjOAZFQGuerq15pZKVza3kTzHO+vU3hht/vC6FBHJUGt0xxcVJlf6N33kjXSaqmzY3xjDUHvP0Y02wRxgehzWWt5+cwmyudVGW2LExg0p3Uf3VAm2lvYnsZWR2AgRME0r0MiG6E/btqfWliz36S6TIIldmlStYXgdsrlRAqAamempckTCIxOAafBNetex4uISOTUY2dv2z7HxL2i3a1dK8HZ+mfxMV1FPqGXSFeCHGin4CYxdljEXtDWJK+pe+2X+21ljR1bqX8WiC7M/0HQQb519X0Mti446cl57Q+ZUKLtIFo7PsV8vgjbp8YKDGD0ahN7VAqOWSaYyabaDzdMWnfznn45ErXMFGcFEQdF6gSyj3AhcaNOJHO80YIN0jn3wlHCsTRZ01dwaFDK0xq6puXNN5ZqIqfamk3kp0BcG4MktaxcPGTUyJEVVZwegeOLpPi76+2DREQi+0GNoHTdeA8qB453YqrSB3kSVjh5Z5bGPmYUKiIUXY3Y3L5DhGh4EeoLPjPDPCYP7kMZdODk5PhEVuzhXlhsudWYHq9+eje2JjzCfzbpG3e2RC6rw1ceEMO7DlVN63P1xxhEcELGb6r1SJU2R9h7/GNrJk3lJTRr0wbYWSE7QONumG+A2GU3yvsQY1TxHJkMANyXQ5twy0nCyFZ7E8qzZ8rtSvTiVBsb6SVSYvUBMYpZyY/9d5pi2JZ6vYUirFul+tItIia9MBv1dwyMbx7wKsx/PEss33lL0+RXf92w9IDxHEydTGkF5x8XuQtSfCJcj7QxQtqRyg4CX5RWcWfSYaRL6gCBpM//J5bkMVfiBc6VWQ5qfuUbyv5np5dQEHAqOj9ZQG9fuIfOzijNt1xl+0306NlJ79wozxEWVaBU+5NWbrmC/GHsqF7aUA KpY88qf5 J4/27qVYOv2qS2p/9RjuqD4y0xtQmWHzanGOyqbwp99wHXnVf9LYUyiEuFLWIllcb/4TQJItg4DsJdGk3G6xGH3cN66/MIb56hr2S+qwbHHP4FHh0TXfjGG8PD9Zf2UzV17d3vC+LAtb2sVBL2CbjePAODqtH0BqPUxNSKfZopI8ni2QNIIaYMWoZmWgQpC5Wu44JpxBE0WjFDA+qLkDiO8TsVClo8UdrCAzWM3F1eX745GhlXyn8v6bl0jRj4muQtGlWx+AHCsadcUwZGFyPRdjcT1tUgPILDfnICaf0z/D86xePuwYt7nI0LC/BvHX1jF1hPREDVrjeL1A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 08:42:53PM +0100, Lorenzo Stoakes wrote: > The core kernel code is currently very inconsistent in its use of > vm_flags_t vs. unsigned long. This prevents us from changing the type of > vm_flags_t in the future and is simply not correct, so correct this. > > While this results in rather a lot of churn, it is a critical pre-requisite > for a future planned change to VMA flag type. > > Additionally, update VMA userland tests to account for the changes. > > To make review easier and to break things into smaller parts, driver and > architecture-specific changes is left for a subsequent commit. > > The code has been adjusted to cascade the changes across all calling code > as far as is needed. > > We will adjust architecture-specific and driver code in a subsequent patch. > > Overall, this patch does not introduce any functional change. > > Signed-off-by: Lorenzo Stoakes Acked-by: Oscar Salvador Heh, for one second I thought this was about to convert vm_fault->flags to the actual enum fault_flag (which wouldn't be bad if you ask me, because "unsigned int flags" is not very descriptive). But this is quite good as well, brings in some consistency. -- Oscar Salvador SUSE Labs