From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F59BC7115B for ; Thu, 19 Jun 2025 12:12:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1769C6B0099; Thu, 19 Jun 2025 08:12:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14EFB6B009A; Thu, 19 Jun 2025 08:12:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 065096B009B; Thu, 19 Jun 2025 08:12:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EE6716B0099 for ; Thu, 19 Jun 2025 08:12:58 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 94F6280E39 for ; Thu, 19 Jun 2025 12:12:58 +0000 (UTC) X-FDA: 83572039236.10.65D1761 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf12.hostedemail.com (Postfix) with ESMTP id 7662E4000F for ; Thu, 19 Jun 2025 12:12:56 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750335176; a=rsa-sha256; cv=none; b=RoxelUG9u1OJrlAxc0hQ4rxfhoHFSLcWpAGUJiTP3nBLxP42CwuzrhVW+YHXezAHRE+kdU r47fIqpKA1GTj2OXd/thFtq/ANIPfMGOIpBkuw5dDgzMuKBfhH/1kktlp0FRzkH3hVUDta tufWDPAwij9fxvSKmD1HQlVCnxMxXjQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750335176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=48OVcbKt7NY/1Ix8zUECQ9bbteZB/gcMi8Gdz2DlXLA=; b=z63De5TZ8XQo58AlmCS4EaJtyeB8z5SwsaiIM6TRblzn1drNMdhPXIInQdKJWPxfW1/V3E oDplMUKLLHcQrxtwTzx5uCsa16V/7z2eg4pd9Rw0UFFnU2wX4ErkSVDOLWPhzaF/Rdv3hh Qn55TxGGQ+JzgNJ3Zb5haaX3giPemks= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EF7911F38D; Thu, 19 Jun 2025 12:12:54 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F06A3136CC; Thu, 19 Jun 2025 12:12:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id PH/eNsL+U2gneAAAD6G6ig (envelope-from ); Thu, 19 Jun 2025 12:12:50 +0000 Date: Thu, 19 Jun 2025 14:12:49 +0200 From: Oscar Salvador To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Catalin Marinas , Will Deacon , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "David S . Miller" , Andreas Larsson , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , Peter Xu , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Hugh Dickins , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Harry Yoo , Dan Williams , Matthew Wilcox , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jason Gunthorpe , John Hubbard , Muchun Song , Jann Horn , Pedro Falcato , Johannes Weiner , Qi Zheng , Shakeel Butt , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, sparclinux@vger.kernel.org, linux-sgx@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm: change vm_get_page_prot() to accept vm_flags_t argument Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: 5bqhbxqdp1enauqxhpoe8a9dywbxjncy X-Rspamd-Queue-Id: 7662E4000F X-Rspamd-Server: rspam02 X-HE-Tag: 1750335176-671482 X-HE-Meta: U2FsdGVkX18eXSnfL8QybJwXim4V8I0y839tDV5p0dXVKm/YVJ576p/z06AFgpGXSJDCreL2EYG/FqVSm1lXGYfRbGyBdWLAn7JjQuOscVCbWGGVuGCStrkBZmnmpW8Ufmye/GHJBfwWowOMcvtUUl1D0Igi8/gN2iw773ZoVVqOj1h4aoZnanHCOi8sxt0OvIJDoJRdUIhPrD8Zs++fs0WLd9FRWvjPnWKNln++fVFrM1klYoWsRGxk8D0cRoIQYKIIixwYGIJ+31wJim1LGwZ6dU1tLJKJ2xayp3l2MB5XRkZeFrDi5y+8osZ7CgDKLzEb5BUAZKQLa5LbF5DSzp/2IjjsFc++6wctb3JtFlp6nI33RmbRYKEmB/ZNAbXPZC1ntXMohKueqvgjwpCVufS3PW4z1HizaTgo7l9zc+aM9AxBYtvPvjiMUj0b/idJA3b7gHUPD/At+OxLYgBNvzrBidYaWHA/BlBECqTZ89G3Jj3q/ugZV4o5NCN/1OlfygvNxt8ha9WBlJO46dbnMVpg87d9MCYwGoMRHM7CIwwvvh8+jXShpzsy6DS39OgoZ8/oESejO9hLcLptgD5jrb0YmXqmfxViVpRsg+pw5xDfn+PIiS/H9Wget9tqgnjOzoJ/2O2IFu/TLbfrXbXys2qIJevNsnw5fUt8pQCWhUup+CqzCFiS5ZDvQIE/OLWTxaGG9LPP9Lxj2xErDjd35tdNIrx7fsvn34WZWx6kO/AqFpsUmiyC6U8aHf/zEMlXpGVSP2UR1yMi2ZuxW+0fg0k1Jc1NcQN4rOZaOr2/DFhR1W+Wq9mTq08+DR8O2gT3ChTd8o2AgNgRJ7gIaer5zOKLc+nh7pfiTF7CuXQ3qX0nK3OJnLQ55KJtFpPGcZSWaSCkcYoWhvODAW3t3Qsvx6D+dlm0m+roHiTzZtNywec2wy5f5VrsHk9h+o4/7MuiwU2cy5HptteuOL66jf2 N2cIZgXG DlVPeqXJoDFmB2v/Ojh8BLQw+9YKRyXK528U0Y3Qg7cabHdRHZosT6YjZfzxE+caUIGIeQd3VDPAkA4X0epFE+I6Dvv81PaHvSFAGs6NtE2cvLHMVncDQyNa1Sju4hk20rAIvsMiLW23+Kg/EXljTglujquTNpTRDKG2fmBFBu1us5+sOWKqNyjKmRWzfmcMdXHw3qeoEcLsXaL8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 08:42:52PM +0100, Lorenzo Stoakes wrote: > We abstract the type of the VMA flags to vm_flags_t, however in may places many? > it is simply assumed this is unsigned long, which is simply incorrect. > > At the moment this is simply an incongruity, however in future we plan to > change this type and therefore this change is a critical requirement for > doing so. > > Overall, this patch does not introduce any functional change. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Oscar Salvador Same comments as Vlastimil, you want to push vmflag_to_pte_pkey_bits further to patch#2 and bring arch/powerpc/mm/book3s64/pgtable.c:pgprot_t vm_get_page_prot(unsigned long vm_flags) -- Oscar Salvador SUSE Labs