From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA668C71159 for ; Thu, 19 Jun 2025 05:48:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49A776B008A; Thu, 19 Jun 2025 01:48:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44ABC6B008C; Thu, 19 Jun 2025 01:48:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 360C16B0092; Thu, 19 Jun 2025 01:48:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2698D6B008A for ; Thu, 19 Jun 2025 01:48:12 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B29B51D92A7 for ; Thu, 19 Jun 2025 05:48:11 +0000 (UTC) X-FDA: 83571069582.03.9F1527B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 15E0C1C0005 for ; Thu, 19 Jun 2025 05:48:09 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IjXP7rVJ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750312090; a=rsa-sha256; cv=none; b=Zb/oCSQ3KMUfpYEbeC9zj4DQs6avq9kzQxT5DN1VbG4mA0H5e1wD8pyUohNzuGtW+5LZ1Y IJL4Dsd2T4js5AVyTJWg0Y7YyMI6sTUlCMRZ5txnG7V5GJiFJTmgCKwdyxkgJhwV5Qq5th itYeZ3hy9WOMKPxL66whRCcXVFsKn18= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IjXP7rVJ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750312090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wiINCdMehZMum17SdacCo/Mcez/8aysjKMpzrYn8xpc=; b=lmpMBbKALxY1OWPbhIDKVtyHHDpWk3OsELAfhGLxByoAtRo56tfnIW3XboqRF7p5GRqxyu 0VSaa9GiH57OD+RZ4TuwwCdPleILoROKeM+MBpk9k/M9Yu1/H8THw8e+wccek4muvTCj8N Gjh41+tW2CURiV0PKEL31xH3JRISg9g= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 438AC5C18B4; Thu, 19 Jun 2025 05:45:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DCB9C4CEEA; Thu, 19 Jun 2025 05:47:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750312088; bh=naO5r0xMIhdjbn0oOa+SVmj9KjDZ5worxHK7bSVntUk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IjXP7rVJ7AZnRuppJyLrpp5E8Fh+t+2oljLVnWBBBSn/d1vR0eGIWRYGA9tuTPZxk 1WjJMU7H0LqXwDq8R0BlorxkYnEHHHlDMoVIzC4TN0b7sC1cULh3G+MWJHwVH7xkz9 tCPMfdyKM5V0i4bvNc7Nmlusq60gK1you1vNrbR0OMNiLtHUI3nfQN0juBAxkHM6/o ts+aKMfmoW7KUXQXeNQG3kObJpnfs/6SAEy+ZvEIdSUbOESxfPgslyESbzwTawbWW0 0p+BbIlpITQh6XRqByB/6dGMmYRgJ3In9Qc8ufkd7ZoKCLwjJIVuYBHy37Sjo6Og4z FW+uh64HrHsSA== Date: Thu, 19 Jun 2025 08:47:46 +0300 From: Mike Rapoport To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Catalin Marinas , Will Deacon , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "David S . Miller" , Andreas Larsson , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , Peter Xu , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Hugh Dickins , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Harry Yoo , Dan Williams , Matthew Wilcox , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jason Gunthorpe , John Hubbard , Muchun Song , Oscar Salvador , Jann Horn , Pedro Falcato , Johannes Weiner , Qi Zheng , Shakeel Butt , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, sparclinux@vger.kernel.org, linux-sgx@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] use vm_flags_t consistently Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 15E0C1C0005 X-Stat-Signature: db7cmp3i6fwd7mjaereybc6seuy9fkap X-Rspam-User: X-HE-Tag: 1750312089-834315 X-HE-Meta: U2FsdGVkX19M9cjzogYt90yy5TCOlJIrPpV9dkvKNXhYkqjZv86UCAuuZ6/wYIQnaoWwQMtsNxXxopahJ51ljMDnrQU5EIwurM7saxo1J6AXUGxNU8uYwAq2cobTOPT27/XhY4kFlt7hJ7PJs7p9TzxmUKZq/o4wHDu6I8x/RTTOhkMH5aa2wYDpl297PehtUdxhlX9eVwWZQTdcUSMUYyJzL7hb6kOvjoAYPLQulHF7gXrU4tk4GH2w0XwMkRbibjcAtokH2dtmhVmUBOUZ0WhXMyTG5iKF2YESeTYOrf05OlfMalkZdWk19nAjAeO5KDOSSpe0NbQSoLYZuD2u7GXUQKPHtnCLNjwrKivNueTwW71RWkKj9PQkHXzzwLLp2kSTq1HDs9xLPG3IgRa23G8WY8f5fiOF4WBtKtb/nbK3mEhloxg1ntxuUiq/X4NZV9W0Jo7cHn/m4IE/Qir9uTUahq/Y2uh/05i9xwBWT7gem1eSAqbpBwj+dFCm//SICi928vcb17+UiAOP3bRdwAq87r6z5vmd5lD4wsV+2IgYXgqZCcTysQRY8E2lh9nIOsUe2cqajfbwUSErMvN53Rle3zOVBw/EHpaTLIsbwcatZjrgo/KnGJd9yhhwuHDEEIBvVNM4X+tU2nSBZ1xN8SZXtwqQHy/lc587De/hDikdxwZ9+ccbZ7TyEVkuLLm8d/JJ9COLWk529Tkjs77sVFVvOOAgnRbmNEiBFq1UsPYdm6psoLET1TOdimZ/xZ4eHWBmO6RxPDzt+aKdEuMHP+Bk8OmpLI2XVEBd2CcDed4npTkeRntRqCyZKFU0rDDcy3x0z5gmup+3i7OuSdfbRNzYnLiUDsC7rGk/zwI0b/kWo0AbRL9RwYlHymCMosSltvhgWhIN07Vdgc+AK3LaOfV9YehhC/XN7iynD5YqgGodgF/6crz3z+uSZ04SreKSpkIDDolh1TIgE5kf8VJ yrs28yUe ujE1TCLJkiJXM9soNiR3pHmjJA7cVRXeJMC1AQyjSbMcOscqUl8/Kd/hSah3N7/20q1YjaUFn27op0NtBK7OGHQ24v4OXIeAEyBEL0BLVTP71aviuAdZJKszEQlqEnLk1zgrvSNkzYA0X4rUVB6x3RtOBn4QhxjAVoFV8vDw3lZOvFEWTeuqfVdCwcCEPPz4g4lGSJn0aYI0JC0y2gqKU0f2/cAhnhxiTPZp/0ZtycSsVdDT/Bx9PcvHFGtfixtEGizp8JlD+XLk+cfrixhBU/zPdW0LrEGVgdoNmcQho3NoKkFCy9CKTfHUk0niuSm00MNYxGBfdeJst54M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 08:42:51PM +0100, Lorenzo Stoakes wrote: > The VMA flags field vma->vm_flags is of type vm_flags_t. Right now this is > exactly equivalent to unsigned long, but it should not be assumed to be. > > Much code that references vma->vm_flags already correctly uses vm_flags_t, > but a fairly large chunk of code simply uses unsigned long and assumes that > the two are equivalent. > > This series corrects that and has us use vm_flags_t consistently. > > This series is motivated by the desire to, in a future series, adjust > vm_flags_t to be a u64 regardless of whether the kernel is 32-bit or 64-bit > in order to deal with the VMA flag exhaustion issue and avoid all the > various problems that arise from it (being unable to use certain features > in 32-bit, being unable to add new flags except for 64-bit, etc.) > > This is therefore a critical first step towards that goal. At any rate, > using the correct type is of value regardless. > > We additionally take the opportunity to refer to VMA flags as vm_flags > where possible to make clear what we're referring to. > > Overall, this series does not introduce any functional change. > > Lorenzo Stoakes (3): > mm: change vm_get_page_prot() to accept vm_flags_t argument > mm: update core kernel code to use vm_flags_t consistently > mm: update architecture and driver code to use vm_flags_t For the series Acked-by: Mike Rapoport (Microsoft) > arch/arm/mm/fault.c | 2 +- > arch/arm64/include/asm/mman.h | 10 +- > arch/arm64/mm/fault.c | 2 +- > arch/arm64/mm/mmap.c | 2 +- > arch/arm64/mm/mmu.c | 2 +- > arch/powerpc/include/asm/book3s/64/pkeys.h | 3 +- > arch/powerpc/include/asm/mman.h | 2 +- > arch/powerpc/include/asm/pkeys.h | 4 +- > arch/powerpc/kvm/book3s_hv_uvmem.c | 2 +- > arch/sparc/include/asm/mman.h | 4 +- > arch/sparc/mm/init_64.c | 2 +- > arch/x86/kernel/cpu/sgx/encl.c | 8 +- > arch/x86/kernel/cpu/sgx/encl.h | 2 +- > arch/x86/mm/pgprot.c | 2 +- > fs/exec.c | 2 +- > fs/userfaultfd.c | 2 +- > include/linux/coredump.h | 2 +- > include/linux/huge_mm.h | 12 +- > include/linux/khugepaged.h | 4 +- > include/linux/ksm.h | 4 +- > include/linux/memfd.h | 4 +- > include/linux/mm.h | 10 +- > include/linux/mm_types.h | 2 +- > include/linux/mman.h | 4 +- > include/linux/pgtable.h | 2 +- > include/linux/rmap.h | 4 +- > include/linux/userfaultfd_k.h | 4 +- > include/trace/events/fs_dax.h | 6 +- > mm/debug.c | 2 +- > mm/execmem.c | 8 +- > mm/filemap.c | 2 +- > mm/gup.c | 2 +- > mm/huge_memory.c | 2 +- > mm/hugetlb.c | 4 +- > mm/internal.h | 4 +- > mm/khugepaged.c | 4 +- > mm/ksm.c | 2 +- > mm/madvise.c | 4 +- > mm/mapping_dirty_helpers.c | 2 +- > mm/memfd.c | 8 +- > mm/memory.c | 4 +- > mm/mmap.c | 16 +- > mm/mprotect.c | 8 +- > mm/mremap.c | 2 +- > mm/nommu.c | 12 +- > mm/rmap.c | 4 +- > mm/shmem.c | 6 +- > mm/userfaultfd.c | 14 +- > mm/vma.c | 78 +++--- > mm/vma.h | 16 +- > mm/vmscan.c | 4 +- > tools/testing/vma/vma.c | 266 ++++++++++----------- > tools/testing/vma/vma_internal.h | 12 +- > 53 files changed, 298 insertions(+), 297 deletions(-) > > -- > 2.49.0 -- Sincerely yours, Mike.