From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D9FC7115A for ; Wed, 18 Jun 2025 14:35:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A23CA6B0088; Wed, 18 Jun 2025 10:35:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D4B36B0089; Wed, 18 Jun 2025 10:35:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EA916B008A; Wed, 18 Jun 2025 10:35:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7CE4E6B0088 for ; Wed, 18 Jun 2025 10:35:21 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3A20ABFE6A for ; Wed, 18 Jun 2025 14:35:21 +0000 (UTC) X-FDA: 83568769242.27.DB57DCC Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf05.hostedemail.com (Postfix) with ESMTP id 47909100002 for ; Wed, 18 Jun 2025 14:35:19 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf05.hostedemail.com: domain of cmarinas@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750257319; a=rsa-sha256; cv=none; b=TwgLnwTZ+EPVFvG6niz0RGUf9no36wMWa6lwycVIYCWIRDOH1EANzb0jk1q2+GMKQmLRir ux+x/hdxrSjOH27fhls3szk+WV7vcs6zkX0KYp55IIKhndQN8Omb7OmdXa8CVe8FHdT66a oM1ysj9zogE4srNF23mlIow4H+demsA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf05.hostedemail.com: domain of cmarinas@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750257319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DiB1EkSqut4rMTxm/+LXeEUSnbbYUA2oGnQOe+U4MvU=; b=nTbdQhFPPMCZar9LBYUKhiJTS3GrXlTasZaxBquDW/3GWhllg53pk1WXsEMMMjU/MRnKRg sElRUNvvgGyPQD672U3DCHWxIqo09YlCfou1FSeFXtj8JfWS7yIxG9jkodykem7x7RArn4 /CXpGxOQCHuGRmEkXAYlp0fYN4sf4l8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 467996112A; Wed, 18 Jun 2025 14:35:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B7A5C4CEE7; Wed, 18 Jun 2025 14:35:10 +0000 (UTC) Date: Wed, 18 Jun 2025 15:35:08 +0100 From: Catalin Marinas To: ankita@nvidia.com Cc: jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org, ryan.roberts@arm.com, shahuang@redhat.com, lpieralisi@kernel.org, david@redhat.com, ddutile@redhat.com, seanjc@google.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, kjaju@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, zhiw@nvidia.com, mochs@nvidia.com, udhoke@nvidia.com, dnigam@nvidia.com, alex.williamson@redhat.com, sebastianene@google.com, coltonlewis@google.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com, linux-mm@kvack.org, tabba@google.com, qperret@google.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maobibo@loongson.cn Subject: Re: [PATCH v7 1/5] KVM: arm64: Rename symbols to reflect whether CMO may be used Message-ID: References: <20250618065541.50049-1-ankita@nvidia.com> <20250618065541.50049-2-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618065541.50049-2-ankita@nvidia.com> X-Rspam-User: X-Rspamd-Queue-Id: 47909100002 X-Rspamd-Server: rspam10 X-Stat-Signature: qygie9gjrd3t74fuw87dt7xos64r686w X-HE-Tag: 1750257319-670908 X-HE-Meta: U2FsdGVkX1+vpWrDzXSg+jzG2gCo9uxtO8ArbBH4825+8Jz3barmsiSwBpqZotYqkn0A3FCXq6Tr2pGpxkiYsgQM030qmBF3qm3NjQj89EeIGKFk/c1TxFwfqhFjzyWcY6HbtK2Kb7KeQEO7GzUp+TUi6VPsULS8oc2OWkhj94xE0+PDqIx/paSd/v2od2FUhYPZlq6eFBESi5dJ1pIyuRlGGh2pvx20uvxcF3nGIMaQCPyveYn3nOfjH09F2c4jIhAAFFhcI1nyq3cV+iJU0RI5z6k8vUYAhCWvpJY7omqTqnF+gyzH3BJ7mGhs4hDG8mEAhUg9S7Q+59ArX4+fZjM7INMxLdhJkAlYKEcckQLs4zT0J8T76xcSIzl2EqLj29cHgMoZB2EZcuklvRNM4vKROYCPalKgjxpZBucU5x6sSP+USrAVjLp2ttJHUblCigaNeW89WVVEaN/DglxRz7hePWee08eoD6AgE3ykYN4Ahry66Zyh8F8CKQdU6BLnpr1r2nQ9zNPN9wOP+409Ob6Go9mljoc0GkjvvkKjfHuxZFpNXfDMULsQgRJ7BDWa9ZIkQcR7yq9DjMffvQH4QPAM2KauFXme5+68/DHDI/qcM1Pg6wdJJ4bm4aRlsf1MrDV+59EmwdtWJNIunsJCYNN7b2EV995snS4KqYnXTQjg6sss2IQzmD/G/U0e9HIepfDCZCOUxPAMyGmHhFEUpXb0gQxaiotWOj7D7t0Ue1hZ2jMzS7Vnr4lzi7y3JDjdc4YHklZ89iixZv67UCUjEeLPa46ToQg2sa8SG789MOm3s8jrMvld+S5Phlmd51nbGEqsgijXUn2iCIbVycNAC0IjvcaPHTK1gV8mq+Oq8KEubEl45V6GwhXdZp5y3CV7/idvj0moRl8KawaWnHXota3a3tTGMVa7nkmYeNeLxGz2rsmPCsD/PTWg6SgsvwGs7+14nCfdGVG/87xdD8/ NLdsfoAi tkgMoU4RggTSK8A8acpBpijMamlsTHO/+gBYUXmkQrKbGsStmdb481BZI90uphZoUBUpq0TxzOgqKjERlKcA6DycgR6tl1GBWhymoOkHASQecPc6E2fteVGq3e2EEkGKFva3+AhrL4wPSihcI/eJ6cDXlx3VrGajUiVuK1XUibUIY6u58NHYVnY7ovUiJOKobTteoXzcXNdHVfWFTmxn19fit0266v18xAWnaQkiQWD/95TUiNravP1wj5DL+AKveILDcIr3toFnvoNpZjUSHehuik+yUEtgmJcdITq9CatBOZWbkvSlC0ZGnWB5vwTTzYLLZ/jn0ZVz9O+g+XbSNkW+XA12IwBVYTkhvG6TIhbpF8E4D6e6Tisv/Ng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 06:55:37AM +0000, ankita@nvidia.com wrote: > -static bool kvm_is_device_pfn(unsigned long pfn) > +static bool kvm_can_use_cmo_pfn(unsigned long pfn) > { > - return !pfn_is_map_memory(pfn); > + return pfn_is_map_memory(pfn); > } I wonder, why not just use pfn_is_map_memory() directly? At a quick grep, it's only used in one place and your patches don't seem to modify this function further. -- Catalin