From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1FAEC71157 for ; Wed, 18 Jun 2025 14:28:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70B226B008A; Wed, 18 Jun 2025 10:28:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BB8A6B0093; Wed, 18 Jun 2025 10:28:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F8786B0095; Wed, 18 Jun 2025 10:28:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 52F276B008A for ; Wed, 18 Jun 2025 10:28:59 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CAC351A1CD5 for ; Wed, 18 Jun 2025 14:28:58 +0000 (UTC) X-FDA: 83568753156.18.3A95358 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf17.hostedemail.com (Postfix) with ESMTP id 05A604000C for ; Wed, 18 Jun 2025 14:28:56 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of cmarinas@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750256937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DE6MTfLXyc5NU0johvRwmDTo6kAlSf9wj5hTl1JGxPA=; b=ADBG29h49FNXiuBDFXhOuojeaM7oAvzb+W6Kpv/YkJ3uumZxMgb5Mo7sS0H5r4SETJn5a/ PrUoWwOTMHeqSDVaPbS/4iqTrwdzwfP31FCe0Qd9/wmhCG0fFIAh8C0TgmIjy/uOlkUnsQ 1LbhZfLqUilwYq6ZCvIBDQrANCnfPfU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750256937; a=rsa-sha256; cv=none; b=DHDdTiJh3/PPA+YG/1JJ1rC6UAox8z1ziLKmBH4iIa60Jpwj1J0vTIlqxgtxejasSTuxxq pDVUeA8qRrFpEyaYpCMULWUmMPHy+LFIkIsoyCf41gcK6pgdm/rzkNYfwYgDQhpw6krxNU sIPcoB1+zJvg+7zo/30WDSMYT2d9h44= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of cmarinas@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 7CC43434B5; Wed, 18 Jun 2025 14:28:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92066C4CEE7; Wed, 18 Jun 2025 14:28:48 +0000 (UTC) Date: Wed, 18 Jun 2025 15:28:46 +0100 From: Catalin Marinas To: ankita@nvidia.com Cc: jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org, ryan.roberts@arm.com, shahuang@redhat.com, lpieralisi@kernel.org, david@redhat.com, ddutile@redhat.com, seanjc@google.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, kjaju@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, zhiw@nvidia.com, mochs@nvidia.com, udhoke@nvidia.com, dnigam@nvidia.com, alex.williamson@redhat.com, sebastianene@google.com, coltonlewis@google.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com, linux-mm@kvack.org, tabba@google.com, qperret@google.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maobibo@loongson.cn Subject: Re: [PATCH v7 1/5] KVM: arm64: Rename symbols to reflect whether CMO may be used Message-ID: References: <20250618065541.50049-1-ankita@nvidia.com> <20250618065541.50049-2-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618065541.50049-2-ankita@nvidia.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 05A604000C X-Stat-Signature: q5snc561k1tcary4us1ggwbiw3pzjd8j X-Rspam-User: X-HE-Tag: 1750256936-930845 X-HE-Meta: U2FsdGVkX1860oxA2yUZ1RXE5iwrtJOapzk4Q4JW6w0RNGGZUvGjPooHuGvMzrBr/DTBKMkZ86izYHOJC31JA4afTP0SFF2Pbh5HgKT6uLiY9DSuaiMV/Ciq+ndNwN6zLCcUtIBtwbqQ+f92GQiesj35TlJ1OL9RGHGv11kkyRX8XLM1uBJlypkP/+PAJw6B3yHZ6SEFCv6w4//vOELnibP2u2WYcOIHi/CBbT1ejTnxcWI+DdSPqBpVEkNbsQmt2zPHvwcHdCDVICe6mggGq5fjgSE2vxDFHxUjQjGs+RFYwy1sSJNtJ5sUXUmznc67GUBgt1Rc28S5qDjedE6vMR3xXwJ4qBGKCU8kj6H7X/RNju6E2ToUwx9iu17Q0KkqjYpFzUZphyzZ5LxnnJJ+DzYQ4uoV744gcMEFwbC2s8ePO2cpbvDOWj8LD1fuwbVeX9mxBmOGJ++EUKRe7TmrdRyLVz56CPyLGfKstWbYnsYH5Y+FBYnWJvvlvs1htab33rC72x5Q2NdR9nB7PL+wylpP+0OFij7zG6EXY1b3UwiRWd08VrNVblHtJOdWoTTxTTQtkQ3GWkND456C/KJ6ztTJCsg8aAoBtySuH9P+hgJhXFTGlUo+zDkhxwUCrNxU+BeVjUPr8CqIw0nrn4G46UKzo5gnuSp32pGOVdqb7kELGW7i2me4GY5OANQY7ZCwIZy16ML4g3IyQD/UYL93ua2pgemW3EJoHPuWlCOIvnYajh1u/9n3FkiUxNNDWKgk8qFnp7MEaJ4oA916S99FA61ZxIlbDlnBzW24gmeo+X5KwRm8cFpg8St7aSHO4Kv3X2iqkrg1nA/akrXCjiBkloMlX551CXihX1kR9D5aq4G4wRBjzhePZKeCqOT7+nv1Y19VzbBtyYP3J22aaUl2BpOgN6i3KuEX/WuexlDMdP164wvdPal167+4T8c1NdRoWS8tyzYnGd9af/3td87 kMZ6iR/D YcWMP5qBqB+pYZxDl6ULSffaLhLcklh4b2SWKrL/0dNohB6HMopnIG+NqoX41oLAElNttE+4+tklb5EpNY2NNgbL6OZAGif43LEbQpijbQLP5LwR95xLxqEINRQ6Qtr86G5PRjOj72eMrpU/IFaPahpxlTpNVu1a5SuC3Pt33FjMTgUfRmTpC1+ShhBcjokvVf/SeKVVYCkFS9tPnL8wXmm5zi1Ggnu8YYj7A/cNgkPYgaXcihkZxUJl/vZbqavP7ZwWnsPCF2xlHIh1ZntzPGkk8QJfkk4UoNxAa/E0l/hBRqv6n0uHB1lDudZNxBEulBYsZ0jvRC69FFLBg7MXqxtcdCfKZrX5xJw7Oi5va4DCX/K5E1ec/kDtlPA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 06:55:37AM +0000, ankita@nvidia.com wrote: > From: Ankit Agrawal > > Currently, the kvm_is_device_pfn() detects if the memory is kernel > mapped. It thus implies whether KVM can use Cache Maintenance > Operations (CMOs) on that PFN. Rename the function to reflect this. > > Additionally, the "device" variable is effectively trying to setup the S2 > to prevent CMOs. Calling it 'disable_cmo' would make this code clearer. I'm not sure CMOs is the only reason. Another is to prevent the guest from mapping device memory as something other than Device with possible implications for external aborts. -- Catalin